2011-02-16 02:12:15 +01:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
|
|
* Copyright (C) 2007-2011 Daniel Marjamäki and Cppcheck team.
|
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "cppcheck.h"
|
|
|
|
#include "settings.h"
|
|
|
|
#include "testsuite.h"
|
|
|
|
#include "threadexecutor.h"
|
|
|
|
|
|
|
|
#include <sstream>
|
|
|
|
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
|
|
|
|
class TestSuppressions : public TestFixture
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
TestSuppressions() : TestFixture("TestSuppressions")
|
|
|
|
{ }
|
|
|
|
|
|
|
|
private:
|
|
|
|
|
|
|
|
void run()
|
|
|
|
{
|
|
|
|
TEST_CASE(suppressionsSettings);
|
2011-02-17 09:46:14 +01:00
|
|
|
TEST_CASE(suppressionsMultiFile);
|
2011-02-16 02:12:15 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// Check the suppression
|
|
|
|
void checkSuppression(const char code[], const std::string &suppression = "")
|
|
|
|
{
|
|
|
|
// Clear the error log
|
|
|
|
errout.str("");
|
|
|
|
|
|
|
|
Settings settings;
|
|
|
|
settings._inlineSuppressions = true;
|
|
|
|
if (!suppression.empty())
|
2011-03-10 10:00:48 +01:00
|
|
|
{
|
|
|
|
std::string r = settings.nomsg.addSuppressionLine(suppression);
|
|
|
|
ASSERT_EQUALS("", r);
|
|
|
|
}
|
2011-02-16 02:12:15 +01:00
|
|
|
|
|
|
|
CppCheck cppCheck(*this, true);
|
|
|
|
cppCheck.settings(settings);
|
|
|
|
cppCheck.addFile("test.cpp", code);
|
|
|
|
cppCheck.check();
|
|
|
|
|
|
|
|
reportUnmatchedSuppressions(cppCheck.settings().nomsg.getUnmatchedGlobalSuppressions());
|
|
|
|
}
|
|
|
|
|
|
|
|
void checkSuppressionThreads(const char code[], const std::string &suppression = "")
|
|
|
|
{
|
|
|
|
errout.str("");
|
|
|
|
output.str("");
|
|
|
|
if (!ThreadExecutor::isEnabled())
|
|
|
|
{
|
|
|
|
// Skip this check on systems which don't use this feature
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<std::string> filenames;
|
|
|
|
filenames.push_back("test.cpp");
|
|
|
|
|
|
|
|
Settings settings;
|
|
|
|
settings._jobs = 1;
|
|
|
|
settings._inlineSuppressions = true;
|
|
|
|
if (!suppression.empty())
|
2011-03-10 10:00:48 +01:00
|
|
|
{
|
|
|
|
std::string r = settings.nomsg.addSuppressionLine(suppression);
|
|
|
|
ASSERT_EQUALS("", r);
|
|
|
|
}
|
2011-02-16 02:12:15 +01:00
|
|
|
ThreadExecutor executor(filenames, settings, *this);
|
|
|
|
for (unsigned int i = 0; i < filenames.size(); ++i)
|
|
|
|
executor.addFileContent(filenames[i], code);
|
|
|
|
|
|
|
|
executor.check();
|
|
|
|
|
|
|
|
reportUnmatchedSuppressions(settings.nomsg.getUnmatchedGlobalSuppressions());
|
|
|
|
}
|
|
|
|
|
2011-02-17 09:46:14 +01:00
|
|
|
// Check the suppression for multiple files
|
|
|
|
void checkSuppression(const char *names[], const char *codes[], const std::string &suppression = "")
|
|
|
|
{
|
|
|
|
// Clear the error log
|
|
|
|
errout.str("");
|
|
|
|
|
|
|
|
Settings settings;
|
|
|
|
settings._inlineSuppressions = true;
|
|
|
|
if (!suppression.empty())
|
|
|
|
settings.nomsg.addSuppressionLine(suppression);
|
|
|
|
|
|
|
|
CppCheck cppCheck(*this, true);
|
|
|
|
cppCheck.settings(settings);
|
|
|
|
for (int i = 0; names[i] != NULL; ++i)
|
|
|
|
cppCheck.addFile(names[i], codes[i]);
|
|
|
|
cppCheck.check();
|
|
|
|
|
|
|
|
reportUnmatchedSuppressions(cppCheck.settings().nomsg.getUnmatchedGlobalSuppressions());
|
|
|
|
}
|
|
|
|
|
2011-02-16 02:12:15 +01:00
|
|
|
void runChecks(void (TestSuppressions::*check)(const char[], const std::string &))
|
|
|
|
{
|
|
|
|
// check to make sure the appropriate error is present
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"");
|
|
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar globally
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"uninitvar");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar globally, without error present
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" b++;\n"
|
|
|
|
"}\n",
|
|
|
|
"uninitvar");
|
|
|
|
ASSERT_EQUALS("[*]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar for this file only
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"uninitvar:test.cpp");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar for this file only, without error present
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" b++;\n"
|
|
|
|
"}\n",
|
|
|
|
"uninitvar:test.cpp");
|
|
|
|
ASSERT_EQUALS("[test.cpp]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
|
|
|
2011-03-10 10:00:48 +01:00
|
|
|
// suppress all for this file only
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"*:test.cpp");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
|
|
// suppress all for this file only, without error present
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" b++;\n"
|
|
|
|
"}\n",
|
|
|
|
"*:test.cpp");
|
|
|
|
ASSERT_EQUALS("[test.cpp]: (information) Unmatched suppression: *\n", errout.str());
|
|
|
|
|
2011-02-16 02:12:15 +01:00
|
|
|
// suppress uninitvar for this file and line
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"uninitvar:test.cpp:3");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar for this file and line, without error present
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" b++;\n"
|
|
|
|
"}\n",
|
|
|
|
"uninitvar:test.cpp:3");
|
|
|
|
ASSERT_EQUALS("[test.cpp:3]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar inline
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" // cppcheck-suppress uninitvar\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
2011-02-19 23:36:03 +01:00
|
|
|
// suppress uninitvar inline
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" // cppcheck-suppress uninitvar\n"
|
|
|
|
"\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar inline
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" /* cppcheck-suppress uninitvar */\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
|
|
// suppress uninitvar inline
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" /* cppcheck-suppress uninitvar */\n"
|
|
|
|
"\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
"");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
2011-02-16 02:12:15 +01:00
|
|
|
// suppress uninitvar inline, without error present
|
|
|
|
(this->*check)("void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" // cppcheck-suppress uninitvar\n"
|
|
|
|
" b++;\n"
|
|
|
|
"}\n",
|
|
|
|
"");
|
|
|
|
ASSERT_EQUALS("[test.cpp:4]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
|
|
}
|
|
|
|
|
|
|
|
void suppressionsSettings()
|
|
|
|
{
|
|
|
|
runChecks(&TestSuppressions::checkSuppression);
|
|
|
|
runChecks(&TestSuppressions::checkSuppressionThreads);
|
|
|
|
}
|
|
|
|
|
2011-02-17 09:46:14 +01:00
|
|
|
void suppressionsMultiFile()
|
|
|
|
{
|
|
|
|
const char *names[] = {"abc.cpp", "xyz.cpp", NULL};
|
2011-02-17 21:07:45 +01:00
|
|
|
const char *codes[] =
|
|
|
|
{
|
2011-02-17 09:46:14 +01:00
|
|
|
"void f() {\n"
|
|
|
|
"}\n",
|
|
|
|
"void f() {\n"
|
|
|
|
" int a;\n"
|
|
|
|
" a++;\n"
|
|
|
|
"}\n",
|
|
|
|
};
|
|
|
|
|
|
|
|
// suppress uninitvar for this file and line
|
|
|
|
checkSuppression(names, codes, "uninitvar:xyz.cpp:3");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
}
|
|
|
|
|
2011-02-16 02:12:15 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
REGISTER_TEST(TestSuppressions)
|