cppcheck/cli/cppcheckexecutor.cpp

607 lines
22 KiB
C++
Raw Normal View History

2008-12-18 22:28:57 +01:00
/*
* Cppcheck - A tool for static C/C++ code analysis
2022-02-05 11:45:17 +01:00
* Copyright (C) 2007-2022 Cppcheck team.
2008-12-18 22:28:57 +01:00
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
2008-12-18 22:28:57 +01:00
*/
#include "cppcheckexecutor.h"
2017-05-27 04:33:47 +02:00
#include "analyzerinfo.h"
#include "cmdlineparser.h"
2021-07-08 21:21:35 +02:00
#include "color.h"
2017-05-27 04:33:47 +02:00
#include "config.h"
2008-12-18 22:28:57 +01:00
#include "cppcheck.h"
#include "errortypes.h"
#include "filelister.h"
2017-05-27 04:33:47 +02:00
#include "importproject.h"
#include "library.h"
#include "path.h"
#include "pathmatch.h"
#include "preprocessor.h"
2017-05-27 04:33:47 +02:00
#include "settings.h"
#include "suppressions.h"
#include "utils.h"
2018-02-10 15:34:49 +01:00
#include "checkunusedfunctions.h"
#if defined(THREADING_MODEL_THREAD)
#include "threadexecutor.h"
#elif defined(THREADING_MODEL_FORK)
#include "processexecutor.h"
#endif
#include <atomic>
2017-09-07 13:02:44 +02:00
#include <cstdio>
#include <cstdlib> // EXIT_SUCCESS and EXIT_FAILURE
#include <functional>
#include <iostream>
2017-05-27 04:33:47 +02:00
#include <list>
2020-05-23 07:16:49 +02:00
#include <memory>
#include <sstream> // IWYU pragma: keep
2017-05-27 04:33:47 +02:00
#include <utility>
#include <vector>
#include <numeric>
#ifdef USE_UNIX_SIGNAL_HANDLING
#include "cppcheckexecutorsig.h"
#endif
#ifdef USE_WINDOWS_SEH
#include "cppcheckexecutorseh.h"
#endif
#ifdef _WIN32
#include <windows.h>
#endif
/*static*/ FILE* CppCheckExecutor::mExceptionOutput = stdout;
2008-12-18 22:28:57 +01:00
CppCheckExecutor::CppCheckExecutor()
: mSettings(nullptr), mLatestProgressOutputTime(0), mErrorOutput(nullptr), mShowAllErrors(false)
2021-08-07 20:51:18 +02:00
{}
2008-12-18 22:28:57 +01:00
CppCheckExecutor::~CppCheckExecutor()
{
2019-07-15 18:16:07 +02:00
delete mErrorOutput;
2008-12-18 22:28:57 +01:00
}
bool CppCheckExecutor::parseFromArgs(CppCheck *cppcheck, int argc, const char* const argv[])
{
Settings& settings = cppcheck->settings();
CmdLineParser parser(&settings);
2018-04-23 12:39:47 +02:00
const bool success = parser.parseFromArgs(argc, argv);
2011-10-13 20:53:06 +02:00
if (success) {
2018-04-23 12:39:47 +02:00
if (parser.getShowVersion() && !parser.getShowErrorMessages()) {
if (!settings.cppcheckCfgProductName.empty()) {
std::cout << settings.cppcheckCfgProductName << std::endl;
} else {
const char * const extraVersion = CppCheck::extraVersion();
if (*extraVersion != 0)
std::cout << "Cppcheck " << CppCheck::version() << " ("
<< extraVersion << ')' << std::endl;
else
std::cout << "Cppcheck " << CppCheck::version() << std::endl;
}
}
2018-04-23 12:39:47 +02:00
if (parser.getShowErrorMessages()) {
2019-07-15 18:31:12 +02:00
mShowAllErrors = true;
std::cout << ErrorMessage::getXMLHeader(settings.cppcheckCfgProductName);
cppcheck->getErrorMessages();
2020-05-23 07:16:49 +02:00
std::cout << ErrorMessage::getXMLFooter() << std::endl;
}
2018-04-23 12:39:47 +02:00
if (parser.exitAfterPrinting()) {
Settings::terminate();
return true;
}
} else {
return false;
}
// Check that all include paths exist
{
2018-04-04 21:11:23 +02:00
for (std::list<std::string>::iterator iter = settings.includePaths.begin();
iter != settings.includePaths.end();
2021-08-07 20:51:18 +02:00
) {
const std::string path(Path::toNativeSeparators(*iter));
if (FileLister::isDirectory(path))
++iter;
2011-10-13 20:53:06 +02:00
else {
// If the include path is not found, warn user and remove the non-existing path from the list.
if (settings.severity.isEnabled(Severity::information))
std::cout << "(information) Couldn't find path given by -I '" << path << '\'' << std::endl;
iter = settings.includePaths.erase(iter);
}
}
}
// Output a warning for the user if he tries to exclude headers
2018-04-23 12:39:47 +02:00
const std::vector<std::string>& ignored = parser.getIgnoredPaths();
const bool warn = std::any_of(ignored.begin(), ignored.end(), [](const std::string& i) {
return Path::isHeader(i);
});
if (warn) {
std::cout << "cppcheck: filename exclusion does not apply to header (.h and .hpp) files." << std::endl;
std::cout << "cppcheck: Please use --suppress for ignoring results from the header files." << std::endl;
}
2018-04-23 12:39:47 +02:00
const std::vector<std::string>& pathnames = parser.getPathNames();
#if defined(_WIN32)
// For Windows we want case-insensitive path matching
const bool caseSensitive = false;
#else
const bool caseSensitive = true;
#endif
if (!mSettings->project.fileSettings.empty() && !mSettings->fileFilters.empty()) {
// filter only for the selected filenames from all project files
std::list<ImportProject::FileSettings> newList;
const std::list<ImportProject::FileSettings>& fileSettings = settings.project.fileSettings;
std::copy_if(fileSettings.begin(), fileSettings.end(), std::back_inserter(newList), [&](const ImportProject::FileSettings& fs) {
return matchglobs(mSettings->fileFilters, fs.filename);
});
2020-01-10 11:31:12 +01:00
if (!newList.empty())
settings.project.fileSettings = newList;
else {
std::cout << "cppcheck: error: could not find any files matching the filter." << std::endl;
return false;
}
2020-01-10 11:31:12 +01:00
} else if (!pathnames.empty()) {
// Execute recursiveAddFiles() to each given file parameter
2018-04-04 21:02:13 +02:00
const PathMatch matcher(ignored, caseSensitive);
for (const std::string &pathname : pathnames) {
std::string err = FileLister::recursiveAddFiles(mFiles, Path::toNativeSeparators(pathname), mSettings->library.markupExtensions(), matcher);
if (!err.empty()) {
std::cout << "cppcheck: " << err << std::endl;
}
}
}
2019-07-15 18:21:52 +02:00
if (mFiles.empty() && settings.project.fileSettings.empty()) {
std::cout << "cppcheck: error: could not find or open any of the paths given." << std::endl;
if (!ignored.empty())
std::cout << "cppcheck: Maybe all paths were ignored?" << std::endl;
return false;
} else if (!mSettings->fileFilters.empty() && settings.project.fileSettings.empty()) {
std::map<std::string, std::size_t> newMap;
for (std::map<std::string, std::size_t>::const_iterator i = mFiles.begin(); i != mFiles.end(); ++i)
if (matchglobs(mSettings->fileFilters, i->first)) {
newMap[i->first] = i->second;
}
mFiles = newMap;
if (mFiles.empty()) {
std::cout << "cppcheck: error: could not find any files matching the filter." << std::endl;
return false;
}
}
2020-01-10 11:31:12 +01:00
return true;
}
int CppCheckExecutor::check(int argc, const char* const argv[])
2008-12-18 22:28:57 +01:00
{
Preprocessor::missingIncludeFlag = false;
Preprocessor::missingSystemIncludeFlag = false;
2018-02-10 15:34:49 +01:00
CheckUnusedFunctions::clear();
CppCheck cppCheck(*this, true, executeCommand);
const Settings& settings = cppCheck.settings();
2019-07-15 18:24:27 +02:00
mSettings = &settings;
if (!parseFromArgs(&cppCheck, argc, argv)) {
2020-05-09 14:45:47 +02:00
mSettings = nullptr;
return EXIT_FAILURE;
}
if (Settings::terminated()) {
2020-05-09 14:45:47 +02:00
mSettings = nullptr;
return EXIT_SUCCESS;
}
2020-05-09 14:45:47 +02:00
int ret;
if (cppCheck.settings().exceptionHandling)
ret = check_wrapper(cppCheck);
2020-05-09 14:45:47 +02:00
else
ret = check_internal(cppCheck);
2020-05-09 14:45:47 +02:00
mSettings = nullptr;
return ret;
}
void CppCheckExecutor::setSettings(const Settings &settings)
{
2019-07-15 18:24:27 +02:00
mSettings = &settings;
}
int CppCheckExecutor::check_wrapper(CppCheck& cppcheck)
{
#ifdef USE_WINDOWS_SEH
return check_wrapper_seh(*this, &CppCheckExecutor::check_internal, cppcheck);
#elif defined(USE_UNIX_SIGNAL_HANDLING)
return check_wrapper_sig(*this, &CppCheckExecutor::check_internal, cppcheck);
#else
return check_internal(cppcheck);
#endif
}
bool CppCheckExecutor::reportSuppressions(const Settings &settings, bool unusedFunctionCheckEnabled, const std::map<std::string, std::size_t> &files, ErrorLogger& errorLogger) {
for (const Suppressions::Suppression& suppression: settings.nomsg.getSuppressions()) {
if (suppression.errorId == "unmatchedSuppression" && suppression.fileName.empty() && suppression.lineNumber == Suppressions::Suppression::NO_LINE)
return false;
}
bool err = false;
if (settings.jointSuppressionReport) {
for (std::map<std::string, std::size_t>::const_iterator i = files.begin(); i != files.end(); ++i) {
err |= errorLogger.reportUnmatchedSuppressions(
settings.nomsg.getUnmatchedLocalSuppressions(i->first, unusedFunctionCheckEnabled));
}
}
err |= errorLogger.reportUnmatchedSuppressions(settings.nomsg.getUnmatchedGlobalSuppressions(unusedFunctionCheckEnabled));
return err;
}
2014-03-18 21:14:09 +01:00
/*
* That is a method which gets called from check_wrapper
* */
int CppCheckExecutor::check_internal(CppCheck& cppcheck)
{
2014-04-07 20:39:19 +02:00
Settings& settings = cppcheck.settings();
2019-07-15 18:24:27 +02:00
mSettings = &settings;
const bool std = tryLoadLibrary(settings.library, settings.exename, "std.cfg");
for (const std::string &lib : settings.libraries) {
if (!tryLoadLibrary(settings.library, settings.exename, lib.c_str())) {
const std::string msg("Failed to load the library " + lib);
2020-05-23 07:16:49 +02:00
const std::list<ErrorMessage::FileLocation> callstack;
ErrorMessage errmsg(callstack, emptyString, Severity::information, msg, "failedToLoadCfg", Certainty::normal);
reportErr(errmsg);
return EXIT_FAILURE;
}
}
if (!std) {
2020-05-23 07:16:49 +02:00
const std::list<ErrorMessage::FileLocation> callstack;
const std::string msg("Failed to load std.cfg. Your Cppcheck installation is broken, please re-install.");
#ifdef FILESDIR
const std::string details("The Cppcheck binary was compiled with FILESDIR set to \""
FILESDIR "\" and will therefore search for "
"std.cfg in " FILESDIR "/cfg.");
#else
const std::string cfgfolder(Path::fromNativeSeparators(Path::getPathFromFilename(settings.exename)) + "cfg");
const std::string details("The Cppcheck binary was compiled without FILESDIR set. Either the "
"std.cfg should be available in " + cfgfolder + " or the FILESDIR "
"should be configured.");
#endif
ErrorMessage errmsg(callstack, emptyString, Severity::information, msg+" "+details, "failedToLoadCfg", Certainty::normal);
reportErr(errmsg);
return EXIT_FAILURE;
}
if (settings.reportProgress)
mLatestProgressOutputTime = std::time(nullptr);
if (!settings.outputFile.empty()) {
2019-07-15 18:16:07 +02:00
mErrorOutput = new std::ofstream(settings.outputFile);
}
if (settings.xml) {
reportErr(ErrorMessage::getXMLHeader(settings.cppcheckCfgProductName));
2009-10-17 08:19:37 +02:00
}
if (!settings.buildDir.empty()) {
2020-12-19 19:02:42 +01:00
settings.loadSummaries();
std::list<std::string> fileNames;
2019-07-15 18:21:52 +02:00
for (std::map<std::string, std::size_t>::const_iterator i = mFiles.begin(); i != mFiles.end(); ++i)
fileNames.emplace_back(i->first);
2020-12-19 20:45:51 +01:00
AnalyzerInformation::writeFilesTxt(settings.buildDir, fileNames, settings.userDefines, settings.project.fileSettings);
}
2009-10-17 08:19:37 +02:00
unsigned int returnValue = 0;
if (settings.jobs == 1) {
2009-10-17 08:19:37 +02:00
// Single process
settings.jointSuppressionReport = true;
const std::size_t totalfilesize = std::accumulate(mFiles.begin(), mFiles.end(), std::size_t(0), [](std::size_t v, const std::pair<std::string, std::size_t>& f) {
return v + f.second;
});
std::size_t processedsize = 0;
unsigned int c = 0;
if (settings.project.fileSettings.empty()) {
2019-07-15 18:21:52 +02:00
for (std::map<std::string, std::size_t>::const_iterator i = mFiles.begin(); i != mFiles.end(); ++i) {
2019-07-15 18:24:27 +02:00
if (!mSettings->library.markupFile(i->first)
|| !mSettings->library.processMarkupAfterCode(i->first)) {
returnValue += cppcheck.check(i->first);
processedsize += i->second;
if (!settings.quiet)
2019-07-15 18:21:52 +02:00
reportStatus(c + 1, mFiles.size(), processedsize, totalfilesize);
c++;
}
2013-10-20 14:09:10 +02:00
}
} else {
// filesettings
// check all files of the project
for (const ImportProject::FileSettings &fs : settings.project.fileSettings) {
returnValue += cppcheck.check(fs);
++c;
if (!settings.quiet)
reportStatus(c, settings.project.fileSettings.size(), c, settings.project.fileSettings.size());
2020-01-31 14:13:52 +01:00
if (settings.clangTidy)
cppcheck.analyseClangTidy(fs);
}
}
// second loop to parse all markup files which may not work until all
2013-10-20 14:09:10 +02:00
// c/cpp files have been parsed and checked
2019-07-15 18:21:52 +02:00
for (std::map<std::string, std::size_t>::const_iterator i = mFiles.begin(); i != mFiles.end(); ++i) {
2019-07-15 18:24:27 +02:00
if (mSettings->library.markupFile(i->first) && mSettings->library.processMarkupAfterCode(i->first)) {
2014-04-07 20:39:19 +02:00
returnValue += cppcheck.check(i->first);
2013-10-20 14:09:10 +02:00
processedsize += i->second;
if (!settings.quiet)
2019-07-15 18:21:52 +02:00
reportStatus(c + 1, mFiles.size(), processedsize, totalfilesize);
2013-10-20 14:09:10 +02:00
c++;
}
}
if (cppcheck.analyseWholeProgram())
returnValue++;
2011-10-13 20:53:06 +02:00
} else {
#if defined(THREADING_MODEL_THREAD)
2019-07-15 18:21:52 +02:00
ThreadExecutor executor(mFiles, settings, *this);
#elif defined(THREADING_MODEL_FORK)
ProcessExecutor executor(mFiles, settings, *this);
#endif
2009-10-17 08:19:37 +02:00
returnValue = executor.check();
}
2009-10-17 08:19:37 +02:00
2019-07-15 18:24:27 +02:00
cppcheck.analyseWholeProgram(mSettings->buildDir, mFiles);
if (settings.severity.isEnabled(Severity::information) || settings.checkConfiguration) {
const bool err = reportSuppressions(settings, cppcheck.isUnusedFunctionCheckEnabled(), mFiles, *this);
if (err && returnValue == 0)
returnValue = settings.exitCode;
}
if (!settings.checkConfiguration) {
cppcheck.tooManyConfigsError(emptyString,0U);
if (settings.checks.isEnabled(Checks::missingInclude) && (Preprocessor::missingIncludeFlag || Preprocessor::missingSystemIncludeFlag)) {
2020-05-23 07:16:49 +02:00
const std::list<ErrorMessage::FileLocation> callStack;
ErrorMessage msg(callStack,
emptyString,
Severity::information,
"Cppcheck cannot find all the include files (use --check-config for details)\n"
"Cppcheck cannot find all the include files. Cppcheck can check the code without the "
"include files found. But the results will probably be more accurate if all the include "
"files are found. Please check your project's include directories and add all of them "
"as include directories for Cppcheck. To see what files Cppcheck cannot find use "
"--check-config.",
"",
Certainty::normal);
if (Preprocessor::missingIncludeFlag) {
msg.id = "missingInclude";
reportInfo(msg);
}
if (Preprocessor::missingSystemIncludeFlag) {
msg.id = "missingIncludeSystem";
reportInfo(msg);
}
}
}
if (settings.xml) {
2020-05-23 07:16:49 +02:00
reportErr(ErrorMessage::getXMLFooter());
2009-10-17 08:19:37 +02:00
}
2019-07-15 18:24:27 +02:00
mSettings = nullptr;
if (returnValue)
return settings.exitCode;
2018-04-04 21:11:23 +02:00
return 0;
2008-12-18 22:28:57 +01:00
}
#ifdef _WIN32
// fix trac ticket #439 'Cppcheck reports wrong filename for filenames containing 8-bit ASCII'
static inline std::string ansiToOEM(const std::string &msg, bool doConvert)
{
if (doConvert) {
2017-08-22 13:15:11 +02:00
const unsigned msglength = msg.length();
// convert ANSI strings to OEM strings in two steps
2017-08-22 13:15:11 +02:00
std::vector<WCHAR> wcContainer(msglength);
std::string result(msglength, '\0');
// ansi code page characters to wide characters
2017-08-22 13:15:11 +02:00
MultiByteToWideChar(CP_ACP, 0, msg.data(), msglength, wcContainer.data(), msglength);
// wide characters to oem codepage characters
2018-04-05 08:12:15 +02:00
WideCharToMultiByte(CP_OEMCP, 0, wcContainer.data(), msglength, const_cast<char *>(result.data()), msglength, nullptr, nullptr);
2017-08-22 13:15:11 +02:00
return result; // hope for return value optimization
}
return msg;
}
#else
// no performance regression on non-windows systems
2017-08-29 20:23:45 +02:00
#define ansiToOEM(msg, doConvert) (msg)
#endif
void CppCheckExecutor::reportErr(const std::string &errmsg)
2008-12-18 22:28:57 +01:00
{
2019-07-15 18:16:07 +02:00
if (mErrorOutput)
*mErrorOutput << errmsg << std::endl;
2017-08-30 17:42:04 +02:00
else {
2019-07-15 18:24:27 +02:00
std::cerr << ansiToOEM(errmsg, (mSettings == nullptr) ? true : !mSettings->xml) << std::endl;
2017-08-29 16:51:56 +02:00
}
2008-12-18 22:28:57 +01:00
}
2021-07-08 21:21:35 +02:00
void CppCheckExecutor::reportOut(const std::string &outmsg, Color c)
2008-12-18 22:28:57 +01:00
{
2021-07-08 21:21:35 +02:00
std::cout << c << ansiToOEM(outmsg, true) << Color::Reset << std::endl;
2008-12-18 22:28:57 +01:00
}
2009-02-01 19:00:47 +01:00
void CppCheckExecutor::reportProgress(const std::string &filename, const char stage[], const std::size_t value)
{
(void)filename;
if (!mLatestProgressOutputTime)
return;
// Report progress messages every 10 seconds
2017-10-14 22:05:58 +02:00
const std::time_t currentTime = std::time(nullptr);
if (currentTime >= (mLatestProgressOutputTime + 10)) {
mLatestProgressOutputTime = currentTime;
// format a progress message
std::ostringstream ostr;
ostr << "progress: "
<< stage
<< ' ' << value << '%';
// Report progress message
reportOut(ostr.str());
}
}
2020-05-23 07:16:49 +02:00
void CppCheckExecutor::reportInfo(const ErrorMessage &msg)
{
reportErr(msg);
}
void CppCheckExecutor::reportStatus(std::size_t fileindex, std::size_t filecount, std::size_t sizedone, std::size_t sizetotal)
{
2011-10-13 20:53:06 +02:00
if (filecount > 1) {
std::ostringstream oss;
2017-08-29 16:51:56 +02:00
const long percentDone = (sizetotal > 0) ? static_cast<long>(static_cast<long double>(sizedone) / sizetotal * 100) : 0;
2012-02-18 11:55:05 +01:00
oss << fileindex << '/' << filecount
2017-08-29 16:51:56 +02:00
<< " files checked " << percentDone
2010-04-15 20:08:51 +02:00
<< "% done";
2021-07-08 21:21:35 +02:00
std::cout << Color::FgBlue << oss.str() << Color::Reset << std::endl;
}
}
2020-05-23 07:16:49 +02:00
void CppCheckExecutor::reportErr(const ErrorMessage &msg)
2009-02-01 19:00:47 +01:00
{
2019-07-15 18:31:12 +02:00
if (mShowAllErrors) {
2017-07-29 18:56:22 +02:00
reportOut(msg.toXML());
return;
}
// Alert only about unique errors
if (!mShownErrors.insert(msg.toString(mSettings->verbose)).second)
return;
if (mSettings->xml)
2017-07-29 18:56:22 +02:00
reportErr(msg.toXML());
else
2019-07-15 18:24:27 +02:00
reportErr(msg.toString(mSettings->verbose, mSettings->templateFormat, mSettings->templateLocation));
2009-02-01 19:00:47 +01:00
}
void CppCheckExecutor::setExceptionOutput(FILE* exceptionOutput)
{
mExceptionOutput = exceptionOutput;
}
FILE* CppCheckExecutor::getExceptionOutput()
{
return mExceptionOutput;
}
bool CppCheckExecutor::tryLoadLibrary(Library& destination, const std::string& basepath, const char* filename)
{
const Library::Error err = destination.load(basepath.c_str(), filename);
if (err.errorcode == Library::ErrorCode::UNKNOWN_ELEMENT)
std::cout << "cppcheck: Found unknown elements in configuration file '" << filename << "': " << err.reason << std::endl;
else if (err.errorcode != Library::ErrorCode::OK) {
std::cout << "cppcheck: Failed to load library configuration file '" << filename << "'. ";
switch (err.errorcode) {
case Library::ErrorCode::OK:
break;
case Library::ErrorCode::FILE_NOT_FOUND:
std::cout << "File not found";
break;
case Library::ErrorCode::BAD_XML:
std::cout << "Bad XML";
break;
case Library::ErrorCode::UNKNOWN_ELEMENT:
std::cout << "Unexpected element";
break;
case Library::ErrorCode::MISSING_ATTRIBUTE:
std::cout << "Missing attribute";
break;
case Library::ErrorCode::BAD_ATTRIBUTE_VALUE:
std::cout << "Bad attribute value";
break;
case Library::ErrorCode::UNSUPPORTED_FORMAT:
std::cout << "File is of unsupported format version";
break;
case Library::ErrorCode::DUPLICATE_PLATFORM_TYPE:
std::cout << "Duplicate platform type";
break;
case Library::ErrorCode::PLATFORM_TYPE_REDEFINED:
std::cout << "Platform type redefined";
break;
}
if (!err.reason.empty())
std::cout << " '" + err.reason + "'";
std::cout << std::endl;
return false;
}
return true;
}
/**
* Execute a shell command and read the output from it. Returns true if command terminated successfully.
*/
// cppcheck-suppress passedByValue - used as callback so we need to preserve the signature
// NOLINTNEXTLINE(performance-unnecessary-value-param) - used as callback so we need to preserve the signature
bool CppCheckExecutor::executeCommand(std::string exe, std::vector<std::string> args, std::string redirect, std::string *output_)
{
output_->clear();
std::string joinedArgs;
for (const std::string &arg : args) {
if (!joinedArgs.empty())
joinedArgs += " ";
if (arg.find(" ") != std::string::npos)
joinedArgs += '"' + arg + '"';
else
joinedArgs += arg;
}
#ifdef _WIN32
// Extra quoutes are needed in windows if filename has space
if (exe.find(" ") != std::string::npos)
exe = "\"" + exe + "\"";
const std::string cmd = exe + " " + joinedArgs + " " + redirect;
std::unique_ptr<FILE, decltype(&_pclose)> pipe(_popen(cmd.c_str(), "r"), _pclose);
#else
const std::string cmd = exe + " " + joinedArgs + " " + redirect;
std::unique_ptr<FILE, decltype(&pclose)> pipe(popen(cmd.c_str(), "r"), pclose);
#endif
if (!pipe)
return false;
char buffer[1024];
while (fgets(buffer, sizeof(buffer), pipe.get()) != nullptr)
*output_ += buffer;
return true;
}