2011-07-28 23:29:16 +02:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2023-01-28 10:16:34 +01:00
|
|
|
* Copyright (C) 2007-2023 Cppcheck team.
|
2011-07-28 23:29:16 +02:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
2015-11-21 20:24:30 +01:00
|
|
|
|
2011-07-28 23:29:16 +02:00
|
|
|
//---------------------------------------------------------------------------
|
2015-11-21 20:24:30 +01:00
|
|
|
#ifndef checkfunctionsH
|
|
|
|
#define checkfunctionsH
|
2011-07-28 23:29:16 +02:00
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
#include "check.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
#include "config.h"
|
2022-01-27 19:03:20 +01:00
|
|
|
#include "errortypes.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
#include "library.h"
|
|
|
|
#include "settings.h"
|
2023-08-18 12:03:50 +02:00
|
|
|
#include "tokenize.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
|
|
|
|
#include <map>
|
2011-07-28 23:29:16 +02:00
|
|
|
#include <string>
|
2017-05-27 04:33:47 +02:00
|
|
|
#include <utility>
|
|
|
|
|
|
|
|
class Token;
|
2020-05-23 07:16:49 +02:00
|
|
|
class ErrorLogger;
|
|
|
|
|
2017-05-27 04:33:47 +02:00
|
|
|
namespace ValueFlow {
|
2017-05-28 15:56:26 +02:00
|
|
|
class Value;
|
2017-05-27 04:33:47 +02:00
|
|
|
} // namespace ValueFlow
|
2011-07-28 23:29:16 +02:00
|
|
|
|
|
|
|
|
|
|
|
/// @addtogroup Checks
|
|
|
|
/// @{
|
|
|
|
|
|
|
|
/**
|
2015-11-22 13:48:55 +01:00
|
|
|
* @brief Check for bad function usage
|
2011-07-28 23:29:16 +02:00
|
|
|
*/
|
|
|
|
|
2015-11-21 20:24:30 +01:00
|
|
|
class CPPCHECKLIB CheckFunctions : public Check {
|
2011-07-28 23:29:16 +02:00
|
|
|
public:
|
2015-11-21 20:24:30 +01:00
|
|
|
/** This constructor is used when registering the CheckFunctions */
|
2021-08-07 20:51:18 +02:00
|
|
|
CheckFunctions() : Check(myName()) {}
|
2011-07-28 23:29:16 +02:00
|
|
|
|
2023-09-11 11:12:42 +02:00
|
|
|
private:
|
2011-07-28 23:29:16 +02:00
|
|
|
/** This constructor is used when running checks. */
|
2015-11-21 20:24:30 +01:00
|
|
|
CheckFunctions(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
2021-08-07 20:51:18 +02:00
|
|
|
: Check(myName(), tokenizer, settings, errorLogger) {}
|
2011-07-28 23:29:16 +02:00
|
|
|
|
2015-11-22 13:48:55 +01:00
|
|
|
/** @brief Run checks against the normal token list */
|
2023-08-18 12:03:50 +02:00
|
|
|
void runChecks(const Tokenizer &tokenizer, ErrorLogger *errorLogger) override {
|
|
|
|
CheckFunctions checkFunctions(&tokenizer, tokenizer.getSettings(), errorLogger);
|
2015-11-22 13:48:55 +01:00
|
|
|
|
|
|
|
checkFunctions.checkIgnoredReturnValue();
|
2021-07-04 11:27:57 +02:00
|
|
|
checkFunctions.checkMissingReturn(); // Missing "return" in exit path
|
2015-11-22 13:48:55 +01:00
|
|
|
|
|
|
|
// --check-library : functions with nonmatching configuration
|
|
|
|
checkFunctions.checkLibraryMatchFunctions();
|
|
|
|
|
|
|
|
checkFunctions.checkProhibitedFunctions();
|
|
|
|
checkFunctions.invalidFunctionUsage();
|
|
|
|
checkFunctions.checkMathFunctions();
|
2017-04-23 07:53:41 +02:00
|
|
|
checkFunctions.memsetZeroBytes();
|
|
|
|
checkFunctions.memsetInvalid2ndParam();
|
2021-07-06 08:07:46 +02:00
|
|
|
checkFunctions.returnLocalStdMove();
|
2022-09-03 23:29:06 +02:00
|
|
|
checkFunctions.useStandardLibrary();
|
2011-07-28 23:29:16 +02:00
|
|
|
}
|
|
|
|
|
2015-11-21 20:24:30 +01:00
|
|
|
/** Check for functions that should not be used */
|
2015-11-22 13:48:55 +01:00
|
|
|
void checkProhibitedFunctions();
|
|
|
|
|
|
|
|
/**
|
2021-08-07 20:51:18 +02:00
|
|
|
* @brief Invalid function usage (invalid input value / overlapping data)
|
|
|
|
*
|
|
|
|
* %Check that given function parameters are valid according to the standard
|
|
|
|
* - wrong radix given for strtol/strtoul
|
|
|
|
* - overlapping data when using sprintf/snprintf
|
|
|
|
* - wrong input value according to library
|
|
|
|
*/
|
2015-11-22 13:48:55 +01:00
|
|
|
void invalidFunctionUsage();
|
|
|
|
|
|
|
|
/** @brief %Check for ignored return values. */
|
|
|
|
void checkIgnoredReturnValue();
|
|
|
|
|
|
|
|
/** @brief %Check for parameters given to math function that do not make sense*/
|
|
|
|
void checkMathFunctions();
|
|
|
|
|
2017-04-23 07:53:41 +02:00
|
|
|
/** @brief %Check for filling zero bytes with memset() */
|
|
|
|
void memsetZeroBytes();
|
|
|
|
|
|
|
|
/** @brief %Check for invalid 2nd parameter of memset() */
|
|
|
|
void memsetInvalid2ndParam();
|
|
|
|
|
2021-07-06 08:07:46 +02:00
|
|
|
/** @brief %Check for copy elision by RVO|NRVO */
|
|
|
|
void returnLocalStdMove();
|
|
|
|
|
2022-09-03 23:29:06 +02:00
|
|
|
void useStandardLibrary();
|
|
|
|
|
2015-11-22 13:48:55 +01:00
|
|
|
/** @brief --check-library: warn for unconfigured function calls */
|
|
|
|
void checkLibraryMatchFunctions();
|
2011-07-28 23:29:16 +02:00
|
|
|
|
2021-07-04 11:27:57 +02:00
|
|
|
/** @brief %Check for missing "return" */
|
|
|
|
void checkMissingReturn();
|
|
|
|
|
2017-04-20 22:14:54 +02:00
|
|
|
void invalidFunctionArgError(const Token *tok, const std::string &functionName, int argnr, const ValueFlow::Value *invalidValue, const std::string &validstr);
|
2015-11-22 13:48:55 +01:00
|
|
|
void invalidFunctionArgBoolError(const Token *tok, const std::string &functionName, int argnr);
|
2019-07-16 08:49:02 +02:00
|
|
|
void invalidFunctionArgStrError(const Token *tok, const std::string &functionName, nonneg int argnr);
|
2015-11-22 13:48:55 +01:00
|
|
|
void ignoredReturnValueError(const Token* tok, const std::string& function);
|
2020-11-05 13:35:52 +01:00
|
|
|
void ignoredReturnErrorCode(const Token* tok, const std::string& function);
|
2019-07-16 08:49:02 +02:00
|
|
|
void mathfunctionCallWarning(const Token *tok, const nonneg int numParam = 1);
|
2015-11-22 13:48:55 +01:00
|
|
|
void mathfunctionCallWarning(const Token *tok, const std::string& oldexp, const std::string& newexp);
|
2017-04-23 07:53:41 +02:00
|
|
|
void memsetZeroBytesError(const Token *tok);
|
|
|
|
void memsetFloatError(const Token *tok, const std::string &var_value);
|
|
|
|
void memsetValueOutOfRangeError(const Token *tok, const std::string &value);
|
2021-09-01 19:49:53 +02:00
|
|
|
void missingReturnError(const Token *tok);
|
2021-07-06 08:07:46 +02:00
|
|
|
void copyElisionError(const Token *tok);
|
2022-09-03 23:29:06 +02:00
|
|
|
void useStandardLibraryError(const Token *tok, const std::string& expected);
|
2015-11-22 13:48:55 +01:00
|
|
|
|
2022-02-10 23:02:24 +01:00
|
|
|
void getErrorMessages(ErrorLogger *errorLogger, const Settings *settings) const override {
|
2016-05-07 16:30:54 +02:00
|
|
|
CheckFunctions c(nullptr, settings, errorLogger);
|
2011-07-28 23:29:16 +02:00
|
|
|
|
2015-11-21 20:24:30 +01:00
|
|
|
for (std::map<std::string, Library::WarnInfo>::const_iterator i = settings->library.functionwarn.cbegin(); i != settings->library.functionwarn.cend(); ++i) {
|
2016-05-07 16:30:54 +02:00
|
|
|
c.reportError(nullptr, Severity::style, i->first+"Called", i->second.message);
|
2015-11-21 20:24:30 +01:00
|
|
|
}
|
2015-11-22 13:48:55 +01:00
|
|
|
|
2017-04-20 22:14:54 +02:00
|
|
|
c.invalidFunctionArgError(nullptr, "func_name", 1, nullptr,"1:4");
|
2016-05-07 16:30:54 +02:00
|
|
|
c.invalidFunctionArgBoolError(nullptr, "func_name", 1);
|
2018-10-14 18:49:34 +02:00
|
|
|
c.invalidFunctionArgStrError(nullptr, "func_name", 1);
|
2016-05-07 16:30:54 +02:00
|
|
|
c.ignoredReturnValueError(nullptr, "malloc");
|
|
|
|
c.mathfunctionCallWarning(nullptr);
|
|
|
|
c.mathfunctionCallWarning(nullptr, "1 - erf(x)", "erfc(x)");
|
2017-04-23 07:53:41 +02:00
|
|
|
c.memsetZeroBytesError(nullptr);
|
|
|
|
c.memsetFloatError(nullptr, "varname");
|
|
|
|
c.memsetValueOutOfRangeError(nullptr, "varname");
|
2021-07-04 11:27:57 +02:00
|
|
|
c.missingReturnError(nullptr);
|
2021-07-06 08:07:46 +02:00
|
|
|
c.copyElisionError(nullptr);
|
2022-09-03 23:29:06 +02:00
|
|
|
c.useStandardLibraryError(nullptr, "memcpy");
|
2015-11-21 20:24:30 +01:00
|
|
|
}
|
2011-07-28 23:29:16 +02:00
|
|
|
|
2014-11-20 14:20:09 +01:00
|
|
|
static std::string myName() {
|
2015-11-21 20:24:30 +01:00
|
|
|
return "Check function usage";
|
2011-07-28 23:29:16 +02:00
|
|
|
}
|
|
|
|
|
2022-02-10 23:02:24 +01:00
|
|
|
std::string classInfo() const override {
|
2015-11-22 13:48:55 +01:00
|
|
|
return "Check function usage:\n"
|
2021-07-04 11:27:57 +02:00
|
|
|
"- missing 'return' in non-void function\n"
|
2015-11-22 13:48:55 +01:00
|
|
|
"- return value of certain functions not used\n"
|
|
|
|
"- invalid input values for functions\n"
|
2017-04-23 07:53:41 +02:00
|
|
|
"- Warn if a function is called whose usage is discouraged\n"
|
|
|
|
"- memset() third argument is zero\n"
|
|
|
|
"- memset() with a value out of range as the 2nd parameter\n"
|
2021-07-06 08:07:46 +02:00
|
|
|
"- memset() with a float as the 2nd parameter\n"
|
2022-09-03 23:29:06 +02:00
|
|
|
"- copy elision optimization for returning value affected by std::move\n"
|
|
|
|
"- use memcpy()/memset() instead of for loop\n";
|
2015-11-21 20:24:30 +01:00
|
|
|
}
|
2011-07-28 23:29:16 +02:00
|
|
|
};
|
|
|
|
/// @}
|
|
|
|
//---------------------------------------------------------------------------
|
2015-11-21 20:24:30 +01:00
|
|
|
#endif // checkfunctionsH
|