2011-07-06 08:55:17 +02:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2023-09-04 19:44:27 +02:00
|
|
|
* Copyright (C) 2007-2023 Cppcheck team.
|
2011-07-06 08:55:17 +02:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
// 64-bit portability
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
#include "check64bit.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
|
2022-01-27 19:03:20 +01:00
|
|
|
#include "errortypes.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
#include "settings.h"
|
2011-07-06 08:55:17 +02:00
|
|
|
#include "symboldatabase.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
#include "token.h"
|
|
|
|
#include "tokenize.h"
|
|
|
|
|
2022-01-27 19:03:20 +01:00
|
|
|
#include <vector>
|
2011-07-06 08:55:17 +02:00
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
Mapped toomanyconfigs ,AssignmentAddressToInteger
,AssignmentIntegerToAddress ,CastIntegerToAddressAtReturn
,CastAddressToIntegerAtReturn ,assertWithSideEffect ,assignmentInAssert
,uselessAssignmentArg ,uselessAssignmentPtrArg
,comparisonOfFuncReturningBoolError
,comparisonOfTwoFuncsReturningBoolError ,comparisonOfBoolWithBoolError
,incrementboolean ,comparisonOfBoolWithInt ,compareBoolExpressionWithInt
,negativeIndex ,pointerOutOfBounds ,arrayIndexThenCheck
,possibleBufferAccessOutOfBounds ,argumentSize
,arrayIndexOutOfBoundsCond ,noConstructor ,copyCtorPointerCopying
,noCopyConstructor ,uninitMemberVar ,operatorEqVarError
,unusedPrivateFunction ,memsetClassFloat ,mallocOnClassWarning
,operatorEq ,thisSubtraction ,operatorEqRetRefThis ,operatorEqToSelf
,useInitializationList ,duplInheritedMember ,assignIfError
,comparisonError ,multiCondition ,mismatchingBitAnd
,oppositeInnerCondition ,incorrectLogicOperator ,redundantCondition
,moduloAlwaysTrueFalse to their CWEs ids.
2016-02-20 23:56:36 +01:00
|
|
|
// CWE ids used
|
|
|
|
static const struct CWE CWE398(398U); // Indicator of Poor Code Quality
|
|
|
|
static const struct CWE CWE758(758U); // Reliance on Undefined, Unspecified, or Implementation-Defined Behavior
|
|
|
|
|
2011-07-06 08:55:17 +02:00
|
|
|
// Register this check class (by creating a static instance of it)
|
2011-10-13 20:53:06 +02:00
|
|
|
namespace {
|
|
|
|
Check64BitPortability instance;
|
2011-07-06 08:55:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void Check64BitPortability::pointerassignment()
|
|
|
|
{
|
2021-02-24 22:00:06 +01:00
|
|
|
if (!mSettings->severity.isEnabled(Severity::portability))
|
2011-07-06 08:55:17 +02:00
|
|
|
return;
|
|
|
|
|
2023-08-29 12:00:52 +02:00
|
|
|
logChecker("Check64BitPortability::pointerassignment"); // portability
|
|
|
|
|
2018-06-16 16:10:28 +02:00
|
|
|
const SymbolDatabase *symbolDatabase = mTokenizer->getSymbolDatabase();
|
2012-04-26 13:39:19 +02:00
|
|
|
|
|
|
|
// Check return values
|
2018-04-20 22:10:29 +02:00
|
|
|
for (const Scope * scope : symbolDatabase->functionScopes) {
|
2017-08-09 20:00:26 +02:00
|
|
|
if (scope->function == nullptr || !scope->function->hasBody()) // We only look for functions with a body
|
2012-04-26 13:39:19 +02:00
|
|
|
continue;
|
|
|
|
|
|
|
|
bool retPointer = false;
|
|
|
|
if (scope->function->token->strAt(-1) == "*") // Function returns a pointer
|
|
|
|
retPointer = true;
|
|
|
|
else if (Token::Match(scope->function->token->previous(), "int|long|DWORD")) // Function returns an integer
|
|
|
|
;
|
|
|
|
else
|
|
|
|
continue;
|
|
|
|
|
2018-04-27 22:36:30 +02:00
|
|
|
for (const Token* tok = scope->bodyStart->next(); tok != scope->bodyEnd; tok = tok->next()) {
|
2015-12-31 18:53:07 +01:00
|
|
|
// skip nested functions
|
|
|
|
if (tok->str() == "{") {
|
2016-05-04 13:23:50 +02:00
|
|
|
if (tok->scope()->type == Scope::ScopeType::eFunction || tok->scope()->type == Scope::ScopeType::eLambda)
|
2015-12-31 18:53:07 +01:00
|
|
|
tok = tok->link();
|
|
|
|
}
|
|
|
|
|
2015-12-30 19:59:23 +01:00
|
|
|
if (tok->str() != "return")
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!tok->astOperand1() || tok->astOperand1()->isNumber())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
const ValueType * const returnType = tok->astOperand1()->valueType();
|
|
|
|
if (!returnType)
|
|
|
|
continue;
|
|
|
|
|
2016-07-29 21:53:58 +02:00
|
|
|
if (retPointer && !returnType->typeScope && returnType->pointer == 0U)
|
2015-12-30 19:59:23 +01:00
|
|
|
returnIntegerError(tok);
|
|
|
|
|
|
|
|
if (!retPointer && returnType->pointer >= 1U)
|
|
|
|
returnPointerError(tok);
|
2012-04-26 13:39:19 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-01-16 15:37:07 +01:00
|
|
|
// Check assignments
|
2018-04-20 22:10:29 +02:00
|
|
|
for (const Scope * scope : symbolDatabase->functionScopes) {
|
2018-04-27 22:36:30 +02:00
|
|
|
for (const Token *tok = scope->bodyStart; tok && tok != scope->bodyEnd; tok = tok->next()) {
|
2015-12-30 19:59:23 +01:00
|
|
|
if (tok->str() != "=")
|
|
|
|
continue;
|
|
|
|
|
|
|
|
const ValueType *lhstype = tok->astOperand1() ? tok->astOperand1()->valueType() : nullptr;
|
|
|
|
const ValueType *rhstype = tok->astOperand2() ? tok->astOperand2()->valueType() : nullptr;
|
|
|
|
if (!lhstype || !rhstype)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Assign integer to pointer..
|
|
|
|
if (lhstype->pointer >= 1U &&
|
2015-12-30 20:59:22 +01:00
|
|
|
!tok->astOperand2()->isNumber() &&
|
2015-12-30 19:59:23 +01:00
|
|
|
rhstype->pointer == 0U &&
|
|
|
|
rhstype->originalTypeName.empty() &&
|
|
|
|
rhstype->type == ValueType::Type::INT)
|
|
|
|
assignmentIntegerToAddressError(tok);
|
|
|
|
|
|
|
|
// Assign pointer to integer..
|
|
|
|
if (rhstype->pointer >= 1U &&
|
|
|
|
lhstype->pointer == 0U &&
|
|
|
|
lhstype->originalTypeName.empty() &&
|
2017-03-30 10:07:25 +02:00
|
|
|
lhstype->isIntegral() &&
|
|
|
|
lhstype->type >= ValueType::Type::CHAR &&
|
|
|
|
lhstype->type <= ValueType::Type::INT)
|
2015-12-30 19:59:23 +01:00
|
|
|
assignmentAddressToIntegerError(tok);
|
2011-07-06 08:55:17 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-07-06 17:57:39 +02:00
|
|
|
void Check64BitPortability::assignmentAddressToIntegerError(const Token *tok)
|
2011-07-06 08:55:17 +02:00
|
|
|
{
|
|
|
|
reportError(tok, Severity::portability,
|
2011-07-06 17:57:39 +02:00
|
|
|
"AssignmentAddressToInteger",
|
2012-07-08 11:38:58 +02:00
|
|
|
"Assigning a pointer to an integer is not portable.\n"
|
|
|
|
"Assigning a pointer to an integer (int/long/etc) is not portable across different platforms and "
|
2011-07-06 12:57:45 +02:00
|
|
|
"compilers. For example in 32-bit Windows and linux they are same width, but in 64-bit Windows and linux "
|
|
|
|
"they are of different width. In worst case you end up assigning 64-bit address to 32-bit integer. The safe "
|
2021-02-24 22:00:06 +01:00
|
|
|
"way is to store addresses only in pointer types (or typedefs like uintptr_t).", CWE758, Certainty::normal);
|
2011-07-06 08:55:17 +02:00
|
|
|
}
|
2011-07-06 17:57:39 +02:00
|
|
|
|
|
|
|
void Check64BitPortability::assignmentIntegerToAddressError(const Token *tok)
|
|
|
|
{
|
|
|
|
reportError(tok, Severity::portability,
|
|
|
|
"AssignmentIntegerToAddress",
|
2012-07-08 11:38:58 +02:00
|
|
|
"Assigning an integer to a pointer is not portable.\n"
|
2011-07-06 17:57:39 +02:00
|
|
|
"Assigning an integer (int/long/etc) to a pointer is not portable across different platforms and "
|
|
|
|
"compilers. For example in 32-bit Windows and linux they are same width, but in 64-bit Windows and linux "
|
2012-07-08 11:38:58 +02:00
|
|
|
"they are of different width. In worst case you end up assigning 64-bit integer to 32-bit pointer. The safe "
|
2021-02-24 22:00:06 +01:00
|
|
|
"way is to store addresses only in pointer types (or typedefs like uintptr_t).", CWE758, Certainty::normal);
|
2011-07-06 17:57:39 +02:00
|
|
|
}
|
2012-04-26 13:39:19 +02:00
|
|
|
|
|
|
|
void Check64BitPortability::returnPointerError(const Token *tok)
|
|
|
|
{
|
|
|
|
reportError(tok, Severity::portability,
|
|
|
|
"CastAddressToIntegerAtReturn",
|
|
|
|
"Returning an address value in a function with integer return type is not portable.\n"
|
|
|
|
"Returning an address value in a function with integer (int/long/etc) return type is not portable across "
|
|
|
|
"different platforms and compilers. For example in 32-bit Windows and Linux they are same width, but in "
|
|
|
|
"64-bit Windows and Linux they are of different width. In worst case you end up casting 64-bit address down "
|
2021-02-24 22:00:06 +01:00
|
|
|
"to 32-bit integer. The safe way is to always return an integer.", CWE758, Certainty::normal);
|
2012-04-26 13:39:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void Check64BitPortability::returnIntegerError(const Token *tok)
|
|
|
|
{
|
|
|
|
reportError(tok, Severity::portability,
|
|
|
|
"CastIntegerToAddressAtReturn",
|
2012-07-08 11:38:58 +02:00
|
|
|
"Returning an integer in a function with pointer return type is not portable.\n"
|
|
|
|
"Returning an integer (int/long/etc) in a function with pointer return type is not portable across different "
|
2012-04-26 13:39:19 +02:00
|
|
|
"platforms and compilers. For example in 32-bit Windows and Linux they are same width, but in 64-bit Windows "
|
2012-07-08 11:38:58 +02:00
|
|
|
"and Linux they are of different width. In worst case you end up casting 64-bit integer down to 32-bit pointer. "
|
2021-02-24 22:00:06 +01:00
|
|
|
"The safe way is to always return a pointer.", CWE758, Certainty::normal);
|
2012-04-26 13:39:19 +02:00
|
|
|
}
|