2009-01-31 20:29:27 +01:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
|
|
* Copyright (C) 2007-2009 Daniel Marjamäki, Reijo Tomperi, Nicolas Le Cam,
|
2009-03-01 20:52:33 +01:00
|
|
|
* Leandro Penz, Kimmo Varis, Vesa Pikki
|
2009-01-31 20:29:27 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#ifndef CheckOtherH
|
|
|
|
#define CheckOtherH
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
2009-03-20 18:16:21 +01:00
|
|
|
#include "check.h"
|
|
|
|
#include "settings.h"
|
2009-01-31 20:29:27 +01:00
|
|
|
|
2009-03-20 18:16:21 +01:00
|
|
|
class Token;
|
|
|
|
|
|
|
|
class CheckOther : public Check
|
2009-01-31 20:29:27 +01:00
|
|
|
{
|
|
|
|
public:
|
2009-03-21 07:53:23 +01:00
|
|
|
/** This constructor is used when registering the CheckClass */
|
2009-03-20 18:16:21 +01:00
|
|
|
CheckOther() : Check()
|
|
|
|
{ }
|
|
|
|
|
2009-03-21 07:53:23 +01:00
|
|
|
/** This constructor is used when running checks.. */
|
2009-03-20 18:16:21 +01:00
|
|
|
CheckOther(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
|
|
|
: Check(tokenizer, settings, errorLogger)
|
|
|
|
{ }
|
|
|
|
|
|
|
|
|
|
|
|
void runChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
2009-03-21 07:53:23 +01:00
|
|
|
{
|
|
|
|
CheckOther checkOther(tokenizer, settings, errorLogger);
|
|
|
|
checkOther.CheckUnsignedDivision();
|
|
|
|
checkOther.CheckCharVariable();
|
|
|
|
}
|
|
|
|
|
|
|
|
void runSimplifiedChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
2009-03-20 18:16:21 +01:00
|
|
|
{
|
|
|
|
CheckOther checkOther(tokenizer, settings, errorLogger);
|
|
|
|
|
|
|
|
if (settings->_checkCodingStyle)
|
|
|
|
{
|
|
|
|
checkOther.WarningOldStylePointerCast();
|
|
|
|
checkOther.WarningRedundantCode();
|
|
|
|
checkOther.WarningIf();
|
|
|
|
checkOther.CheckVariableScope();
|
|
|
|
checkOther.CheckConstantFunctionParameter();
|
|
|
|
checkOther.CheckStructMemberUsage();
|
|
|
|
checkOther.CheckIncompleteStatement();
|
|
|
|
}
|
|
|
|
|
|
|
|
checkOther.strPlusChar();
|
|
|
|
checkOther.returnPointerToStackData();
|
|
|
|
checkOther.InvalidFunctionUsage();
|
|
|
|
}
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Casting
|
|
|
|
void WarningOldStylePointerCast();
|
|
|
|
|
|
|
|
// Redundant code
|
|
|
|
void WarningRedundantCode();
|
|
|
|
|
|
|
|
// Warning upon: if (condition);
|
|
|
|
void WarningIf();
|
|
|
|
|
|
|
|
// Invalid function usage..
|
|
|
|
void InvalidFunctionUsage();
|
|
|
|
|
|
|
|
// Check for unsigned division that might create bad results
|
|
|
|
void CheckUnsignedDivision();
|
|
|
|
|
|
|
|
// Check scope of variables
|
|
|
|
void CheckVariableScope();
|
|
|
|
|
|
|
|
// Check for constant function parameter
|
|
|
|
void CheckConstantFunctionParameter();
|
|
|
|
|
|
|
|
// Check that all struct members are used
|
|
|
|
void CheckStructMemberUsage();
|
|
|
|
|
|
|
|
// Using char variable as array index / as operand in bit operation
|
|
|
|
void CheckCharVariable();
|
|
|
|
|
|
|
|
// Incomplete statement. A statement that only contains a constant or variable
|
|
|
|
void CheckIncompleteStatement();
|
|
|
|
|
|
|
|
/** str plus char */
|
|
|
|
void strPlusChar();
|
|
|
|
|
2009-02-04 19:49:19 +01:00
|
|
|
/** Returning pointer to local data */
|
|
|
|
void returnPointerToStackData();
|
|
|
|
|
2009-02-07 21:06:00 +01:00
|
|
|
protected:
|
2009-01-31 20:29:27 +01:00
|
|
|
void CheckVariableScope_LookupVar(const Token *tok1, const char varname[]);
|
|
|
|
|
|
|
|
// Redundant condition
|
|
|
|
// if (haystack.find(needle) != haystack.end())
|
|
|
|
// haystack.remove(needle);
|
|
|
|
void redundantCondition2();
|
|
|
|
};
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#endif
|
|
|
|
|