2009-10-19 20:57:11 +02:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2010-04-13 21:23:17 +02:00
|
|
|
* Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team.
|
2009-10-19 20:57:11 +02:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#include "checkexceptionsafety.h"
|
|
|
|
|
|
|
|
#include "token.h"
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
// Register CheckExceptionSafety..
|
|
|
|
namespace
|
|
|
|
{
|
|
|
|
CheckExceptionSafety instance;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
void CheckExceptionSafety::destructors()
|
|
|
|
{
|
|
|
|
// This is a style error..
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!_settings->_checkCodingStyle)
|
2009-10-19 20:57:11 +02:00
|
|
|
return;
|
|
|
|
|
|
|
|
// Perform check..
|
2010-04-02 07:30:58 +02:00
|
|
|
for (const Token * tok = _tokenizer->tokens(); tok; tok = tok->next())
|
2009-10-19 20:57:11 +02:00
|
|
|
{
|
2010-12-31 13:58:17 +01:00
|
|
|
// Skip executable scopes
|
2010-04-02 07:30:58 +02:00
|
|
|
if (Token::simpleMatch(tok, ") {"))
|
2009-10-19 20:57:11 +02:00
|
|
|
tok = tok->next()->link();
|
|
|
|
|
2010-12-31 13:58:17 +01:00
|
|
|
// only looking for destructors
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!Token::Match(tok, "~ %var% ( ) {"))
|
2009-10-19 20:57:11 +02:00
|
|
|
continue;
|
|
|
|
|
|
|
|
// Inspect this destructor..
|
|
|
|
unsigned int indentlevel = 0;
|
2010-04-02 07:30:58 +02:00
|
|
|
for (const Token *tok2 = tok->tokAt(5); tok2; tok2 = tok2->next())
|
2009-10-19 20:57:11 +02:00
|
|
|
{
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok2->str() == "{")
|
2009-10-19 20:57:11 +02:00
|
|
|
{
|
|
|
|
++indentlevel;
|
|
|
|
}
|
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (tok2->str() == "}")
|
2009-10-19 20:57:11 +02:00
|
|
|
{
|
2010-04-02 07:30:58 +02:00
|
|
|
if (indentlevel <= 1)
|
2009-10-19 20:57:11 +02:00
|
|
|
break;
|
|
|
|
--indentlevel;
|
|
|
|
}
|
|
|
|
|
2010-12-31 13:58:17 +01:00
|
|
|
// throw found within a destructor
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (tok2->str() == "throw")
|
2009-10-19 20:57:11 +02:00
|
|
|
{
|
|
|
|
destructorsError(tok2);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-10-31 18:58:42 +01:00
|
|
|
|
2009-11-08 09:54:08 +01:00
|
|
|
|
|
|
|
|
|
|
|
void CheckExceptionSafety::deallocThrow()
|
|
|
|
{
|
2010-12-31 13:58:17 +01:00
|
|
|
// Deallocate a global/member pointer and then throw exception
|
|
|
|
// the pointer will be a dead pointer
|
2010-04-02 07:30:58 +02:00
|
|
|
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next())
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
2010-12-31 13:58:17 +01:00
|
|
|
// only looking for delete now
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok->str() != "delete")
|
2009-11-08 09:54:08 +01:00
|
|
|
continue;
|
|
|
|
|
|
|
|
// Check if this is something similar with: "delete p;"
|
|
|
|
tok = tok->next();
|
2010-04-02 07:30:58 +02:00
|
|
|
if (Token::simpleMatch(tok, "[ ]"))
|
2009-11-08 09:54:08 +01:00
|
|
|
tok = tok->tokAt(2);
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!tok)
|
2009-11-08 09:54:08 +01:00
|
|
|
break;
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!Token::Match(tok, "%var% ;"))
|
2009-11-08 09:54:08 +01:00
|
|
|
continue;
|
|
|
|
const unsigned int varid(tok->varId());
|
2010-04-02 07:30:58 +02:00
|
|
|
if (varid == 0)
|
2009-11-08 09:54:08 +01:00
|
|
|
continue;
|
|
|
|
|
|
|
|
// is this variable a global variable?
|
|
|
|
{
|
2010-12-31 13:58:17 +01:00
|
|
|
// TODO: Isn't it better to use symbol database instead?
|
2009-11-08 09:54:08 +01:00
|
|
|
bool globalVar = false;
|
2010-04-02 07:30:58 +02:00
|
|
|
for (const Token *tok2 = _tokenizer->tokens(); tok2; tok2 = tok2->next())
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
2011-01-07 20:45:33 +01:00
|
|
|
if (tok2->varId() == varid)
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
|
|
|
globalVar = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok2->str() == "class")
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
2010-04-02 07:30:58 +02:00
|
|
|
while (tok2 && tok2->str() != ";" && tok2->str() != "{")
|
2009-11-08 09:54:08 +01:00
|
|
|
tok2 = tok2->next();
|
|
|
|
tok2 = tok2 ? tok2->next() : 0;
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!tok2)
|
2009-11-08 09:54:08 +01:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok2->str() == "{")
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
|
|
|
tok2 = tok2->link();
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!tok2)
|
2009-11-08 09:54:08 +01:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2010-12-31 13:58:17 +01:00
|
|
|
|
|
|
|
// Not a global variable.. skip checking this var.
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!globalVar)
|
2009-11-08 09:54:08 +01:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2010-12-31 13:58:17 +01:00
|
|
|
// indentlevel..
|
2009-11-08 09:54:08 +01:00
|
|
|
unsigned int indentlevel = 0;
|
2010-12-31 13:58:17 +01:00
|
|
|
|
|
|
|
// Token where throw occurs
|
2009-11-08 09:54:08 +01:00
|
|
|
const Token *ThrowToken = 0;
|
2010-12-31 13:58:17 +01:00
|
|
|
|
|
|
|
// is there a throw after the deallocation?
|
2010-04-02 07:30:58 +02:00
|
|
|
for (const Token *tok2 = tok; tok2; tok2 = tok2->next())
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok2->str() == "{")
|
2009-11-08 09:54:08 +01:00
|
|
|
++indentlevel;
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (tok2->str() == "}")
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
2010-04-02 07:30:58 +02:00
|
|
|
if (indentlevel == 0)
|
2009-11-08 09:54:08 +01:00
|
|
|
break;
|
|
|
|
--indentlevel;
|
|
|
|
}
|
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok2->str() == "throw")
|
2009-11-08 09:54:08 +01:00
|
|
|
ThrowToken = tok2;
|
|
|
|
|
2010-12-31 13:58:17 +01:00
|
|
|
// if the variable is not assigned after the throw then it
|
|
|
|
// is assumed that it is not the intention that it is a dead pointer.
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (Token::Match(tok2, "%varid% =", varid))
|
2009-11-08 09:54:08 +01:00
|
|
|
{
|
2010-04-02 07:30:58 +02:00
|
|
|
if (ThrowToken)
|
2009-11-08 09:54:08 +01:00
|
|
|
deallocThrowError(ThrowToken, tok->str());
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|