2017-10-09 15:25:55 +02:00
|
|
|
#!/usr/bin/env python
|
|
|
|
#
|
|
|
|
# MISRA C 2012 checkers
|
|
|
|
#
|
|
|
|
# Example usage of this addon (scan a sourcefile main.cpp)
|
|
|
|
# cppcheck --dump main.cpp
|
2018-01-20 14:13:09 +01:00
|
|
|
# python misra.py --rule-texts=<path-to-rule-texts> main.cpp.dump
|
2017-10-09 15:25:55 +02:00
|
|
|
#
|
|
|
|
# Limitations: This addon is released as open source. Rule texts can't be freely
|
|
|
|
# distributed. https://www.misra.org.uk/forum/viewtopic.php?f=56&t=1189
|
|
|
|
#
|
2018-03-16 08:12:39 +01:00
|
|
|
# The MISRA standard documents may be obtained from https://www.misra.org.uk
|
|
|
|
#
|
2018-04-10 08:55:25 +02:00
|
|
|
# Total number of rules: 143
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-05-21 21:46:58 +02:00
|
|
|
from __future__ import print_function
|
|
|
|
|
2017-10-09 15:25:55 +02:00
|
|
|
import cppcheckdata
|
|
|
|
import sys
|
|
|
|
import re
|
2018-01-20 14:13:09 +01:00
|
|
|
import os
|
2018-05-24 06:31:20 +02:00
|
|
|
import argparse
|
2019-01-18 21:30:08 +01:00
|
|
|
import codecs
|
2019-09-28 20:16:10 +02:00
|
|
|
import string
|
|
|
|
|
|
|
|
try:
|
|
|
|
from itertools import izip as zip
|
|
|
|
except ImportError:
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
|
|
def grouped(iterable, n):
|
|
|
|
"s -> (s0,s1,s2,...sn-1), (sn,sn+1,sn+2,...s2n-1), (s2n,s2n+1,s2n+2,...s3n-1), ..."
|
|
|
|
return zip(*[iter(iterable)]*n)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
typeBits = {
|
|
|
|
'CHAR': None,
|
|
|
|
'SHORT': None,
|
|
|
|
'INT': None,
|
|
|
|
'LONG': None,
|
|
|
|
'LONG_LONG': None,
|
|
|
|
'POINTER': None
|
|
|
|
}
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2017-10-09 15:25:55 +02:00
|
|
|
def simpleMatch(token, pattern):
|
|
|
|
for p in pattern.split(' '):
|
|
|
|
if not token or token.str != p:
|
|
|
|
return False
|
|
|
|
token = token.next
|
|
|
|
return True
|
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2018-03-13 14:22:25 +01:00
|
|
|
def rawlink(rawtoken):
|
|
|
|
if rawtoken.str == '}':
|
|
|
|
indent = 0
|
|
|
|
while rawtoken:
|
|
|
|
if rawtoken.str == '}':
|
|
|
|
indent = indent + 1
|
|
|
|
elif rawtoken.str == '{':
|
|
|
|
indent = indent - 1
|
|
|
|
if indent == 0:
|
|
|
|
break
|
|
|
|
rawtoken = rawtoken.previous
|
|
|
|
else:
|
|
|
|
rawtoken = None
|
|
|
|
return rawtoken
|
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2017-10-09 15:25:55 +02:00
|
|
|
KEYWORDS = {
|
|
|
|
'auto',
|
|
|
|
'break',
|
|
|
|
'case',
|
|
|
|
'char',
|
|
|
|
'const',
|
|
|
|
'continue',
|
|
|
|
'default',
|
|
|
|
'do',
|
|
|
|
'double',
|
|
|
|
'else',
|
|
|
|
'enum',
|
|
|
|
'extern',
|
|
|
|
'float',
|
|
|
|
'for',
|
|
|
|
'goto',
|
|
|
|
'if',
|
|
|
|
'int',
|
|
|
|
'long',
|
|
|
|
'register',
|
|
|
|
'return',
|
|
|
|
'short',
|
|
|
|
'signed',
|
|
|
|
'sizeof',
|
|
|
|
'static',
|
|
|
|
'struct',
|
|
|
|
'switch',
|
|
|
|
'typedef',
|
|
|
|
'union',
|
|
|
|
'unsigned',
|
|
|
|
'void',
|
|
|
|
'volatile',
|
|
|
|
'while'
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-05-21 12:04:20 +02:00
|
|
|
def getEssentialTypeCategory(expr):
|
|
|
|
if not expr:
|
|
|
|
return None
|
2019-08-11 10:15:07 +02:00
|
|
|
if expr.str == ',':
|
|
|
|
return getEssentialTypeCategory(expr.astOperand2)
|
|
|
|
if expr.str in ('<', '<=', '==', '!=', '>=', '>', '&&', '||', '!'):
|
|
|
|
return 'bool'
|
|
|
|
if expr.str in ('<<', '>>'):
|
|
|
|
# TODO this is incomplete
|
|
|
|
return getEssentialTypeCategory(expr.astOperand1)
|
|
|
|
if len(expr.str) == 1 and expr.str in '+-*/%&|^':
|
|
|
|
# TODO this is incomplete
|
2019-08-11 09:47:37 +02:00
|
|
|
e1 = getEssentialTypeCategory(expr.astOperand1)
|
|
|
|
e2 = getEssentialTypeCategory(expr.astOperand2)
|
|
|
|
#print('{0}: {1} {2}'.format(expr.str, e1, e2))
|
|
|
|
if e1 and e2 and e1 == e2:
|
|
|
|
return e1
|
|
|
|
if expr.valueType:
|
|
|
|
return expr.valueType.sign
|
2019-08-11 10:15:07 +02:00
|
|
|
if expr.valueType and expr.valueType.typeScope:
|
|
|
|
return "enum<" + expr.valueType.typeScope.className + ">"
|
2018-05-21 12:04:20 +02:00
|
|
|
if expr.variable:
|
|
|
|
typeToken = expr.variable.typeStartToken
|
|
|
|
while typeToken:
|
|
|
|
if typeToken.valueType:
|
2019-08-10 18:12:23 +02:00
|
|
|
if typeToken.valueType.type == 'bool':
|
2018-05-21 12:04:20 +02:00
|
|
|
return typeToken.valueType.type
|
2019-08-10 18:12:23 +02:00
|
|
|
if typeToken.valueType.type in ('float', 'double', 'long double'):
|
2018-05-21 12:04:20 +02:00
|
|
|
return "float"
|
|
|
|
if typeToken.valueType.sign:
|
|
|
|
return typeToken.valueType.sign
|
|
|
|
typeToken = typeToken.next
|
|
|
|
if expr.valueType:
|
|
|
|
return expr.valueType.sign
|
2018-05-23 16:26:00 +02:00
|
|
|
return None
|
2018-05-21 12:04:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
def getEssentialCategorylist(operand1, operand2):
|
|
|
|
if not operand1 or not operand2:
|
|
|
|
return None, None
|
2019-08-10 18:12:23 +02:00
|
|
|
if (operand1.str in ('++', '--') or
|
|
|
|
operand2.str in ('++', '--')):
|
2018-05-21 12:04:20 +02:00
|
|
|
return None, None
|
2019-04-10 21:21:17 +02:00
|
|
|
if ((operand1.valueType and operand1.valueType.pointer) or
|
|
|
|
(operand2.valueType and operand2.valueType.pointer)):
|
2018-05-21 12:04:20 +02:00
|
|
|
return None, None
|
|
|
|
e1 = getEssentialTypeCategory(operand1)
|
|
|
|
e2 = getEssentialTypeCategory(operand2)
|
|
|
|
return e1, e2
|
|
|
|
|
|
|
|
|
2017-10-09 15:25:55 +02:00
|
|
|
def getEssentialType(expr):
|
|
|
|
if not expr:
|
|
|
|
return None
|
|
|
|
if expr.variable:
|
|
|
|
typeToken = expr.variable.typeStartToken
|
|
|
|
while typeToken and typeToken.isName:
|
2019-08-10 18:12:23 +02:00
|
|
|
if typeToken.str in ('char', 'short', 'int', 'long', 'float', 'double'):
|
2017-10-09 15:25:55 +02:00
|
|
|
return typeToken.str
|
|
|
|
typeToken = typeToken.next
|
|
|
|
|
2019-08-10 18:12:23 +02:00
|
|
|
elif expr.astOperand1 and expr.astOperand2 and expr.str in ('+', '-', '*', '/', '%', '&', '|', '^', '>>', "<<", "?", ":"):
|
2018-05-24 22:28:36 +02:00
|
|
|
if expr.astOperand1.valueType and expr.astOperand1.valueType.pointer > 0:
|
|
|
|
return None
|
|
|
|
if expr.astOperand2.valueType and expr.astOperand2.valueType.pointer > 0:
|
|
|
|
return None
|
2017-10-09 15:25:55 +02:00
|
|
|
e1 = getEssentialType(expr.astOperand1)
|
|
|
|
e2 = getEssentialType(expr.astOperand2)
|
|
|
|
if not e1 or not e2:
|
|
|
|
return None
|
|
|
|
types = ['bool', 'char', 'short', 'int', 'long', 'long long']
|
|
|
|
try:
|
|
|
|
i1 = types.index(e1)
|
|
|
|
i2 = types.index(e2)
|
|
|
|
if i2 >= i1:
|
|
|
|
return types[i2]
|
|
|
|
return types[i1]
|
|
|
|
except ValueError:
|
|
|
|
return None
|
2018-05-24 22:28:36 +02:00
|
|
|
elif expr.str == "~":
|
|
|
|
e1 = getEssentialType(expr.astOperand1)
|
|
|
|
return e1
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
return None
|
|
|
|
|
|
|
|
|
|
|
|
def bitsOfEssentialType(expr):
|
|
|
|
type = getEssentialType(expr)
|
|
|
|
if type is None:
|
|
|
|
return 0
|
|
|
|
if type == 'char':
|
2018-05-24 06:31:20 +02:00
|
|
|
return typeBits['CHAR']
|
2017-10-09 15:25:55 +02:00
|
|
|
if type == 'short':
|
2018-05-24 06:31:20 +02:00
|
|
|
return typeBits['SHORT']
|
2017-10-09 15:25:55 +02:00
|
|
|
if type == 'int':
|
2018-05-24 06:31:20 +02:00
|
|
|
return typeBits['INT']
|
2017-10-09 15:25:55 +02:00
|
|
|
if type == 'long':
|
2018-05-24 06:31:20 +02:00
|
|
|
return typeBits['LONG']
|
2017-10-09 15:25:55 +02:00
|
|
|
if type == 'long long':
|
2018-05-24 06:31:20 +02:00
|
|
|
return typeBits['LONG_LONG']
|
2017-10-09 15:25:55 +02:00
|
|
|
return 0
|
|
|
|
|
|
|
|
|
|
|
|
def isCast(expr):
|
|
|
|
if not expr or expr.str != '(' or not expr.astOperand1 or expr.astOperand2:
|
|
|
|
return False
|
|
|
|
if simpleMatch(expr, '( )'):
|
|
|
|
return False
|
|
|
|
return True
|
|
|
|
|
|
|
|
|
|
|
|
def isFunctionCall(expr):
|
|
|
|
if not expr:
|
|
|
|
return False
|
|
|
|
if expr.str != '(' or not expr.astOperand1:
|
|
|
|
return False
|
|
|
|
if expr.astOperand1 != expr.previous:
|
|
|
|
return False
|
|
|
|
if expr.astOperand1.str in KEYWORDS:
|
|
|
|
return False
|
|
|
|
return True
|
|
|
|
|
|
|
|
|
2019-05-26 18:46:00 +02:00
|
|
|
def hasExternalLinkage(var):
|
2019-06-27 06:59:47 +02:00
|
|
|
return var.isGlobal and not var.isStatic
|
2019-05-26 18:46:00 +02:00
|
|
|
|
|
|
|
|
2017-10-09 15:25:55 +02:00
|
|
|
def countSideEffects(expr):
|
2019-08-10 18:12:23 +02:00
|
|
|
if not expr or expr.str in (',', ';'):
|
2017-10-09 15:25:55 +02:00
|
|
|
return 0
|
|
|
|
ret = 0
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('++', '--', '='):
|
2017-10-09 15:25:55 +02:00
|
|
|
ret = 1
|
|
|
|
return ret + countSideEffects(expr.astOperand1) + countSideEffects(expr.astOperand2)
|
|
|
|
|
|
|
|
|
|
|
|
def getForLoopExpressions(forToken):
|
|
|
|
if not forToken or forToken.str != 'for':
|
|
|
|
return None
|
|
|
|
lpar = forToken.next
|
|
|
|
if not lpar or lpar.str != '(':
|
|
|
|
return None
|
|
|
|
if not lpar.astOperand2 or lpar.astOperand2.str != ';':
|
|
|
|
return None
|
|
|
|
if not lpar.astOperand2.astOperand2 or lpar.astOperand2.astOperand2.str != ';':
|
|
|
|
return None
|
|
|
|
return [lpar.astOperand2.astOperand1,
|
|
|
|
lpar.astOperand2.astOperand2.astOperand1,
|
|
|
|
lpar.astOperand2.astOperand2.astOperand2]
|
|
|
|
|
|
|
|
|
2018-06-04 10:12:51 +02:00
|
|
|
def findCounterTokens(cond):
|
|
|
|
if not cond:
|
|
|
|
return []
|
|
|
|
if cond.str in ['&&', '||']:
|
|
|
|
c = findCounterTokens(cond.astOperand1)
|
|
|
|
c.extend(findCounterTokens(cond.astOperand2))
|
|
|
|
return c
|
|
|
|
ret = []
|
|
|
|
if ((cond.isArithmeticalOp and cond.astOperand1 and cond.astOperand2) or
|
|
|
|
(cond.isComparisonOp and cond.astOperand1 and cond.astOperand2)):
|
|
|
|
if cond.astOperand1.isName:
|
|
|
|
ret.append(cond.astOperand1)
|
|
|
|
if cond.astOperand2.isName:
|
|
|
|
ret.append(cond.astOperand2)
|
|
|
|
if cond.astOperand1.isOp:
|
|
|
|
ret.extend(findCounterTokens(cond.astOperand1))
|
|
|
|
if cond.astOperand2.isOp:
|
|
|
|
ret.extend(findCounterTokens(cond.astOperand2))
|
|
|
|
return ret
|
|
|
|
|
|
|
|
|
|
|
|
def isFloatCounterInWhileLoop(whileToken):
|
|
|
|
if not simpleMatch(whileToken, 'while ('):
|
|
|
|
return False
|
|
|
|
lpar = whileToken.next
|
|
|
|
rpar = lpar.link
|
|
|
|
counterTokens = findCounterTokens(lpar.astOperand2)
|
|
|
|
whileBodyStart = None
|
|
|
|
if simpleMatch(rpar, ') {'):
|
|
|
|
whileBodyStart = rpar.next
|
|
|
|
elif simpleMatch(whileToken.previous, '} while') and simpleMatch(whileToken.previous.link.previous, 'do {'):
|
|
|
|
whileBodyStart = whileToken.previous.link
|
|
|
|
else:
|
2017-10-09 15:25:55 +02:00
|
|
|
return False
|
2018-06-04 10:12:51 +02:00
|
|
|
token = whileBodyStart
|
2018-08-05 20:36:21 +02:00
|
|
|
while token != whileBodyStart.link:
|
2018-06-04 10:12:51 +02:00
|
|
|
token = token.next
|
|
|
|
for counterToken in counterTokens:
|
|
|
|
if not counterToken.valueType or not counterToken.valueType.isFloat():
|
|
|
|
continue
|
|
|
|
if token.isAssignmentOp and token.astOperand1.str == counterToken.str:
|
|
|
|
return True
|
2019-08-10 18:12:23 +02:00
|
|
|
if token.str == counterToken.str and token.astParent and token.astParent.str in ('++', '--'):
|
2018-06-04 10:12:51 +02:00
|
|
|
return True
|
2017-10-09 15:25:55 +02:00
|
|
|
return False
|
|
|
|
|
|
|
|
|
|
|
|
def hasSideEffectsRecursive(expr):
|
|
|
|
if not expr:
|
|
|
|
return False
|
|
|
|
if expr.str == '=' and expr.astOperand1 and expr.astOperand1.str == '[':
|
|
|
|
prev = expr.astOperand1.previous
|
|
|
|
if prev and (prev.str == '{' or prev.str == '{'):
|
|
|
|
return hasSideEffectsRecursive(expr.astOperand2)
|
2018-05-22 13:27:27 +02:00
|
|
|
if expr.str == '=' and expr.astOperand1 and expr.astOperand1.str == '.':
|
|
|
|
e = expr.astOperand1
|
|
|
|
while e and e.str == '.' and e.astOperand2:
|
|
|
|
e = e.astOperand1
|
|
|
|
if e and e.str == '.':
|
|
|
|
return False
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('++', '--', '='):
|
2017-10-09 15:25:55 +02:00
|
|
|
return True
|
|
|
|
# Todo: Check function calls
|
|
|
|
return hasSideEffectsRecursive(expr.astOperand1) or hasSideEffectsRecursive(expr.astOperand2)
|
|
|
|
|
|
|
|
|
|
|
|
def isBoolExpression(expr):
|
2018-04-18 16:20:54 +02:00
|
|
|
if not expr:
|
|
|
|
return False
|
2018-05-02 20:56:03 +02:00
|
|
|
if expr.valueType and (expr.valueType.type == 'bool' or expr.valueType.bits == 1):
|
2018-04-18 16:20:54 +02:00
|
|
|
return True
|
2018-05-29 06:50:32 +02:00
|
|
|
return expr.str in ['!', '==', '!=', '<', '<=', '>', '>=', '&&', '||', '0', '1', 'true', 'false']
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
|
|
|
def isConstantExpression(expr):
|
|
|
|
if expr.isNumber:
|
|
|
|
return True
|
|
|
|
if expr.isName:
|
|
|
|
return False
|
|
|
|
if simpleMatch(expr.previous, 'sizeof ('):
|
|
|
|
return True
|
|
|
|
if expr.astOperand1 and not isConstantExpression(expr.astOperand1):
|
|
|
|
return False
|
|
|
|
if expr.astOperand2 and not isConstantExpression(expr.astOperand2):
|
|
|
|
return False
|
|
|
|
return True
|
|
|
|
|
|
|
|
|
|
|
|
def isUnsignedInt(expr):
|
|
|
|
# TODO this function is very incomplete. use ValueType?
|
|
|
|
if not expr:
|
|
|
|
return False
|
|
|
|
if expr.isNumber:
|
|
|
|
return 'u' in expr.str or 'U' in expr.str
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('+', '-', '*', '/', '%'):
|
2017-10-09 15:25:55 +02:00
|
|
|
return isUnsignedInt(expr.astOperand1) or isUnsignedInt(expr.astOperand2)
|
|
|
|
return False
|
|
|
|
|
|
|
|
|
|
|
|
def getPrecedence(expr):
|
|
|
|
if not expr:
|
|
|
|
return 16
|
|
|
|
if not expr.astOperand1 or not expr.astOperand2:
|
|
|
|
return 16
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('*', '/', '%'):
|
2017-10-09 15:25:55 +02:00
|
|
|
return 12
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('+', '-'):
|
2017-10-09 15:25:55 +02:00
|
|
|
return 11
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('<<', '>>'):
|
2017-10-09 15:25:55 +02:00
|
|
|
return 10
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('<', '>', '<=', '>='):
|
2017-10-09 15:25:55 +02:00
|
|
|
return 9
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('==', '!='):
|
2017-10-09 15:25:55 +02:00
|
|
|
return 8
|
|
|
|
if expr.str == '&':
|
|
|
|
return 7
|
|
|
|
if expr.str == '^':
|
|
|
|
return 6
|
|
|
|
if expr.str == '|':
|
|
|
|
return 5
|
|
|
|
if expr.str == '&&':
|
|
|
|
return 4
|
|
|
|
if expr.str == '||':
|
|
|
|
return 3
|
2019-08-10 18:12:23 +02:00
|
|
|
if expr.str in ('?', ':'):
|
2017-10-09 15:25:55 +02:00
|
|
|
return 2
|
|
|
|
if expr.isAssignmentOp:
|
|
|
|
return 1
|
|
|
|
if expr.str == ',':
|
|
|
|
return 0
|
|
|
|
return -1
|
|
|
|
|
|
|
|
|
2018-04-24 09:28:24 +02:00
|
|
|
def findRawLink(token):
|
|
|
|
tok1 = None
|
|
|
|
tok2 = None
|
|
|
|
forward = False
|
|
|
|
|
|
|
|
if token.str in '{([':
|
|
|
|
tok1 = token.str
|
|
|
|
tok2 = '})]'['{(['.find(token.str)]
|
|
|
|
forward = True
|
|
|
|
elif token.str in '})]':
|
|
|
|
tok1 = token.str
|
|
|
|
tok2 = '{(['['})]'.find(token.str)]
|
|
|
|
forward = False
|
|
|
|
else:
|
|
|
|
return None
|
|
|
|
|
|
|
|
# try to find link
|
|
|
|
indent = 0
|
|
|
|
while token:
|
|
|
|
if token.str == tok1:
|
|
|
|
indent = indent + 1
|
|
|
|
elif token.str == tok2:
|
|
|
|
if indent <= 1:
|
|
|
|
return token
|
|
|
|
indent = indent - 1
|
2018-05-24 06:31:20 +02:00
|
|
|
if forward is True:
|
2018-04-24 09:28:24 +02:00
|
|
|
token = token.next
|
|
|
|
else:
|
|
|
|
token = token.previous
|
|
|
|
|
|
|
|
# raw link not found
|
|
|
|
return None
|
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2018-04-24 09:28:24 +02:00
|
|
|
def numberOfParentheses(tok1, tok2):
|
2017-10-09 15:25:55 +02:00
|
|
|
while tok1 and tok1 != tok2:
|
|
|
|
if tok1.str == '(' or tok1.str == ')':
|
|
|
|
return False
|
|
|
|
tok1 = tok1.next
|
|
|
|
return tok1 == tok2
|
|
|
|
|
|
|
|
|
|
|
|
def findGotoLabel(gotoToken):
|
|
|
|
label = gotoToken.next.str
|
|
|
|
tok = gotoToken.next.next
|
|
|
|
while tok:
|
|
|
|
if tok.str == '}' and tok.scope.type == 'Function':
|
|
|
|
break
|
|
|
|
if tok.str == label and tok.next.str == ':':
|
|
|
|
return tok
|
|
|
|
tok = tok.next
|
|
|
|
return None
|
|
|
|
|
|
|
|
|
|
|
|
def findInclude(directives, header):
|
|
|
|
for directive in directives:
|
|
|
|
if directive.str == '#include ' + header:
|
|
|
|
return directive
|
|
|
|
return None
|
|
|
|
|
2018-04-03 15:11:25 +02:00
|
|
|
|
|
|
|
# Get function arguments
|
|
|
|
def getArgumentsRecursive(tok, arguments):
|
|
|
|
if tok is None:
|
|
|
|
return
|
|
|
|
if tok.str == ',':
|
|
|
|
getArgumentsRecursive(tok.astOperand1, arguments)
|
|
|
|
getArgumentsRecursive(tok.astOperand2, arguments)
|
|
|
|
else:
|
2018-05-24 06:31:20 +02:00
|
|
|
arguments.append(tok)
|
|
|
|
|
2018-04-03 15:11:25 +02:00
|
|
|
|
|
|
|
def getArguments(ftok):
|
|
|
|
arguments = []
|
|
|
|
getArgumentsRecursive(ftok.astOperand2, arguments)
|
|
|
|
return arguments
|
|
|
|
|
|
|
|
|
2019-04-11 10:36:02 +02:00
|
|
|
def isalnum(c):
|
2019-09-28 20:16:10 +02:00
|
|
|
return c in string.digits or c in string.ascii_letters
|
|
|
|
|
2019-04-11 10:36:02 +02:00
|
|
|
|
2019-09-28 20:16:10 +02:00
|
|
|
def isHexEscapeSequence(symbols):
|
|
|
|
"""Checks that given symbols are valid hex escape sequence.
|
2019-04-11 10:36:02 +02:00
|
|
|
|
2019-09-29 21:23:19 +02:00
|
|
|
hexadecimal-escape-sequence:
|
|
|
|
\\x hexadecimal-digit
|
|
|
|
hexadecimal-escape-sequence hexadecimal-digit
|
2019-09-28 20:16:10 +02:00
|
|
|
|
|
|
|
Reference: n1570 6.4.4.4"""
|
|
|
|
if len(symbols) < 3 or symbols[:2] != '\\x':
|
|
|
|
return False
|
|
|
|
return all([s in string.hexdigits for s in symbols[2:]])
|
2018-03-31 12:17:55 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2019-09-28 20:16:10 +02:00
|
|
|
def isOctalEscapeSequence(symbols):
|
|
|
|
"""Checks that given symbols are valid octal escape sequence:
|
|
|
|
|
|
|
|
octal-escape-sequence:
|
|
|
|
\ octal-digit
|
|
|
|
\ octal-digit octal-digit
|
|
|
|
\ octal-digit octal-digit octal-digit
|
|
|
|
|
|
|
|
Reference: n1570 6.4.4.4"""
|
|
|
|
if len(symbols) not in range(2, 5) or symbols[0] != '\\':
|
|
|
|
return False
|
|
|
|
return all([s in string.octdigits for s in symbols[1:]])
|
|
|
|
|
|
|
|
|
|
|
|
def isSimpleEscapeSequence(symbols):
|
|
|
|
"""Checks that given symbols are simple escape sequence.
|
|
|
|
Reference: n1570 6.4.4.4"""
|
|
|
|
if len(symbols) != 2 or symbols[0] != '\\':
|
|
|
|
return False
|
|
|
|
return symbols[1] in ("'", '"', '?', '\\', 'a', 'b', 'f', 'n', 'r', 't', 'v')
|
|
|
|
|
|
|
|
|
|
|
|
def hasNumericEscapeSequence(symbols):
|
2019-09-29 21:23:19 +02:00
|
|
|
"""Check that given string contains octal or hexadecimal escape sequences."""
|
2019-09-28 20:16:10 +02:00
|
|
|
if '\\' not in symbols:
|
|
|
|
return False
|
|
|
|
for c, cn in grouped(symbols, 2):
|
|
|
|
if c == '\\' and cn in ('x' + string.octdigits):
|
|
|
|
return True
|
|
|
|
return False
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2018-05-03 10:59:09 +02:00
|
|
|
def isNoReturnScope(tok):
|
|
|
|
if tok is None or tok.str != '}':
|
|
|
|
return False
|
|
|
|
if tok.previous is None or tok.previous.str != ';':
|
|
|
|
return False
|
|
|
|
if simpleMatch(tok.previous.previous, 'break ;'):
|
|
|
|
return True
|
|
|
|
prev = tok.previous.previous
|
|
|
|
while prev and prev.str not in ';{}':
|
|
|
|
if prev.str in '])':
|
|
|
|
prev = prev.link
|
|
|
|
prev = prev.previous
|
|
|
|
if prev and prev.next.str in ['throw', 'return']:
|
|
|
|
return True
|
|
|
|
return False
|
|
|
|
|
2019-04-11 10:36:02 +02:00
|
|
|
|
|
|
|
class Define:
|
|
|
|
def __init__(self, directive):
|
|
|
|
self.args = []
|
|
|
|
self.expansionList = ''
|
|
|
|
|
|
|
|
res = re.match(r'#define [A-Za-z0-9_]+\(([A-Za-z0-9_,]+)\)[ ]+(.*)', directive.str)
|
|
|
|
if res is None:
|
|
|
|
return
|
|
|
|
|
|
|
|
self.args = res.group(1).split(',')
|
|
|
|
self.expansionList = res.group(2)
|
|
|
|
|
|
|
|
|
2019-06-19 21:57:28 +02:00
|
|
|
def getAddonRules():
|
|
|
|
"""Returns dict of MISRA rules handled by this addon."""
|
|
|
|
addon_rules = []
|
|
|
|
compiled = re.compile(r'.*def[ ]+misra_([0-9]+)_([0-9]+)[(].*')
|
|
|
|
for line in open(__file__):
|
|
|
|
res = compiled.match(line)
|
|
|
|
if res is None:
|
|
|
|
continue
|
|
|
|
addon_rules.append(res.group(1) + '.' + res.group(2))
|
|
|
|
return addon_rules
|
|
|
|
|
|
|
|
|
|
|
|
def getCppcheckRules():
|
|
|
|
"""Returns list of rules handled by cppcheck."""
|
|
|
|
return ['1.3', '2.1', '2.2', '2.4', '2.6', '8.3', '12.2', '13.2', '13.6',
|
|
|
|
'14.3', '17.5', '18.1', '18.2', '18.3', '18.6', '20.6',
|
|
|
|
'22.1', '22.2', '22.4', '22.6']
|
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def generateTable():
|
2019-06-19 21:57:28 +02:00
|
|
|
# print table
|
2018-09-29 09:05:13 +02:00
|
|
|
numberOfRules = {}
|
|
|
|
numberOfRules[1] = 3
|
|
|
|
numberOfRules[2] = 7
|
|
|
|
numberOfRules[3] = 2
|
|
|
|
numberOfRules[4] = 2
|
|
|
|
numberOfRules[5] = 9
|
|
|
|
numberOfRules[6] = 2
|
|
|
|
numberOfRules[7] = 4
|
|
|
|
numberOfRules[8] = 14
|
|
|
|
numberOfRules[9] = 5
|
|
|
|
numberOfRules[10] = 8
|
|
|
|
numberOfRules[11] = 9
|
|
|
|
numberOfRules[12] = 4
|
|
|
|
numberOfRules[13] = 6
|
|
|
|
numberOfRules[14] = 4
|
|
|
|
numberOfRules[15] = 7
|
|
|
|
numberOfRules[16] = 7
|
|
|
|
numberOfRules[17] = 8
|
|
|
|
numberOfRules[18] = 8
|
|
|
|
numberOfRules[19] = 2
|
|
|
|
numberOfRules[20] = 14
|
|
|
|
numberOfRules[21] = 12
|
|
|
|
numberOfRules[22] = 6
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2019-06-19 21:57:28 +02:00
|
|
|
# Rules that can be checked with compilers:
|
2018-09-29 09:05:13 +02:00
|
|
|
# compiler = ['1.1', '1.2']
|
|
|
|
|
2019-06-19 21:57:28 +02:00
|
|
|
addon = getAddonRules()
|
|
|
|
cppcheck = getCppcheckRules()
|
2018-09-29 09:05:13 +02:00
|
|
|
for i1 in range(1, 23):
|
|
|
|
for i2 in range(1, numberOfRules[i1] + 1):
|
|
|
|
num = str(i1) + '.' + str(i2)
|
|
|
|
s = ''
|
|
|
|
if num in addon:
|
|
|
|
s = 'X (Addon)'
|
|
|
|
elif num in cppcheck:
|
|
|
|
s = 'X (Cppcheck)'
|
|
|
|
num = num + ' '
|
|
|
|
print(num[:8] + s)
|
|
|
|
|
|
|
|
|
2019-07-24 07:16:48 +02:00
|
|
|
def remove_file_prefix(file_path, prefix):
|
|
|
|
"""
|
|
|
|
Remove a file path prefix from a give path. leftover
|
|
|
|
directory separators at the beginning of a file
|
|
|
|
after the removal are also stripped.
|
|
|
|
|
|
|
|
Example:
|
|
|
|
'/remove/this/path/file.c'
|
|
|
|
with a prefix of:
|
|
|
|
'/remove/this/path'
|
|
|
|
becomes:
|
|
|
|
file.c
|
|
|
|
"""
|
|
|
|
result = None
|
|
|
|
if file_path.startswith(prefix):
|
|
|
|
result = file_path[len(prefix):]
|
|
|
|
# Remove any leftover directory separators at the
|
|
|
|
# beginning
|
|
|
|
result = result.lstrip('\\/')
|
|
|
|
else:
|
|
|
|
result = file_path
|
|
|
|
return result
|
|
|
|
|
|
|
|
|
2019-06-23 14:08:05 +02:00
|
|
|
class Rule(object):
|
|
|
|
"""Class to keep rule text and metadata"""
|
|
|
|
|
|
|
|
MISRA_SEVERIY_LEVELS = ['Required', 'Mandatory', 'Advisory']
|
|
|
|
|
2019-04-03 19:39:05 +02:00
|
|
|
def __init__(self, num1, num2):
|
|
|
|
self.num1 = num1
|
|
|
|
self.num2 = num2
|
|
|
|
self.text = ''
|
2019-06-23 14:08:05 +02:00
|
|
|
self.misra_severity = ''
|
2019-04-03 19:39:05 +02:00
|
|
|
|
|
|
|
@property
|
|
|
|
def num(self):
|
|
|
|
return self.num1 * 100 + self.num2
|
|
|
|
|
2019-06-23 14:08:05 +02:00
|
|
|
@property
|
|
|
|
def misra_severity(self):
|
|
|
|
return self._misra_severity
|
|
|
|
|
|
|
|
@misra_severity.setter
|
|
|
|
def misra_severity(self, val):
|
|
|
|
if val in self.MISRA_SEVERIY_LEVELS:
|
|
|
|
self._misra_severity = val
|
|
|
|
else:
|
|
|
|
self._misra_severity = ''
|
|
|
|
|
2019-04-03 19:39:05 +02:00
|
|
|
@property
|
|
|
|
def cppcheck_severity(self):
|
2019-06-23 14:08:05 +02:00
|
|
|
return 'style'
|
2019-04-03 19:39:05 +02:00
|
|
|
|
|
|
|
def __repr__(self):
|
2019-06-23 14:08:05 +02:00
|
|
|
return "%d.%d (%s)" % (self.num1, self.num2, self.misra_severity)
|
2018-10-18 09:17:57 +02:00
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
|
|
|
|
class MisraSettings(object):
|
|
|
|
"""Hold settings for misra.py script."""
|
|
|
|
|
|
|
|
__slots__ = ["verify", "quiet", "show_summary"]
|
|
|
|
|
|
|
|
def __init__(self, args):
|
|
|
|
"""
|
|
|
|
:param args: Arguments given by argparse.
|
|
|
|
"""
|
|
|
|
self.verify = False
|
|
|
|
self.quiet = False
|
|
|
|
self.show_summary = True
|
|
|
|
|
|
|
|
if args.verify:
|
|
|
|
self.verify = True
|
|
|
|
if args.cli:
|
|
|
|
self.quiet = True
|
|
|
|
self.show_summary = False
|
|
|
|
if args.quiet:
|
|
|
|
self.quiet = True
|
|
|
|
if args.no_summary:
|
|
|
|
self.show_summary = False
|
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
class MisraChecker:
|
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
def __init__(self, settings, stdversion="c90"):
|
|
|
|
"""
|
|
|
|
:param settings: misra.py script settings.
|
|
|
|
"""
|
|
|
|
|
|
|
|
self.settings = settings
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
# Test validation rules lists
|
|
|
|
self.verify_expected = list()
|
|
|
|
self.verify_actual = list()
|
|
|
|
|
|
|
|
# List of formatted violation messages
|
2019-04-03 19:39:05 +02:00
|
|
|
self.violations = dict()
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
# if --rule-texts is specified this dictionary
|
|
|
|
# is loaded with descriptions of each rule
|
|
|
|
# by rule number (in hundreds).
|
|
|
|
# ie rule 1.2 becomes 102
|
|
|
|
self.ruleTexts = dict()
|
|
|
|
|
|
|
|
# Dictionary of dictionaries for rules to suppress
|
|
|
|
# Dict1 is keyed by rule number in the hundreds format of
|
|
|
|
# Major * 100 + minor. ie Rule 5.2 = (5*100) + 2
|
2019-01-06 17:15:57 +01:00
|
|
|
# Dict 2 is keyed by filename. An entry of None means suppress globally.
|
2018-09-29 09:05:13 +02:00
|
|
|
# Each file name entry contails a list of tuples of (lineNumber, symbolName)
|
2018-10-18 09:17:57 +02:00
|
|
|
# or an item of None which indicates suppress rule for the entire file.
|
2018-09-29 09:05:13 +02:00
|
|
|
# The line and symbol name tuple may have None as either of its elements but
|
|
|
|
# should not be None for both.
|
|
|
|
self.suppressedRules = dict()
|
|
|
|
|
|
|
|
# List of suppression extracted from the dumpfile
|
|
|
|
self.dumpfileSuppressions = None
|
|
|
|
|
2019-07-24 07:16:48 +02:00
|
|
|
# Prefix to ignore when matching suppression files.
|
|
|
|
self.filePrefix = None
|
|
|
|
|
2019-04-03 19:38:03 +02:00
|
|
|
# Statistics of all violations suppressed per rule
|
|
|
|
self.suppressionStats = dict()
|
|
|
|
|
2019-06-14 12:06:57 +02:00
|
|
|
self.stdversion = stdversion
|
|
|
|
|
|
|
|
def get_num_significant_naming_chars(self, cfg):
|
|
|
|
if cfg.standards and cfg.standards.c == "c99":
|
|
|
|
return 63
|
|
|
|
else:
|
|
|
|
return 31
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_3_1(self, rawTokens):
|
|
|
|
for token in rawTokens:
|
2019-10-03 21:15:00 +02:00
|
|
|
starts_with_double_slash = token.str.startswith('//')
|
|
|
|
if token.str.startswith('/*') or starts_with_double_slash:
|
2018-09-29 09:05:13 +02:00
|
|
|
s = token.str.lstrip('/')
|
2019-10-03 21:15:00 +02:00
|
|
|
if ((not starts_with_double_slash) and '//' in s) or '/*' in s:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 3, 1)
|
|
|
|
|
2019-10-16 11:31:42 +02:00
|
|
|
def misra_3_2(self, rawTokens):
|
|
|
|
for token in rawTokens:
|
|
|
|
if token.str.startswith('//'):
|
|
|
|
# Check for comment ends with trigraph which might be replaced
|
|
|
|
# by a backslash.
|
|
|
|
if token.str.endswith('??/'):
|
|
|
|
self.reportError(token, 3, 2)
|
|
|
|
# Check for comment which has been merged with subsequent line
|
|
|
|
# because it ends with backslash.
|
|
|
|
# The last backslash is no more part of the comment token thus
|
|
|
|
# check if next token exists and compare line numbers.
|
|
|
|
elif (token.next != None) and (token.linenr == token.next.linenr):
|
|
|
|
self.reportError(token, 3, 2)
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_4_1(self, rawTokens):
|
|
|
|
for token in rawTokens:
|
2019-09-28 20:16:10 +02:00
|
|
|
if (token.str[0] != '"') and (token.str[0] != '\''):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
2019-09-28 20:16:10 +02:00
|
|
|
if len(token.str) < 3:
|
|
|
|
continue
|
|
|
|
|
|
|
|
delimiter = token.str[0]
|
|
|
|
symbols = token.str[1:-1]
|
|
|
|
|
|
|
|
# No closing delimiter. This will not compile.
|
|
|
|
if token.str[-1] != delimiter:
|
|
|
|
continue
|
|
|
|
|
|
|
|
if len(symbols) < 2:
|
|
|
|
continue
|
|
|
|
|
|
|
|
if not hasNumericEscapeSequence(symbols):
|
|
|
|
continue
|
|
|
|
|
|
|
|
# String literals that contains one or more escape sequences. All of them should be
|
|
|
|
# terminated.
|
|
|
|
for sequence in ['\\' + t for t in symbols.split('\\')][1:]:
|
|
|
|
if (isHexEscapeSequence(sequence) or isOctalEscapeSequence(sequence) or
|
|
|
|
isSimpleEscapeSequence(sequence)):
|
2018-03-31 12:17:55 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
else:
|
|
|
|
self.reportError(token, 4, 1)
|
2018-03-31 12:17:55 +02:00
|
|
|
|
2019-10-09 08:26:05 +02:00
|
|
|
def misra_4_2(self, rawTokens):
|
|
|
|
for token in rawTokens:
|
|
|
|
if (token.str[0] != '"') or (token.str[-1] != '"'):
|
|
|
|
continue
|
|
|
|
# Check for trigraph sequence as defined by ISO/IEC 9899:1999
|
|
|
|
for sequence in ['??=', '??(', '??/', '??)', '??\'', '??<', '??!', '??>', '??-']:
|
|
|
|
if sequence in token.str[1:-1]:
|
|
|
|
# First trigraph sequence match, report error and leave loop.
|
|
|
|
self.reportError(token, 4, 2)
|
|
|
|
break
|
2019-09-28 20:16:10 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_5_1(self, data):
|
2019-07-09 15:53:23 +02:00
|
|
|
long_vars = {}
|
2018-09-29 09:05:13 +02:00
|
|
|
for var in data.variables:
|
2019-05-26 18:46:00 +02:00
|
|
|
if var.nameToken is None:
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
2019-05-26 18:46:00 +02:00
|
|
|
if len(var.nameToken.str) <= 31:
|
|
|
|
continue
|
|
|
|
if not hasExternalLinkage(var):
|
|
|
|
continue
|
2019-07-09 15:53:23 +02:00
|
|
|
long_vars.setdefault(var.nameToken.str[:31], []).append(var.nameToken)
|
|
|
|
for name_prefix in long_vars:
|
|
|
|
tokens = long_vars[name_prefix]
|
|
|
|
if len(tokens) < 2:
|
|
|
|
continue
|
2019-08-18 12:19:05 +02:00
|
|
|
for tok in sorted(tokens, key=lambda t: (t.linenr, t.column))[1:]:
|
2019-07-09 15:53:23 +02:00
|
|
|
self.reportError(tok, 5, 1)
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_5_2(self, data):
|
|
|
|
scopeVars = {}
|
|
|
|
for var in data.variables:
|
2019-05-26 18:46:00 +02:00
|
|
|
if var.nameToken is None:
|
|
|
|
continue
|
|
|
|
if len(var.nameToken.str) <= 31:
|
|
|
|
continue
|
|
|
|
if var.nameToken.scope not in scopeVars:
|
|
|
|
scopeVars.setdefault(var.nameToken.scope, {})["varlist"] = []
|
|
|
|
scopeVars.setdefault(var.nameToken.scope, {})["scopelist"] = []
|
|
|
|
scopeVars[var.nameToken.scope]["varlist"].append(var)
|
2018-09-29 09:05:13 +02:00
|
|
|
for scope in data.scopes:
|
|
|
|
if scope.nestedIn and scope.className:
|
|
|
|
if scope.nestedIn not in scopeVars:
|
|
|
|
scopeVars.setdefault(scope.nestedIn, {})["varlist"] = []
|
|
|
|
scopeVars.setdefault(scope.nestedIn, {})["scopelist"] = []
|
|
|
|
scopeVars[scope.nestedIn]["scopelist"].append(scope)
|
|
|
|
for scope in scopeVars:
|
|
|
|
if len(scopeVars[scope]["varlist"]) <= 1:
|
|
|
|
continue
|
|
|
|
for i, variable1 in enumerate(scopeVars[scope]["varlist"]):
|
|
|
|
for variable2 in scopeVars[scope]["varlist"][i + 1:]:
|
|
|
|
if variable1.isArgument and variable2.isArgument:
|
|
|
|
continue
|
2019-05-26 18:46:00 +02:00
|
|
|
if hasExternalLinkage(variable1) or hasExternalLinkage(variable2):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
|
|
|
if (variable1.nameToken.str[:31] == variable2.nameToken.str[:31] and
|
|
|
|
variable1.Id != variable2.Id):
|
|
|
|
if int(variable1.nameToken.linenr) > int(variable2.nameToken.linenr):
|
|
|
|
self.reportError(variable1.nameToken, 5, 2)
|
|
|
|
else:
|
|
|
|
self.reportError(variable2.nameToken, 5, 2)
|
|
|
|
for innerscope in scopeVars[scope]["scopelist"]:
|
|
|
|
if variable1.nameToken.str[:31] == innerscope.className[:31]:
|
|
|
|
if int(variable1.nameToken.linenr) > int(innerscope.bodyStart.linenr):
|
|
|
|
self.reportError(variable1.nameToken, 5, 2)
|
|
|
|
else:
|
|
|
|
self.reportError(innerscope.bodyStart, 5, 2)
|
|
|
|
if len(scopeVars[scope]["scopelist"]) <= 1:
|
|
|
|
continue
|
|
|
|
for i, scopename1 in enumerate(scopeVars[scope]["scopelist"]):
|
|
|
|
for scopename2 in scopeVars[scope]["scopelist"][i + 1:]:
|
|
|
|
if scopename1.className[:31] == scopename2.className[:31]:
|
|
|
|
if int(scopename1.bodyStart.linenr) > int(scopename2.bodyStart.linenr):
|
|
|
|
self.reportError(scopename1.bodyStart, 5, 2)
|
|
|
|
else:
|
|
|
|
self.reportError(scopename2.bodyStart, 5, 2)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_5_3(self, data):
|
2019-06-14 12:06:57 +02:00
|
|
|
num_sign_chars = self.get_num_significant_naming_chars(data)
|
2018-09-29 09:05:13 +02:00
|
|
|
enum = []
|
|
|
|
scopeVars = {}
|
|
|
|
for var in data.variables:
|
2018-10-18 09:11:51 +02:00
|
|
|
if var.nameToken is not None:
|
|
|
|
if var.nameToken.scope not in scopeVars:
|
|
|
|
scopeVars[var.nameToken.scope] = []
|
|
|
|
scopeVars[var.nameToken.scope].append(var)
|
2018-09-29 09:05:13 +02:00
|
|
|
for innerScope in data.scopes:
|
|
|
|
if innerScope.type == "Enum":
|
|
|
|
enum_token = innerScope.bodyStart.next
|
|
|
|
while enum_token != innerScope.bodyEnd:
|
|
|
|
if enum_token.values and enum_token.isName:
|
|
|
|
enum.append(enum_token.str)
|
|
|
|
enum_token = enum_token.next
|
|
|
|
continue
|
|
|
|
if innerScope not in scopeVars:
|
|
|
|
continue
|
|
|
|
if innerScope.type == "Global":
|
|
|
|
continue
|
|
|
|
for innerVar in scopeVars[innerScope]:
|
|
|
|
outerScope = innerScope.nestedIn
|
|
|
|
while outerScope:
|
|
|
|
if outerScope not in scopeVars:
|
|
|
|
outerScope = outerScope.nestedIn
|
|
|
|
continue
|
|
|
|
for outerVar in scopeVars[outerScope]:
|
2019-06-14 12:06:57 +02:00
|
|
|
if innerVar.nameToken.str[:num_sign_chars] == outerVar.nameToken.str[:num_sign_chars]:
|
2018-09-29 09:05:13 +02:00
|
|
|
if outerVar.isArgument and outerScope.type == "Global" and not innerVar.isArgument:
|
|
|
|
continue
|
|
|
|
if int(innerVar.nameToken.linenr) > int(outerVar.nameToken.linenr):
|
|
|
|
self.reportError(innerVar.nameToken, 5, 3)
|
|
|
|
else:
|
|
|
|
self.reportError(outerVar.nameToken, 5, 3)
|
2017-10-09 15:25:55 +02:00
|
|
|
outerScope = outerScope.nestedIn
|
2018-09-29 09:05:13 +02:00
|
|
|
for scope in data.scopes:
|
2019-06-14 12:06:57 +02:00
|
|
|
if scope.className and innerVar.nameToken.str[:num_sign_chars] == scope.className[:num_sign_chars]:
|
2018-09-29 09:05:13 +02:00
|
|
|
if int(innerVar.nameToken.linenr) > int(scope.bodyStart.linenr):
|
|
|
|
self.reportError(innerVar.nameToken, 5, 3)
|
|
|
|
else:
|
|
|
|
self.reportError(scope.bodyStart, 5, 3)
|
|
|
|
|
|
|
|
for e in enum:
|
2019-01-22 07:28:29 +01:00
|
|
|
for scope in data.scopes:
|
2019-06-14 12:06:57 +02:00
|
|
|
if scope.className and innerVar.nameToken.str[:num_sign_chars] == e[:num_sign_chars]:
|
2019-01-22 07:28:29 +01:00
|
|
|
if int(innerVar.nameToken.linenr) > int(innerScope.bodyStart.linenr):
|
|
|
|
self.reportError(innerVar.nameToken, 5, 3)
|
|
|
|
else:
|
|
|
|
self.reportError(innerScope.bodyStart, 5, 3)
|
2018-09-29 09:05:13 +02:00
|
|
|
for e in enum:
|
2018-05-14 13:09:38 +02:00
|
|
|
for scope in data.scopes:
|
2019-06-14 12:06:57 +02:00
|
|
|
if scope.className and scope.className[:num_sign_chars] == e[:num_sign_chars]:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(scope.bodyStart, 5, 3)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_5_4(self, data):
|
2019-06-14 12:06:57 +02:00
|
|
|
num_sign_chars = self.get_num_significant_naming_chars(data)
|
2018-09-29 09:05:13 +02:00
|
|
|
macro = {}
|
|
|
|
compile_name = re.compile(r'#define ([a-zA-Z0-9_]+)')
|
|
|
|
compile_param = re.compile(r'#define ([a-zA-Z0-9_]+)[(]([a-zA-Z0-9_, ]+)[)]')
|
|
|
|
for dir in data.directives:
|
|
|
|
res1 = compile_name.match(dir.str)
|
|
|
|
if res1:
|
|
|
|
if dir not in macro:
|
|
|
|
macro.setdefault(dir, {})["name"] = []
|
|
|
|
macro.setdefault(dir, {})["params"] = []
|
|
|
|
macro[dir]["name"] = res1.group(1)
|
|
|
|
res2 = compile_param.match(dir.str)
|
|
|
|
if res2:
|
|
|
|
res_gp2 = res2.group(2).split(",")
|
|
|
|
res_gp2 = [macroname.replace(" ", "") for macroname in res_gp2]
|
|
|
|
macro[dir]["params"].extend(res_gp2)
|
|
|
|
for mvar in macro:
|
|
|
|
if len(macro[mvar]["params"]) > 0:
|
|
|
|
for i, macroparam1 in enumerate(macro[mvar]["params"]):
|
|
|
|
for j, macroparam2 in enumerate(macro[mvar]["params"]):
|
2019-06-14 12:06:57 +02:00
|
|
|
if j > i and macroparam1[:num_sign_chars] == macroparam2[:num_sign_chars]:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(mvar, 5, 4)
|
|
|
|
|
|
|
|
for x, m_var1 in enumerate(macro):
|
|
|
|
for y, m_var2 in enumerate(macro):
|
2019-08-31 07:53:16 +02:00
|
|
|
if x < y and macro[m_var1]["name"] != macro[m_var2]["name"] and \
|
|
|
|
macro[m_var1]["name"][:num_sign_chars] == macro[m_var2]["name"][:num_sign_chars]:
|
2018-09-29 09:05:13 +02:00
|
|
|
if m_var1.linenr > m_var2.linenr:
|
|
|
|
self.reportError(m_var1, 5, 4)
|
2018-05-14 13:09:38 +02:00
|
|
|
else:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(m_var2, 5, 4)
|
|
|
|
for param in macro[m_var2]["params"]:
|
2019-06-14 12:06:57 +02:00
|
|
|
if macro[m_var1]["name"][:num_sign_chars] == param[:num_sign_chars]:
|
2018-09-29 09:05:13 +02:00
|
|
|
if m_var1.linenr > m_var2.linenr:
|
|
|
|
self.reportError(m_var1, 5, 4)
|
|
|
|
else:
|
|
|
|
self.reportError(m_var2, 5, 4)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_5_5(self, data):
|
2019-06-14 12:06:57 +02:00
|
|
|
num_sign_chars = self.get_num_significant_naming_chars(data)
|
2018-09-29 09:05:13 +02:00
|
|
|
macroNames = []
|
|
|
|
compiled = re.compile(r'#define ([A-Za-z0-9_]+)')
|
|
|
|
for dir in data.directives:
|
|
|
|
res = compiled.match(dir.str)
|
|
|
|
if res:
|
|
|
|
macroNames.append(res.group(1))
|
|
|
|
for var in data.variables:
|
|
|
|
for macro in macroNames:
|
2018-10-18 09:11:51 +02:00
|
|
|
if var.nameToken is not None:
|
2019-06-14 12:06:57 +02:00
|
|
|
if var.nameToken.str[:num_sign_chars] == macro[:num_sign_chars]:
|
2018-10-18 09:11:51 +02:00
|
|
|
self.reportError(var.nameToken, 5, 5)
|
2018-09-29 09:05:13 +02:00
|
|
|
for scope in data.scopes:
|
|
|
|
for macro in macroNames:
|
2019-06-14 12:06:57 +02:00
|
|
|
if scope.className and scope.className[:num_sign_chars] == macro[:num_sign_chars]:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(scope.bodyStart, 5, 5)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_7_1(self, rawTokens):
|
|
|
|
compiled = re.compile(r'^0[0-7]+$')
|
|
|
|
for tok in rawTokens:
|
|
|
|
if compiled.match(tok.str):
|
|
|
|
self.reportError(tok, 7, 1)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_7_3(self, rawTokens):
|
|
|
|
compiled = re.compile(r'^[0-9.uU]+l')
|
|
|
|
for tok in rawTokens:
|
|
|
|
if compiled.match(tok.str):
|
|
|
|
self.reportError(tok, 7, 3)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_8_11(self, data):
|
|
|
|
for var in data.variables:
|
|
|
|
if var.isExtern and simpleMatch(var.nameToken.next, '[ ]') and var.nameToken.scope.type == 'Global':
|
|
|
|
self.reportError(var.nameToken, 8, 11)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_8_12(self, data):
|
2018-05-14 13:09:38 +02:00
|
|
|
for scope in data.scopes:
|
2018-09-29 09:05:13 +02:00
|
|
|
if scope.type != 'Enum':
|
2018-05-21 12:04:20 +02:00
|
|
|
continue
|
2019-06-01 13:10:20 +02:00
|
|
|
enum_values = []
|
|
|
|
implicit_enum_values = []
|
2018-09-29 09:05:13 +02:00
|
|
|
e_token = scope.bodyStart.next
|
|
|
|
while e_token != scope.bodyEnd:
|
2019-06-01 13:10:20 +02:00
|
|
|
if e_token.str == '(':
|
2019-08-04 12:24:28 +02:00
|
|
|
e_token = e_token.link
|
2019-06-01 13:10:20 +02:00
|
|
|
continue
|
|
|
|
if not e_token.previous.str in ',{':
|
|
|
|
e_token = e_token.next
|
|
|
|
continue
|
|
|
|
if e_token.isName and e_token.values and e_token.valueType and e_token.valueType.typeScope == scope:
|
2018-09-29 09:05:13 +02:00
|
|
|
token_values = [v.intvalue for v in e_token.values]
|
|
|
|
enum_values += token_values
|
|
|
|
if e_token.next.str != "=":
|
|
|
|
implicit_enum_values += token_values
|
|
|
|
e_token = e_token.next
|
|
|
|
for implicit_enum_value in implicit_enum_values:
|
|
|
|
if enum_values.count(implicit_enum_value) != 1:
|
|
|
|
self.reportError(scope.bodyStart, 8, 12)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_8_14(self, rawTokens):
|
|
|
|
for token in rawTokens:
|
|
|
|
if token.str == 'restrict':
|
|
|
|
self.reportError(token, 8, 14)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_9_5(self, rawTokens):
|
|
|
|
for token in rawTokens:
|
|
|
|
if simpleMatch(token, '[ ] = { ['):
|
|
|
|
self.reportError(token, 9, 5)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_10_1(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not token.isOp:
|
2018-05-21 12:04:20 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
e1 = getEssentialTypeCategory(token.astOperand1)
|
|
|
|
e2 = getEssentialTypeCategory(token.astOperand2)
|
|
|
|
if not e1 or not e2:
|
2018-05-21 12:04:20 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if token.str in ['<<', '>>']:
|
|
|
|
if e1 != 'unsigned':
|
|
|
|
self.reportError(token, 10, 1)
|
|
|
|
elif e2 != 'unsigned' and not token.astOperand2.isNumber:
|
|
|
|
self.reportError(token, 10, 1)
|
|
|
|
|
|
|
|
def misra_10_4(self, data):
|
|
|
|
op = {'+', '-', '*', '/', '%', '&', '|', '^', '+=', '-=', ':'}
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str not in op and not token.isComparisonOp:
|
|
|
|
continue
|
|
|
|
if not token.astOperand1 or not token.astOperand2:
|
|
|
|
continue
|
|
|
|
if not token.astOperand1.valueType or not token.astOperand2.valueType:
|
|
|
|
continue
|
|
|
|
if ((token.astOperand1.str in op or token.astOperand1.isComparisonOp) and
|
|
|
|
(token.astOperand2.str in op or token.astOperand1.isComparisonOp)):
|
|
|
|
e1, e2 = getEssentialCategorylist(token.astOperand1.astOperand2, token.astOperand2.astOperand1)
|
|
|
|
elif token.astOperand1.str in op or token.astOperand1.isComparisonOp:
|
|
|
|
e1, e2 = getEssentialCategorylist(token.astOperand1.astOperand2, token.astOperand2)
|
|
|
|
elif token.astOperand2.str in op or token.astOperand2.isComparisonOp:
|
|
|
|
e1, e2 = getEssentialCategorylist(token.astOperand1, token.astOperand2.astOperand1)
|
2018-05-24 22:28:36 +02:00
|
|
|
else:
|
2018-09-29 09:05:13 +02:00
|
|
|
e1, e2 = getEssentialCategorylist(token.astOperand1, token.astOperand2)
|
|
|
|
if token.str == "+=" or token.str == "+":
|
|
|
|
if e1 == "char" and (e2 == "signed" or e2 == "unsigned"):
|
|
|
|
continue
|
|
|
|
if e2 == "char" and (e1 == "signed" or e1 == "unsigned"):
|
|
|
|
continue
|
|
|
|
if token.str == "-=" or token.str == "-":
|
|
|
|
if e1 == "char" and (e2 == "signed" or e2 == "unsigned"):
|
|
|
|
continue
|
|
|
|
if e1 and e2 and (e1.find('Anonymous') != -1 and (e2 == "signed" or e2 == "unsigned")):
|
2017-10-09 15:25:55 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if e1 and e2 and (e2.find('Anonymous') != -1 and (e1 == "signed" or e1 == "unsigned")):
|
|
|
|
continue
|
|
|
|
if e1 and e2 and e1 != e2:
|
|
|
|
self.reportError(token, 10, 4)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_10_6(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != '=' or not token.astOperand1 or not token.astOperand2:
|
|
|
|
continue
|
2019-08-10 18:12:23 +02:00
|
|
|
if (token.astOperand2.str not in ('+', '-', '*', '/', '%', '&', '|', '^', '>>', "<<", "?", ":", '~') and
|
2018-09-29 09:05:13 +02:00
|
|
|
not isCast(token.astOperand2)):
|
|
|
|
continue
|
|
|
|
vt1 = token.astOperand1.valueType
|
|
|
|
vt2 = token.astOperand2.valueType
|
|
|
|
if not vt1 or vt1.pointer > 0:
|
|
|
|
continue
|
|
|
|
if not vt2 or vt2.pointer > 0:
|
2017-10-09 15:25:55 +02:00
|
|
|
continue
|
2018-05-28 12:58:19 +02:00
|
|
|
try:
|
|
|
|
intTypes = ['char', 'short', 'int', 'long', 'long long']
|
2018-09-29 09:05:13 +02:00
|
|
|
index1 = intTypes.index(vt1.type)
|
|
|
|
if isCast(token.astOperand2):
|
|
|
|
e = vt2.type
|
|
|
|
else:
|
|
|
|
e = getEssentialType(token.astOperand2)
|
2018-05-28 12:58:19 +02:00
|
|
|
if not e:
|
|
|
|
continue
|
|
|
|
index2 = intTypes.index(e)
|
|
|
|
if index1 > index2:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 10, 6)
|
2018-05-28 12:58:19 +02:00
|
|
|
except ValueError:
|
|
|
|
pass
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_10_8(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not isCast(token):
|
|
|
|
continue
|
|
|
|
if not token.valueType or token.valueType.pointer > 0:
|
|
|
|
continue
|
|
|
|
if not token.astOperand1.valueType or token.astOperand1.valueType.pointer > 0:
|
|
|
|
continue
|
|
|
|
if not token.astOperand1.astOperand1:
|
|
|
|
continue
|
2019-08-10 18:12:23 +02:00
|
|
|
if token.astOperand1.str not in ('+', '-', '*', '/', '%', '&', '|', '^', '>>', "<<", "?", ":", '~'):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
|
|
|
if token.astOperand1.str != '~' and not token.astOperand1.astOperand2:
|
|
|
|
continue
|
|
|
|
if token.astOperand1.str == '~':
|
|
|
|
e2 = getEssentialTypeCategory(token.astOperand1.astOperand1)
|
|
|
|
else:
|
|
|
|
e2, e3 = getEssentialCategorylist(token.astOperand1.astOperand1, token.astOperand1.astOperand2)
|
|
|
|
if e2 != e3:
|
|
|
|
continue
|
|
|
|
e1 = getEssentialTypeCategory(token)
|
|
|
|
if e1 != e2:
|
|
|
|
self.reportError(token, 10, 8)
|
|
|
|
else:
|
|
|
|
try:
|
|
|
|
intTypes = ['char', 'short', 'int', 'long', 'long long']
|
|
|
|
index1 = intTypes.index(token.valueType.type)
|
|
|
|
e = getEssentialType(token.astOperand1)
|
|
|
|
if not e:
|
|
|
|
continue
|
|
|
|
index2 = intTypes.index(e)
|
|
|
|
if index1 > index2:
|
|
|
|
self.reportError(token, 10, 8)
|
|
|
|
except ValueError:
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
|
|
def misra_11_3(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not isCast(token):
|
|
|
|
continue
|
|
|
|
vt1 = token.valueType
|
|
|
|
vt2 = token.astOperand1.valueType
|
|
|
|
if not vt1 or not vt2:
|
|
|
|
continue
|
|
|
|
if vt1.type == 'void' or vt2.type == 'void':
|
|
|
|
continue
|
|
|
|
if (vt1.pointer > 0 and vt1.type == 'record' and
|
|
|
|
vt2.pointer > 0 and vt2.type == 'record' and
|
|
|
|
vt1.typeScopeId != vt2.typeScopeId):
|
|
|
|
self.reportError(token, 11, 3)
|
|
|
|
elif (vt1.pointer == vt2.pointer and vt1.pointer > 0 and
|
|
|
|
vt1.type != vt2.type and vt1.type != 'char'):
|
|
|
|
self.reportError(token, 11, 3)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_11_4(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not isCast(token):
|
|
|
|
continue
|
|
|
|
vt1 = token.valueType
|
|
|
|
vt2 = token.astOperand1.valueType
|
|
|
|
if not vt1 or not vt2:
|
|
|
|
continue
|
|
|
|
if vt2.pointer > 0 and vt1.pointer == 0 and (vt1.isIntegral() or vt1.isEnum()) and vt2.type != 'void':
|
|
|
|
self.reportError(token, 11, 4)
|
|
|
|
elif vt1.pointer > 0 and vt2.pointer == 0 and (vt2.isIntegral() or vt2.isEnum())and vt1.type != 'void':
|
|
|
|
self.reportError(token, 11, 4)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_11_5(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not isCast(token):
|
|
|
|
if token.astOperand1 and token.astOperand2 and token.str == "=" and token.next.str != "(":
|
|
|
|
vt1 = token.astOperand1.valueType
|
|
|
|
vt2 = token.astOperand2.valueType
|
|
|
|
if not vt1 or not vt2:
|
|
|
|
continue
|
|
|
|
if vt1.pointer > 0 and vt1.type != 'void' and vt2.pointer == vt1.pointer and vt2.type == 'void':
|
|
|
|
self.reportError(token, 11, 5)
|
|
|
|
continue
|
2019-08-10 18:12:23 +02:00
|
|
|
if token.astOperand1.astOperand1 and token.astOperand1.astOperand1.str in ('malloc', 'calloc', 'realloc', 'free'):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
|
|
|
vt1 = token.valueType
|
|
|
|
vt2 = token.astOperand1.valueType
|
|
|
|
if not vt1 or not vt2:
|
|
|
|
continue
|
|
|
|
if vt1.pointer > 0 and vt1.type != 'void' and vt2.pointer == vt1.pointer and vt2.type == 'void':
|
|
|
|
self.reportError(token, 11, 5)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_11_6(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not isCast(token):
|
|
|
|
continue
|
|
|
|
if token.astOperand1.astOperand1:
|
|
|
|
continue
|
|
|
|
vt1 = token.valueType
|
|
|
|
vt2 = token.astOperand1.valueType
|
|
|
|
if not vt1 or not vt2:
|
|
|
|
continue
|
|
|
|
if vt1.pointer == 1 and vt1.type == 'void' and vt2.pointer == 0 and token.astOperand1.str != "0":
|
|
|
|
self.reportError(token, 11, 6)
|
|
|
|
elif vt1.pointer == 0 and vt1.type != 'void' and vt2.pointer == 1 and vt2.type == 'void':
|
|
|
|
self.reportError(token, 11, 6)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_11_7(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not isCast(token):
|
|
|
|
continue
|
|
|
|
vt1 = token.valueType
|
|
|
|
vt2 = token.astOperand1.valueType
|
|
|
|
if not vt1 or not vt2:
|
|
|
|
continue
|
|
|
|
if token.astOperand1.astOperand1:
|
|
|
|
continue
|
|
|
|
if (vt2.pointer > 0 and vt1.pointer == 0 and
|
|
|
|
not vt1.isIntegral() and not vt1.isEnum() and
|
2019-10-03 10:15:50 +02:00
|
|
|
vt1.type != 'void'):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 11, 7)
|
|
|
|
elif (vt1.pointer > 0 and vt2.pointer == 0 and
|
|
|
|
not vt2.isIntegral() and not vt2.isEnum() and
|
|
|
|
vt1.type != 'void'):
|
|
|
|
self.reportError(token, 11, 7)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_11_8(self, data):
|
|
|
|
# TODO: reuse code in CERT-EXP05
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if isCast(token):
|
|
|
|
# C-style cast
|
|
|
|
if not token.valueType:
|
2018-04-03 15:11:25 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if not token.astOperand1.valueType:
|
2018-04-03 15:11:25 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if token.valueType.pointer == 0:
|
2018-04-03 15:11:25 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if token.astOperand1.valueType.pointer == 0:
|
2018-04-03 15:11:25 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
const1 = token.valueType.constness
|
|
|
|
const2 = token.astOperand1.valueType.constness
|
2018-04-03 15:11:25 +02:00
|
|
|
if (const1 % 2) < (const2 % 2):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 11, 8)
|
|
|
|
|
|
|
|
elif token.str == '(' and token.astOperand1 and token.astOperand2 and token.astOperand1.function:
|
|
|
|
# Function call
|
|
|
|
function = token.astOperand1.function
|
|
|
|
arguments = getArguments(token)
|
|
|
|
for argnr, argvar in function.argument.items():
|
|
|
|
if argnr < 1 or argnr > len(arguments):
|
|
|
|
continue
|
|
|
|
if not argvar.isPointer:
|
|
|
|
continue
|
|
|
|
argtok = arguments[argnr - 1]
|
|
|
|
if not argtok.valueType:
|
|
|
|
continue
|
|
|
|
if argtok.valueType.pointer == 0:
|
|
|
|
continue
|
|
|
|
const1 = argvar.constness
|
|
|
|
const2 = arguments[argnr - 1].valueType.constness
|
|
|
|
if (const1 % 2) < (const2 % 2):
|
|
|
|
self.reportError(token, 11, 8)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_11_9(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.astOperand1 and token.astOperand2 and token.str in ["=", "==", "!=", "?", ":"]:
|
|
|
|
vt1 = token.astOperand1.valueType
|
|
|
|
vt2 = token.astOperand2.valueType
|
|
|
|
if not vt1 or not vt2:
|
|
|
|
continue
|
|
|
|
if vt1.pointer > 0 and vt2.pointer == 0 and token.astOperand2.str == "NULL":
|
|
|
|
continue
|
|
|
|
if (token.astOperand2.values and vt1.pointer > 0 and
|
|
|
|
vt2.pointer == 0 and token.astOperand2.values):
|
|
|
|
for val in token.astOperand2.values:
|
|
|
|
if val.intvalue == 0:
|
|
|
|
self.reportError(token, 11, 9)
|
|
|
|
|
|
|
|
def misra_12_1_sizeof(self, rawTokens):
|
|
|
|
state = 0
|
|
|
|
compiled = re.compile(r'^[a-zA-Z_]')
|
|
|
|
for tok in rawTokens:
|
|
|
|
if tok.str.startswith('//') or tok.str.startswith('/*'):
|
|
|
|
continue
|
|
|
|
if tok.str == 'sizeof':
|
|
|
|
state = 1
|
|
|
|
elif state == 1:
|
|
|
|
if compiled.match(tok.str):
|
|
|
|
state = 2
|
|
|
|
else:
|
|
|
|
state = 0
|
|
|
|
elif state == 2:
|
2019-08-10 18:12:23 +02:00
|
|
|
if tok.str in ('+', '-', '*', '/', '%'):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(tok, 12, 1)
|
|
|
|
else:
|
|
|
|
state = 0
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_12_1(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
p = getPrecedence(token)
|
|
|
|
if p < 2 or p > 12:
|
|
|
|
continue
|
|
|
|
p1 = getPrecedence(token.astOperand1)
|
|
|
|
if p < p1 <= 12 and numberOfParentheses(token.astOperand1, token):
|
|
|
|
self.reportError(token, 12, 1)
|
2018-05-23 15:48:07 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
p2 = getPrecedence(token.astOperand2)
|
|
|
|
if p < p2 <= 12 and numberOfParentheses(token, token.astOperand2):
|
|
|
|
self.reportError(token, 12, 1)
|
2018-05-23 15:48:07 +02:00
|
|
|
continue
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_12_2(self, data):
|
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if not (token.str in ('<<', '>>')):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
|
|
|
if (not token.astOperand2) or (not token.astOperand2.values):
|
|
|
|
continue
|
|
|
|
maxval = 0
|
|
|
|
for val in token.astOperand2.values:
|
|
|
|
if val.intvalue and val.intvalue > maxval:
|
|
|
|
maxval = val.intvalue
|
|
|
|
if maxval == 0:
|
|
|
|
continue
|
|
|
|
sz = bitsOfEssentialType(token.astOperand1)
|
|
|
|
if sz <= 0:
|
|
|
|
continue
|
|
|
|
if maxval >= sz:
|
|
|
|
self.reportError(token, 12, 2)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_12_3(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != ',' or token.scope.type == 'Enum' or \
|
|
|
|
token.scope.type == 'Class' or token.scope.type == 'Global':
|
|
|
|
continue
|
|
|
|
if token.astParent and token.astParent.str in ['(', ',', '{']:
|
|
|
|
continue
|
|
|
|
self.reportError(token, 12, 3)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_12_4(self, data):
|
|
|
|
if typeBits['INT'] == 16:
|
|
|
|
max_uint = 0xffff
|
|
|
|
elif typeBits['INT'] == 32:
|
|
|
|
max_uint = 0xffffffff
|
|
|
|
else:
|
|
|
|
return
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
for token in data.tokenlist:
|
|
|
|
if (not isConstantExpression(token)) or (not isUnsignedInt(token)):
|
|
|
|
continue
|
|
|
|
if not token.values:
|
|
|
|
continue
|
|
|
|
for value in token.values:
|
|
|
|
if value.intvalue < 0 or value.intvalue > max_uint:
|
|
|
|
self.reportError(token, 12, 4)
|
|
|
|
break
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_13_1(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not simpleMatch(token, '= {'):
|
|
|
|
continue
|
|
|
|
init = token.next
|
|
|
|
if hasSideEffectsRecursive(init):
|
|
|
|
self.reportError(init, 13, 1)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_13_3(self, data):
|
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if token.str not in ('++', '--'):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
|
|
|
astTop = token
|
2019-08-10 18:12:23 +02:00
|
|
|
while astTop.astParent and astTop.astParent.str not in (',', ';'):
|
2018-09-29 09:05:13 +02:00
|
|
|
astTop = astTop.astParent
|
|
|
|
if countSideEffects(astTop) >= 2:
|
|
|
|
self.reportError(astTop, 13, 3)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_13_4(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != '=':
|
|
|
|
continue
|
|
|
|
if not token.astParent:
|
|
|
|
continue
|
2019-08-10 18:12:23 +02:00
|
|
|
if token.astOperand1.str == '[' and token.astOperand1.previous.str in ('{', ','):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
2019-04-27 17:43:26 +02:00
|
|
|
if not (token.astParent.str in [',', ';', '{']):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 13, 4)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_13_5(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.isLogicalOp and hasSideEffectsRecursive(token.astOperand2):
|
|
|
|
self.reportError(token, 13, 5)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_13_6(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str == 'sizeof' and hasSideEffectsRecursive(token.next):
|
|
|
|
self.reportError(token, 13, 6)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_14_1(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str == 'for':
|
|
|
|
exprs = getForLoopExpressions(token)
|
|
|
|
if not exprs:
|
|
|
|
continue
|
|
|
|
for counter in findCounterTokens(exprs[1]):
|
|
|
|
if counter.valueType and counter.valueType.isFloat():
|
|
|
|
self.reportError(token, 14, 1)
|
|
|
|
elif token.str == 'while':
|
|
|
|
if isFloatCounterInWhileLoop(token):
|
|
|
|
self.reportError(token, 14, 1)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_14_2(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
expressions = getForLoopExpressions(token)
|
|
|
|
if not expressions:
|
|
|
|
continue
|
|
|
|
if expressions[0] and not expressions[0].isAssignmentOp:
|
|
|
|
self.reportError(token, 14, 2)
|
|
|
|
elif hasSideEffectsRecursive(expressions[1]):
|
|
|
|
self.reportError(token, 14, 2)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_14_4(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != '(':
|
|
|
|
continue
|
|
|
|
if not token.astOperand1 or not (token.astOperand1.str in ['if', 'while']):
|
2018-06-04 10:12:51 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if not isBoolExpression(token.astOperand2):
|
|
|
|
self.reportError(token, 14, 4)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_15_1(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str == "goto":
|
|
|
|
self.reportError(token, 15, 1)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_15_2(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != 'goto':
|
|
|
|
continue
|
|
|
|
if (not token.next) or (not token.next.isName):
|
|
|
|
continue
|
|
|
|
if not findGotoLabel(token):
|
|
|
|
self.reportError(token, 15, 2)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_15_3(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != 'goto':
|
|
|
|
continue
|
|
|
|
if (not token.next) or (not token.next.isName):
|
|
|
|
continue
|
|
|
|
tok = findGotoLabel(token)
|
|
|
|
if not tok:
|
|
|
|
continue
|
|
|
|
scope = token.scope
|
|
|
|
while scope and scope != tok.scope:
|
|
|
|
scope = scope.nestedIn
|
|
|
|
if not scope:
|
|
|
|
self.reportError(token, 15, 3)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_15_5(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str == 'return' and token.scope.type != 'Function':
|
|
|
|
self.reportError(token, 15, 5)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_15_6(self, rawTokens):
|
|
|
|
state = 0
|
|
|
|
indent = 0
|
|
|
|
tok1 = None
|
|
|
|
for token in rawTokens:
|
|
|
|
if token.str in ['if', 'for', 'while']:
|
|
|
|
if simpleMatch(token.previous, '# if'):
|
|
|
|
continue
|
|
|
|
if simpleMatch(token.previous, "} while"):
|
|
|
|
# is there a 'do { .. } while'?
|
|
|
|
start = rawlink(token.previous)
|
|
|
|
if start and simpleMatch(start.previous, 'do {'):
|
|
|
|
continue
|
|
|
|
if state == 2:
|
|
|
|
self.reportError(tok1, 15, 6)
|
|
|
|
state = 1
|
|
|
|
indent = 0
|
|
|
|
tok1 = token
|
|
|
|
elif token.str == 'else':
|
|
|
|
if simpleMatch(token.previous, '# else'):
|
|
|
|
continue
|
|
|
|
if simpleMatch(token, 'else if'):
|
|
|
|
continue
|
|
|
|
if state == 2:
|
|
|
|
self.reportError(tok1, 15, 6)
|
|
|
|
state = 2
|
|
|
|
indent = 0
|
|
|
|
tok1 = token
|
|
|
|
elif state == 1:
|
|
|
|
if indent == 0 and token.str != '(':
|
|
|
|
state = 0
|
|
|
|
continue
|
|
|
|
if token.str == '(':
|
|
|
|
indent = indent + 1
|
|
|
|
elif token.str == ')':
|
|
|
|
if indent == 0:
|
|
|
|
state = 0
|
|
|
|
elif indent == 1:
|
|
|
|
state = 2
|
|
|
|
indent = indent - 1
|
|
|
|
elif state == 2:
|
|
|
|
if token.str.startswith('//') or token.str.startswith('/*'):
|
|
|
|
continue
|
|
|
|
state = 0
|
|
|
|
if token.str != '{':
|
|
|
|
self.reportError(tok1, 15, 6)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_15_7(self, data):
|
2018-10-01 20:16:48 +02:00
|
|
|
for scope in data.scopes:
|
|
|
|
if scope.type != 'Else':
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
2018-10-01 20:16:48 +02:00
|
|
|
if not simpleMatch(scope.bodyStart, '{ if ('):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
2019-08-18 12:19:05 +02:00
|
|
|
if scope.bodyStart.column > 0:
|
2019-08-11 17:54:02 +02:00
|
|
|
continue
|
2018-10-01 20:16:48 +02:00
|
|
|
tok = scope.bodyStart.next.next.link
|
|
|
|
if not simpleMatch(tok, ') {'):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
2018-10-01 20:16:48 +02:00
|
|
|
tok = tok.next.link
|
|
|
|
if not simpleMatch(tok, '} else'):
|
|
|
|
self.reportError(tok, 15, 7)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
# TODO add 16.1 rule
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_16_2(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str == 'case' and token.scope.type != 'Switch':
|
|
|
|
self.reportError(token, 16, 2)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_16_3(self, rawTokens):
|
|
|
|
STATE_NONE = 0 # default state, not in switch case/default block
|
|
|
|
STATE_BREAK = 1 # break/comment is seen but not its ';'
|
|
|
|
STATE_OK = 2 # a case/default is allowed (we have seen 'break;'/'comment'/'{'/attribute)
|
|
|
|
state = STATE_NONE
|
|
|
|
for token in rawTokens:
|
|
|
|
if token.str == 'break' or token.str == 'return' or token.str == 'throw':
|
|
|
|
state = STATE_BREAK
|
|
|
|
elif token.str == ';':
|
|
|
|
if state == STATE_BREAK:
|
|
|
|
state = STATE_OK
|
|
|
|
else:
|
|
|
|
state = STATE_NONE
|
|
|
|
elif token.str.startswith('/*') or token.str.startswith('//'):
|
|
|
|
if 'fallthrough' in token.str.lower():
|
|
|
|
state = STATE_OK
|
|
|
|
elif simpleMatch(token, '[ [ fallthrough ] ] ;'):
|
|
|
|
state = STATE_BREAK
|
|
|
|
elif token.str == '{':
|
|
|
|
state = STATE_OK
|
|
|
|
elif token.str == '}' and state == STATE_OK:
|
|
|
|
# is this {} an unconditional block of code?
|
2019-08-11 19:08:57 +02:00
|
|
|
prev = findRawLink(token)
|
|
|
|
if prev:
|
|
|
|
prev = prev.previous
|
|
|
|
while prev and prev.str[:2] in ('//', '/*'):
|
|
|
|
prev = prev.previous
|
|
|
|
if (prev is None) or (prev.str not in ':;{}'):
|
2018-09-29 09:05:13 +02:00
|
|
|
state = STATE_NONE
|
|
|
|
elif token.str == 'case' or token.str == 'default':
|
|
|
|
if state != STATE_OK:
|
|
|
|
self.reportError(token, 16, 3)
|
|
|
|
state = STATE_OK
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_16_4(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != 'switch':
|
2017-10-09 15:25:55 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if not simpleMatch(token, 'switch ('):
|
2017-10-09 15:25:55 +02:00
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if not simpleMatch(token.next.link, ') {'):
|
|
|
|
continue
|
|
|
|
startTok = token.next.link.next
|
|
|
|
tok = startTok.next
|
|
|
|
while tok and tok.str != '}':
|
|
|
|
if tok.str == '{':
|
|
|
|
tok = tok.link
|
|
|
|
elif tok.str == 'default':
|
|
|
|
break
|
|
|
|
tok = tok.next
|
|
|
|
if tok and tok.str != 'default':
|
|
|
|
self.reportError(token, 16, 4)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_16_5(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str != 'default':
|
|
|
|
continue
|
|
|
|
if token.previous and token.previous.str == '{':
|
|
|
|
continue
|
|
|
|
tok2 = token
|
|
|
|
while tok2:
|
2019-08-10 18:12:23 +02:00
|
|
|
if tok2.str in ('}', 'case'):
|
2018-09-29 09:05:13 +02:00
|
|
|
break
|
|
|
|
if tok2.str == '{':
|
|
|
|
tok2 = tok2.link
|
|
|
|
tok2 = tok2.next
|
|
|
|
if tok2 and tok2.str == 'case':
|
|
|
|
self.reportError(token, 16, 5)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_16_6(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not (simpleMatch(token, 'switch (') and simpleMatch(token.next.link, ') {')):
|
|
|
|
continue
|
|
|
|
tok = token.next.link.next.next
|
|
|
|
count = 0
|
|
|
|
while tok:
|
|
|
|
if tok.str in ['break', 'return', 'throw']:
|
|
|
|
count = count + 1
|
|
|
|
elif tok.str == '{':
|
|
|
|
tok = tok.link
|
|
|
|
if isNoReturnScope(tok):
|
|
|
|
count = count + 1
|
|
|
|
elif tok.str == '}':
|
|
|
|
break
|
|
|
|
tok = tok.next
|
|
|
|
if count < 2:
|
|
|
|
self.reportError(token, 16, 6)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_16_7(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if simpleMatch(token, 'switch (') and isBoolExpression(token.next.astOperand2):
|
|
|
|
self.reportError(token, 16, 7)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_17_1(self, data):
|
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if isFunctionCall(token) and token.astOperand1.str in ('va_list', 'va_arg', 'va_start', 'va_end', 'va_copy'):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 17, 1)
|
|
|
|
elif token.str == 'va_list':
|
|
|
|
self.reportError(token, 17, 1)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2019-07-13 15:09:50 +02:00
|
|
|
def misra_17_2(self, data):
|
|
|
|
# find recursions..
|
|
|
|
def find_recursive_call(search_for_function, direct_call, calls_map, visited=set()):
|
|
|
|
if direct_call == search_for_function:
|
|
|
|
return True
|
2019-07-13 15:17:19 +02:00
|
|
|
for indirect_call in calls_map.get(direct_call, []):
|
2019-07-13 15:09:50 +02:00
|
|
|
if indirect_call == search_for_function:
|
|
|
|
return True
|
|
|
|
if indirect_call in visited:
|
|
|
|
# This has already been handled
|
|
|
|
continue
|
|
|
|
visited.add(indirect_call)
|
|
|
|
if find_recursive_call(search_for_function, indirect_call, calls_map, visited):
|
|
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
|
|
# List functions called in each function
|
|
|
|
function_calls = {}
|
|
|
|
for scope in data.scopes:
|
|
|
|
if scope.type != 'Function':
|
|
|
|
continue
|
|
|
|
calls = []
|
|
|
|
tok = scope.bodyStart
|
|
|
|
while tok != scope.bodyEnd:
|
|
|
|
tok = tok.next
|
|
|
|
if not isFunctionCall(tok):
|
|
|
|
continue
|
|
|
|
f = tok.astOperand1.function
|
|
|
|
if f is not None and f not in calls:
|
|
|
|
calls.append(f)
|
|
|
|
function_calls[scope.function] = calls
|
|
|
|
|
|
|
|
# Report warnings for all recursions..
|
|
|
|
for func in function_calls:
|
|
|
|
for call in function_calls[func]:
|
|
|
|
if not find_recursive_call(func, call, function_calls):
|
|
|
|
# Function call is not recursive
|
|
|
|
continue
|
|
|
|
# Warn about all functions calls..
|
|
|
|
for scope in data.scopes:
|
|
|
|
if scope.type != 'Function' or scope.function != func:
|
|
|
|
continue
|
|
|
|
tok = scope.bodyStart
|
|
|
|
while tok != scope.bodyEnd:
|
|
|
|
if tok.function and tok.function == call:
|
|
|
|
self.reportError(tok, 17, 2)
|
|
|
|
tok = tok.next
|
|
|
|
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_17_6(self, rawTokens):
|
|
|
|
for token in rawTokens:
|
|
|
|
if simpleMatch(token, '[ static'):
|
|
|
|
self.reportError(token, 17, 6)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
|
2019-05-22 21:39:33 +02:00
|
|
|
def misra_17_7(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not token.scope.isExecutable:
|
|
|
|
continue
|
|
|
|
if token.str != '(' or token.astParent:
|
|
|
|
continue
|
|
|
|
if not token.previous.isName or token.previous.varId:
|
|
|
|
continue
|
|
|
|
if token.valueType is None:
|
|
|
|
continue
|
|
|
|
if token.valueType.type == 'void' and token.valueType.pointer == 0:
|
|
|
|
continue
|
|
|
|
self.reportError(token, 17, 7)
|
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_17_8(self, data):
|
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if not (token.isAssignmentOp or (token.str in ('++', '--'))):
|
2018-09-29 09:05:13 +02:00
|
|
|
continue
|
|
|
|
if not token.astOperand1:
|
|
|
|
continue
|
|
|
|
var = token.astOperand1.variable
|
|
|
|
if var and var.isArgument:
|
|
|
|
self.reportError(token, 17, 8)
|
|
|
|
|
2019-07-09 15:57:12 +02:00
|
|
|
def misra_18_4(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not token.str in ('+', '-', '+=', '-='):
|
|
|
|
continue
|
|
|
|
if token.astOperand1 is None or token.astOperand2 is None:
|
|
|
|
continue
|
|
|
|
vt1 = token.astOperand1.valueType
|
|
|
|
vt2 = token.astOperand2.valueType
|
|
|
|
if vt1 and vt1.pointer > 0:
|
|
|
|
self.reportError(token, 18, 4)
|
|
|
|
elif vt2 and vt2.pointer > 0:
|
|
|
|
self.reportError(token, 18, 4)
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def misra_18_5(self, data):
|
|
|
|
for var in data.variables:
|
|
|
|
if not var.isPointer:
|
|
|
|
continue
|
|
|
|
typetok = var.nameToken
|
|
|
|
count = 0
|
|
|
|
while typetok:
|
|
|
|
if typetok.str == '*':
|
2017-10-09 15:25:55 +02:00
|
|
|
count = count + 1
|
2018-09-29 09:05:13 +02:00
|
|
|
elif not typetok.isName:
|
|
|
|
break
|
|
|
|
typetok = typetok.previous
|
|
|
|
if count > 2:
|
|
|
|
self.reportError(var.nameToken, 18, 5)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2019-07-01 07:00:43 +02:00
|
|
|
def misra_18_7(self, data):
|
|
|
|
for scope in data.scopes:
|
|
|
|
if scope.type != 'Struct':
|
|
|
|
continue
|
|
|
|
|
|
|
|
token = scope.bodyStart.next
|
|
|
|
while token != scope.bodyEnd and token is not None:
|
|
|
|
# Handle nested structures to not duplicate an error.
|
|
|
|
if token.str == '{':
|
|
|
|
token = token.link
|
|
|
|
|
|
|
|
if cppcheckdata.simpleMatch(token, "[ ]"):
|
|
|
|
self.reportError(token, 18, 7)
|
|
|
|
break
|
|
|
|
token = token.next
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_18_8(self, data):
|
|
|
|
for var in data.variables:
|
|
|
|
if not var.isArray or not var.isLocal:
|
|
|
|
continue
|
|
|
|
# TODO Array dimensions are not available in dump, must look in tokens
|
|
|
|
typetok = var.nameToken.next
|
|
|
|
if not typetok or typetok.str != '[':
|
|
|
|
continue
|
2019-10-26 17:29:38 +02:00
|
|
|
# Unknown define or syntax error
|
|
|
|
if not typetok.astOperand2:
|
|
|
|
continue
|
2018-09-29 09:05:13 +02:00
|
|
|
if not isConstantExpression(typetok.astOperand2):
|
|
|
|
self.reportError(var.nameToken, 18, 8)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_19_2(self, data):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str == 'union':
|
|
|
|
self.reportError(token, 19, 2)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_20_1(self, data):
|
|
|
|
for directive in data.directives:
|
|
|
|
if not directive.str.startswith('#include'):
|
|
|
|
continue
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.file != directive.file:
|
|
|
|
continue
|
|
|
|
if int(token.linenr) < int(directive.linenr):
|
|
|
|
self.reportError(directive, 20, 1)
|
|
|
|
break
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_20_2(self, data):
|
|
|
|
for directive in data.directives:
|
|
|
|
if not directive.str.startswith('#include '):
|
|
|
|
continue
|
2019-08-10 18:12:23 +02:00
|
|
|
for pattern in ('\\', '//', '/*', "'"):
|
2018-09-29 09:05:13 +02:00
|
|
|
if pattern in directive.str:
|
|
|
|
self.reportError(directive, 20, 2)
|
|
|
|
break
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_20_3(self, rawTokens):
|
|
|
|
linenr = -1
|
|
|
|
for token in rawTokens:
|
|
|
|
if token.str.startswith('/') or token.linenr == linenr:
|
|
|
|
continue
|
|
|
|
linenr = token.linenr
|
|
|
|
if not simpleMatch(token, '# include'):
|
|
|
|
continue
|
|
|
|
headerToken = token.next.next
|
|
|
|
num = 0
|
|
|
|
while headerToken and headerToken.linenr == linenr:
|
|
|
|
if not headerToken.str.startswith('/*') and not headerToken.str.startswith('//'):
|
|
|
|
num += 1
|
|
|
|
headerToken = headerToken.next
|
|
|
|
if num != 1:
|
|
|
|
self.reportError(token, 20, 3)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_20_4(self, data):
|
|
|
|
for directive in data.directives:
|
|
|
|
res = re.search(r'#define ([a-z][a-z0-9_]+)', directive.str)
|
|
|
|
if res and (res.group(1) in KEYWORDS):
|
|
|
|
self.reportError(directive, 20, 4)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_20_5(self, data):
|
|
|
|
for directive in data.directives:
|
|
|
|
if directive.str.startswith('#undef '):
|
|
|
|
self.reportError(directive, 20, 5)
|
|
|
|
|
|
|
|
|
2019-04-11 10:36:02 +02:00
|
|
|
def misra_20_7(self, data):
|
|
|
|
for directive in data.directives:
|
|
|
|
d = Define(directive)
|
|
|
|
exp = '(' + d.expansionList + ')'
|
|
|
|
for arg in d.args:
|
2019-04-11 10:50:07 +02:00
|
|
|
pos = 0
|
|
|
|
while pos < len(exp):
|
|
|
|
pos = exp.find(arg, pos)
|
|
|
|
if pos < 0:
|
|
|
|
break
|
|
|
|
pos1 = pos - 1
|
|
|
|
pos2 = pos + len(arg)
|
|
|
|
pos = pos2
|
|
|
|
if isalnum(exp[pos1]) or exp[pos1]=='_':
|
|
|
|
continue
|
|
|
|
if isalnum(exp[pos2]) or exp[pos2]=='_':
|
|
|
|
continue
|
|
|
|
while exp[pos1] == ' ':
|
|
|
|
pos1 -= 1
|
|
|
|
if exp[pos1] != '(' and exp[pos1] != '[':
|
2019-06-27 06:59:47 +02:00
|
|
|
self.reportError(directive, 20, 7)
|
2019-04-11 10:50:07 +02:00
|
|
|
break
|
|
|
|
while exp[pos2] == ' ':
|
|
|
|
pos2 += 1
|
|
|
|
if exp[pos2] != ')' and exp[pos2] != ']':
|
2019-06-27 06:59:47 +02:00
|
|
|
self.reportError(directive, 20, 7)
|
2019-04-11 10:50:07 +02:00
|
|
|
break
|
|
|
|
|
|
|
|
|
|
|
|
def misra_20_10(self, data):
|
|
|
|
for directive in data.directives:
|
|
|
|
d = Define(directive)
|
|
|
|
if d.expansionList.find('#') >= 0:
|
2019-06-27 06:59:47 +02:00
|
|
|
self.reportError(directive, 20, 10)
|
2019-04-11 10:36:02 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_20_13(self, data):
|
2019-04-08 18:26:17 +02:00
|
|
|
dir_pattern = re.compile(r'#[ ]*([^ (<]*)')
|
2018-09-29 09:05:13 +02:00
|
|
|
for directive in data.directives:
|
|
|
|
dir = directive.str
|
2019-04-08 18:26:17 +02:00
|
|
|
mo = dir_pattern.match(dir)
|
|
|
|
if mo:
|
|
|
|
dir = mo.group(1)
|
|
|
|
if dir not in ['define', 'elif', 'else', 'endif', 'error', 'if', 'ifdef', 'ifndef', 'include',
|
|
|
|
'pragma', 'undef', 'warning']:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(directive, 20, 13)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_20_14(self, data):
|
|
|
|
# stack for #if blocks. contains the #if directive until the corresponding #endif is seen.
|
|
|
|
# the size increases when there are inner #if directives.
|
|
|
|
ifStack = []
|
|
|
|
for directive in data.directives:
|
|
|
|
if directive.str.startswith('#if ') or directive.str.startswith('#ifdef ') or directive.str.startswith('#ifndef '):
|
|
|
|
ifStack.append(directive)
|
|
|
|
elif directive.str == '#else' or directive.str.startswith('#elif '):
|
|
|
|
if len(ifStack) == 0:
|
|
|
|
self.reportError(directive, 20, 14)
|
|
|
|
ifStack.append(directive)
|
|
|
|
elif directive.file != ifStack[-1].file:
|
|
|
|
self.reportError(directive, 20, 14)
|
|
|
|
elif directive.str == '#endif':
|
|
|
|
if len(ifStack) == 0:
|
|
|
|
self.reportError(directive, 20, 14)
|
|
|
|
elif directive.file != ifStack[-1].file:
|
|
|
|
self.reportError(directive, 20, 14)
|
|
|
|
ifStack.pop()
|
|
|
|
|
|
|
|
|
2019-10-26 08:32:46 +02:00
|
|
|
def misra_21_1(self, data):
|
|
|
|
# Reference: n1570 7.1.3 - Reserved identifiers
|
|
|
|
re_forbidden_macro = re.compile(r'#define (errno|_[_A-Z]+)')
|
|
|
|
|
|
|
|
# Search for forbidden identifiers in macro names
|
|
|
|
for directive in data.directives:
|
|
|
|
res = re.search(re_forbidden_macro, directive.str)
|
|
|
|
if res:
|
|
|
|
self.reportError(directive, 21, 1)
|
|
|
|
|
|
|
|
# Search for forbidden identifiers
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if not token.isName:
|
|
|
|
continue
|
|
|
|
if len(token.str) < 2:
|
|
|
|
continue
|
|
|
|
if token.str == 'errno':
|
|
|
|
self.reportError(token, 21, 1)
|
|
|
|
if token.str[0] == '_':
|
|
|
|
if (token.str[1] in string.ascii_uppercase) or (token.str[1] == '_'):
|
|
|
|
self.reportError(token, 21, 1)
|
|
|
|
|
|
|
|
# Allow identifiers with file scope visibility (static)
|
|
|
|
if token.scope.type == 'Global':
|
|
|
|
if token.variable and token.variable.isStatic:
|
|
|
|
continue
|
|
|
|
if token.function and token.function.isStatic:
|
|
|
|
continue
|
|
|
|
|
|
|
|
self.reportError(token, 21, 1)
|
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_3(self, data):
|
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if isFunctionCall(token) and (token.astOperand1.str in ('malloc', 'calloc', 'realloc', 'free')):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 21, 3)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_4(self, data):
|
|
|
|
directive = findInclude(data.directives, '<setjmp.h>')
|
|
|
|
if directive:
|
|
|
|
self.reportError(directive, 21, 4)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_5(self, data):
|
|
|
|
directive = findInclude(data.directives, '<signal.h>')
|
|
|
|
if directive:
|
|
|
|
self.reportError(directive, 21, 5)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_6(self, data):
|
|
|
|
dir_stdio = findInclude(data.directives, '<stdio.h>')
|
|
|
|
dir_wchar = findInclude(data.directives, '<wchar.h>')
|
|
|
|
if dir_stdio:
|
|
|
|
self.reportError(dir_stdio, 21, 6)
|
|
|
|
if dir_wchar:
|
|
|
|
self.reportError(dir_wchar, 21, 6)
|
|
|
|
|
|
|
|
|
|
|
|
def misra_21_7(self, data):
|
2017-10-09 15:25:55 +02:00
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if isFunctionCall(token) and (token.astOperand1.str in ('atof', 'atoi', 'atol', 'atoll')):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 21, 7)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_8(self, data):
|
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if isFunctionCall(token) and (token.astOperand1.str in ('abort', 'exit', 'getenv', 'system')):
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 21, 8)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_9(self, data):
|
|
|
|
for token in data.tokenlist:
|
2019-08-10 18:12:23 +02:00
|
|
|
if (token.str in ('bsearch', 'qsort')) and token.next and token.next.str == '(':
|
2018-09-29 09:05:13 +02:00
|
|
|
self.reportError(token, 21, 9)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_10(self, data):
|
|
|
|
directive = findInclude(data.directives, '<time.h>')
|
|
|
|
if directive:
|
|
|
|
self.reportError(directive, 21, 10)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
for token in data.tokenlist:
|
|
|
|
if (token.str == 'wcsftime') and token.next and token.next.str == '(':
|
|
|
|
self.reportError(token, 21, 10)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def misra_21_11(self, data):
|
|
|
|
directive = findInclude(data.directives, '<tgmath.h>')
|
|
|
|
if directive:
|
|
|
|
self.reportError(directive, 21, 11)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2019-10-26 08:32:46 +02:00
|
|
|
def misra_21_12(self, data):
|
|
|
|
if findInclude(data.directives, '<fenv.h>'):
|
|
|
|
for token in data.tokenlist:
|
|
|
|
if token.str == 'fexcept_t' and token.isName:
|
|
|
|
self.reportError(token, 21, 12)
|
|
|
|
if isFunctionCall(token) and (token.astOperand1.str in (
|
|
|
|
'feclearexcept',
|
|
|
|
'fegetexceptflag',
|
|
|
|
'feraiseexcept',
|
|
|
|
'fesetexceptflag',
|
|
|
|
'fetestexcept')):
|
|
|
|
self.reportError(token, 21, 12)
|
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def get_verify_expected(self):
|
|
|
|
"""Return the list of expected violations in the verify test"""
|
|
|
|
return self.verify_expected
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-05-20 14:44:12 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def get_verify_actual(self):
|
|
|
|
"""Return the list of actual violations in for the verify test"""
|
|
|
|
return self.verify_actual
|
2018-05-20 14:44:12 +02:00
|
|
|
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2019-04-03 19:39:05 +02:00
|
|
|
def get_violations(self, violation_type = None):
|
2018-09-29 09:05:13 +02:00
|
|
|
"""Return the list of violations for a normal checker run"""
|
2019-04-03 19:39:05 +02:00
|
|
|
if violation_type == None:
|
|
|
|
return self.violations.items()
|
|
|
|
else:
|
|
|
|
return self.violations[violation_type]
|
|
|
|
|
|
|
|
def get_violation_types(self):
|
|
|
|
"""Return the list of violations for a normal checker run"""
|
|
|
|
return self.violations.keys()
|
2017-10-09 15:25:55 +02:00
|
|
|
|
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def addSuppressedRule(self, ruleNum,
|
|
|
|
fileName = None,
|
|
|
|
lineNumber = None,
|
|
|
|
symbolName = None):
|
|
|
|
"""
|
|
|
|
Add a suppression to the suppressions data structure
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
Suppressions are stored in a dictionary of dictionaries that
|
|
|
|
contains a list of tuples.
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
The first dictionary is keyed by the MISRA rule in hundreds
|
|
|
|
format. The value of that dictionary is a dictionary of filenames.
|
|
|
|
If the value is None then the rule is assumed to be suppressed for
|
|
|
|
all files.
|
2018-10-18 09:17:57 +02:00
|
|
|
If the filename exists then the value of that dictionary contains a list
|
|
|
|
with the scope of the suppression. If the list contains an item of None
|
|
|
|
then the rule is assumed to be suppresed for the entire file. Otherwise
|
|
|
|
the list contains line number, symbol name tuples.
|
2018-09-29 09:05:13 +02:00
|
|
|
For each tuple either line number or symbol name can can be none.
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
"""
|
2018-10-18 09:17:57 +02:00
|
|
|
normalized_filename = None
|
|
|
|
|
|
|
|
if fileName is not None:
|
2019-06-26 07:30:08 +02:00
|
|
|
normalized_filename = os.path.expanduser(fileName)
|
|
|
|
normalized_filename = os.path.normpath(normalized_filename)
|
2018-05-20 14:44:12 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
if lineNumber is not None or symbolName is not None:
|
|
|
|
line_symbol = (lineNumber, symbolName)
|
|
|
|
else:
|
|
|
|
line_symbol = None
|
2018-05-20 14:44:12 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
# If the rule is not in the dict already then add it
|
|
|
|
if not ruleNum in self.suppressedRules:
|
|
|
|
ruleItemList = list()
|
|
|
|
ruleItemList.append(line_symbol)
|
2018-05-20 14:44:12 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
fileDict = dict()
|
2018-10-18 09:17:57 +02:00
|
|
|
fileDict[normalized_filename] = ruleItemList
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
self.suppressedRules[ruleNum] = fileDict
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
# Rule is added. Done.
|
|
|
|
return
|
2018-05-24 06:31:20 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
# Rule existed in the dictionary. Check for
|
|
|
|
# filename entries.
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2019-03-01 01:01:39 +01:00
|
|
|
# Get the dictionary for the rule number
|
2018-09-29 09:05:13 +02:00
|
|
|
fileDict = self.suppressedRules[ruleNum]
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
# If the filename is not in the dict already add it
|
2018-10-18 09:17:57 +02:00
|
|
|
if not normalized_filename in fileDict:
|
2018-09-29 09:05:13 +02:00
|
|
|
ruleItemList = list()
|
|
|
|
ruleItemList.append(line_symbol)
|
2018-03-31 12:52:00 +02:00
|
|
|
|
2018-10-18 09:17:57 +02:00
|
|
|
fileDict[normalized_filename] = ruleItemList
|
2018-03-31 12:52:00 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
# Rule is added with a file scope. Done
|
|
|
|
return
|
2018-03-31 12:52:00 +02:00
|
|
|
|
2018-10-18 09:17:57 +02:00
|
|
|
# Rule has a matching filename. Get the rule item list.
|
2018-03-31 12:52:00 +02:00
|
|
|
|
2018-10-18 09:17:57 +02:00
|
|
|
# Check the lists of rule items
|
|
|
|
# to see if this (lineNumber, symbonName) combination
|
|
|
|
# or None already exists.
|
|
|
|
ruleItemList = fileDict[normalized_filename]
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
if line_symbol is None:
|
|
|
|
# is it already in the list?
|
|
|
|
if not line_symbol in ruleItemList:
|
|
|
|
ruleItemList.append(line_symbol)
|
|
|
|
else:
|
|
|
|
# Check the list looking for matches
|
|
|
|
matched = False
|
|
|
|
for each in ruleItemList:
|
|
|
|
if each is not None:
|
|
|
|
if (each[0] == line_symbol[0]) and (each[1] == line_symbol[1]):
|
|
|
|
matched = True
|
|
|
|
|
|
|
|
# Append the rule item if it was not already found
|
|
|
|
if not matched:
|
|
|
|
ruleItemList.append(line_symbol)
|
|
|
|
|
|
|
|
|
|
|
|
def isRuleSuppressed(self, location, ruleNum):
|
|
|
|
"""
|
|
|
|
Check to see if a rule is suppressed.
|
|
|
|
ruleNum is the rule number in hundreds format
|
|
|
|
|
|
|
|
If the rule exists in the dict then check for a filename
|
|
|
|
If the filename is None then rule is suppressed globally
|
|
|
|
for all files.
|
|
|
|
If the filename exists then look for list of
|
|
|
|
line number, symbol name tuples. If the list is None then
|
|
|
|
the rule is suppressed for the entire file
|
|
|
|
If the list of tuples exists then search the list looking for
|
2018-11-03 07:34:27 +01:00
|
|
|
matching line numbers. Symbol names are currently ignored
|
2018-09-29 09:05:13 +02:00
|
|
|
because they can include regular expressions.
|
|
|
|
TODO: Support symbol names and expression matching.
|
|
|
|
|
|
|
|
"""
|
|
|
|
ruleIsSuppressed = False
|
2018-10-18 09:17:57 +02:00
|
|
|
linenr = location.linenr
|
|
|
|
|
|
|
|
# Remove any prefix listed in command arguments from the filename.
|
|
|
|
filename = None
|
|
|
|
if location.file is not None:
|
2019-07-24 07:16:48 +02:00
|
|
|
if self.filePrefix is not None:
|
|
|
|
filename = remove_file_prefix(location.file, self.filePrefix)
|
|
|
|
else:
|
|
|
|
filename = os.path.basename(location.file)
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
if ruleNum in self.suppressedRules:
|
|
|
|
fileDict = self.suppressedRules[ruleNum]
|
|
|
|
|
|
|
|
# a file name entry of None means that the rule is suppressed
|
|
|
|
# globally
|
|
|
|
if None in fileDict:
|
|
|
|
ruleIsSuppressed = True
|
|
|
|
else:
|
|
|
|
# Does the filename match one of the names in
|
|
|
|
# the file list
|
|
|
|
if filename in fileDict:
|
|
|
|
# Get the list of ruleItems
|
|
|
|
ruleItemList = fileDict[filename]
|
|
|
|
|
2018-10-18 09:17:57 +02:00
|
|
|
if None in ruleItemList:
|
|
|
|
# Entry of None in the ruleItemList means the rule is
|
|
|
|
# suppressed for all lines in the filename
|
2018-09-29 09:05:13 +02:00
|
|
|
ruleIsSuppressed = True
|
|
|
|
else:
|
|
|
|
# Iterate though the the list of line numbers
|
|
|
|
# and symbols looking for a match of the line
|
|
|
|
# number. Matching the symbol is a TODO:
|
|
|
|
for each in ruleItemList:
|
|
|
|
if each is not None:
|
|
|
|
if each[0] == linenr:
|
|
|
|
ruleIsSuppressed = True
|
|
|
|
|
|
|
|
return ruleIsSuppressed
|
|
|
|
|
|
|
|
|
|
|
|
def parseSuppressions(self):
|
|
|
|
"""
|
|
|
|
Parse the suppression list provided by cppcheck looking for
|
|
|
|
rules that start with 'misra' or MISRA. The MISRA rule number
|
|
|
|
follows using either '_' or '.' to separate the numbers.
|
|
|
|
Examples:
|
|
|
|
misra_6.0
|
|
|
|
misra_7_0
|
|
|
|
misra.21.11
|
|
|
|
"""
|
|
|
|
rule_pattern = re.compile(r'^(misra|MISRA)[_.]([0-9]+)[_.]([0-9]+)')
|
|
|
|
|
|
|
|
for each in self.dumpfileSuppressions:
|
|
|
|
res = rule_pattern.match(each.errorId)
|
|
|
|
|
|
|
|
if res:
|
|
|
|
num1 = int(res.group(2)) * 100
|
|
|
|
ruleNum = num1 + int(res.group(3))
|
2019-07-16 22:32:41 +02:00
|
|
|
linenr = None
|
|
|
|
if each.lineNumber:
|
|
|
|
linenr = int(each.lineNumber)
|
|
|
|
self.addSuppressedRule(ruleNum, each.fileName, linenr, each.symbolName)
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
|
2018-10-18 09:17:57 +02:00
|
|
|
def showSuppressedRules(self):
|
|
|
|
"""
|
|
|
|
Print out rules in suppression list sorted by Rule Number
|
|
|
|
"""
|
|
|
|
print("Suppressed Rules List:")
|
|
|
|
outlist = list()
|
|
|
|
|
|
|
|
for ruleNum in self.suppressedRules:
|
|
|
|
fileDict = self.suppressedRules[ruleNum]
|
|
|
|
|
|
|
|
for fname in fileDict:
|
|
|
|
ruleItemList = fileDict[fname]
|
|
|
|
|
|
|
|
for item in ruleItemList:
|
|
|
|
if item is None:
|
|
|
|
item_str = "None"
|
|
|
|
else:
|
|
|
|
item_str = str(item[0])
|
|
|
|
|
2019-04-03 19:38:03 +02:00
|
|
|
outlist.append("%s: %s: %s (%d locations suppressed)" % (float(ruleNum)/100,fname,item_str, len(self.suppressionStats.get(ruleNum, []))))
|
2018-10-18 09:17:57 +02:00
|
|
|
|
|
|
|
for line in sorted(outlist, reverse=True):
|
|
|
|
print(" %s" % line)
|
|
|
|
|
2019-07-24 07:16:48 +02:00
|
|
|
def setFilePrefix(self, prefix):
|
|
|
|
"""
|
|
|
|
Set the file prefix to ignnore from files when matching
|
|
|
|
suppression files
|
|
|
|
"""
|
|
|
|
self.filePrefix = prefix
|
2018-10-18 09:17:57 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def setSuppressionList(self, suppressionlist):
|
|
|
|
num1 = 0
|
|
|
|
num2 = 0
|
|
|
|
rule_pattern = re.compile(r'([0-9]+).([0-9]+)')
|
|
|
|
strlist = suppressionlist.split(",")
|
|
|
|
|
|
|
|
# build ignore list
|
|
|
|
for item in strlist:
|
|
|
|
res = rule_pattern.match(item)
|
|
|
|
if res:
|
|
|
|
num1 = int(res.group(1))
|
|
|
|
num2 = int(res.group(2))
|
|
|
|
ruleNum = (num1*100)+num2
|
|
|
|
|
|
|
|
self.addSuppressedRule(ruleNum)
|
|
|
|
|
|
|
|
|
|
|
|
def reportError(self, location, num1, num2):
|
|
|
|
ruleNum = num1 * 100 + num2
|
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
if self.settings.verify:
|
2018-09-29 09:05:13 +02:00
|
|
|
self.verify_actual.append(str(location.linenr) + ':' + str(num1) + '.' + str(num2))
|
|
|
|
elif self.isRuleSuppressed(location, ruleNum):
|
|
|
|
# Error is suppressed. Ignore
|
2019-04-03 19:38:03 +02:00
|
|
|
if not ruleNum in self.suppressionStats:
|
|
|
|
self.suppressionStats[ruleNum] = []
|
|
|
|
self.suppressionStats[ruleNum].append(location)
|
2018-09-29 09:05:13 +02:00
|
|
|
return
|
|
|
|
else:
|
2019-04-13 10:22:13 +02:00
|
|
|
errorId = 'c2012-' + str(num1) + '.' + str(num2)
|
2019-06-23 14:08:05 +02:00
|
|
|
misra_severity = 'Undefined'
|
|
|
|
cppcheck_severity = 'style'
|
2018-09-29 09:05:13 +02:00
|
|
|
if ruleNum in self.ruleTexts:
|
2019-04-13 10:22:13 +02:00
|
|
|
errmsg = self.ruleTexts[ruleNum].text
|
2019-06-23 14:08:05 +02:00
|
|
|
if self.ruleTexts[ruleNum].misra_severity:
|
|
|
|
misra_severity = self.ruleTexts[ruleNum].misra_severity
|
|
|
|
cppcheck_severity = self.ruleTexts[ruleNum].cppcheck_severity
|
2018-09-29 09:05:13 +02:00
|
|
|
elif len(self.ruleTexts) == 0:
|
2019-04-13 10:22:13 +02:00
|
|
|
errmsg = 'misra violation (use --rule-texts=<file> to get proper output)'
|
2018-09-29 09:05:13 +02:00
|
|
|
else:
|
|
|
|
return
|
2019-06-25 00:42:13 +02:00
|
|
|
cppcheckdata.reportError(location, cppcheck_severity, errmsg, 'misra', errorId, misra_severity)
|
2019-04-13 10:22:13 +02:00
|
|
|
|
2019-06-23 14:08:05 +02:00
|
|
|
if not misra_severity in self.violations:
|
|
|
|
self.violations[misra_severity] = []
|
|
|
|
self.violations[misra_severity].append('misra-' + errorId)
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
def loadRuleTexts(self, filename):
|
|
|
|
num1 = 0
|
|
|
|
num2 = 0
|
|
|
|
appendixA = False
|
|
|
|
ruleText = False
|
2019-06-17 21:17:29 +02:00
|
|
|
expect_more = False
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
Rule_pattern = re.compile(r'^Rule ([0-9]+).([0-9]+)')
|
2019-09-09 21:43:44 +02:00
|
|
|
severity_pattern = re.compile(r'.*[ ]*(Advisory|Required|Mandatory)$')
|
2018-09-29 09:05:13 +02:00
|
|
|
xA_Z_pattern = re.compile(r'^[#A-Z].*')
|
|
|
|
a_z_pattern = re.compile(r'^[a-z].*')
|
2019-01-18 21:30:08 +01:00
|
|
|
# Try to detect the file encoding
|
|
|
|
file_stream = None
|
|
|
|
encodings = ['ascii', 'utf-8', 'windows-1250', 'windows-1252']
|
|
|
|
for e in encodings:
|
|
|
|
try:
|
|
|
|
file_stream = codecs.open(filename, 'r', encoding=e)
|
|
|
|
file_stream.readlines()
|
|
|
|
file_stream.seek(0)
|
|
|
|
except UnicodeDecodeError:
|
|
|
|
file_stream = None
|
|
|
|
else:
|
|
|
|
break
|
|
|
|
if not file_stream:
|
|
|
|
print('Could not find a suitable codec for "' + filename + '".')
|
|
|
|
print('If you know the codec please report it to the developers so the list can be enhanced.')
|
|
|
|
print('Trying with default codec now and ignoring errors if possible ...')
|
|
|
|
try:
|
|
|
|
file_stream = open(filename, 'rt', errors='ignore')
|
|
|
|
except TypeError:
|
|
|
|
# Python 2 does not support the errors parameter
|
|
|
|
file_stream = open(filename, 'rt')
|
2019-06-17 21:17:29 +02:00
|
|
|
|
2019-04-03 19:39:05 +02:00
|
|
|
rule = None
|
2019-09-09 21:43:44 +02:00
|
|
|
have_severity = False
|
|
|
|
severity_loc = 0
|
|
|
|
|
2019-01-18 21:30:08 +01:00
|
|
|
for line in file_stream:
|
2019-09-09 21:43:44 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
line = line.replace('\r', '').replace('\n', '')
|
2019-09-09 21:43:44 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
if not appendixA:
|
|
|
|
if line.find('Appendix A') >= 0 and line.find('Summary of guidelines') >= 10:
|
|
|
|
appendixA = True
|
|
|
|
continue
|
|
|
|
if line.find('Appendix B') >= 0:
|
|
|
|
break
|
2019-04-16 10:57:31 +02:00
|
|
|
if len(line) == 0:
|
|
|
|
continue
|
2019-06-17 21:17:29 +02:00
|
|
|
|
|
|
|
# Parse rule declaration.
|
2018-09-29 09:05:13 +02:00
|
|
|
res = Rule_pattern.match(line)
|
2019-09-09 21:43:44 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
if res:
|
2019-09-09 21:43:44 +02:00
|
|
|
have_severity = False
|
|
|
|
expect_more = False
|
|
|
|
severity_loc = 0
|
2018-09-29 09:05:13 +02:00
|
|
|
num1 = int(res.group(1))
|
|
|
|
num2 = int(res.group(2))
|
2019-04-03 19:39:05 +02:00
|
|
|
rule = Rule(num1, num2)
|
2019-09-09 21:43:44 +02:00
|
|
|
|
|
|
|
if not have_severity and rule is not None:
|
|
|
|
res = severity_pattern.match(line)
|
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
if res:
|
2019-06-23 14:08:05 +02:00
|
|
|
rule.misra_severity = res.group(1)
|
2019-09-09 21:43:44 +02:00
|
|
|
have_severity = True
|
|
|
|
else:
|
|
|
|
severity_loc += 1;
|
|
|
|
|
|
|
|
# Only look for severity on the Rule line
|
|
|
|
# or the next non-blank line after
|
|
|
|
# If it's not in either of those locations then
|
|
|
|
# assume a severity was not provided.
|
|
|
|
|
|
|
|
if severity_loc < 2:
|
|
|
|
continue
|
|
|
|
else:
|
|
|
|
rule.misra_severity = ''
|
|
|
|
have_severity = True
|
|
|
|
|
2019-04-16 10:57:31 +02:00
|
|
|
if rule is None:
|
|
|
|
continue
|
2019-06-17 21:17:29 +02:00
|
|
|
|
|
|
|
# Parse continuing of rule text.
|
|
|
|
if expect_more:
|
2019-04-16 10:57:31 +02:00
|
|
|
if a_z_pattern.match(line):
|
|
|
|
self.ruleTexts[rule.num].text += ' ' + line
|
2019-06-17 21:17:29 +02:00
|
|
|
continue
|
2019-09-09 21:43:44 +02:00
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
expect_more = False
|
|
|
|
continue
|
|
|
|
|
|
|
|
# Parse beginning of rule text.
|
|
|
|
if xA_Z_pattern.match(line):
|
|
|
|
rule.text = line
|
|
|
|
self.ruleTexts[rule.num] = rule
|
|
|
|
expect_more = True
|
|
|
|
|
2019-06-19 21:57:28 +02:00
|
|
|
def verifyRuleTexts(self):
|
|
|
|
"""Prints rule numbers without rule text."""
|
|
|
|
rule_texts_rules = []
|
|
|
|
for rule_num in self.ruleTexts:
|
|
|
|
rule = self.ruleTexts[rule_num]
|
|
|
|
rule_texts_rules.append(str(rule.num1) + '.' + str(rule.num2))
|
|
|
|
|
|
|
|
all_rules = list(getAddonRules() + getCppcheckRules())
|
|
|
|
|
|
|
|
missing_rules = list(set(all_rules) - set(rule_texts_rules))
|
|
|
|
if len(missing_rules) == 0:
|
|
|
|
print("Rule texts are correct.")
|
|
|
|
else:
|
|
|
|
print("Missing rule texts: " + ', '.join(missing_rules))
|
|
|
|
|
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
def printStatus(self, *args, **kwargs):
|
|
|
|
if not self.settings.quiet:
|
|
|
|
print(*args, **kwargs)
|
2018-03-31 12:52:00 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
def parseDump(self, dumpfile):
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
data = cppcheckdata.parsedump(dumpfile)
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
self.dumpfileSuppressions = data.suppressions
|
|
|
|
self.parseSuppressions()
|
2018-06-04 21:50:21 +02:00
|
|
|
|
2018-09-29 09:05:13 +02:00
|
|
|
typeBits['CHAR'] = data.platform.char_bit
|
|
|
|
typeBits['SHORT'] = data.platform.short_bit
|
|
|
|
typeBits['INT'] = data.platform.int_bit
|
|
|
|
typeBits['LONG'] = data.platform.long_bit
|
|
|
|
typeBits['LONG_LONG'] = data.platform.long_long_bit
|
|
|
|
typeBits['POINTER'] = data.platform.pointer_bit
|
2017-10-09 15:25:55 +02:00
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
if self.settings.verify:
|
2018-09-29 09:05:13 +02:00
|
|
|
for tok in data.rawTokens:
|
|
|
|
if tok.str.startswith('//') and 'TODO' not in tok.str:
|
|
|
|
compiled = re.compile(r'[0-9]+\.[0-9]+')
|
|
|
|
for word in tok.str[2:].split(' '):
|
|
|
|
if compiled.match(word):
|
|
|
|
self.verify_expected.append(str(tok.linenr) + ':' + word)
|
|
|
|
else:
|
2019-06-17 21:17:29 +02:00
|
|
|
self.printStatus('Checking ' + dumpfile + '...')
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
cfgNumber = 0
|
|
|
|
|
|
|
|
for cfg in data.configurations:
|
|
|
|
cfgNumber = cfgNumber + 1
|
|
|
|
if len(data.configurations) > 1:
|
2019-06-17 21:17:29 +02:00
|
|
|
self.printStatus('Checking ' + dumpfile + ', config "' + cfg.name + '"...')
|
2018-09-29 09:05:13 +02:00
|
|
|
|
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_3_1(data.rawTokens)
|
2019-10-16 11:31:42 +02:00
|
|
|
self.misra_3_2(data.rawTokens)
|
2018-09-29 09:05:13 +02:00
|
|
|
self.misra_4_1(data.rawTokens)
|
2019-10-09 08:26:05 +02:00
|
|
|
self.misra_4_2(data.rawTokens)
|
2018-09-29 09:05:13 +02:00
|
|
|
self.misra_5_1(cfg)
|
|
|
|
self.misra_5_2(cfg)
|
|
|
|
self.misra_5_3(cfg)
|
|
|
|
self.misra_5_4(cfg)
|
|
|
|
self.misra_5_5(cfg)
|
|
|
|
# 6.1 require updates in Cppcheck (type info for bitfields are lost)
|
|
|
|
# 6.2 require updates in Cppcheck (type info for bitfields are lost)
|
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_7_1(data.rawTokens)
|
|
|
|
self.misra_7_3(data.rawTokens)
|
|
|
|
self.misra_8_11(cfg)
|
|
|
|
self.misra_8_12(cfg)
|
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_8_14(data.rawTokens)
|
|
|
|
self.misra_9_5(data.rawTokens)
|
|
|
|
self.misra_10_1(cfg)
|
|
|
|
self.misra_10_4(cfg)
|
|
|
|
self.misra_10_6(cfg)
|
|
|
|
self.misra_10_8(cfg)
|
|
|
|
self.misra_11_3(cfg)
|
|
|
|
self.misra_11_4(cfg)
|
|
|
|
self.misra_11_5(cfg)
|
|
|
|
self.misra_11_6(cfg)
|
|
|
|
self.misra_11_7(cfg)
|
|
|
|
self.misra_11_8(cfg)
|
|
|
|
self.misra_11_9(cfg)
|
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_12_1_sizeof(data.rawTokens)
|
|
|
|
self.misra_12_1(cfg)
|
|
|
|
self.misra_12_2(cfg)
|
|
|
|
self.misra_12_3(cfg)
|
|
|
|
self.misra_12_4(cfg)
|
|
|
|
self.misra_13_1(cfg)
|
|
|
|
self.misra_13_3(cfg)
|
|
|
|
self.misra_13_4(cfg)
|
|
|
|
self.misra_13_5(cfg)
|
|
|
|
self.misra_13_6(cfg)
|
|
|
|
self.misra_14_1(cfg)
|
|
|
|
self.misra_14_2(cfg)
|
|
|
|
self.misra_14_4(cfg)
|
|
|
|
self.misra_15_1(cfg)
|
|
|
|
self.misra_15_2(cfg)
|
|
|
|
self.misra_15_3(cfg)
|
|
|
|
self.misra_15_5(cfg)
|
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_15_6(data.rawTokens)
|
|
|
|
self.misra_15_7(cfg)
|
|
|
|
self.misra_16_2(cfg)
|
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_16_3(data.rawTokens)
|
|
|
|
self.misra_16_4(cfg)
|
|
|
|
self.misra_16_5(cfg)
|
|
|
|
self.misra_16_6(cfg)
|
|
|
|
self.misra_16_7(cfg)
|
|
|
|
self.misra_17_1(cfg)
|
2019-07-13 15:09:50 +02:00
|
|
|
self.misra_17_2(cfg)
|
2018-09-29 09:05:13 +02:00
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_17_6(data.rawTokens)
|
2019-05-22 21:39:33 +02:00
|
|
|
self.misra_17_7(cfg)
|
2018-09-29 09:05:13 +02:00
|
|
|
self.misra_17_8(cfg)
|
2019-07-09 15:57:12 +02:00
|
|
|
self.misra_18_4(cfg)
|
2018-09-29 09:05:13 +02:00
|
|
|
self.misra_18_5(cfg)
|
2019-07-01 07:00:43 +02:00
|
|
|
self.misra_18_7(cfg)
|
2018-09-29 09:05:13 +02:00
|
|
|
self.misra_18_8(cfg)
|
|
|
|
self.misra_19_2(cfg)
|
|
|
|
self.misra_20_1(cfg)
|
|
|
|
self.misra_20_2(cfg)
|
|
|
|
if cfgNumber == 1:
|
|
|
|
self.misra_20_3(data.rawTokens)
|
|
|
|
self.misra_20_4(cfg)
|
|
|
|
self.misra_20_5(cfg)
|
2019-04-11 10:36:02 +02:00
|
|
|
self.misra_20_7(cfg)
|
2019-04-11 10:50:07 +02:00
|
|
|
self.misra_20_10(cfg)
|
2018-09-29 09:05:13 +02:00
|
|
|
self.misra_20_13(cfg)
|
|
|
|
self.misra_20_14(cfg)
|
2019-10-26 08:32:46 +02:00
|
|
|
self.misra_21_1(cfg)
|
2018-09-29 09:05:13 +02:00
|
|
|
self.misra_21_3(cfg)
|
|
|
|
self.misra_21_4(cfg)
|
|
|
|
self.misra_21_5(cfg)
|
|
|
|
self.misra_21_6(cfg)
|
|
|
|
self.misra_21_7(cfg)
|
|
|
|
self.misra_21_8(cfg)
|
|
|
|
self.misra_21_9(cfg)
|
|
|
|
self.misra_21_10(cfg)
|
|
|
|
self.misra_21_11(cfg)
|
2019-10-26 08:32:46 +02:00
|
|
|
self.misra_21_12(cfg)
|
2018-09-29 09:05:13 +02:00
|
|
|
# 22.4 is already covered by Cppcheck writeReadOnlyFile
|
2018-05-24 06:31:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
RULE_TEXTS_HELP = '''Path to text file of MISRA rules
|
2018-05-20 14:48:01 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
If you have the tool 'pdftotext' you might be able
|
|
|
|
to generate this textfile with such command:
|
2018-05-20 14:48:01 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
pdftotext MISRA_C_2012.pdf MISRA_C_2012.txt
|
|
|
|
|
|
|
|
Otherwise you can more or less copy/paste the chapter
|
|
|
|
Appendix A Summary of guidelines
|
|
|
|
from the MISRA pdf. You can buy the MISRA pdf from
|
|
|
|
http://www.misra.org.uk/
|
|
|
|
|
|
|
|
Format:
|
|
|
|
|
|
|
|
<..arbitrary text..>
|
|
|
|
Appendix A Summary of guidelines
|
|
|
|
Rule 1.1
|
|
|
|
Rule text for 1.1
|
|
|
|
Rule 1.2
|
|
|
|
Rule text for 1.2
|
|
|
|
<...>
|
|
|
|
|
|
|
|
'''
|
|
|
|
|
|
|
|
SUPPRESS_RULES_HELP = '''MISRA rules to suppress (comma-separated)
|
|
|
|
|
|
|
|
For example, if you'd like to suppress rules 15.1, 11.3,
|
|
|
|
and 20.13, run:
|
|
|
|
|
|
|
|
python misra.py --suppress-rules 15.1,11.3,20.13 ...
|
|
|
|
|
|
|
|
'''
|
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
|
|
|
|
def get_args():
|
|
|
|
"""Generates list of command-line arguments acceptable by misra.py script."""
|
|
|
|
parser = cppcheckdata.ArgumentParser()
|
|
|
|
parser.add_argument("--rule-texts", type=str, help=RULE_TEXTS_HELP)
|
2019-06-19 21:57:28 +02:00
|
|
|
parser.add_argument("--verify-rule-texts", help="Verify that all supported rules texts are present in given file and exit.", action="store_true")
|
2019-06-17 21:17:29 +02:00
|
|
|
parser.add_argument("--suppress-rules", type=str, help=SUPPRESS_RULES_HELP)
|
|
|
|
parser.add_argument("--quiet", help="Only print something when there is an error", action="store_true")
|
|
|
|
parser.add_argument("--no-summary", help="Hide summary of violations", action="store_true")
|
|
|
|
parser.add_argument("-verify", help=argparse.SUPPRESS, action="store_true")
|
|
|
|
parser.add_argument("-generate-table", help=argparse.SUPPRESS, action="store_true")
|
|
|
|
parser.add_argument("dumpfile", nargs='*', help="Path of dump file from cppcheck")
|
|
|
|
parser.add_argument("--show-suppressed-rules", help="Print rule suppression list", action="store_true")
|
2019-07-24 07:16:48 +02:00
|
|
|
parser.add_argument("-P", "--file-prefix", type=str, help="Prefix to strip when matching suppression file rules")
|
2019-06-17 21:17:29 +02:00
|
|
|
parser.add_argument("--cli", help="Addon is executed from Cppcheck", action="store_true")
|
|
|
|
return parser.parse_args()
|
|
|
|
|
|
|
|
|
|
|
|
def main():
|
|
|
|
args = get_args()
|
|
|
|
settings = MisraSettings(args)
|
|
|
|
checker = MisraChecker(settings)
|
|
|
|
|
|
|
|
if args.generate_table:
|
|
|
|
generateTable()
|
|
|
|
sys.exit(0)
|
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
if args.rule_texts:
|
2019-06-26 07:30:08 +02:00
|
|
|
filename = os.path.expanduser(args.rule_texts)
|
|
|
|
filename = os.path.normpath(filename)
|
2018-05-24 06:31:20 +02:00
|
|
|
if not os.path.isfile(filename):
|
|
|
|
print('Fatal error: file is not found: ' + filename)
|
|
|
|
sys.exit(1)
|
2018-09-29 09:05:13 +02:00
|
|
|
checker.loadRuleTexts(filename)
|
2019-06-19 21:57:28 +02:00
|
|
|
if args.verify_rule_texts:
|
|
|
|
checker.verifyRuleTexts()
|
|
|
|
sys.exit(0)
|
|
|
|
|
|
|
|
if args.verify_rule_texts and not args.rule_texts:
|
|
|
|
print("Error: Please specify rule texts file with --rule-texts=<file>")
|
|
|
|
sys.exit(1)
|
2018-09-29 09:05:13 +02:00
|
|
|
|
2018-05-24 06:31:20 +02:00
|
|
|
if args.suppress_rules:
|
2018-09-29 09:05:13 +02:00
|
|
|
checker.setSuppressionList(args.suppress_rules)
|
|
|
|
|
2019-07-24 07:16:48 +02:00
|
|
|
if args.file_prefix:
|
|
|
|
checker.setFilePrefix(args.file_prefix)
|
|
|
|
|
2018-08-04 21:37:08 +02:00
|
|
|
if args.dumpfile:
|
2018-08-09 08:51:00 +02:00
|
|
|
exitCode = 0
|
2018-08-04 21:37:08 +02:00
|
|
|
for item in args.dumpfile:
|
2018-09-29 09:05:13 +02:00
|
|
|
checker.parseDump(item)
|
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
if settings.verify:
|
2018-09-29 09:05:13 +02:00
|
|
|
verify_expected = checker.get_verify_expected()
|
|
|
|
verify_actual = checker.get_verify_actual()
|
|
|
|
|
|
|
|
for expected in verify_expected:
|
|
|
|
if expected not in verify_actual:
|
|
|
|
print('Expected but not seen: ' + expected)
|
|
|
|
exitCode = 1
|
|
|
|
for actual in verify_actual:
|
|
|
|
if actual not in verify_expected:
|
|
|
|
print('Not expected: ' + actual)
|
|
|
|
exitCode = 1
|
|
|
|
|
2019-01-06 17:15:57 +01:00
|
|
|
# Existing behavior of verify mode is to exit
|
2018-09-29 09:05:13 +02:00
|
|
|
# on the first un-expected output.
|
|
|
|
# TODO: Is this required? or can it be moved to after
|
|
|
|
# all input files have been processed
|
|
|
|
if exitCode != 0:
|
|
|
|
sys.exit(exitCode)
|
|
|
|
|
|
|
|
# Under normal operation exit with a non-zero exit code
|
|
|
|
# if there were any violations.
|
2019-06-17 21:17:29 +02:00
|
|
|
if not settings.verify:
|
2018-09-29 09:05:13 +02:00
|
|
|
number_of_violations = len(checker.get_violations())
|
|
|
|
if number_of_violations > 0:
|
|
|
|
exitCode = 1
|
|
|
|
|
2019-06-17 21:17:29 +02:00
|
|
|
if settings.show_summary:
|
2019-06-23 14:08:05 +02:00
|
|
|
print("\nMISRA rules violations found:\n\t%s\n" % ("\n\t".join([ "%s: %d" % (viol, len(checker.get_violations(viol))) for viol in checker.get_violation_types()])))
|
|
|
|
|
2019-04-08 18:10:40 +02:00
|
|
|
rules_violated = {}
|
|
|
|
for severity, ids in checker.get_violations():
|
|
|
|
for misra_id in ids:
|
|
|
|
rules_violated[misra_id] = rules_violated.get(misra_id, 0) + 1
|
2019-06-23 14:08:05 +02:00
|
|
|
print("MISRA rules violated:")
|
2019-04-08 18:10:40 +02:00
|
|
|
convert = lambda text: int(text) if text.isdigit() else text
|
|
|
|
misra_sort = lambda key: [ convert(c) for c in re.split('[\.-]([0-9]*)', key) ]
|
|
|
|
for misra_id in sorted(rules_violated.keys(), key=misra_sort):
|
2019-04-16 08:45:06 +02:00
|
|
|
res = re.match(r'misra-c2012-([0-9]+)\\.([0-9]+)', misra_id)
|
|
|
|
if res is None:
|
|
|
|
num = 0
|
|
|
|
else:
|
|
|
|
num = int(res.group(1)) * 100 + int(res.group(2))
|
2019-04-11 10:36:02 +02:00
|
|
|
severity = '-'
|
|
|
|
if num in checker.ruleTexts:
|
2019-06-23 14:08:05 +02:00
|
|
|
severity = checker.ruleTexts[num].cppcheck_severity
|
2019-04-11 10:36:02 +02:00
|
|
|
print("\t%15s (%s): %d" % (misra_id, severity, rules_violated[misra_id]))
|
2018-09-29 09:05:13 +02:00
|
|
|
|
2018-10-18 09:17:57 +02:00
|
|
|
if args.show_suppressed_rules:
|
|
|
|
checker.showSuppressedRules()
|
|
|
|
|
2018-08-09 08:51:00 +02:00
|
|
|
sys.exit(exitCode)
|
2019-06-17 21:17:29 +02:00
|
|
|
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
main()
|