2016-01-16 18:52:34 +01:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2023-01-28 10:16:34 +01:00
|
|
|
* Copyright (C) 2007-2023 Cppcheck team.
|
2016-01-16 18:52:34 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
2017-05-27 04:33:47 +02:00
|
|
|
|
2016-01-16 18:52:34 +01:00
|
|
|
#include "astutils.h"
|
2022-01-27 19:03:20 +01:00
|
|
|
#include "library.h"
|
2016-01-16 19:08:51 +01:00
|
|
|
#include "settings.h"
|
2023-01-27 08:18:32 +01:00
|
|
|
#include "fixture.h"
|
2023-04-08 16:08:47 +02:00
|
|
|
#include "symboldatabase.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
#include "token.h"
|
|
|
|
#include "tokenize.h"
|
|
|
|
#include "tokenlist.h"
|
2016-01-16 18:52:34 +01:00
|
|
|
|
2020-05-26 20:13:56 +02:00
|
|
|
#include <cstring>
|
2022-09-16 07:15:49 +02:00
|
|
|
#include <sstream> // IWYU pragma: keep
|
2016-01-16 18:52:34 +01:00
|
|
|
|
|
|
|
class TestAstUtils : public TestFixture {
|
|
|
|
public:
|
2021-08-07 20:51:18 +02:00
|
|
|
TestAstUtils() : TestFixture("TestAstUtils") {}
|
2016-01-16 18:52:34 +01:00
|
|
|
|
|
|
|
private:
|
|
|
|
|
2022-02-10 23:02:24 +01:00
|
|
|
void run() override {
|
2021-11-29 07:34:39 +01:00
|
|
|
TEST_CASE(findLambdaEndTokenTest);
|
|
|
|
TEST_CASE(findLambdaStartTokenTest);
|
|
|
|
TEST_CASE(isNullOperandTest);
|
|
|
|
TEST_CASE(isReturnScopeTest);
|
|
|
|
TEST_CASE(isSameExpressionTest);
|
|
|
|
TEST_CASE(isVariableChangedTest);
|
|
|
|
TEST_CASE(isVariableChangedByFunctionCallTest);
|
2023-03-21 18:16:40 +01:00
|
|
|
TEST_CASE(isExpressionChangedTest);
|
2021-11-29 07:34:39 +01:00
|
|
|
TEST_CASE(nextAfterAstRightmostLeafTest);
|
2021-01-25 17:23:47 +01:00
|
|
|
TEST_CASE(isUsedAsBool);
|
2016-01-16 18:52:34 +01:00
|
|
|
}
|
|
|
|
|
2023-05-31 20:55:39 +02:00
|
|
|
#define findLambdaEndToken(...) findLambdaEndToken_(__FILE__, __LINE__, __VA_ARGS__)
|
|
|
|
bool findLambdaEndToken_(const char* file, int line, const char code[], const char pattern[] = nullptr, bool checkNext = true) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2018-10-31 12:36:08 +01:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
2023-05-31 20:55:39 +02:00
|
|
|
const Token* const tokStart = pattern ? Token::findsimplematch(tokenizer.tokens(), pattern, strlen(pattern)) : tokenizer.tokens();
|
|
|
|
const Token * const tokEnd = (::findLambdaEndToken)(tokStart);
|
|
|
|
return tokEnd && (!checkNext || tokEnd->next() == nullptr);
|
2018-10-31 12:36:08 +01:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void findLambdaEndTokenTest() {
|
2020-02-13 16:27:06 +01:00
|
|
|
const Token* nullTok = nullptr;
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT(nullptr == (::findLambdaEndToken)(nullTok));
|
2018-10-31 12:36:08 +01:00
|
|
|
ASSERT_EQUALS(false, findLambdaEndToken("void f() { }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[]{ }"));
|
2019-04-15 06:37:27 +02:00
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[]{ return 0; }"));
|
2018-10-31 12:36:08 +01:00
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](){ }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[&](){ }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[&, i](){ }"));
|
2019-04-15 06:37:27 +02:00
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](int a, int b) { return a + b; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](int a, int b) mutable { return a + b; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](int a, int b) constexpr { return a + b; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) mutable -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(false, findLambdaEndToken("[](void) foo -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) constexpr -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) constexpr -> int* { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) constexpr -> const * int { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) mutable -> const * int { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) constexpr -> const ** int { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("[](void) constexpr -> const * const* int { return x; }"));
|
2023-05-31 20:55:39 +02:00
|
|
|
ASSERT_EQUALS(false, findLambdaEndToken("int** a[] { new int*[2] { new int, new int} }", "[ ]"));
|
|
|
|
ASSERT_EQUALS(false, findLambdaEndToken("int** a[] { new int*[2] { new int, new int} }", "[ 2"));
|
|
|
|
ASSERT_EQUALS(false, findLambdaEndToken("shared_ptr<Type *[]> sp{ new Type *[2] {new Type, new Type}, Deleter<Type>{ 2 } };", "[ 2"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaEndToken("int i = 5 * []{ return 7; }();", "[", /*checkNext*/ false));
|
2019-04-15 06:37:27 +02:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
#define findLambdaStartToken(code) findLambdaStartToken_(code, __FILE__, __LINE__)
|
|
|
|
bool findLambdaStartToken_(const char code[], const char* file, int line) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2019-04-15 06:37:27 +02:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
|
|
|
const Token * const tokStart = (::findLambdaStartToken)(tokenizer.list.back());
|
2019-04-15 06:37:27 +02:00
|
|
|
return tokStart && tokStart == tokenizer.list.front();
|
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void findLambdaStartTokenTest() {
|
|
|
|
ASSERT(nullptr == (::findLambdaStartToken)(nullptr));
|
2019-04-15 06:37:27 +02:00
|
|
|
ASSERT_EQUALS(false, findLambdaStartToken("void f() { }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[]{ }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[]{ return 0; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](){ }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[&](){ }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[&, i](){ }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](int a, int b) { return a + b; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](int a, int b) mutable { return a + b; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](int a, int b) constexpr { return a + b; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) mutable -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(false, findLambdaStartToken("[](void) foo -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) constexpr -> int { return -1; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) constexpr -> int* { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) constexpr -> const * int { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) mutable -> const * int { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) constexpr -> const ** int { return x; }"));
|
|
|
|
ASSERT_EQUALS(true, findLambdaStartToken("[](void) constexpr -> const * const* int { return x; }"));
|
2018-10-31 12:36:08 +01:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
#define isNullOperand(code) isNullOperand_(code, __FILE__, __LINE__)
|
|
|
|
bool isNullOperand_(const char code[], const char* file, int line) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2020-02-09 11:16:08 +01:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
|
|
|
return (::isNullOperand)(tokenizer.tokens());
|
2020-02-09 11:16:08 +01:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void isNullOperandTest() {
|
2020-02-09 11:16:08 +01:00
|
|
|
ASSERT_EQUALS(true, isNullOperand("(void*)0;"));
|
|
|
|
ASSERT_EQUALS(true, isNullOperand("(void*)0U;"));
|
|
|
|
ASSERT_EQUALS(true, isNullOperand("(void*)0x0LL;"));
|
|
|
|
ASSERT_EQUALS(true, isNullOperand("NULL;"));
|
|
|
|
ASSERT_EQUALS(true, isNullOperand("nullptr;"));
|
|
|
|
ASSERT_EQUALS(true, isNullOperand("(void*)NULL;"));
|
|
|
|
ASSERT_EQUALS(true, isNullOperand("static_cast<int*>(0);"));
|
|
|
|
ASSERT_EQUALS(false, isNullOperand("0;"));
|
|
|
|
ASSERT_EQUALS(false, isNullOperand("(void*)0.0;"));
|
|
|
|
ASSERT_EQUALS(false, isNullOperand("(void*)1;"));
|
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
#define isReturnScope(code, offset) isReturnScope_(code, offset, __FILE__, __LINE__)
|
|
|
|
bool isReturnScope_(const char code[], int offset, const char* file, int line) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2016-01-16 19:08:51 +01:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
2016-01-16 18:52:34 +01:00
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
2016-01-17 12:38:49 +01:00
|
|
|
const Token * const tok = (offset < 0)
|
|
|
|
? tokenizer.list.back()->tokAt(1+offset)
|
|
|
|
: tokenizer.tokens()->tokAt(offset);
|
2022-06-07 21:20:33 +02:00
|
|
|
return (isReturnScope)(tok);
|
2016-01-16 18:52:34 +01:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void isReturnScopeTest() {
|
2016-01-17 12:38:49 +01:00
|
|
|
ASSERT_EQUALS(true, isReturnScope("void f() { if (a) { return; } }", -2));
|
2018-12-14 18:31:10 +01:00
|
|
|
ASSERT_EQUALS(true, isReturnScope("int f() { if (a) { return {}; } }", -2)); // #8891
|
|
|
|
ASSERT_EQUALS(true, isReturnScope("std::string f() { if (a) { return std::string{}; } }", -2)); // #8891
|
|
|
|
ASSERT_EQUALS(true, isReturnScope("std::string f() { if (a) { return std::string{\"\"}; } }", -2)); // #8891
|
2016-01-17 12:38:49 +01:00
|
|
|
ASSERT_EQUALS(true, isReturnScope("void f() { if (a) { return (ab){0}; } }", -2)); // #7103
|
|
|
|
ASSERT_EQUALS(false, isReturnScope("void f() { if (a) { return (ab){0}; } }", -4)); // #7103
|
2016-01-18 15:39:20 +01:00
|
|
|
ASSERT_EQUALS(true, isReturnScope("void f() { if (a) { {throw new string(x);}; } }", -4)); // #7144
|
|
|
|
ASSERT_EQUALS(true, isReturnScope("void f() { if (a) { {throw new string(x);}; } }", -2)); // #7144
|
2018-12-14 18:31:10 +01:00
|
|
|
ASSERT_EQUALS(false, isReturnScope("void f() { [=]() { return data; }; }", -1));
|
|
|
|
ASSERT_EQUALS(true, isReturnScope("auto f() { return [=]() { return data; }; }", -1));
|
|
|
|
ASSERT_EQUALS(true, isReturnScope("auto f() { return [=]() { return data; }(); }", -1));
|
|
|
|
ASSERT_EQUALS(false, isReturnScope("auto f() { [=]() { return data; }(); }", -1));
|
2019-11-28 16:11:55 +01:00
|
|
|
|
|
|
|
ASSERT_EQUALS(true, isReturnScope("void negativeTokenOffset() { return; }", -1));
|
|
|
|
ASSERT_EQUALS(false, isReturnScope("void zeroTokenOffset() { return; }", 0));
|
|
|
|
ASSERT_EQUALS(true, isReturnScope("void positiveTokenOffset() { return; }", 7));
|
2016-01-16 18:52:34 +01:00
|
|
|
}
|
2017-09-11 13:45:36 +02:00
|
|
|
|
2023-10-08 11:29:52 +02:00
|
|
|
#define isSameExpression(...) isSameExpression_(__FILE__, __LINE__, __VA_ARGS__)
|
|
|
|
bool isSameExpression_(const char* file, int line, const char code[], const char tokStr1[], const char tokStr2[]) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2020-02-01 07:22:41 +01:00
|
|
|
Library library;
|
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
2020-05-26 20:13:56 +02:00
|
|
|
const Token * const tok1 = Token::findsimplematch(tokenizer.tokens(), tokStr1, strlen(tokStr1));
|
|
|
|
const Token * const tok2 = Token::findsimplematch(tok1->next(), tokStr2, strlen(tokStr2));
|
2022-06-07 21:20:33 +02:00
|
|
|
return (isSameExpression)(false, false, tok1, tok2, library, false, true, nullptr);
|
2020-02-01 07:22:41 +01:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void isSameExpressionTest() {
|
2020-02-01 07:22:41 +01:00
|
|
|
ASSERT_EQUALS(true, isSameExpression("x = 1 + 1;", "1", "1"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("x = 1 + 1u;", "1", "1u"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("x = 1.0 + 1.0;", "1.0", "1.0"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("x = 1.0f + 1.0;", "1.0f", "1.0"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("x = 1L + 1;", "1L", "1"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("x = 0.0f + 0x0p+0f;", "0.0f", "0x0p+0f"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("x < x;", "x", "x"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("x < y;", "x", "y"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("(x + 1) < (x + 1);", "+", "+"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("(x + 1) < (x + 1L);", "+", "+"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("(1 + x) < (x + 1);", "+", "+"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("(1.0l + x) < (1.0 + x);", "+", "+"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("(0.0 + x) < (x + 0x0p+0);", "+", "+"));
|
2020-02-03 09:35:24 +01:00
|
|
|
ASSERT_EQUALS(true, isSameExpression("void f() {double y = 1e1; (x + y) < (x + 10.0); } ", "+", "+"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("void f() {double y = 1e1; (x + 10.0) < (y + x); } ", "+", "+"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("void f() {double y = 1e1; double z = 10.0; (x + y) < (x + z); } ", "+", "+"));
|
2020-05-19 07:53:54 +02:00
|
|
|
ASSERT_EQUALS(true, isSameExpression("A + A", "A", "A"));
|
|
|
|
|
|
|
|
//https://trac.cppcheck.net/ticket/9700
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("A::B + A::B;", "::", "::"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("A::B + A::C;", "::", "::"));
|
|
|
|
ASSERT_EQUALS(true, isSameExpression("A::B* get() { if(x) return new A::B(true); else return new A::B(true); }", "new", "new"));
|
|
|
|
ASSERT_EQUALS(false, isSameExpression("A::B* get() { if(x) return new A::B(true); else return new A::C(true); }", "new", "new"));
|
|
|
|
ASSERT_EQUALS(true, true);
|
2020-02-01 07:22:41 +01:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
#define isVariableChanged(code, startPattern, endPattern) isVariableChanged_(code, startPattern, endPattern, __FILE__, __LINE__)
|
|
|
|
bool isVariableChanged_(const char code[], const char startPattern[], const char endPattern[], const char* file, int line) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2017-09-11 13:45:36 +02:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
2020-05-26 20:13:56 +02:00
|
|
|
const Token * const tok1 = Token::findsimplematch(tokenizer.tokens(), startPattern, strlen(startPattern));
|
|
|
|
const Token * const tok2 = Token::findsimplematch(tokenizer.tokens(), endPattern, strlen(endPattern));
|
2022-06-07 21:20:33 +02:00
|
|
|
return (isVariableChanged)(tok1, tok2, 1, false, &settings, true);
|
2017-09-11 13:45:36 +02:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void isVariableChangedTest() {
|
2017-09-12 22:42:10 +02:00
|
|
|
// #8211 - no lhs for >> , do not crash
|
2019-04-19 20:53:07 +02:00
|
|
|
isVariableChanged("void f() {\n"
|
|
|
|
" int b;\n"
|
|
|
|
" if (b) { (int)((INTOF(8))result >> b); }\n"
|
|
|
|
"}", "if", "}");
|
2019-07-26 07:03:21 +02:00
|
|
|
// #9235
|
2023-09-20 06:43:58 +02:00
|
|
|
ASSERT_EQUALS(false,
|
|
|
|
isVariableChanged("void f() {\n"
|
|
|
|
" int &a = a;\n"
|
|
|
|
"}\n",
|
|
|
|
"= a",
|
|
|
|
"}"));
|
2023-03-21 18:16:40 +01:00
|
|
|
|
|
|
|
ASSERT_EQUALS(false, isVariableChanged("void f(const A& a) { a.f(); }", "{", "}"));
|
|
|
|
ASSERT_EQUALS(true,
|
|
|
|
isVariableChanged("void g(int*);\n"
|
|
|
|
"void f(int x) { g(&x); }\n",
|
|
|
|
"{",
|
|
|
|
"}"));
|
2023-12-15 11:01:08 +01:00
|
|
|
|
|
|
|
ASSERT_EQUALS(false, isVariableChanged("const int A[] = { 1, 2, 3 };", "[", "]"));
|
2017-09-11 13:45:36 +02:00
|
|
|
}
|
2017-09-20 22:09:09 +02:00
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
#define isVariableChangedByFunctionCall(code, pattern, inconclusive) isVariableChangedByFunctionCall_(code, pattern, inconclusive, __FILE__, __LINE__)
|
|
|
|
bool isVariableChangedByFunctionCall_(const char code[], const char pattern[], bool *inconclusive, const char* file, int line) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2017-09-20 22:09:09 +02:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
2017-09-20 22:09:09 +02:00
|
|
|
const Token * const argtok = Token::findmatch(tokenizer.tokens(), pattern);
|
2023-04-02 20:36:23 +02:00
|
|
|
ASSERT_LOC(argtok, file, line);
|
|
|
|
int indirect = (argtok->variable() && argtok->variable()->isArray());
|
|
|
|
return (isVariableChangedByFunctionCall)(argtok, indirect, &settings, inconclusive);
|
2017-09-20 22:09:09 +02:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void isVariableChangedByFunctionCallTest() {
|
2017-09-20 22:09:09 +02:00
|
|
|
const char *code;
|
|
|
|
bool inconclusive;
|
|
|
|
|
|
|
|
// #8271 - template method
|
|
|
|
code = "void f(int x) {\n"
|
|
|
|
" a<int>(x);\n"
|
|
|
|
"}";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "x ) ;", &inconclusive));
|
2019-02-28 17:02:46 +01:00
|
|
|
ASSERT_EQUALS(true, inconclusive);
|
2021-11-08 20:28:55 +01:00
|
|
|
|
|
|
|
code = "int f(int x) {\n"
|
|
|
|
"return int(x);\n"
|
|
|
|
"}\n";
|
2023-04-02 20:36:23 +02:00
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "x ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(int* p);\n"
|
|
|
|
"void f(int x) {\n"
|
|
|
|
" return g(&x);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(true, isVariableChangedByFunctionCall(code, "x ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(const int* p);\n"
|
|
|
|
"void f(int x) {\n"
|
|
|
|
" return g(&x);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
2021-11-08 20:28:55 +01:00
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "x ) ;", &inconclusive));
|
2023-04-02 20:36:23 +02:00
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(int** pp);\n"
|
|
|
|
"void f(int* p) {\n"
|
|
|
|
" return g(&p);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(true, isVariableChangedByFunctionCall(code, "p ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(int* const* pp);\n"
|
|
|
|
"void f(int* p) {\n"
|
|
|
|
" return g(&p);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "p ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(int a[2]);\n"
|
|
|
|
"void f() {\n"
|
|
|
|
" int b[2] = {};\n"
|
|
|
|
" return g(b);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(true, isVariableChangedByFunctionCall(code, "b ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(const int a[2]);\n"
|
|
|
|
"void f() {\n"
|
|
|
|
" int b[2] = {};\n"
|
|
|
|
" return g(b);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
TODO_ASSERT_EQUALS(false, true, isVariableChangedByFunctionCall(code, "b ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(std::array<int, 2> a);\n"
|
|
|
|
"void f() {\n"
|
|
|
|
" std::array<int, 2> b = {};\n"
|
|
|
|
" return g(b);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "b ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(std::array<int, 2>& a);\n"
|
|
|
|
"void f() {\n"
|
|
|
|
" std::array<int, 2> b = {};\n"
|
|
|
|
" return g(b);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(true, isVariableChangedByFunctionCall(code, "b ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(const std::array<int, 2>& a);\n"
|
|
|
|
"void f() {\n"
|
|
|
|
" std::array<int, 2> b = {};\n"
|
|
|
|
" return g(b);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "b ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "void g(std::array<int, 2>* p);\n"
|
|
|
|
"void f() {\n"
|
|
|
|
" std::array<int, 2> b = {};\n"
|
|
|
|
" return g(&b);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(true, isVariableChangedByFunctionCall(code, "b ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "struct S {};\n"
|
|
|
|
"void g(S);\n"
|
|
|
|
"void f(S* s) {\n"
|
|
|
|
" g(*s);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "s ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
|
|
|
|
|
|
|
code = "struct S {};\n"
|
|
|
|
"void g(const S&);\n"
|
|
|
|
"void f(S* s) {\n"
|
|
|
|
" g(*s);\n"
|
|
|
|
"}\n";
|
|
|
|
inconclusive = false;
|
|
|
|
ASSERT_EQUALS(false, isVariableChangedByFunctionCall(code, "s ) ;", &inconclusive));
|
|
|
|
ASSERT_EQUALS(false, inconclusive);
|
2017-09-20 22:09:09 +02:00
|
|
|
}
|
2018-11-10 16:40:40 +01:00
|
|
|
|
2023-03-21 18:16:40 +01:00
|
|
|
#define isExpressionChanged(code, var, startPattern, endPattern) \
|
|
|
|
isExpressionChanged_(code, var, startPattern, endPattern, __FILE__, __LINE__)
|
|
|
|
bool isExpressionChanged_(const char code[],
|
|
|
|
const char var[],
|
|
|
|
const char startPattern[],
|
|
|
|
const char endPattern[],
|
|
|
|
const char* file,
|
|
|
|
int line)
|
|
|
|
{
|
2023-05-02 15:54:19 +02:00
|
|
|
const Settings settings = settingsBuilder().library("std.cfg").build();
|
2023-03-21 18:16:40 +01:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
|
|
|
const Token* const start = Token::findsimplematch(tokenizer.tokens(), startPattern, strlen(startPattern));
|
|
|
|
const Token* const end = Token::findsimplematch(start, endPattern, strlen(endPattern));
|
|
|
|
const Token* const expr = Token::findsimplematch(tokenizer.tokens(), var, strlen(var));
|
2023-10-19 18:42:52 +02:00
|
|
|
return (findExpressionChanged)(expr, start, end, &settings, true);
|
2023-03-21 18:16:40 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void isExpressionChangedTest()
|
|
|
|
{
|
|
|
|
ASSERT_EQUALS(true, isExpressionChanged("void f(std::map<int, int>& m) { m[0]; }", "m [", "{", "}"));
|
|
|
|
ASSERT_EQUALS(false, isExpressionChanged("void f(const A& a) { a.f(); }", "a .", "{", "}"));
|
|
|
|
|
|
|
|
ASSERT_EQUALS(true,
|
|
|
|
isExpressionChanged("void g(int*);\n"
|
|
|
|
"void f(int x) { g(&x); }\n",
|
|
|
|
"x",
|
|
|
|
") {",
|
|
|
|
"}"));
|
|
|
|
|
|
|
|
ASSERT_EQUALS(true,
|
|
|
|
isExpressionChanged("struct S { void f(); int i; };\n"
|
|
|
|
"void call_f(S& s) { (s.*(&S::f))(); }\n",
|
|
|
|
"s .",
|
|
|
|
"{ (",
|
|
|
|
"}"));
|
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
#define nextAfterAstRightmostLeaf(code, parentPattern, rightPattern) nextAfterAstRightmostLeaf_(code, parentPattern, rightPattern, __FILE__, __LINE__)
|
|
|
|
bool nextAfterAstRightmostLeaf_(const char code[], const char parentPattern[], const char rightPattern[], const char* file, int line) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2018-11-10 16:40:40 +01:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
2021-11-29 07:34:39 +01:00
|
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
2020-05-26 20:13:56 +02:00
|
|
|
const Token * tok = Token::findsimplematch(tokenizer.tokens(), parentPattern, strlen(parentPattern));
|
2021-11-29 07:34:39 +01:00
|
|
|
return Token::simpleMatch((::nextAfterAstRightmostLeaf)(tok), rightPattern, strlen(rightPattern));
|
2018-11-10 16:40:40 +01:00
|
|
|
}
|
|
|
|
|
2021-11-29 07:34:39 +01:00
|
|
|
void nextAfterAstRightmostLeafTest() {
|
2018-11-10 16:40:40 +01:00
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("void f(int a, int b) { int x = a + b; }", "=", "; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = g(a); }", "=", "; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = g(a)[b]; }", "=", "; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = g(g(a)[b]); }", "=", "; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = g(g(a)[b] + a); }", "=", "; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = g(a)[b + 1]; }", "=", "; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("void f() { int a; int b; int x = [](int a){}; }", "=", "; }"));
|
2018-11-10 21:30:01 +01:00
|
|
|
|
2018-11-10 16:40:40 +01:00
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = a + b; }", "+", "; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = g(a)[b + 1]; }", "+", "] ; }"));
|
|
|
|
ASSERT_EQUALS(true, nextAfterAstRightmostLeaf("int * g(int); void f(int a, int b) { int x = g(a + 1)[b]; }", "+", ") ["));
|
|
|
|
}
|
2021-01-25 17:23:47 +01:00
|
|
|
|
|
|
|
enum class Result {False, True, Fail};
|
|
|
|
|
|
|
|
Result isUsedAsBool(const char code[], const char pattern[]) {
|
2023-05-02 11:48:24 +02:00
|
|
|
const Settings settings;
|
2021-01-25 17:23:47 +01:00
|
|
|
Tokenizer tokenizer(&settings, this);
|
|
|
|
std::istringstream istr(code);
|
|
|
|
if (!tokenizer.tokenize(istr, "test.cpp"))
|
|
|
|
return Result::Fail;
|
|
|
|
const Token * const argtok = Token::findmatch(tokenizer.tokens(), pattern);
|
|
|
|
if (!argtok)
|
|
|
|
return Result::Fail;
|
|
|
|
return ::isUsedAsBool(argtok) ? Result::True : Result::False;
|
|
|
|
}
|
|
|
|
|
|
|
|
void isUsedAsBool() {
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { bool b = true; }", "b"));
|
|
|
|
ASSERT(Result::False ==isUsedAsBool("void f() { int i = true; }", "i"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (i) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; while (i) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; for (;i;) {} }", "i ; )"));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; for (;;i) {} }", "i )"));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; for (i;;) {} }", "i ; ; )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; for (int j=0; i; ++j) {} }", "i ; ++"));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; if (i == 2) {} }", "i =="));
|
2021-05-04 13:46:46 +02:00
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; if (i == true) {} }", "i =="));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i,j; if (i == (j&&f())) {} }", "i =="));
|
2021-01-25 17:23:47 +01:00
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (!i == 0) {} }", "i =="));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (!i) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (!!i) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (i && f()) {} }", "i &&"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; int j = i && f(); }", "i &&"));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; if (i & f()) {} }", "i &"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (static_cast<bool>(i)) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if ((bool)i) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (1+static_cast<bool>(i)) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (1+(bool)i) {} }", "i )"));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; if (1+static_cast<int>(i)) {} }", "i )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; if (1+!static_cast<int>(i)) {} }", "i )"));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; if (1+(int)i) {} }", "i )"));
|
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int i; if (i + 2) {} }", "i +"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int i; bool b = i; }", "i ; }"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("void f(bool b); void f() { int i; f(i); }","i )"));
|
2023-08-20 22:32:41 +02:00
|
|
|
ASSERT(Result::False == isUsedAsBool("void f() { int *i; if (*i) {} }", "i )"));
|
2021-01-25 17:23:47 +01:00
|
|
|
ASSERT(Result::True == isUsedAsBool("void f() { int *i; if (*i) {} }", "* i )"));
|
2022-11-27 09:22:55 +01:00
|
|
|
ASSERT(Result::True == isUsedAsBool("int g(); void h(bool); void f() { h(g()); }", "( ) )"));
|
|
|
|
ASSERT(Result::True == isUsedAsBool("int g(int); void h(bool); void f() { h(g(0)); }", "( 0 ) )"));
|
2021-01-25 17:23:47 +01:00
|
|
|
}
|
2016-01-16 18:52:34 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
REGISTER_TEST(TestAstUtils)
|