2010-10-31 12:31:11 +01:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2018-01-14 15:37:52 +01:00
|
|
|
* Copyright (C) 2007-2017 Cppcheck team.
|
2010-10-31 12:31:11 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#ifndef checkuninitvarH
|
|
|
|
#define checkuninitvarH
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
#include "check.h"
|
2017-05-27 04:33:47 +02:00
|
|
|
#include "config.h"
|
|
|
|
|
|
|
|
#include <set>
|
|
|
|
#include <string>
|
2010-10-31 12:31:11 +01:00
|
|
|
|
2017-05-27 04:33:47 +02:00
|
|
|
class ErrorLogger;
|
2012-05-25 13:40:18 +02:00
|
|
|
class Scope;
|
2017-05-27 04:33:47 +02:00
|
|
|
class Settings;
|
|
|
|
class Token;
|
|
|
|
class Tokenizer;
|
2012-05-25 13:40:18 +02:00
|
|
|
class Variable;
|
2010-10-31 12:31:11 +01:00
|
|
|
|
2017-09-07 23:08:55 +02:00
|
|
|
|
|
|
|
struct VariableValue {
|
|
|
|
explicit VariableValue(MathLib::bigint val = 0) : value(val), notEqual(false) {}
|
|
|
|
MathLib::bigint value;
|
|
|
|
bool notEqual;
|
|
|
|
};
|
|
|
|
|
2010-10-31 12:31:11 +01:00
|
|
|
/// @addtogroup Checks
|
|
|
|
/// @{
|
|
|
|
|
|
|
|
|
|
|
|
/** @brief Checking for uninitialized variables */
|
|
|
|
|
2012-06-10 14:19:09 +02:00
|
|
|
class CPPCHECKLIB CheckUninitVar : public Check {
|
2010-10-31 12:31:11 +01:00
|
|
|
public:
|
|
|
|
/** @brief This constructor is used when registering the CheckUninitVar */
|
2015-07-23 20:37:09 +02:00
|
|
|
CheckUninitVar() : Check(myName()) {
|
2013-08-07 16:27:37 +02:00
|
|
|
}
|
2010-10-31 12:31:11 +01:00
|
|
|
|
|
|
|
/** @brief This constructor is used when running checks. */
|
|
|
|
CheckUninitVar(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
2015-07-23 20:37:09 +02:00
|
|
|
: Check(myName(), tokenizer, settings, errorLogger) {
|
2013-08-07 16:27:37 +02:00
|
|
|
}
|
2010-10-31 12:31:11 +01:00
|
|
|
|
|
|
|
/** @brief Run checks against the simplified token list */
|
2014-11-20 14:20:09 +01:00
|
|
|
void runSimplifiedChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger) {
|
2010-10-31 12:31:11 +01:00
|
|
|
CheckUninitVar checkUninitVar(tokenizer, settings, errorLogger);
|
2011-12-13 21:57:27 +01:00
|
|
|
checkUninitVar.check();
|
2014-08-05 06:24:23 +02:00
|
|
|
checkUninitVar.deadPointer();
|
2017-04-23 18:05:14 +02:00
|
|
|
checkUninitVar.valueFlowUninit();
|
2010-10-31 12:31:11 +01:00
|
|
|
}
|
|
|
|
|
2011-12-13 21:57:27 +01:00
|
|
|
/** Check for uninitialized variables */
|
|
|
|
void check();
|
2016-12-21 23:11:11 +01:00
|
|
|
void checkScope(const Scope* scope, const std::set<std::string> &arrayTypeDefs);
|
2015-01-22 13:51:43 +01:00
|
|
|
void checkStruct(const Token *tok, const Variable &structvar);
|
2015-07-23 14:51:38 +02:00
|
|
|
enum Alloc { NO_ALLOC, NO_CTOR_CALL, CTOR_CALL, ARRAY };
|
2017-09-07 23:08:55 +02:00
|
|
|
bool checkScopeForVariable(const Token *tok, const Variable& var, bool* const possibleInit, bool* const noreturn, Alloc* const alloc, const std::string &membervar, std::map<unsigned int, VariableValue> variableValue);
|
2015-01-23 19:38:39 +01:00
|
|
|
bool checkIfForWhileHead(const Token *startparentheses, const Variable& var, bool suppressErrors, bool isuninit, Alloc alloc, const std::string &membervar);
|
|
|
|
bool checkLoopBody(const Token *tok, const Variable& var, const Alloc alloc, const std::string &membervar, const bool suppressErrors);
|
2015-07-23 08:46:59 +02:00
|
|
|
void checkRhs(const Token *tok, const Variable &var, Alloc alloc, unsigned int number_of_if, const std::string &membervar);
|
2017-04-01 09:31:27 +02:00
|
|
|
bool isVariableUsage(const Token *vartok, bool pointer, Alloc alloc) const;
|
|
|
|
int isFunctionParUsage(const Token *vartok, bool pointer, Alloc alloc) const;
|
2015-06-19 18:21:46 +02:00
|
|
|
bool isMemberVariableAssignment(const Token *tok, const std::string &membervar) const;
|
2015-01-23 19:38:39 +01:00
|
|
|
bool isMemberVariableUsage(const Token *tok, bool isPointer, Alloc alloc, const std::string &membervar) const;
|
2011-12-26 18:32:42 +01:00
|
|
|
|
2014-08-05 06:24:23 +02:00
|
|
|
/** ValueFlow-based checking for dead pointer usage */
|
|
|
|
void deadPointer();
|
|
|
|
void deadPointerError(const Token *pointer, const Token *alias);
|
|
|
|
|
2017-04-23 18:05:14 +02:00
|
|
|
/** ValueFlow-based checking for uninitialized variables */
|
|
|
|
void valueFlowUninit();
|
|
|
|
|
2014-11-15 10:43:49 +01:00
|
|
|
/* data for multifile checking */
|
|
|
|
class MyFileInfo : public Check::FileInfo {
|
|
|
|
public:
|
2018-01-15 15:54:09 +01:00
|
|
|
struct FunctionArg {
|
|
|
|
FunctionArg(const std::string &s, unsigned int i, const std::string &fileName, unsigned int linenr, const std::string &varname) : functionName(s), argnr(i), variableName(varname) {
|
|
|
|
location.fileName = fileName;
|
|
|
|
location.linenr = linenr;
|
|
|
|
}
|
|
|
|
std::string functionName;
|
|
|
|
unsigned int argnr;
|
|
|
|
std::string variableName;
|
|
|
|
struct {
|
|
|
|
std::string fileName;
|
|
|
|
unsigned int linenr;
|
|
|
|
} location;
|
|
|
|
};
|
|
|
|
|
|
|
|
/* function arguments that must be initialized */
|
|
|
|
std::list<FunctionArg> unsafeFunctionArgs;
|
|
|
|
|
|
|
|
/* uninitialized function args */
|
|
|
|
std::list<FunctionArg> uninitializedFunctionArgs;
|
|
|
|
|
|
|
|
std::string toString() const;
|
2014-11-15 10:43:49 +01:00
|
|
|
};
|
|
|
|
|
2018-01-15 15:54:09 +01:00
|
|
|
/** @brief Parse current TU and extract file info */
|
|
|
|
Check::FileInfo *getFileInfo(const Tokenizer *tokenizer, const Settings *settings) const;
|
|
|
|
|
|
|
|
Check::FileInfo * loadFileInfoFromXml(const tinyxml2::XMLElement *xmlElement) const;
|
|
|
|
|
|
|
|
/** @brief Analyse all file infos for all TU */
|
|
|
|
bool analyseWholeProgram(const std::list<Check::FileInfo*> &fileInfo, const Settings& settings, ErrorLogger &errorLogger);
|
|
|
|
|
2011-09-05 19:42:48 +02:00
|
|
|
void uninitstringError(const Token *tok, const std::string &varname, bool strncpy_);
|
2010-10-31 12:31:11 +01:00
|
|
|
void uninitdataError(const Token *tok, const std::string &varname);
|
|
|
|
void uninitvarError(const Token *tok, const std::string &varname);
|
2015-07-23 08:46:59 +02:00
|
|
|
void uninitvarError(const Token *tok, const std::string &varname, Alloc alloc) {
|
2015-07-23 14:51:38 +02:00
|
|
|
if (alloc == NO_CTOR_CALL || alloc == CTOR_CALL)
|
2015-07-23 08:46:59 +02:00
|
|
|
uninitdataError(tok, varname);
|
2015-07-23 14:51:38 +02:00
|
|
|
else
|
|
|
|
uninitvarError(tok, varname);
|
2015-07-23 08:46:59 +02:00
|
|
|
}
|
2013-01-17 21:04:22 +01:00
|
|
|
void uninitStructMemberError(const Token *tok, const std::string &membername);
|
2010-10-31 12:31:11 +01:00
|
|
|
|
2012-03-27 19:40:39 +02:00
|
|
|
private:
|
2014-11-20 14:20:09 +01:00
|
|
|
void getErrorMessages(ErrorLogger *errorLogger, const Settings *settings) const {
|
2016-05-07 16:30:54 +02:00
|
|
|
CheckUninitVar c(nullptr, settings, errorLogger);
|
2010-12-29 12:43:29 +01:00
|
|
|
|
2010-10-31 12:31:11 +01:00
|
|
|
// error
|
2016-05-07 16:30:54 +02:00
|
|
|
c.uninitstringError(nullptr, "varname", true);
|
|
|
|
c.uninitdataError(nullptr, "varname");
|
|
|
|
c.uninitvarError(nullptr, "varname");
|
|
|
|
c.uninitStructMemberError(nullptr, "a.b");
|
|
|
|
c.deadPointerError(nullptr, nullptr);
|
2010-10-31 12:31:11 +01:00
|
|
|
}
|
|
|
|
|
2014-11-20 14:20:09 +01:00
|
|
|
static std::string myName() {
|
2010-10-31 12:31:11 +01:00
|
|
|
return "Uninitialized variables";
|
|
|
|
}
|
|
|
|
|
2014-11-20 14:20:09 +01:00
|
|
|
std::string classInfo() const {
|
2010-10-31 12:31:11 +01:00
|
|
|
return "Uninitialized variables\n"
|
2014-09-30 14:56:12 +02:00
|
|
|
"- using uninitialized local variables\n"
|
|
|
|
"- using allocated data before it has been initialized\n"
|
|
|
|
"- using dead pointer\n";
|
2010-10-31 12:31:11 +01:00
|
|
|
}
|
|
|
|
};
|
|
|
|
/// @}
|
|
|
|
//---------------------------------------------------------------------------
|
2013-09-04 20:59:49 +02:00
|
|
|
#endif // checkuninitvarH
|