2022-07-08 16:42:57 +02:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2023-06-21 16:41:22 +02:00
|
|
|
* Copyright (C) 2007-2023 Cppcheck team.
|
2022-07-08 16:42:57 +02:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef EXECUTOR_H
|
|
|
|
#define EXECUTOR_H
|
|
|
|
|
|
|
|
#include <cstddef>
|
|
|
|
#include <list>
|
2023-03-04 12:05:17 +01:00
|
|
|
#include <mutex>
|
2022-07-08 16:42:57 +02:00
|
|
|
#include <string>
|
aligned and optimized unique error handling (#5280)
The handling in `CppCheck::reportErr()` and `Executor::hasToLog()` was
slightly different. I hope this can somehow be shared after the executor
reworking.
We were also using a very inappropriate container for the error list
which caused a lot of overhead.
`-D__GNUC__ --debug-warnings --template=daca2 --check-library -j2
../test/testsymboldatabase.cpp`
Clang 15
main process `284,218,587` -> `175,691,241`
worker process `9,123,697,183` -> `8,951,903,360`
2023-12-17 21:59:06 +01:00
|
|
|
#include <unordered_set>
|
2023-11-07 21:21:24 +01:00
|
|
|
#include <utility>
|
2022-07-08 16:42:57 +02:00
|
|
|
|
|
|
|
class Settings;
|
|
|
|
class ErrorLogger;
|
2023-03-04 12:05:17 +01:00
|
|
|
class ErrorMessage;
|
2023-08-07 18:39:57 +02:00
|
|
|
class Suppressions;
|
2023-11-03 23:24:04 +01:00
|
|
|
struct FileSettings;
|
2022-07-08 16:42:57 +02:00
|
|
|
|
|
|
|
/// @addtogroup CLI
|
|
|
|
/// @{
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This class will take a list of filenames and settings and check then
|
|
|
|
* all files using threads.
|
|
|
|
*/
|
|
|
|
class Executor {
|
|
|
|
public:
|
2023-11-07 21:21:24 +01:00
|
|
|
Executor(const std::list<std::pair<std::string, std::size_t>> &files, const std::list<FileSettings>& fileSettings, const Settings &settings, Suppressions &suppressions, ErrorLogger &errorLogger);
|
2023-08-16 17:13:36 +02:00
|
|
|
virtual ~Executor() = default;
|
2022-07-12 17:36:36 +02:00
|
|
|
|
|
|
|
Executor(const Executor &) = delete;
|
2022-07-08 16:42:57 +02:00
|
|
|
void operator=(const Executor &) = delete;
|
|
|
|
|
|
|
|
virtual unsigned int check() = 0;
|
|
|
|
|
2023-04-08 18:06:38 +02:00
|
|
|
/**
|
|
|
|
* Information about how many files have been checked
|
|
|
|
*
|
|
|
|
* @param fileindex This many files have been checked.
|
|
|
|
* @param filecount This many files there are in total.
|
|
|
|
* @param sizedone The sum of sizes of the files checked.
|
|
|
|
* @param sizetotal The total sizes of the files.
|
|
|
|
*/
|
|
|
|
void reportStatus(std::size_t fileindex, std::size_t filecount, std::size_t sizedone, std::size_t sizetotal);
|
|
|
|
|
2022-07-08 16:42:57 +02:00
|
|
|
protected:
|
2023-03-04 12:05:17 +01:00
|
|
|
/**
|
|
|
|
* @brief Check if message is being suppressed and unique.
|
|
|
|
* @param msg the message to check
|
|
|
|
* @return true if message is not suppressed and unique
|
|
|
|
*/
|
|
|
|
bool hasToLog(const ErrorMessage &msg);
|
|
|
|
|
2023-11-07 21:21:24 +01:00
|
|
|
const std::list<std::pair<std::string, std::size_t>> &mFiles;
|
2023-11-03 23:24:04 +01:00
|
|
|
const std::list<FileSettings>& mFileSettings;
|
2023-08-07 18:39:57 +02:00
|
|
|
const Settings &mSettings;
|
|
|
|
Suppressions &mSuppressions;
|
2022-07-08 16:42:57 +02:00
|
|
|
ErrorLogger &mErrorLogger;
|
2023-03-04 12:05:17 +01:00
|
|
|
|
|
|
|
private:
|
|
|
|
std::mutex mErrorListSync;
|
aligned and optimized unique error handling (#5280)
The handling in `CppCheck::reportErr()` and `Executor::hasToLog()` was
slightly different. I hope this can somehow be shared after the executor
reworking.
We were also using a very inappropriate container for the error list
which caused a lot of overhead.
`-D__GNUC__ --debug-warnings --template=daca2 --check-library -j2
../test/testsymboldatabase.cpp`
Clang 15
main process `284,218,587` -> `175,691,241`
worker process `9,123,697,183` -> `8,951,903,360`
2023-12-17 21:59:06 +01:00
|
|
|
// TODO: store hashes instead of the full messages
|
|
|
|
std::unordered_set<std::string> mErrorList;
|
2022-07-08 16:42:57 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
/// @}
|
|
|
|
|
|
|
|
#endif // EXECUTOR_H
|