2009-02-10 20:40:21 +01:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2009-05-30 07:48:12 +02:00
|
|
|
* Copyright (C) 2007-2009 Daniel Marjamäki and Cppcheck team.
|
2009-02-10 20:40:21 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
2009-09-27 17:08:31 +02:00
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2009-02-10 20:40:21 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#ifndef checkstlH
|
|
|
|
#define checkstlH
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
2009-03-18 22:40:38 +01:00
|
|
|
#include "check.h"
|
|
|
|
|
2009-02-11 06:08:29 +01:00
|
|
|
class Token;
|
2009-02-10 20:40:21 +01:00
|
|
|
|
2009-07-17 10:49:01 +02:00
|
|
|
/// @addtogroup Checks
|
|
|
|
/// @{
|
|
|
|
|
|
|
|
|
2009-07-08 17:14:34 +02:00
|
|
|
/** @brief %Check STL usage */
|
2009-03-18 22:40:38 +01:00
|
|
|
class CheckStl : public Check
|
2009-02-10 20:40:21 +01:00
|
|
|
{
|
|
|
|
public:
|
2009-03-21 07:53:23 +01:00
|
|
|
/** This constructor is used when registering the CheckClass */
|
2009-03-20 17:15:51 +01:00
|
|
|
CheckStl() : Check()
|
|
|
|
{ }
|
|
|
|
|
2009-03-21 07:53:23 +01:00
|
|
|
/** This constructor is used when running checks.. */
|
2009-03-20 17:15:51 +01:00
|
|
|
CheckStl(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
|
|
|
: Check(tokenizer, settings, errorLogger)
|
|
|
|
{ }
|
2009-03-18 22:40:38 +01:00
|
|
|
|
2009-03-21 07:53:23 +01:00
|
|
|
void runSimplifiedChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
2009-03-18 22:40:38 +01:00
|
|
|
{
|
2009-03-20 17:15:51 +01:00
|
|
|
CheckStl checkStl(tokenizer, settings, errorLogger);
|
|
|
|
|
|
|
|
checkStl.stlOutOfBounds();
|
|
|
|
checkStl.iterators();
|
2009-10-18 18:42:01 +02:00
|
|
|
checkStl.mismatchingContainers();
|
2009-03-20 17:15:51 +01:00
|
|
|
checkStl.erase();
|
|
|
|
checkStl.pushback();
|
2009-04-13 17:48:13 +02:00
|
|
|
checkStl.stlBoundries();
|
2009-11-02 20:24:38 +01:00
|
|
|
checkStl.find();
|
2009-12-19 15:24:59 +01:00
|
|
|
checkStl.size();
|
2009-03-18 22:40:38 +01:00
|
|
|
}
|
2009-02-10 20:40:21 +01:00
|
|
|
|
2009-02-10 20:56:00 +01:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Finds errors like this:
|
|
|
|
* for (unsigned ii = 0; ii <= foo.size(); ++ii)
|
|
|
|
*/
|
|
|
|
void stlOutOfBounds();
|
|
|
|
|
2009-02-11 06:08:29 +01:00
|
|
|
/**
|
|
|
|
* Finds errors like this:
|
|
|
|
* for (it = foo.begin(); it != bar.end(); ++it)
|
|
|
|
*/
|
2009-02-10 20:40:21 +01:00
|
|
|
void iterators();
|
|
|
|
|
2009-10-18 18:42:01 +02:00
|
|
|
/**
|
|
|
|
* Mismatching containers:
|
|
|
|
* std::find(foo.begin(), bar.end(), x)
|
|
|
|
*/
|
|
|
|
void mismatchingContainers();
|
|
|
|
|
2009-05-03 07:37:39 +02:00
|
|
|
/** Dereferencing an erased iterator */
|
|
|
|
void dereferenceErasedError(const Token *tok, const std::string &itername);
|
|
|
|
|
2009-02-11 06:08:29 +01:00
|
|
|
/**
|
|
|
|
* Dangerous usage of erase
|
|
|
|
*/
|
|
|
|
void erase();
|
|
|
|
|
2009-02-18 20:57:43 +01:00
|
|
|
/**
|
2009-10-15 21:29:56 +02:00
|
|
|
* Dangerous usage of push_back and insert
|
2009-02-18 20:57:43 +01:00
|
|
|
*/
|
|
|
|
void pushback();
|
|
|
|
|
2009-04-13 17:48:13 +02:00
|
|
|
/**
|
|
|
|
* bad condition.. "it < alist.end()"
|
|
|
|
*/
|
|
|
|
void stlBoundries();
|
2009-11-02 20:25:08 +01:00
|
|
|
|
2009-11-02 20:24:38 +01:00
|
|
|
/** usage of std::find */
|
|
|
|
void find();
|
2009-04-13 17:48:13 +02:00
|
|
|
|
2009-12-19 15:24:59 +01:00
|
|
|
/**
|
|
|
|
* Suggest using empty() instead of checking size() against zero for containers.
|
|
|
|
* Item 4 from Scott Meyers book "Effective STL".
|
|
|
|
*/
|
|
|
|
void size();
|
|
|
|
|
2009-02-10 20:40:21 +01:00
|
|
|
private:
|
2009-02-11 06:08:29 +01:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Helper function used by the 'erase' function
|
|
|
|
* This function parses a loop
|
|
|
|
* @param it iterator token
|
|
|
|
*/
|
|
|
|
void eraseCheckLoop(const Token *it);
|
2009-03-20 20:09:44 +01:00
|
|
|
|
2009-03-21 14:20:10 +01:00
|
|
|
void stlOutOfBoundsError(const Token *tok, const std::string &num, const std::string &var);
|
2009-03-20 20:09:44 +01:00
|
|
|
void iteratorsError(const Token *tok, const std::string &container1, const std::string &container2);
|
2009-10-18 18:42:01 +02:00
|
|
|
void mismatchingContainersError(const Token *tok);
|
2009-03-21 17:58:13 +01:00
|
|
|
void eraseError(const Token *tok);
|
2009-10-21 20:15:11 +02:00
|
|
|
void invalidIteratorError(const Token *tok, const std::string &func, const std::string &iterator_name);
|
2009-04-28 21:18:02 +02:00
|
|
|
void invalidPointerError(const Token *tok, const std::string &pointer_name);
|
2009-07-25 00:36:15 +02:00
|
|
|
void stlBoundriesError(const Token *tok, const std::string &container_name);
|
2009-11-02 20:24:38 +01:00
|
|
|
void findError(const Token *tok);
|
2009-12-19 15:24:59 +01:00
|
|
|
void sizeError(const Token *tok);
|
2009-03-20 20:09:44 +01:00
|
|
|
|
2009-03-21 14:07:51 +01:00
|
|
|
void getErrorMessages()
|
|
|
|
{
|
|
|
|
iteratorsError(0, "container1", "container2");
|
2009-10-18 18:42:01 +02:00
|
|
|
mismatchingContainersError(0);
|
2009-05-03 07:37:39 +02:00
|
|
|
dereferenceErasedError(0, "iter");
|
2009-03-21 14:20:10 +01:00
|
|
|
stlOutOfBoundsError(0, "i", "foo");
|
2009-03-21 17:58:13 +01:00
|
|
|
eraseError(0);
|
2009-10-21 20:15:11 +02:00
|
|
|
invalidIteratorError(0, "push_back|push_front|insert", "iterator");
|
2009-04-28 21:18:02 +02:00
|
|
|
invalidPointerError(0, "pointer");
|
2009-07-25 00:36:15 +02:00
|
|
|
stlBoundriesError(0, "container");
|
2009-11-02 20:24:38 +01:00
|
|
|
findError(0);
|
2009-12-19 15:24:59 +01:00
|
|
|
sizeError(0);
|
2009-03-21 14:07:51 +01:00
|
|
|
}
|
2009-06-12 12:19:37 +02:00
|
|
|
|
2009-06-12 15:20:08 +02:00
|
|
|
std::string name() const
|
|
|
|
{
|
|
|
|
return "STL usage";
|
|
|
|
}
|
|
|
|
|
2009-06-12 12:19:37 +02:00
|
|
|
std::string classInfo() const
|
|
|
|
{
|
2009-06-12 15:20:08 +02:00
|
|
|
return "Check for invalid usage of STL:\n"
|
2009-06-12 12:19:37 +02:00
|
|
|
" * out of bounds errors\n"
|
|
|
|
" * misuse of iterators when iterating through a container\n"
|
2009-10-18 18:42:01 +02:00
|
|
|
" * mismatching containers in calls\n"
|
2009-06-12 12:19:37 +02:00
|
|
|
" * dereferencing an erased iterator\n"
|
2009-11-02 20:24:38 +01:00
|
|
|
" * for vectors: using iterator/pointer after push_back has been used\n"
|
2009-12-19 19:24:48 +01:00
|
|
|
" * dangerous usage of find\n"
|
|
|
|
" * optimisation: using empty() instead of size()";
|
2009-06-12 12:19:37 +02:00
|
|
|
}
|
2009-12-19 15:24:59 +01:00
|
|
|
|
|
|
|
bool isStlContainer(const Token *tok);
|
2009-02-10 20:40:21 +01:00
|
|
|
};
|
2009-07-17 10:49:01 +02:00
|
|
|
/// @}
|
2009-02-10 20:40:21 +01:00
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#endif
|
|
|
|
|