2008-12-18 22:28:57 +01:00
|
|
|
/*
|
2009-01-21 21:04:20 +01:00
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2012-01-01 00:05:37 +01:00
|
|
|
* Copyright (C) 2007-2012 Daniel Marjamäki and Cppcheck team.
|
2008-12-18 22:28:57 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
2009-09-27 17:08:31 +02:00
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2008-12-18 22:28:57 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
2009-06-07 22:12:20 +02:00
|
|
|
#include "checkunusedfunctions.h"
|
2008-12-18 22:28:57 +01:00
|
|
|
#include "tokenize.h"
|
2009-07-13 19:11:31 +02:00
|
|
|
#include "token.h"
|
2011-10-30 09:53:01 +01:00
|
|
|
#include <cctype>
|
2008-12-18 22:28:57 +01:00
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
// FUNCTION USAGE - Check for unused functions etc
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
2009-06-07 22:12:20 +02:00
|
|
|
void CheckUnusedFunctions::parseTokens(const Tokenizer &tokenizer)
|
2008-12-18 22:28:57 +01:00
|
|
|
{
|
2011-12-03 12:19:26 +01:00
|
|
|
// if there are templates there might be false positives
|
|
|
|
templates |= tokenizer.codeWithTemplates();
|
|
|
|
if (templates)
|
|
|
|
return;
|
|
|
|
|
2008-12-18 22:28:57 +01:00
|
|
|
// Function declarations..
|
2011-10-13 20:53:06 +02:00
|
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next()) {
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok->fileIndex() != 0)
|
2008-12-18 22:28:57 +01:00
|
|
|
continue;
|
|
|
|
|
2010-02-03 18:37:48 +01:00
|
|
|
// token contains a ':' => skip to next ; or {
|
2011-10-13 20:53:06 +02:00
|
|
|
if (tok->str().find(":") != std::string::npos) {
|
2010-04-02 07:30:58 +02:00
|
|
|
while (tok && tok->str().find_first_of(";{"))
|
2010-02-03 18:37:48 +01:00
|
|
|
tok = tok->next();
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok)
|
2010-02-03 18:37:48 +01:00
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
}
|
2009-02-27 17:36:37 +01:00
|
|
|
|
2009-06-14 07:58:36 +02:00
|
|
|
// If this is a template function, skip it
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok->previous() && tok->previous()->str() == ">")
|
2009-06-14 07:58:36 +02:00
|
|
|
continue;
|
|
|
|
|
2009-01-03 21:29:20 +01:00
|
|
|
const Token *funcname = 0;
|
2008-12-18 22:28:57 +01:00
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
if (Token::Match(tok, "%type% %var% ("))
|
2011-11-20 15:09:57 +01:00
|
|
|
funcname = tok->next();
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (Token::Match(tok, "%type% * %var% ("))
|
2008-12-18 22:28:57 +01:00
|
|
|
funcname = tok->tokAt(2);
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (Token::Match(tok, "%type% :: %var% (") && !Token::Match(tok, tok->strAt(2).c_str()))
|
2008-12-18 22:28:57 +01:00
|
|
|
funcname = tok->tokAt(2);
|
|
|
|
|
2009-12-08 22:41:47 +01:00
|
|
|
// Don't assume throw as a function name: void foo() throw () {}
|
2010-04-02 07:30:58 +02:00
|
|
|
if (Token::Match(tok->previous(), ")|const"))
|
2009-12-08 22:41:47 +01:00
|
|
|
funcname = 0;
|
|
|
|
|
2008-12-18 22:28:57 +01:00
|
|
|
// Check that ") {" is found..
|
2011-10-13 20:53:06 +02:00
|
|
|
for (const Token *tok2 = funcname; tok2; tok2 = tok2->next()) {
|
|
|
|
if (tok2->str() == ")") {
|
2010-04-02 07:30:58 +02:00
|
|
|
if (! Token::simpleMatch(tok2, ") {") &&
|
|
|
|
! Token::simpleMatch(tok2, ") const {") &&
|
|
|
|
! Token::simpleMatch(tok2, ") const throw ( ) {") &&
|
|
|
|
! Token::simpleMatch(tok2, ") throw ( ) {"))
|
2011-09-18 07:13:39 +02:00
|
|
|
funcname = 0;
|
2008-12-18 22:28:57 +01:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-10-13 20:53:06 +02:00
|
|
|
if (funcname) {
|
2009-01-05 16:49:57 +01:00
|
|
|
FunctionUsage &func = _functions[ funcname->str()];
|
2008-12-18 22:28:57 +01:00
|
|
|
|
2011-09-18 18:58:28 +02:00
|
|
|
if (!func.lineNumber)
|
2011-09-18 07:13:39 +02:00
|
|
|
func.lineNumber = funcname->linenr();
|
|
|
|
|
2008-12-18 22:28:57 +01:00
|
|
|
// No filename set yet..
|
2011-10-13 20:53:06 +02:00
|
|
|
if (func.filename.empty()) {
|
2008-12-18 22:28:57 +01:00
|
|
|
func.filename = tokenizer.getFiles()->at(0);
|
2011-09-18 07:13:39 +02:00
|
|
|
}
|
2008-12-18 22:28:57 +01:00
|
|
|
// Multiple files => filename = "+"
|
2011-10-13 20:53:06 +02:00
|
|
|
else if (func.filename != tokenizer.getFiles()->at(0)) {
|
2010-07-18 11:22:26 +02:00
|
|
|
//func.filename = "+";
|
2008-12-18 22:28:57 +01:00
|
|
|
func.usedOtherFile |= func.usedSameFile;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Function usage..
|
2011-10-13 20:53:06 +02:00
|
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next()) {
|
2009-01-03 21:29:20 +01:00
|
|
|
const Token *funcname = 0;
|
|
|
|
|
2011-10-13 20:53:06 +02:00
|
|
|
if (Token::Match(tok->next(), "%var% (")) {
|
2009-02-27 17:36:37 +01:00
|
|
|
funcname = tok->next();
|
|
|
|
}
|
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (Token::Match(tok, "[;{}.,()[=+-/&|!?:] %var% [(),;:}]"))
|
2008-12-18 22:28:57 +01:00
|
|
|
funcname = tok->next();
|
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
else if (Token::Match(tok, "[=(,] & %var% :: %var% [,);]"))
|
2009-05-31 08:01:16 +02:00
|
|
|
funcname = tok->tokAt(4);
|
|
|
|
|
2009-06-05 15:02:26 +02:00
|
|
|
else
|
|
|
|
continue;
|
|
|
|
|
2010-12-15 18:45:53 +01:00
|
|
|
// funcname ( => Assert that the end parenthesis isn't followed by {
|
2011-10-13 20:53:06 +02:00
|
|
|
if (Token::Match(funcname, "%var% (")) {
|
2008-12-18 22:28:57 +01:00
|
|
|
int parlevel = 0;
|
2011-10-13 20:53:06 +02:00
|
|
|
for (const Token *tok2 = funcname; tok2; tok2 = tok2->next()) {
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok2->str() == "(")
|
2008-12-18 22:28:57 +01:00
|
|
|
++parlevel;
|
|
|
|
|
2011-10-13 20:53:06 +02:00
|
|
|
else if (tok2->str() == ")") {
|
2008-12-18 22:28:57 +01:00
|
|
|
--parlevel;
|
2010-04-02 07:30:58 +02:00
|
|
|
if (parlevel == 0 && (Token::Match(tok2, ") const|{")))
|
2008-12-18 22:28:57 +01:00
|
|
|
funcname = NULL;
|
2010-04-02 07:30:58 +02:00
|
|
|
if (parlevel <= 0)
|
2008-12-18 22:28:57 +01:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-10-13 20:53:06 +02:00
|
|
|
if (funcname) {
|
2009-01-05 16:49:57 +01:00
|
|
|
FunctionUsage &func = _functions[ funcname->str()];
|
2008-12-18 22:28:57 +01:00
|
|
|
|
2010-04-02 07:30:58 +02:00
|
|
|
if (func.filename.empty() || func.filename == "+")
|
2008-12-18 22:28:57 +01:00
|
|
|
func.usedOtherFile = true;
|
|
|
|
else
|
|
|
|
func.usedSameFile = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-07-08 13:01:53 +02:00
|
|
|
void CheckUnusedFunctions::check(ErrorLogger * const errorLogger)
|
2008-12-18 22:28:57 +01:00
|
|
|
{
|
2011-12-03 12:19:26 +01:00
|
|
|
if (templates)
|
|
|
|
return;
|
|
|
|
|
2011-10-13 20:53:06 +02:00
|
|
|
for (std::map<std::string, FunctionUsage>::const_iterator it = _functions.begin(); it != _functions.end(); ++it) {
|
2008-12-18 22:28:57 +01:00
|
|
|
const FunctionUsage &func = it->second;
|
2010-04-02 07:30:58 +02:00
|
|
|
if (func.usedOtherFile || func.filename.empty())
|
2008-12-18 22:28:57 +01:00
|
|
|
continue;
|
2011-10-29 20:04:43 +02:00
|
|
|
if (it->first == "main" ||
|
|
|
|
it->first == "WinMain" ||
|
|
|
|
it->first == "_tmain" ||
|
|
|
|
it->first == "if" ||
|
|
|
|
(it->first.compare(0, 8, "operator") == 0 && it->first.size() > 8 && !std::isalnum(it->first[8])))
|
2009-01-16 17:20:35 +01:00
|
|
|
continue;
|
2011-10-13 20:53:06 +02:00
|
|
|
if (! func.usedSameFile) {
|
2009-01-11 07:44:32 +01:00
|
|
|
std::string filename;
|
2010-04-02 07:30:58 +02:00
|
|
|
if (func.filename == "+")
|
2009-01-11 07:44:32 +01:00
|
|
|
filename = "";
|
|
|
|
else
|
|
|
|
filename = func.filename;
|
2011-09-18 07:13:39 +02:00
|
|
|
unusedFunctionError(errorLogger, filename, func.lineNumber, it->first);
|
2011-10-13 20:53:06 +02:00
|
|
|
} else if (! func.usedOtherFile) {
|
2009-07-14 08:17:12 +02:00
|
|
|
/** @todo add error message "function is only used in <file> it can be static" */
|
|
|
|
/*
|
2008-12-18 22:28:57 +01:00
|
|
|
std::ostringstream errmsg;
|
|
|
|
errmsg << "The function '" << it->first << "' is only used in the file it was declared in so it should have local linkage.";
|
|
|
|
_errorLogger->reportErr( errmsg.str() );
|
|
|
|
*/
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-18 07:13:39 +02:00
|
|
|
void CheckUnusedFunctions::unusedFunctionError(ErrorLogger * const errorLogger,
|
2011-09-18 18:58:28 +02:00
|
|
|
const std::string &filename, unsigned int lineNumber,
|
|
|
|
const std::string &funcname)
|
2010-04-04 22:55:28 +02:00
|
|
|
{
|
2010-07-08 13:01:53 +02:00
|
|
|
std::list<ErrorLogger::ErrorMessage::FileLocation> locationList;
|
2011-10-13 20:53:06 +02:00
|
|
|
if (!filename.empty()) {
|
2010-07-08 13:01:53 +02:00
|
|
|
ErrorLogger::ErrorMessage::FileLocation fileLoc;
|
2010-07-17 00:27:40 +02:00
|
|
|
fileLoc.setfile(filename);
|
2011-09-18 07:13:39 +02:00
|
|
|
fileLoc.line = lineNumber;
|
2010-07-08 13:01:53 +02:00
|
|
|
locationList.push_back(fileLoc);
|
|
|
|
}
|
|
|
|
|
2011-04-14 18:02:01 +02:00
|
|
|
const ErrorLogger::ErrorMessage errmsg(locationList, Severity::style, "The function '" + funcname + "' is never used", "unusedFunction", false);
|
2010-07-08 13:01:53 +02:00
|
|
|
if (errorLogger)
|
|
|
|
errorLogger->reportErr(errmsg);
|
|
|
|
else
|
|
|
|
reportError(errmsg);
|
2010-04-04 22:55:28 +02:00
|
|
|
}
|