491 lines
17 KiB
C++
491 lines
17 KiB
C++
|
/*
|
|||
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|||
|
|
* Copyright (C) 2007-2013 Daniel Marjam<EFBFBD>ki and Cppcheck team.
|
|||
|
|
*
|
|||
|
|
* This program is free software: you can redistribute it and/or modify
|
|||
|
|
* it under the terms of the GNU General Public License as published by
|
|||
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|||
|
|
* (at your option) any later version.
|
|||
|
|
*
|
|||
|
|
* This program is distributed in the hope that it will be useful,
|
|||
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|||
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|||
|
|
* GNU General Public License for more details.
|
|||
|
|
*
|
|||
|
|
* You should have received a copy of the GNU General Public License
|
|||
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|||
|
|
*/
|
|||
|
|
|
|||
|
|
|
|||
|
|
#include "tokenize.h"
|
|||
|
|
#include "checksizeof.h"
|
|||
|
|
#include "testsuite.h"
|
|||
|
|
#include <sstream>
|
|||
|
|
|
|||
|
|
extern std::ostringstream errout;
|
|||
|
|
|
|||
|
|
class TestSizeof : public TestFixture {
|
|||
|
|
public:
|
|||
|
|
TestSizeof() : TestFixture("TestSizeof")
|
|||
|
|
{ }
|
|||
|
|
|
|||
|
|
private:
|
|||
|
|
|
|||
|
|
|
|||
|
|
void run() {
|
|||
|
|
TEST_CASE(sizeofsizeof);
|
|||
|
|
TEST_CASE(sizeofCalculation);
|
|||
|
|
TEST_CASE(checkPointerSizeof);
|
|||
|
|
TEST_CASE(sizeofForArrayParameter);
|
|||
|
|
TEST_CASE(sizeofForNumericParameter);
|
|||
|
|
TEST_CASE(suspiciousSizeofCalculation);
|
|||
|
|
}
|
|||
|
|
|
|||
|
|
void check(const char code[]) {
|
|||
|
|
// Clear the error buffer..
|
|||
|
|
errout.str("");
|
|||
|
|
|
|||
|
|
Settings settings;
|
|||
|
|
settings.addEnabled("warning");
|
|||
|
|
settings.inconclusive = true;
|
|||
|
|
|
|||
|
|
// Tokenize..
|
|||
|
|
Tokenizer tokenizer(&settings, this);
|
|||
|
|
std::istringstream istr(code);
|
|||
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|||
|
|
|
|||
|
|
// Check...
|
|||
|
|
CheckSizeof checkSizeof(&tokenizer, &settings, this);
|
|||
|
|
checkSizeof.runChecks(&tokenizer, &settings, this);
|
|||
|
|
}
|
|||
|
|
|
|||
|
|
void sizeofsizeof() {
|
|||
|
|
check("void foo()\n"
|
|||
|
|
"{\n"
|
|||
|
|
" int i = sizeof sizeof char;\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning) Calling 'sizeof' on 'sizeof'.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void foo()\n"
|
|||
|
|
"{\n"
|
|||
|
|
" int i = sizeof (sizeof long);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning) Calling 'sizeof' on 'sizeof'.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void foo(long *p)\n"
|
|||
|
|
"{\n"
|
|||
|
|
" int i = sizeof (sizeof (p));\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning) Calling 'sizeof' on 'sizeof'.\n", errout.str());
|
|||
|
|
}
|
|||
|
|
|
|||
|
|
void sizeofCalculation() {
|
|||
|
|
check("int a, b; int a,sizeof(a+b)");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:1]: (warning) Found calculation inside sizeof().\n", errout.str());
|
|||
|
|
|
|||
|
|
check("int a, b; sizeof(a*b)");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:1]: (warning) Found calculation inside sizeof().\n", errout.str());
|
|||
|
|
|
|||
|
|
check("int a, b; sizeof(-a)");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:1]: (warning) Found calculation inside sizeof().\n", errout.str());
|
|||
|
|
|
|||
|
|
check("int a, b; sizeof(*a)");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("sizeof(void * const)");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("sizeof(foo++)");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:1]: (warning) Found calculation inside sizeof().\n", errout.str());
|
|||
|
|
|
|||
|
|
check("sizeof(--foo)");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:1]: (warning) Found calculation inside sizeof().\n", errout.str());
|
|||
|
|
}
|
|||
|
|
|
|||
|
|
void sizeofForArrayParameter() {
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int a[10];\n"
|
|||
|
|
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" unsigned int a = 2;\n"
|
|||
|
|
" unsigned int b = 2;\n"
|
|||
|
|
" int c[(a+b)];\n"
|
|||
|
|
" std::cout << sizeof(c) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" unsigned int a = { 2 };\n"
|
|||
|
|
" unsigned int b[] = { 0 };\n"
|
|||
|
|
" int c[a[b[0]]];\n"
|
|||
|
|
" std::cout << sizeof(c) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" unsigned int a[] = { 1 };\n"
|
|||
|
|
" unsigned int b = 2;\n"
|
|||
|
|
" int c[(a[0]+b)];\n"
|
|||
|
|
" std::cout << sizeof(c) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int a[] = { 1, 2, 3 };\n"
|
|||
|
|
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int a[3] = { 1, 2, 3 };\n"
|
|||
|
|
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f( int a[]) {\n"
|
|||
|
|
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (error) Using 'sizeof' on array given as "
|
|||
|
|
"function argument returns size of a pointer.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f( int a[]) {\n"
|
|||
|
|
" std::cout << sizeof a / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (error) Using 'sizeof' on array given as "
|
|||
|
|
"function argument returns size of a pointer.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f( int a[3] ) {\n"
|
|||
|
|
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (error) Using 'sizeof' on array given as "
|
|||
|
|
"function argument returns size of a pointer.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f(int *p) {\n"
|
|||
|
|
" p[0] = 0;\n"
|
|||
|
|
" int unused = sizeof(p);\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" char p[] = \"test\";\n"
|
|||
|
|
" int unused = sizeof(p);\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
// ticket #2495
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" static float col[][3]={\n"
|
|||
|
|
" {1,0,0},\n"
|
|||
|
|
" {0,0,1},\n"
|
|||
|
|
" {0,1,0},\n"
|
|||
|
|
" {1,0,1},\n"
|
|||
|
|
" {1,0,1},\n"
|
|||
|
|
" {1,0,1},\n"
|
|||
|
|
" };\n"
|
|||
|
|
" const int COL_MAX=sizeof(col)/sizeof(col[0]);\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
// ticket #155
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" char buff1[1024*64],buff2[sizeof(buff1)*2];\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
// ticket #2510
|
|||
|
|
check("void f( int a[], int b) {\n"
|
|||
|
|
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (error) Using 'sizeof' on array given as "
|
|||
|
|
"function argument returns size of a pointer.\n", errout.str());
|
|||
|
|
|
|||
|
|
// ticket #2510
|
|||
|
|
check("void f( int a[3] , int b[2] ) {\n"
|
|||
|
|
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (error) Using 'sizeof' on array given as "
|
|||
|
|
"function argument returns size of a pointer.\n", errout.str());
|
|||
|
|
|
|||
|
|
// ticket #2510
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" char buff1[1024*64],buff2[sizeof(buff1)*(2+1)];\n"
|
|||
|
|
"}\n"
|
|||
|
|
);
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
}
|
|||
|
|
|
|||
|
|
void sizeofForNumericParameter() {
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" std::cout << sizeof(10) << std::endl;\n"
|
|||
|
|
"}\n");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning) Suspicious usage of 'sizeof' with a numeric constant as parameter.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" std::cout << sizeof(-10) << std::endl;\n"
|
|||
|
|
"}\n");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning) Suspicious usage of 'sizeof' with a numeric constant as parameter.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" std::cout << sizeof 10 << std::endl;\n"
|
|||
|
|
"}\n");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning) Suspicious usage of 'sizeof' with a numeric constant as parameter.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" std::cout << sizeof -10 << std::endl;\n"
|
|||
|
|
"}\n");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning) Suspicious usage of 'sizeof' with a numeric constant as parameter.\n", errout.str());
|
|||
|
|
}
|
|||
|
|
|
|||
|
|
void suspiciousSizeofCalculation() {
|
|||
|
|
check("int* p;\n"
|
|||
|
|
"return sizeof(p)/5;");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Division of result of sizeof() on pointer type.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("unknown p;\n"
|
|||
|
|
"return sizeof(p)/5;");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("return sizeof(unknown)/5;");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("int p;\n"
|
|||
|
|
"return sizeof(p)/5;");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("int* p[5];\n"
|
|||
|
|
"return sizeof(p)/5;");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
|
|||
|
|
check("return sizeof(foo)*sizeof(bar);");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:1]: (warning, inconclusive) Multiplying sizeof() with sizeof() indicates a logic error.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("return (foo)*sizeof(bar);");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("return sizeof(foo)*bar;");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
}
|
|||
|
|
|
|||
|
|
void checkPointerSizeof() {
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" char *x = malloc(10);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(*x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(&x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(100 * sizeof(x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(x) * 100);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof *x);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof x);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(100 * sizeof x);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = calloc(1, sizeof(*x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = calloc(1, sizeof *x);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = calloc(1, sizeof(x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = calloc(1, sizeof x);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = calloc(1, sizeof(int));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" char x[10];\n"
|
|||
|
|
" memset(x, 0, sizeof(x));\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" char* x[10];\n"
|
|||
|
|
" memset(x, 0, sizeof(x));\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" char x[10];\n"
|
|||
|
|
" memset(x, 0, sizeof x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int));\n"
|
|||
|
|
" memset(x, 0, sizeof(int));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int));\n"
|
|||
|
|
" memset(x, 0, sizeof(*x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int));\n"
|
|||
|
|
" memset(x, 0, sizeof *x);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int));\n"
|
|||
|
|
" memset(x, 0, sizeof x);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int));\n"
|
|||
|
|
" memset(x, 0, sizeof(x));\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int) * 10);\n"
|
|||
|
|
" memset(x, 0, sizeof(x) * 10);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int) * 10);\n"
|
|||
|
|
" memset(x, 0, sizeof x * 10);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning, inconclusive) Size of pointer 'x' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int) * 10);\n"
|
|||
|
|
" memset(x, 0, sizeof(*x) * 10);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int) * 10);\n"
|
|||
|
|
" memset(x, 0, sizeof *x * 10);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check("void f() {\n"
|
|||
|
|
" int *x = malloc(sizeof(int) * 10);\n"
|
|||
|
|
" memset(x, 0, sizeof(int) * 10);\n"
|
|||
|
|
" free(x);\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
|
|||
|
|
check(
|
|||
|
|
"int fun(const char *buf1)\n"
|
|||
|
|
"{\n"
|
|||
|
|
" const char *buf1_ex = \"foobarbaz\";\n"
|
|||
|
|
" return strncmp(buf1, buf1_ex, sizeof(buf1_ex)) == 0;\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:4]: (warning, inconclusive) Size of pointer 'buf1_ex' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
check(
|
|||
|
|
"int fun(const char *buf1) {\n"
|
|||
|
|
" return strncmp(buf1, foo(buf2), sizeof(buf1)) == 0;\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Size of pointer 'buf1' used instead of size of its data.\n", errout.str());
|
|||
|
|
|
|||
|
|
// #ticket 3874
|
|||
|
|
check("void f()\n"
|
|||
|
|
"{\n"
|
|||
|
|
" int * pIntArray[10];\n"
|
|||
|
|
" memset(pIntArray, 0, sizeof(pIntArray));\n"
|
|||
|
|
"}");
|
|||
|
|
ASSERT_EQUALS("", errout.str());
|
|||
|
|
}
|
|||
|
|
};
|