cppcheck/test/testpostfixoperator.cpp

393 lines
13 KiB
C++
Raw Normal View History

2010-10-12 19:54:39 +02:00
/*
* Cppcheck - A tool for static C/C++ code analysis
2022-02-05 11:45:17 +01:00
* Copyright (C) 2007-2022 Cppcheck team.
2010-10-12 19:54:39 +02:00
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
2017-05-27 04:33:47 +02:00
2010-10-12 19:54:39 +02:00
#include "checkpostfixoperator.h"
#include "errortypes.h"
2017-05-27 04:33:47 +02:00
#include "settings.h"
2010-10-12 19:54:39 +02:00
#include "testsuite.h"
2017-05-27 04:33:47 +02:00
#include "tokenize.h"
2010-10-12 19:54:39 +02:00
#include <iosfwd>
#include <sstream>
2010-10-12 19:54:39 +02:00
2011-10-13 20:53:06 +02:00
class TestPostfixOperator : public TestFixture {
2010-10-12 19:54:39 +02:00
public:
2021-08-07 20:51:18 +02:00
TestPostfixOperator() : TestFixture("TestPostfixOperator") {}
2010-10-12 19:54:39 +02:00
private:
Settings settings;
2010-10-12 19:54:39 +02:00
#define check(code) check_(code, __FILE__, __LINE__)
void check_(const char code[], const char* file, int line) {
// Clear the error buffer..
errout.str("");
2010-10-12 19:54:39 +02:00
// Tokenize..
Tokenizer tokenizer(&settings, this);
2010-10-12 19:54:39 +02:00
std::istringstream istr(code);
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
2010-10-12 19:54:39 +02:00
// Check for postfix operators..
CheckPostfixOperator checkPostfixOperator(&tokenizer, &settings, this);
checkPostfixOperator.postfixOperator();
}
void run() override {
settings.severity.enable(Severity::performance);
2010-10-12 19:54:39 +02:00
TEST_CASE(testsimple);
TEST_CASE(testfor);
TEST_CASE(testvolatile);
TEST_CASE(testiterator);
TEST_CASE(test2168);
TEST_CASE(pointerSimplest);
TEST_CASE(pointer); // #2321 - postincrement of pointer is OK
TEST_CASE(testtemplate); // #4686
TEST_CASE(testmember);
TEST_CASE(testcomma);
TEST_CASE(testauto); // #8350
}
2014-11-20 14:20:09 +01:00
void testsimple() {
check("int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" unsigned int k(0);\n"
" std::cout << k << std::endl;\n"
" k++;\n"
" std::cout << k << std::endl;\n"
" if(k) {\n"
" k++;\n"
" }\n"
" std::cout << k << std::endl;\n"
" k--;\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
2010-10-12 19:54:39 +02:00
ASSERT_EQUALS("", errout.str());
check("class K {};"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" K k(0);\n"
" std::cout << k << std::endl;\n"
" k++;\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:5]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-12 19:54:39 +02:00
check("struct K {};"
"void foo()\n"
"{\n"
" K k(0);\n"
" k++;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
check("struct K {};\n"
"void foo(K& k)\n"
"{\n"
" k++;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
check("union K {};"
"void foo()\n"
"{\n"
" K k(0);\n"
" k++;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
check("class K {};"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" K k(1);\n"
" std::cout << k << std::endl;\n"
" if(k) {\n"
" k++;\n"
" }\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:6]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-12 19:54:39 +02:00
check("class K {};"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" K k(1);\n"
" std::cout << k << std::endl;\n"
" if(k) {\n"
" ++k;\n"
" }\n"
" k++;\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:8]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-12 19:54:39 +02:00
check("class K {};"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" K k(0);\n"
" std::cout << k << std::endl;\n"
" k--;\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:5]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-12 19:54:39 +02:00
check("class K {};"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" K k(0);\n"
" std::cout << k << std::endl;\n"
" ++k;\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
2010-10-12 19:54:39 +02:00
ASSERT_EQUALS("", errout.str());
check("class K {};"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" K k(0);\n"
" std::cout << k << std::endl;\n"
" --k;\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
2010-10-12 19:54:39 +02:00
ASSERT_EQUALS("", errout.str());
// #9042
check("template <class T>\n"
"class c {\n"
" int i = 0;\n"
" c() { i--; }\n"
"};\n"
"template <class T>\n"
"class s {};\n"
"using BOOL = char;");
ASSERT_EQUALS("", errout.str());
2010-10-12 19:54:39 +02:00
}
2014-11-20 14:20:09 +01:00
void testfor() {
check("int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" for ( unsigned int i=0; i <= 10; i++) {\n"
" std::cout << i << std::endl;\n"
" }\n"
" return 0;\n"
"}");
2010-10-12 19:54:39 +02:00
ASSERT_EQUALS("", errout.str());
check("class K {};\n"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" for ( K i(0); i <= 10; i++) {\n"
" std::cout << i << std::endl;\n"
" }\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-12 19:54:39 +02:00
check("class K {};\n"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" for ( K i(0); i <= 10; ++i) {\n"
" std::cout << i << std::endl;\n"
" }\n"
" return 0;\n"
"}");
2010-10-12 19:54:39 +02:00
ASSERT_EQUALS("", errout.str());
check("class K {};\n"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" for ( K i(10); i > 1; i--) {\n"
" std::cout << i << std::endl;\n"
" }\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-12 19:54:39 +02:00
check("class K {};\n"
2010-10-14 19:59:10 +02:00
"int main(int argc, char *argv[])\n"
"{\n"
" for ( K i=10; i > 1; --i) {\n"
" std::cout << i << std::endl;\n"
" }\n"
" return 0;\n"
"}");
2010-10-12 19:54:39 +02:00
ASSERT_EQUALS("", errout.str());
2010-10-14 19:59:10 +02:00
}
2010-10-12 19:54:39 +02:00
2014-11-20 14:20:09 +01:00
void testvolatile() {
check("class K {};\n"
"int main()\n"
2010-10-14 19:59:10 +02:00
"{\n"
" volatile K k(0);\n"
" std::cout << k << std::endl;\n"
" k++;\n"
" std::cout << k << std::endl;\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:6]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-14 19:59:10 +02:00
}
2014-11-20 14:20:09 +01:00
void testiterator() {
check("class Base {};\n"
2010-10-14 19:59:10 +02:00
"int main() {\n"
" std::vector<Base*> v;\n"
" v.push_back(new Base());\n"
" v.push_back(new Base());\n"
" for (std::vector<Base*>::iterator i=v.begin(); i!=v.end(); i++) {\n"
" ;;\n"
" }\n"
" v.clear();\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:6]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-14 19:59:10 +02:00
check("int main() {\n"
2010-10-14 19:59:10 +02:00
" std::vector<int> v;\n"
" std::vector<int>::iterator it;\n"
" for( int i=0; i < 10; ++i ) v.push_back(i);\n"
" unsigned int total = 0;\n"
" it = v.begin();\n"
" while( it != v.end() ) {\n"
" total += *it;\n"
" it++;\n"
" }\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:9]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-14 19:59:10 +02:00
check("int main() {\n"
2010-10-14 19:59:10 +02:00
" std::vector<int> v;\n"
" std::vector<int>::const_iterator it;\n"
" for( int i=0; i < 10; ++i ) v.push_back(i);\n"
" unsigned int total = 0;\n"
" it = v.begin();\n"
" while( it != v.end() ) {\n"
" it++;\n"
" }\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:8]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-14 19:59:10 +02:00
check("int main() {\n"
2010-10-14 19:59:10 +02:00
" std::vector<int> v;\n"
" std::vector<int>::iterator it;\n"
" for( int i=0; i < 10; ++i ) v.push_back(i);\n"
" unsigned int total = 0;\n"
" std::vector<int>::reverse_iterator rit;\n"
" rit= v.rend();\n"
" while( rit != v.rbegin() ) {\n"
" rit--;\n"
" }\n"
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:9]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
2010-10-14 19:59:10 +02:00
}
2010-10-12 19:54:39 +02:00
2014-11-20 14:20:09 +01:00
void test2168() {
check("--> declare allocator lock here\n"
"int main(){}");
ASSERT_EQUALS("", errout.str());
}
void pointerSimplest() {
check("void f(int* p){\n"
" p++;\n"
" std::cout << *p;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
2014-11-20 14:20:09 +01:00
void pointer() {
check("static struct class * ab;\n"
"int * p;\n"
"\n"
"void f() {\n"
" p++;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
2014-11-20 14:20:09 +01:00
void testtemplate() {
check("bool foo() {\n"
" std::vector<FilterConfigCacheEntry>::iterator aIter(aImport.begin());\n"
" aIter++;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
}
2014-11-20 14:20:09 +01:00
void testmember() {
check("bool foo() {\n"
" class A {}; class B {A a;};\n"
" B b;\n"
" b.a++;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
check("bool foo() {\n"
" class A {}; class B {A a;};\n"
" B b;\n"
" foo(b.a++);\n"
"}");
ASSERT_EQUALS("", errout.str());
}
2014-11-20 14:20:09 +01:00
void testcomma() {
check("bool foo(int i) {\n"
" class A {};\n"
" A a;\n"
" i++, a++;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (performance) Prefer prefix ++/-- operators for non-primitive types.\n", errout.str());
check("bool foo(int i) {\n"
" class A {};\n"
" A a;\n"
" foo(i, a++);\n"
" foo(a++, i);\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void testauto() { // #8350
check("enum class Color { Red = 0, Green = 1, };\n"
"int fun(const Color color) {\n"
" auto a = 0;\n"
" for (auto i = static_cast<int>(color); i < 10; i++) {\n"
" a += i;\n"
" }\n"
" return a;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
2010-10-12 19:54:39 +02:00
};
REGISTER_TEST(TestPostfixOperator)