2009-10-19 20:57:11 +02:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2011-01-09 20:33:36 +01:00
|
|
|
* Copyright (C) 2007-2011 Daniel Marjamäki and Cppcheck team.
|
2009-10-19 20:57:11 +02:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#include "checkexceptionsafety.h"
|
2011-12-09 19:53:00 +01:00
|
|
|
#include "symboldatabase.h"
|
2009-10-19 20:57:11 +02:00
|
|
|
#include "token.h"
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
// Register CheckExceptionSafety..
|
2011-10-13 20:53:06 +02:00
|
|
|
namespace {
|
|
|
|
CheckExceptionSafety instance;
|
2009-10-19 20:57:11 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
void CheckExceptionSafety::destructors()
|
|
|
|
{
|
2011-12-09 19:53:00 +01:00
|
|
|
const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();
|
2009-10-19 20:57:11 +02:00
|
|
|
|
2011-12-09 19:53:00 +01:00
|
|
|
// Perform check..
|
|
|
|
for (std::list<Scope>::const_iterator i = symbolDatabase->scopeList.begin(); i != symbolDatabase->scopeList.end(); ++i) {
|
|
|
|
for (std::list<Function>::const_iterator j = i->functionList.begin(); j != i->functionList.end(); ++j) {
|
|
|
|
// only looking for destructors
|
|
|
|
if (j->type == Function::eDestructor && j->start) {
|
|
|
|
// Inspect this destructor..
|
|
|
|
for (const Token *tok = j->start->next(); tok != j->start->link(); tok = tok->next()) {
|
|
|
|
// throw found within a destructor
|
|
|
|
if (tok->str() == "throw") {
|
|
|
|
destructorsError(tok);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2009-10-19 20:57:11 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-10-31 18:58:42 +01:00
|
|
|
|
2009-11-08 09:54:08 +01:00
|
|
|
|
|
|
|
|
|
|
|
void CheckExceptionSafety::deallocThrow()
|
|
|
|
{
|
2011-12-09 19:53:00 +01:00
|
|
|
const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();
|
|
|
|
|
2010-12-31 13:58:17 +01:00
|
|
|
// Deallocate a global/member pointer and then throw exception
|
|
|
|
// the pointer will be a dead pointer
|
2011-10-13 20:53:06 +02:00
|
|
|
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) {
|
2010-12-31 13:58:17 +01:00
|
|
|
// only looking for delete now
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok->str() != "delete")
|
2009-11-08 09:54:08 +01:00
|
|
|
continue;
|
|
|
|
|
|
|
|
// Check if this is something similar with: "delete p;"
|
|
|
|
tok = tok->next();
|
2010-04-02 07:30:58 +02:00
|
|
|
if (Token::simpleMatch(tok, "[ ]"))
|
2009-11-08 09:54:08 +01:00
|
|
|
tok = tok->tokAt(2);
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!tok)
|
2009-11-08 09:54:08 +01:00
|
|
|
break;
|
2010-04-02 07:30:58 +02:00
|
|
|
if (!Token::Match(tok, "%var% ;"))
|
2009-11-08 09:54:08 +01:00
|
|
|
continue;
|
|
|
|
const unsigned int varid(tok->varId());
|
2010-04-02 07:30:58 +02:00
|
|
|
if (varid == 0)
|
2009-11-08 09:54:08 +01:00
|
|
|
continue;
|
|
|
|
|
2011-12-09 19:53:00 +01:00
|
|
|
// we only look for global variables
|
|
|
|
const Variable* var = symbolDatabase->getVariableFromVarId(varid);
|
|
|
|
if (!var || !var->isGlobal())
|
|
|
|
continue;
|
2009-11-08 09:54:08 +01:00
|
|
|
|
2010-12-31 13:58:17 +01:00
|
|
|
// indentlevel..
|
2009-11-08 09:54:08 +01:00
|
|
|
unsigned int indentlevel = 0;
|
2010-12-31 13:58:17 +01:00
|
|
|
|
|
|
|
// Token where throw occurs
|
2009-11-08 09:54:08 +01:00
|
|
|
const Token *ThrowToken = 0;
|
2010-12-31 13:58:17 +01:00
|
|
|
|
|
|
|
// is there a throw after the deallocation?
|
2011-10-13 20:53:06 +02:00
|
|
|
for (const Token *tok2 = tok; tok2; tok2 = tok2->next()) {
|
2010-04-02 07:30:58 +02:00
|
|
|
if (tok2->str() == "{")
|
2009-11-08 09:54:08 +01:00
|
|
|
++indentlevel;
|
2011-10-13 20:53:06 +02:00
|
|
|
else if (tok2->str() == "}") {
|
2010-04-02 07:30:58 +02:00
|
|
|
if (indentlevel == 0)
|
2009-11-08 09:54:08 +01:00
|
|
|
break;
|
|
|
|
--indentlevel;
|
|
|
|
}
|
|
|
|
|
2011-12-09 19:53:00 +01:00
|
|
|
else if (tok2->str() == "throw")
|
2009-11-08 09:54:08 +01:00
|
|
|
ThrowToken = tok2;
|
|
|
|
|
2010-12-31 13:58:17 +01:00
|
|
|
// if the variable is not assigned after the throw then it
|
|
|
|
// is assumed that it is not the intention that it is a dead pointer.
|
2011-10-13 20:53:06 +02:00
|
|
|
else if (Token::Match(tok2, "%varid% =", varid)) {
|
2010-04-02 07:30:58 +02:00
|
|
|
if (ThrowToken)
|
2009-11-08 09:54:08 +01:00
|
|
|
deallocThrowError(ThrowToken, tok->str());
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-02-05 10:11:09 +01:00
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
// catch(const exception & err)
|
|
|
|
// {
|
|
|
|
// throw err; // <- should be just "throw;"
|
|
|
|
// }
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
void CheckExceptionSafety::checkRethrowCopy()
|
|
|
|
{
|
2011-08-07 09:28:08 +02:00
|
|
|
if (!_settings->isEnabled("style"))
|
2011-02-05 10:11:09 +01:00
|
|
|
return;
|
|
|
|
|
2011-12-09 19:53:00 +01:00
|
|
|
const char catchPattern1[] = "catch (";
|
|
|
|
const char catchPattern2[] = "%var% ) { %any%";
|
|
|
|
|
|
|
|
const Token* tok = Token::findsimplematch(_tokenizer->tokens(), catchPattern1);
|
2011-10-13 20:53:06 +02:00
|
|
|
while (tok) {
|
2011-12-09 19:53:00 +01:00
|
|
|
const Token* endScopeTok = tok->next();
|
|
|
|
const Token* endBracketTok = tok->next()->link();
|
2011-02-05 10:11:09 +01:00
|
|
|
|
2011-12-09 19:53:00 +01:00
|
|
|
if (endBracketTok && Token::Match(endBracketTok->previous(), catchPattern2)) {
|
|
|
|
const Token* startScopeTok = endBracketTok->next();
|
|
|
|
endScopeTok = startScopeTok->link();
|
|
|
|
const unsigned int varid = endBracketTok->previous()->varId();
|
|
|
|
|
|
|
|
const Token* rethrowTok = Token::findmatch(startScopeTok->next(), "throw %varid%", endScopeTok->previous(), varid);
|
|
|
|
if (rethrowTok) {
|
|
|
|
rethrowCopyError(rethrowTok, endBracketTok->strAt(-1));
|
|
|
|
}
|
2011-02-05 10:11:09 +01:00
|
|
|
}
|
|
|
|
|
2011-12-09 19:53:00 +01:00
|
|
|
tok = Token::findsimplematch(endScopeTok->next(), catchPattern1);
|
2011-02-05 10:11:09 +01:00
|
|
|
}
|
|
|
|
}
|
2009-11-08 09:54:08 +01:00
|
|
|
|