2008-12-18 22:28:57 +01:00
/*
2009-01-21 21:04:20 +01:00
* Cppcheck - A tool for static C / C + + code analysis
2015-01-03 12:14:58 +01:00
* Copyright ( C ) 2007 - 2015 Daniel Marjamäki and Cppcheck team .
2008-12-18 22:28:57 +01:00
*
* This program is free software : you can redistribute it and / or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation , either version 3 of the License , or
* ( at your option ) any later version .
*
* This program is distributed in the hope that it will be useful ,
* but WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the
* GNU General Public License for more details .
*
* You should have received a copy of the GNU General Public License
2009-09-27 17:08:31 +02:00
* along with this program . If not , see < http : //www.gnu.org/licenses/>.
2008-12-18 22:28:57 +01:00
*/
2009-10-25 12:49:06 +01:00
# include "tokenize.h"
# include "checkother.h"
2008-12-18 22:28:57 +01:00
# include "testsuite.h"
2011-10-13 20:53:06 +02:00
class TestCharVar : public TestFixture {
2008-12-18 22:28:57 +01:00
public :
2014-11-20 14:20:09 +01:00
TestCharVar ( ) : TestFixture ( " TestCharVar " ) {
2013-08-07 16:27:37 +02:00
}
2008-12-18 22:28:57 +01:00
private :
2014-11-20 14:20:09 +01:00
void run ( ) {
2011-11-06 11:26:28 +01:00
TEST_CASE ( array_index_1 ) ;
TEST_CASE ( array_index_2 ) ;
2015-10-06 17:30:51 +02:00
TEST_CASE ( bitop ) ;
2008-12-18 22:28:57 +01:00
}
2014-11-20 14:20:09 +01:00
void check ( const char code [ ] ) {
2010-12-01 18:00:55 +01:00
// Clear the error buffer..
errout . str ( " " ) ;
Settings settings ;
2013-03-03 11:41:59 +01:00
settings . addEnabled ( " warning " ) ;
2010-12-01 18:00:55 +01:00
2008-12-18 22:28:57 +01:00
// Tokenize..
2010-12-01 18:00:55 +01:00
Tokenizer tokenizer ( & settings , this ) ;
2008-12-18 22:28:57 +01:00
std : : istringstream istr ( code ) ;
2009-01-05 16:49:57 +01:00
tokenizer . tokenize ( istr , " test.cpp " ) ;
2008-12-18 22:28:57 +01:00
// Check char variable usage..
2009-03-20 18:16:21 +01:00
CheckOther checkOther ( & tokenizer , & settings , this ) ;
2009-07-05 22:16:43 +02:00
checkOther . checkCharVariable ( ) ;
2008-12-18 22:28:57 +01:00
}
2014-11-20 14:20:09 +01:00
void array_index_1 ( ) {
2012-03-10 12:19:28 +01:00
check ( " int buf[256]; \n "
" void foo() \n "
2009-01-05 16:49:57 +01:00
" { \n "
" unsigned char ch = 0x80; \n "
" buf[ch] = 0; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-01-05 16:49:57 +01:00
2012-03-10 12:19:28 +01:00
check ( " int buf[256]; \n "
" void foo() \n "
2009-01-05 16:49:57 +01:00
" { \n "
" char ch = 0x80; \n "
" buf[ch] = 0; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2015-10-06 17:30:51 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-01-05 16:49:57 +01:00
2012-03-10 12:19:28 +01:00
check ( " int buf[256]; \n "
" void foo() \n "
2009-01-30 07:06:03 +01:00
" { \n "
" signed char ch = 0x80; \n "
" buf[ch] = 0; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2012-09-16 19:44:02 +02:00
ASSERT_EQUALS ( " [test.cpp:5]: (warning) Signed 'char' type used as array index. \n " , errout . str ( ) ) ;
2009-01-30 07:06:03 +01:00
2012-03-10 12:19:28 +01:00
check ( " int buf[256]; \n "
2015-10-06 17:30:51 +02:00
" void foo(signed char ch) \n "
2009-01-05 16:49:57 +01:00
" { \n "
" buf[ch] = 0; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2015-10-06 17:30:51 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2011-08-09 17:03:22 +02:00
check ( " void foo(const char str[]) \n "
" { \n "
" map[str] = 0; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2011-08-09 17:03:22 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2008-12-18 22:28:57 +01:00
}
2014-11-20 14:20:09 +01:00
void array_index_2 ( ) {
2011-11-06 11:26:28 +01:00
// #3282 - False positive
check ( " void foo(char i); \n "
" void bar(int i) { \n "
" const char *s = \" abcde \" ; \n "
" foo(s[i]); \n "
" } " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
2008-12-18 22:28:57 +01:00
2015-10-06 17:30:51 +02:00
void bitop ( ) {
check ( " void foo(int *result) { \n "
" signed char ch = -1; \n "
" *result = a | ch; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2015-10-06 17:30:51 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (warning) When using 'char' variables in bit operations, sign extension can generate unexpected results. \n " , errout . str ( ) ) ;
2009-06-20 19:24:58 +02:00
2015-10-06 17:30:51 +02:00
check ( " void foo(int *result) { \n "
" unsigned char ch = -1; \n "
" *result = a | ch; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2009-06-20 19:24:58 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2015-10-06 17:30:51 +02:00
check ( " void foo(char *result) { \n "
" signed char ch = -1; \n "
" *result = a | ch; \n "
2013-03-19 09:18:58 +01:00
" } " ) ;
2009-06-20 19:24:58 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2015-10-06 17:30:51 +02:00
// 0x03 & ..
check ( " void foo(int *result) { \n "
" signed char ch = -1; \n "
" *result = 0x03 | ch; \n "
2011-07-05 18:41:27 +02:00
" } " ) ;
2012-09-16 19:44:02 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (warning) When using 'char' variables in bit operations, sign extension can generate unexpected results. \n " , errout . str ( ) ) ;
2011-07-05 19:57:07 +02:00
2015-10-06 17:30:51 +02:00
check ( " void foo(int *result) { \n "
" signed char ch = -1; \n "
" *result = 0x03 & ch; \n "
2012-06-09 08:43:13 +02:00
" } " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2011-07-05 18:41:27 +02:00
}
2008-12-18 22:28:57 +01:00
} ;
2009-01-05 16:49:57 +01:00
REGISTER_TEST ( TestCharVar )