walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity
cppcheck/test/testuninitvar.cpp

2556 lines
94 KiB
C++
Raw Normal View History

Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
/*
* Cppcheck - A tool for static C/C++ code analysis
Update year to 2012
2012-01-01 00:05:37 +01:00
* Copyright (C) 2007-2012 Daniel Marjamäki and Cppcheck team.
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "tokenize.h"
#include "checkuninitvar.h"
#include "testsuite.h"
#include <sstream>
extern std::ostringstream errout;
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
class TestUninitVar : public TestFixture {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
public:
TestUninitVar() : TestFixture("TestUninitVar")
{ }
private:
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void run() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
TEST_CASE(uninitvar1);
replaced tabs with spaces
2012-09-05 19:46:44 +02:00
TEST_CASE(uninitvar_bitop); // using uninitialized operand in bit operation
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
TEST_CASE(uninitvar_alloc); // data is allocated but not initialized
TEST_CASE(uninitvar_arrays); // arrays
TEST_CASE(uninitvar_class); // class/struct
TEST_CASE(uninitvar_enum); // enum variables
TEST_CASE(uninitvar_if); // handling if
TEST_CASE(uninitvar_loops); // handling for/while
TEST_CASE(uninitvar_switch); // handling switch
TEST_CASE(uninitvar_references); // references
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
TEST_CASE(uninitvar_return); // return
Message refactorization: Changed expression "0-terminate" to "null-terminate" as discussed on 24b98feadb9ddfc319b86a8d9e78d985f9d4b50b
2012-11-03 21:21:19 +01:00
TEST_CASE(uninitvar_strncpy); // strncpy doesn't always null-terminate
TEST_CASE(uninitvar_memset); // not null-terminated
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
TEST_CASE(uninitvar_func); // analyse functions
fix
2011-02-26 20:08:37 +01:00
TEST_CASE(func_uninit_var); // analyse function calls for: 'int a(int x) { return x+x; }'
TEST_CASE(func_uninit_pointer); // analyse function calls for: 'void a(int *p) { *p = 0; }'
Fixed #2367 (false positive: (error) Uninitialized variable: s)
2010-12-27 21:05:33 +01:00
TEST_CASE(uninitvar_typeof); // typeof
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
// checking for uninitialized variables without using the
// ExecutionPath functionality
TEST_CASE(uninitvar2);
added testcase for ticket #3844
2012-05-28 12:56:24 +02:00
TEST_CASE(uninitvar3); // #3844
Fixed #3869 (References to items in array result it 'Uninitialized variable' errors)
2012-06-08 16:17:55 +02:00
TEST_CASE(uninitvar4); // #3869 (reference)
Fixed #3861 (uninitialized variables)
2012-06-13 19:09:51 +02:00
TEST_CASE(uninitvar5); // #3861
Reviewed handling of unknown types in CheckUninitVar
2012-06-22 16:39:39 +02:00
TEST_CASE(uninitvar6); // handling unknown types in C and C++ files
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
TEST_CASE(uninitvar2_func); // function calls
Uninitialized variables: Better value flow analysis. Fixed false positives.
2012-12-24 19:11:13 +01:00
TEST_CASE(uninitvar2_value); // value flow
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
Reviewed handling of unknown types in C files in UninitVar
2012-06-22 19:57:07 +02:00
void checkUninitVar(const char code[], const char filename[] = "test.cpp") {
Tokenizer: add assert(_settings) to Tokenizer to insure the tokenizer always has settings. Ticket: #2219
2010-12-01 18:00:55 +01:00
// Clear the error buffer..
errout.str("");
Settings settings;
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// Tokenize..
Tokenizer: add assert(_settings) to Tokenizer to insure the tokenizer always has settings. Ticket: #2219
2010-12-01 18:00:55 +01:00
Tokenizer tokenizer(&settings, this);
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
std::istringstream istr(code);
Reviewed handling of unknown types in C files in UninitVar
2012-06-22 19:57:07 +02:00
tokenizer.tokenize(istr, filename);
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
tokenizer.simplifyTokenList();
Fixed #3666 (False positive: Uninitialized variable (taking address))
2012-03-16 17:28:05 +01:00
// Check code..
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
CheckUninitVar check(&tokenizer, &settings, this);
check.executionPaths();
}
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar1() {
Uninitialized variables: Fixed false negative. Ticket: #2207
2010-11-16 20:01:57 +01:00
// Ticket #2207 - False negative
checkUninitVar("void foo() {\n"
" int a;\n"
" b = c - a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
Uninitialized variables: Fixed simple undetected case for '= %var% -'
2010-11-16 20:07:41 +01:00
checkUninitVar("void foo() {\n"
" int a;\n"
" b = a - c;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
Fix #2813 (False negative: Uninitialized variable not found for realloc) http://sourceforge.net/apps/trac/cppcheck/ticket/2813 Patch provided by: marekzmyslowski
2011-09-28 20:46:09 +02:00
checkUninitVar("void foo() {\n"
" int *p;\n"
" realloc(p,10);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("void foo() {\n"
" int *p = NULL;\n"
" realloc(p,10);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// dereferencing uninitialized pointer..
checkUninitVar("static void foo()\n"
"{\n"
" Foo *p;\n"
" p->abcd();\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" Foo<int> *p;\n"
" p->abcd();\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("void f(Foo *p)\n"
"{\n"
" int a;\n"
" p->a = malloc(4 * a);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int *p;\n"
" delete p;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int *p;\n"
" delete [] p;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int *p;\n"
" *p = 135;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
Fixed #2753 (False negative: dereference uninitialized pointer 'buf[0] = 0;')
2011-04-26 20:26:09 +02:00
checkUninitVar("static void foo()\n"
"{\n"
" int *p;\n"
" p[0] = 135;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("static void foo()\n"
"{\n"
" int *x;\n"
" int y = *x;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int *x;\n"
" int &y(*x);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" int x;\n"
" int *y = &x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3058 (False positive: Uninitialized variable: data)
2011-09-03 18:53:14 +02:00
checkUninitVar("void foo()\n"
"{\n"
" int *x;\n"
" int *&y = x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void foo()\n"
"{\n"
" int x = xyz::x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" int a;\n"
" a = 5 + a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("void f()\n"
"{\n"
" int a;\n"
" a++;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
Fixed #3919 (False positive: uninitialized variable (extern))
2012-06-26 18:28:41 +02:00
checkUninitVar("void f()\n"
"{\n"
" extern int a;\n"
" a++;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" int a;\n"
" bar(4 * a);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int i;\n"
" if (i);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int i;\n"
" for (int x = 0; i < 10; x++);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int i;\n"
" for (int x = 0; x < 10; i++);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar("static int foo(int x)\n"
"{\n"
" int i;\n"
" if (x)\n"
" i = 0;\n"
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
" i++;\n"
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int ar[10];\n"
" int i;\n"
" ar[i] = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" int x, y;\n"
" x = (y = 10);\n"
" int z = y * 2;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Refactoring TestUninitVar. Added TODO test case.
2012-06-23 16:44:02 +02:00
// Ticket #3597
checkUninitVar("int f() {\n"
replaced tabs with spaces
2012-09-05 19:46:44 +02:00
" int a;\n"
" int b = 1;\n"
" (b += a) = 1;\n"
Refactoring TestUninitVar. Added TODO test case.
2012-06-23 16:44:02 +02:00
"}\n");
TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n","", errout.str());
checkUninitVar("int f() {\n"
replaced tabs with spaces
2012-09-05 19:46:44 +02:00
" int a,b,c;\n"
" a = b = c;\n"
Refactoring TestUninitVar. Added TODO test case.
2012-06-23 16:44:02 +02:00
"}\n");
TODO_ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: c\n", "", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("static void foo()\n"
"{\n"
" Foo p;\n"
" p.abcd();\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("static void foo()\n"
"{\n"
" Foo p;\n"
" int x = p.abcd();\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
// Unknown types
Uninitialized variables: Added test case
2012-06-23 15:52:35 +02:00
{
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
checkUninitVar("void a()\n"
Uninitialized variables: Added test case
2012-06-23 15:52:35 +02:00
"{\n"
" A ret;\n"
" return ret;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
checkUninitVar("void a()\n"
Uninitialized variables: Added test case
2012-06-23 15:52:35 +02:00
"{\n"
" A ret;\n"
" return ret;\n"
"}\n",
"test.c");
Fixed #3916 (false positive: uninitialized variable when using assignment and , in rhs)
2012-06-27 20:44:19 +02:00
TODO_ASSERT_EQUALS("[test.c:4]: (error) Uninitialized variable: ret\n", "", errout.str());
// #3916 - avoid false positive
checkUninitVar("void f(float x) {\n"
" union lf { long l; float f; } u_lf;\n"
" float hx = (u_lf.f = (x), u_lf.l);\n"
"}\n",
"test.c");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Added test case
2012-06-23 15:52:35 +02:00
}
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void a()\n"
"{\n"
" int x[10];\n"
" int *y = x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void a()\n"
"{\n"
" int x;\n"
" int *y = &x;\n"
" *y = 0;\n"
" x++;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void a()\n"
"{\n"
" char x[10], y[10];\n"
" char *z = x;\n"
" memset(z, 0, sizeof(x));\n"
" memcpy(y, x, sizeof(x));\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
// Handling >> and <<
{
checkUninitVar("int a() {\n"
" int ret;\n"
" std::cin >> ret;\n"
" ret++;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
checkUninitVar("int a() {\n"
" int ret;\n"
" int a = value >> ret;\n"
" ret++;\n"
"}\n",
"test.c");
ASSERT_EQUALS("[test.c:3]: (error) Uninitialized variable: ret\n", errout.str());
Reviewed handling of << and >> in C files in CheckUninitVar
2012-06-23 12:41:00 +02:00
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
checkUninitVar("void foo() {\n" // #3707
" Node node;\n"
" int x;\n"
" node[\"abcd\"] >> x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3707 (Uninitialized variable with operator >> and templates)
2012-04-24 19:50:54 +02:00
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
checkUninitVar("int a(FArchive &arc) {\n" // #3060 (initialization through operator<<)
" int *p;\n"
" arc << p;\n"
" return *p;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3060 (False positive: Uninitialized variable: fresh)
2011-09-04 12:53:53 +02:00
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
checkUninitVar("int a() {\n"
" int ret;\n"
" int a = value << ret;\n"
" return ret;\n"
"}\n",
"test.c");
ASSERT_EQUALS("[test.c:3]: (error) Uninitialized variable: ret\n", errout.str());
Fixed #4320 (False positives 'unassignedVariable' and 'uninitvar')
2012-12-18 19:02:30 +01:00
// #4320
checkUninitVar("void f() {\n"
" int a;\n"
" a << 1;\n"
" return a;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
}
Reviewed handling of << and >> in C files in CheckUninitVar
2012-06-23 12:41:00 +02:00
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
checkUninitVar("void a() {\n" // asm
" int x;\n"
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
" asm();\n"
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
" x++;\n"
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void a()\n"
"{\n"
" int x[10];\n"
" struct xyz xyz1 = { .x = x };\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void a()\n"
"{\n"
" struct S *s;\n"
" s->x = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
checkUninitVar("void a()\n"
"{\n"
" struct S *s;\n"
" FOREACH() { }\n"
" s->x = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: s\n", errout.str());
checkUninitVar("void a()\n"
"{\n"
" struct S *s1;\n"
" struct S *s2;\n"
" FOREACH(s1) { }\n"
" s2->x = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: s2\n", errout.str());
// #1533
checkUninitVar("char a()\n"
"{\n"
" char key;\n"
" struct A msg = { .buf = {&key} };\n"
" init(&msg);\n"
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
" key++;\n"
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" char *buf = malloc(100);\n"
" struct ABC *abc = buf;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("class Fred {\n"
"public:\n"
" FILE *f;\n"
" ~Fred();\n"
"}\n"
"Fred::~Fred()\n"
"{\n"
" fclose(f);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" int c;\n"
" ab(sizeof(xyz), &c);\n"
" if (c);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" int c;\n"
" a = (f2(&c));\n"
" c++;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f(int a)\n"
"{\n"
" if (a) {\n"
" char *p;\n"
" *p = 0;\n"
" }\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: p\n", errout.str());
// +=
checkUninitVar("void f()\n"
"{\n"
" int c;\n"
" c += 2;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char *s = malloc(100);\n"
" *s += 10;\n"
"}\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: s\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" int a[10];\n"
Uninitialized variables: better handling of for example 'a[1] = 1+a[2];'
2010-11-05 19:24:14 +01:00
" a[0] = 10 - a[1];\n"
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
"}\n");
Uninitialized variables: better handling of for example 'a[1] = 1+a[2];'
2010-11-05 19:24:14 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// goto/setjmp/longjmp..
checkUninitVar("void foo(int x)\n"
"{\n"
" long b;\n"
" if (g()) {\n"
" b =2;\n"
" goto found;\n"
" }\n"
"\n"
" return;\n"
"\n"
"found:\n"
" int a = b;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo()\n"
"{\n"
" jmp_buf env;\n"
" int a;\n"
" int val = setjmp(env);\n"
" if(val)\n"
" return a;\n"
" a = 1;\n"
" longjmp(env, 1);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
// macro_for..
checkUninitVar("int foo()\n"
"{\n"
" int retval;\n"
" if (condition) {\n"
" for12(1,2) { }\n"
" retval = 1;\n"
" }\n"
" else\n"
" retval = 2;\n"
" return retval;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo()\n"
"{\n"
" int i;\n"
" goto exit;\n"
" i++;\n"
"exit:\n"
"}\n");
ASSERT_EQUALS("", errout.str());
fix #2146 (uninitialized variable: false negative for 'return x ? 1 : y;')
2011-08-01 03:33:43 +02:00
Fixed ticket #3480 (segmentation fault of cppcheck)
2012-01-09 12:36:05 +01:00
// Ticket #3480 - Don't crash garbage code
checkUninitVar("int f()\n"
"{\n"
" return if\n"
"}\n");
ASSERT_EQUALS("", errout.str());
#3873 added testcase to make sure false positive does not appear again.
2012-06-24 00:00:15 +02:00
// Ticket #3873 (false positive)
checkUninitVar("MachineLoopRange *MachineLoopRanges::getLoopRange(const MachineLoop *Loop) {\n"
" MachineLoopRange *&Range = Cache[Loop];\n"
" if (!Range)\n"
replaced tabs with spaces
2012-09-05 19:46:44 +02:00
" Range = new MachineLoopRange(Loop, Allocator, *Indexes);\n"
#3873 added testcase to make sure false positive does not appear again.
2012-06-24 00:00:15 +02:00
" return Range;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #4040 (false positive: (error) Uninitialized variable: iter)
2012-08-27 15:48:21 +02:00
// #4040 - False positive
checkUninitVar("int f(int x) {\n"
" int iter;\n"
" {\n"
" union\n"
" {\n"
" int asInt;\n"
" double asDouble;\n"
" };\n"
"\n"
" iter = x;\n"
" }\n"
" return 1 + iter;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
added testcase for ticket #3844
2012-05-28 12:56:24 +02:00
void uninitvar3() { // #3844
// avoid false positive
checkUninitVar("namespace std _GLIBCXX_VISIBILITY(default)\n"
"{\n"
"_GLIBCXX_BEGIN_NAMESPACE_CONTAINER\n"
replaced tabs with spaces
2012-09-05 19:46:44 +02:00
" typedef unsigned long _Bit_type;\n"
" struct _Bit_reference\n"
" {\n"
" _Bit_type * _M_p;\n"
" _Bit_type _M_mask;\n"
" _Bit_reference(_Bit_type * __x, _Bit_type __y)\n"
" : _M_p(__x), _M_mask(__y) { }\n"
" };\n"
added testcase for ticket #3844
2012-05-28 12:56:24 +02:00
"}\n");
ASSERT_EQUALS("", errout.str());
}
Uninitialized variables: Fixed simple undetected case for '= %var% |' and '| %var% ;'
2010-11-16 20:16:44 +01:00
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_bitop() {
Uninitialized variables: Fixed simple undetected case for '= %var% |' and '| %var% ;'
2010-11-16 20:16:44 +01:00
checkUninitVar("void foo() {\n"
" int b;\n"
" c = a | b;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: b\n", errout.str());
checkUninitVar("void foo() {\n"
" int b;\n"
" c = b | a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: b\n", errout.str());
}
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// if..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_if() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("static void foo()\n"
"{\n"
" Foo *p;\n"
" if (x)\n"
" p = new Foo;\n"
" p->abcd();\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("static void foo(int x)\n"
"{\n"
" int a;\n"
" if (x==1);\n"
" if (x==2);\n"
" x = a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("int foo()\n"
"{\n"
" int i;\n"
" if (x)\n"
" i = 22;\n"
" else\n"
" i = 33;\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo()\n"
"{\n"
" int i;\n"
" if (x)\n"
" i = 22;\n"
" else\n"
" {\n"
" char *y = {0};\n"
" i = 33;\n"
" }\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo()\n"
"{\n"
" int i;\n"
" if (x)\n"
" {\n"
" struct abc abc1 = (struct abc) { .a=0, .b=0, .c=0 };\n"
" i = 22;\n"
" }\n"
" else\n"
" {\n"
" i = 33;\n"
" }\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("static void foo(int x)\n"
"{\n"
" Foo *p;\n"
" if (x)\n"
" p = new Foo;\n"
" if (x)\n"
" p->abcd();\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo(int a)\n"
"{\n"
" int n;\n"
" int condition;\n"
" if(a == 1) {\n"
" n=0;\n"
" condition=0;\n"
" }\n"
" else {\n"
" n=1;\n"
" }\n"
"\n"
" if( n == 0) {\n"
" a=condition;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" C *c;\n"
" if (fun(&c));\n"
" c->Release();\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positive when there is assignment in condition
2012-07-17 07:03:40 +02:00
checkUninitVar("void f() {\n"
" char a[10];\n"
" if (a[0] = x){}\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("int foo(int x)\n"
"{\n"
" int i;\n"
" if (one())\n"
" i = 1;\n"
" else\n"
" return 3;\n"
" return i;\n"
"}\n");
Fixed #2207 (False positive: uninitialized variable (return if uninitialized))
2010-11-15 20:35:01 +01:00
ASSERT_EQUALS("", errout.str());
// Ticket #2207 - False positive
checkUninitVar("void foo(int x) {\n"
" int a;\n"
" if (x)\n"
" a = 1;\n"
" if (!x)\n"
" return;\n"
" b = (c - a);\n"
"}\n");
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo()\n"
"{\n"
" int ret;\n"
" if (one())\n"
" ret = 1;\n"
" else\n"
" throw 3;\n"
" return ret;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int f(int a)\n"
"{\n"
" int ret;\n"
" if (a == 1)\n"
" ret = 1;\n"
" else\n"
" XYZ ret = 2;\n" // XYZ may be an unexpanded macro so bailout the checking of "ret".
" return ret;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int f(int a, int b)\n"
"{\n"
" int x;\n"
" if (a)\n"
" x = a;\n"
" else {\n"
" do { } while (f2());\n"
" x = b;\n"
" }\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo(long verbose,bool bFlag)\n"
"{\n"
" double t;\n"
" if (bFlag)\n"
" {\n"
" if (verbose)\n"
" t = 1;\n"
" if (verbose)\n"
" std::cout << (12-t);\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2401 (false positive: Uninitialized variable: result)
2011-01-05 20:44:04 +01:00
checkUninitVar("int test(int cond1, int cond2) {\n"
" int foo;\n"
" if (cond1 || cond2) {\n"
" if (cond2)\n"
" foo = 0;\n"
" }\n"
" if (cond2) {\n"
" int t = foo*foo;\n"
" }\n"
Uninitialized variables. Fixed false positive when there are multiple related conditions. ticket: #2399
2011-01-05 19:54:56 +01:00
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// ? :
checkUninitVar("static void foo(int v)\n"
"{\n"
" int x;\n"
" x = v <= 0 ? -1 : x;\n"
"}\n");
Uninitialized variables: Fixed false negative when ? operator is used in rhs
2012-06-23 12:19:03 +02:00
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void foo()\n"
"{\n"
" const char *msgid1, *msgid2;\n"
" int ret = bar(&msgid1);\n"
" if (ret > 0) {\n"
" ret = bar(&msgid2);\n"
" }\n"
" ret = ret <= 0 ? -1 :\n"
" strcmp(msgid1, msgid2) == 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo(int a, int b)\n"
"{\n"
" int x; x = (a<b) ? 1 : 0;\n"
" int y = y;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: y\n", errout.str());
// ; { .. }
checkUninitVar("int foo()\n"
"{\n"
" int retval;\n"
" if (condition) {\n"
" { }\n"
" retval = 1; }\n"
" else\n"
" retval = 2;\n"
" return retval;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" {\n"
" for (int i = 0; i < 10; ++i)\n"
" { }\n"
" }\n"
"\n"
" { }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Added testcases for #3098
2012-09-09 19:49:40 +02:00
// Ticket #3098 - False negative uninitialized variable
checkUninitVar("void f()\n"
"{\n"
" char *c1,*c2;\n"
" if(strcoll(c1,c2))\n"
" {\n"
" }\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c1\n"
"[test.cpp:4]: (error) Uninitialized variable: c2\n", errout.str());
checkUninitVar("void f(char *c1, char *c2)\n"
"{\n"
" if(strcoll(c1,c2))\n"
" {\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
Fixed #3586 (false positive: uninitvar in argument in namespaced function)
2012-09-15 10:48:17 +02:00
" char *c1;\n"
" c1=strcpy(c1,\"test\");\n"
Added testcases for #3098
2012-09-09 19:49:40 +02:00
"}\n");
TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c1\n","", errout.str());
checkUninitVar("void f(char *c1)\n"
"{\n"
Fixed #3586 (false positive: uninitvar in argument in namespaced function)
2012-09-15 10:48:17 +02:00
" c1=strcpy(c1,\"test\");\n"
Added testcases for #3098
2012-09-09 19:49:40 +02:00
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
// handling for/while loops..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_loops() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// for..
checkUninitVar("void f()\n"
"{\n"
" for (int i = 0; i < 4; ++i) {\n"
" int a;\n"
" b(4*a);\n"
" }"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("void f() {\n"
" int k;\n"
" for (int i = 0; i < 4; ++i) {\n"
" k = k + 2;\n"
" }\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: k\n", errout.str());
uninitialized variables: fixed problem when parsing loop bodies
2010-11-13 08:03:59 +01:00
checkUninitVar("void f() {\n"
" gchar sel[10];\n"
" for (int i = 0; i < 4; ++i) {\n"
" int sz = sizeof(sel);\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("enum ABCD { A, B, C, D };\n"
"\n"
"static void f(char *str ) {\n"
scripts: added tabs.pl - in my opinion it is bad to use tabs inside string constants. spaces or \t should be used instead.
2011-02-05 12:53:28 +01:00
" enum ABCD i;\n"
" for (i = 0; i < D; i++) {\n"
" str[i] = 0;\n"
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void x() {\n"
" do {\n"
" Token * tok;\n"
" for (tok = a; tok; tok = tok->next())\n"
" {\n"
" }\n"
" } while (tok2);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
// while..
checkUninitVar("int f()\n"
"{\n"
" int i;\n"
" while (fgets())\n"
" i = 1;\n"
" return i;"
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar("void f(int i)\n"
"{\n"
" int a;\n"
" while (i < 10)\n"
" i++;\n"
" a++;"
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: a\n", errout.str());
Fixed #2226 (segmentation fault of cppcheck)
2010-11-24 18:08:21 +01:00
// Ticket #2226: C++0x loop
checkUninitVar("void f() {\n"
" container c;\n"
" for (iterator it : c) {\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2345 (False positive: uninitialized variable (in sub-condition in if inside a loop))
2010-12-23 09:15:45 +01:00
// Ticket #2345: False positive in sub-condition in if inside a loop
checkUninitVar("void f(int x) {\n"
" const PoolItem* pItem;\n"
" while (x > 0) {\n"
" if (GetItem(&pItem) && (*pItem != rPool))\n"
" { }\n"
" x--;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f(int x) {\n"
" const PoolItem* pItem;\n"
" while (x > 0) {\n"
" if (*pItem != rPool)\n"
" { }\n"
" x--;\n"
" }\n"
"}\n");
Fixed #2526 (Make TODO_ASSERT_EQUALS take three arguments (value, to_be, as_is)?... Removed replaced EXPECTED with... WANTED (to-be): The future expected value. CURRENT (as-is): Documenting how cppcheck behaves now. This removes the need for an ASSERT_EQUALS but enforces the check for every TODO_ASSERT_EQUALS.
2011-01-30 12:54:19 +01:00
TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: pItem\n",
"", errout.str());
Fixed #2231 (uninitialized variable: undetected when initialization in for loop)
2011-02-19 20:19:46 +01:00
// #2231 - conditional initialization in loop..
checkUninitVar("int foo(char *a) {\n"
" int x;\n"
"\n"
" for (int i = 0; i < 10; ++i) {\n"
" if (a[i] == 'x') {\n"
" x = i;\n"
" break;\n"
" }\n"
" }\n"
"\n"
" return x;\n"
"}");
ASSERT_EQUALS("[test.cpp:11]: (error) Uninitialized variable: x\n", errout.str());
Fixed #2796 (uninitialized and leaving scope)
2011-07-25 16:35:30 +02:00
// Ticket #2796
checkUninitVar("void foo() {\n"
" while (true) {\n"
" int x;\n"
" if (y) x = 0;\n"
" else break;\n"
" return x;\n" // <- x is initialized
" }\n"
"}");
ASSERT_EQUALS("", errout.str());
Add tests for various bugs. False positive: uninitialized variable (ticket #3287). False positive: null pointer dereference in typeid (ticket #3290).
2011-11-04 09:49:49 +01:00
// Assignment in for. Ticket #3287
checkUninitVar("int foo(char* in, bool b) {\n"
" char* c;\n"
" if (b) for (c = in; *c == 0; ++c) {}\n"
" else c = in + strlen(in) - 1;\n"
" *c = 0;\n"
"}\n");
TODO_ASSERT_EQUALS("", "[test.cpp:5]: (error) Uninitialized variable: c\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
// switch..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_switch() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f(int x)\n"
"{\n"
" short c;\n"
" switch(x) {\n"
" case 1:\n"
" c++;\n"
" break;\n"
" };\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: c\n", errout.str());
checkUninitVar("char * f()\n"
"{\n"
" static char ret[200];\n"
" memset(ret, 0, sizeof(ret));\n"
" switch (x)\n"
" {\n"
" case 1: return ret;\n"
" case 2: return ret;\n"
" }\n"
" return 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo(const int iVar, unsigned int slot, unsigned int pin)\n"
"{\n"
" int i;\n"
"\n"
" if (iVar == 0)\n"
" {\n"
" switch (slot)\n"
" {\n"
" case 4: return 5;\n"
" default: return -1;\n"
" }\n"
" }\n"
" else\n"
" {\n"
" switch (pin)\n"
" {\n"
" case 0: i = 2; break;\n"
" default: i = -1; break;\n"
" }\n"
" }\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
// No segmentation fault
checkUninitVar("void a() try\n"
"{\n"
" {\n"
" while (1) {\n"
" switch (1) {\n"
" case 1: {\n"
" int i;\n"
" }\n"
" }\n"
" }\n"
" } catch (...) {\n"
" }\n"
"}\n");
// #1855 - switch(foo(&x))
checkUninitVar("int a()\n"
"{\n"
" int x;\n"
" switch (foo(&x))\n"
" {\n"
" case 1:\n"
" return x;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3231 (False positive: uninitialized variable '({...})')
2011-10-30 18:19:09 +01:00
// #3231 - ({ switch .. })
checkUninitVar("void f() {\n"
" int a;\n"
" ({\n"
" switch(sizeof(int)) {\n"
" case 4:\n"
" default:\n"
" (a)=0;\n"
" break;\n"
" };\n"
" })\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
// arrays..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_arrays() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("int f()\n"
"{\n"
" char a[10];\n"
" a[a[0]] = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("int f()\n"
"{\n"
" char a[10];\n"
" char c = *a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
Fixed #2185 (False negative: when constant is undefined a 'dangerous usage of strncpy' is not found)
2010-11-10 20:20:05 +01:00
checkUninitVar("int f()\n"
"{\n"
" char a[SIZE+10];\n"
" char c = *a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("int f()\n"
"{\n"
" char a[10];\n"
" *a = '\\0';\n"
" int i = strlen(a);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char a, b[10];\n"
" a = b[0] = 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char a[10], b[10];\n"
" a[0] = b[0] = 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char a[10], *p;\n"
" *(p = a) = 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2764 (False positive: Uninitialized variable '&(x[0])')
2011-05-05 21:26:18 +02:00
checkUninitVar("void f() {\n"
" char a[10], *p;\n"
" p = &(a[10]);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char c[50] = \"\";\n"
" strcat(c, \"test\");\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char s[20];\n"
" strcpy(s2, s);\n"
"};\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char s[20];\n"
" strcat(s, \"abc\");\n"
"};\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char s[20];\n"
" strchr(s, ' ');\n"
"};\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" int y[2];\n"
" int s;\n"
Unit test cleanup: Removed some empty lines and whitespaces before \n.
2012-12-06 19:19:22 +01:00
" GetField( y + 0, y + 1 );\n"
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
" s = y[0]*y[1];\n"
"}\n");
Fixed #2188 (Does not detect initialization)
2010-11-12 16:11:44 +01:00
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" int a[2];\n"
" init(a - 1);\n"
" int b = a[0];\n"
"}\n");
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
ASSERT_EQUALS("", errout.str());
Fixed #2306 (False positive: array of std::string is reported as uninitialized)
2010-12-17 21:20:04 +01:00
checkUninitVar("void foo()\n"
"{\n"
" Fred a[2];\n"
" Fred b = a[0];\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2320 (false positive: Uninitialized variable: kbuf)
2010-12-18 10:06:21 +01:00
// Ticket #2320
checkUninitVar("void foo() {\n"
" char a[2];\n"
" char *b = (a+2) & 7;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized vars: handle printf a little better. Ticket: #3050
2011-09-05 20:18:58 +02:00
checkUninitVar("void f() {\n" // Ticket #3050
" char a[2];\n"
" printf(\"%s\", a);\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
Fixed #3497 (False positive: Uninitialized variable)
2012-01-13 07:26:56 +01:00
checkUninitVar("void f() {\n" // Ticket #3497
" char header[1];\n"
" *((unsigned char*)(header)) = 0xff;\n"
" return header[0];\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3497 (False positive: Uninitialized variable)
2012-01-21 20:42:41 +01:00
checkUninitVar("void f() {\n" // Ticket #3497
" char header[1];\n"
" *((unsigned char*)((unsigned char *)(header))) = 0xff;\n"
" return header[0];\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3666 (False positive: Uninitialized variable (taking address))
2012-03-16 17:28:05 +01:00
checkUninitVar("void f() {\n"
" ABC abc;\n"
" int a[1];\n"
"\n"
" abc.a = a;\n"
" init(&abc);\n"
" return a[0];\n"
"}");
ASSERT_EQUALS("", errout.str());
#3344 added missing testcase
2012-04-26 13:37:13 +02:00
// ticket #3344
checkUninitVar("void f(){\n"
" char *strMsg = \"This is a message\";\n"
" char *buffer=(char*)malloc(128*sizeof(char));\n"
" strcpy(strMsg,buffer);\n"
" free(buffer);\n"
"}\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: buffer\n", errout.str());
Fixed #3845
2012-05-25 16:28:32 +02:00
// #3845
checkUninitVar("int foo() {\n"
" int a[1] = {5};\n"
" return a[0];\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo() {\n"
" int a[2][2] = {{3,4}, {5,6}};\n"
" return a[0][1];\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo() {\n"
" int a[1];\n"
" return a[0];\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("int foo() {\n"
" int a[2][2];\n"
" return a[0][1];\n"
"}");
TODO_ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", "", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
// alloc..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_alloc() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char *s = malloc(100);\n"
" strcat(s, \"abc\");\n"
"};\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: s\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
Improved parsing of functions that accept nullpointers but no uninitialized data (Fixed #3811)
2012-05-16 09:56:39 +02:00
checkUninitVar("void f()\n"
"{\n"
" char *s = malloc(100);\n"
" perror(s);\n"
"};");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: s\n", errout.str());
Improved parsing of functions that accept nullpointers but no uninitialized data (Fixed #3811)
2012-05-16 09:56:39 +02:00
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char *s1 = new char[10];\n"
" char *s2 = new char[strlen(s1)];\n"
"};\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: s1\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char *p = malloc(64);\n"
" int x = p[0];\n"
"}\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: p\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char *p = malloc(64);\n"
" if (p[0]) { }\n"
"}\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: p\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char *p = malloc(64);\n"
" return p[0];\n"
"}\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Memory is allocated but not initialized: p\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" Fred *fred = new Fred;\n"
" fred->foo();\n"
"};\n");
ASSERT_EQUALS("", errout.str());
Fixed #2202 (false postive: Data is allocated but not initialized: rbdc)
2010-11-15 17:11:08 +01:00
checkUninitVar("void f()\n"
"{\n"
" Fred *fred = malloc(sizeof(Fred));\n"
" x(&fred->f);\n"
"};\n");
ASSERT_EQUALS("", errout.str());
Fixed #2218 (False positive: Data is allocated but not initialized)
2010-11-27 17:34:54 +01:00
checkUninitVar("void f()\n"
"{\n"
" Fred *fred = malloc(sizeof(Fred));\n"
" x(fred->f);\n"
"};\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void foo(char *s)\n"
"{\n"
" char *a = malloc(100);\n"
" *a = *s;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" char *a;\n"
" if (a);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" char *a = malloc(100);\n"
" if (a);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" ABC *abc = malloc(100);\n"
" abc->a = 123;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" ABC *abc = malloc(100);\n"
" abc->a.word = 123;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" ABC *abc = malloc(100);\n"
" abc->a = 123;\n"
" abc->a += 123;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" ABC *abc = malloc(100);\n"
" free(abc);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" char *s = malloc(100);\n"
" if (!s)\n"
" return;\n"
" char c = *s;\n"
"};\n");
Message refactorization: checkuninitvar.cpp, checkunusedfunctions.cpp, checkunusedvar.cpp
2012-11-01 18:40:20 +01:00
ASSERT_EQUALS("[test.cpp:6]: (error) Memory is allocated but not initialized: s\n", errout.str());
Fixed #3708 (False positive: uninitialized variable (allocation, unknown nonpointer type))
2012-05-14 18:34:39 +02:00
// #3708 - false positive when using ptr typedef
checkUninitVar("void f() {\n"
" uintptr_t x = malloc(100);\n"
" uintptr_t y = x + 10;\n" // <- not bad usage
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
// class / struct..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_class() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("class Fred\n"
"{\n"
" int i;\n"
" int a() { return i; }\n"
"};\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" struct Relative {\n"
" Surface *surface;\n"
" void MoveTo(int x, int y) {\n"
" surface->MoveTo();\n"
" }\n"
" };\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" static const struct ab {\n"
" int a,b;\n"
" int get_a() { return a; }"
" } = { 0, 0 };\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" int i;\n"
" {\n"
" union ab {\n"
" int a,b;\n"
" }\n"
" i = 0;\n"
" }\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2265 (False positive: Uninitialized variable: path)
2010-11-30 18:40:36 +01:00
checkUninitVar("void f(int x) {\n"
" struct AB ab;\n"
" x = ab.x = 12;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
// enum..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_enum() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" enum AB { a, b };\n"
" AB ab;\n"
" if (ab);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: ab\n", errout.str());
}
// references..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_references() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" int a;\n"
" int &b = a;\n"
" b = 0;\n"
" int x = a;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f(struct blame_entry *ent)\n"
"{\n"
" struct origin *suspect = ent->suspect;\n"
" char hex[41];\n"
" strcpy(hex, sha1_to_hex(suspect->commit->object.sha1));\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" const std::string s(x());\n"
" strchr(s.c_str(), ',');\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
Refactoring TestUninitVar. Created TestUninitVar::uninitvar_return
2012-06-23 16:27:57 +02:00
void uninitvar_return() {
checkUninitVar("static int foo()\n"
"{\n"
" int ret;\n"
" return ret;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: ret\n", errout.str());
checkUninitVar("static int foo()\n"
"{\n"
" int ret;\n"
" return ret+5;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: ret\n", errout.str());
checkUninitVar("static int foo() {\n"
" int ret;\n"
" return ret = 5;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
{
checkUninitVar("static int foo() {\n"
" int ret;\n"
" return cin >> ret;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("static int foo() {\n"
" int ret;\n"
" return cin >> ret;\n"
"}\n", "test.c");
ASSERT_EQUALS("[test.c:3]: (error) Uninitialized variable: ret\n", errout.str());
}
// Ticket #2146 - False negative
checkUninitVar("int f(int x) {\n"
" int y;\n"
" return x ? 1 : y;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2]: (error) Uninitialized variable: y\n", errout.str());
// Ticket #3106 - False positive
{
checkUninitVar("int f() {\n"
" int i;\n"
" return x(&i) ? i : 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int f() {\n"
" int i;\n"
" return x() ? i : 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: i\n", errout.str());
}
}
Message refactorization: Changed expression "0-terminate" to "null-terminate" as discussed on 24b98feadb9ddfc319b86a8d9e78d985f9d4b50b
2012-11-03 21:21:19 +01:00
// strncpy doesn't always null-terminate..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_strncpy() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char a[100];\n"
" strncpy(a, s, 20);\n"
" strncat(a, s, 20);\n"
"}\n");
Message refactorization: Changed expression "0-terminate" to "null-terminate" as discussed on 24b98feadb9ddfc319b86a8d9e78d985f9d4b50b
2012-11-03 21:21:19 +01:00
ASSERT_EQUALS("[test.cpp:5]: (error) Dangerous usage of 'a' (strncpy doesn't always null-terminate it).\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char a[100];\n"
" strncpy(a, \"hello\", 3);\n"
" strncat(a, \"world\", 20);\n"
"}\n");
Message refactorization: Changed expression "0-terminate" to "null-terminate" as discussed on 24b98feadb9ddfc319b86a8d9e78d985f9d4b50b
2012-11-03 21:21:19 +01:00
ASSERT_EQUALS("[test.cpp:5]: (error) Dangerous usage of 'a' (strncpy doesn't always null-terminate it).\n", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" char a[100];\n"
" strncpy(a, \"hello\", sizeof(a));\n"
" strncat(a, \"world\", 20);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3245 (False positive: Dangerous usage of 'string' (strncpy doesn't always 0-terminate it))
2011-10-29 19:11:42 +02:00
// #3245 - false positive
{
checkUninitVar("void f() {\n"
" char a[100];\n"
" strncpy(a,p,10);\n"
" memcmp(a,q,10);\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f() {\n"
" char a[100];\n"
" strncpy(a,p,10);\n"
" if (memcmp(a,q,10)==0);\n"
"}");
ASSERT_EQUALS("", errout.str());
}
Uninitialized variables: Fixed false 'dangerous usage of strncpy' positive when resulting string is used by strncpy
2011-12-23 08:44:28 +01:00
// Using strncpy isn't necessarily dangerous usage
checkUninitVar("void f(const char dev[], char *str) {\n"
" char buf[10];\n"
" strncpy(buf, dev, 10);\n"
" strncpy(str, buf, 10);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
uninitstring: fix false negatives when non-zero memset is used. Ticket: #3050
2011-09-05 19:42:48 +02:00
// initialization with memset (not 0-terminating string)..
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_memset() {
uninitstring: fix false negatives when non-zero memset is used. Ticket: #3050
2011-09-05 19:42:48 +02:00
checkUninitVar("void f() {\n"
" char a[20];\n"
" memset(a, 'a', 20);\n"
" strcat(a, s);\n"
"}\n");
Message refactorization: Changed expression "0-terminate" to "null-terminate" as discussed on 24b98feadb9ddfc319b86a8d9e78d985f9d4b50b
2012-11-03 21:21:19 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Dangerous usage of 'a' (not null-terminated).\n", errout.str());
uninitstring: fix false negatives when non-zero memset is used. Ticket: #3050
2011-09-05 19:42:48 +02:00
}
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
std::string analyseFunctions(const char code[]) {
Tokenizer: add assert(_settings) to Tokenizer to insure the tokenizer always has settings. Ticket: #2219
2010-12-01 18:00:55 +01:00
// Clear the error buffer..
errout.str("");
Settings settings;
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// Tokenize..
Tokenizer: add assert(_settings) to Tokenizer to insure the tokenizer always has settings. Ticket: #2219
2010-12-01 18:00:55 +01:00
Tokenizer tokenizer(&settings, this);
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
std::istringstream istr(code);
tokenizer.tokenize(istr, "test.cpp");
std::set<std::string> f;
const CheckUninitVar check((const Tokenizer *)0, (const Settings *)0, (ErrorLogger *)0);
check.analyse(tokenizer.tokens(), f);
std::string ret;
for (std::set<std::string>::const_iterator it = f.begin(); it != f.end(); ++it)
ret += (ret.empty() ? "" : " ") + *it;
return ret;
}
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_func() {
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// function analysis..
ASSERT_EQUALS("foo", analyseFunctions("void foo(int x) { }"));
Fixed #2148 (uninitialized variable: false negative, function parameter that is passed by value)
2010-11-12 17:06:14 +01:00
ASSERT_EQUALS("foo", analyseFunctions("void foo(int x);"));
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
ASSERT_EQUALS("foo", analyseFunctions("void foo(const int &x) { }"));
ASSERT_EQUALS("foo", analyseFunctions("void foo(int &x) { ++x; }"));
replaced tabs with spaces
2012-09-05 19:46:44 +02:00
ASSERT_EQUALS("rename", analyseFunctions("int rename (const char* oldname, const char* newname);")); // Ticket #914
Fixed #914 (improve check: usage of uninitialized variable)
2010-11-12 17:14:37 +01:00
ASSERT_EQUALS("rename", analyseFunctions("int rename (const char oldname[], const char newname[]);"));
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
ASSERT_EQUALS("", analyseFunctions("void foo(int &x) { x = 0; }"));
ASSERT_EQUALS("", analyseFunctions("void foo(s x) { }"));
Fixed #2946 (False positive: Uninitialized buffer variable (init in subfunction))
2011-07-27 10:34:12 +02:00
// TODO: it's ok to pass a valid pointer to "foo". See #2775 and #2946
TODO_ASSERT_EQUALS("foo", "", analyseFunctions("void foo(Fred *fred) { fred->x = 0; }"));
ASSERT_EQUALS("", analyseFunctions("void foo(int *x) { x[0] = 0; }"));
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// function calls..
checkUninitVar("void assignOne(int &x)\n"
"{ x = 1; }\n"
"\n"
"int f()\n"
"{\n"
" int i;\n"
" assignOne(i);\n"
" return i;\n"
"};\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int f(int (*assign)(int *p))\n"
"{\n"
" int i;\n"
" (*assign)(&i);\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int f()\n"
"{\n"
" char s[10];\n"
" return bar(s);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f()\n"
"{\n"
" FILE *f;\n"
" fflush(f);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: f\n", errout.str());
Uninitialized variables: Fixed false negatives when calling unknown function with uninitialized variable by value: 'f(a+1)'
2010-11-13 15:10:17 +01:00
checkUninitVar("void f()\n"
"{\n"
" int i;\n"
" x(i+2);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
Fixed #2196 (False positive: Invalid data is allocated but not initialized (initialization in loop))
2010-11-13 10:33:35 +01:00
checkUninitVar("void f()\n"
"{\n"
" char *p = malloc(10);\n"
" read(p + 1);\n"
" return p;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
checkUninitVar("void f()\n"
"{\n"
" Abc *p;\n"
" int sz = sizeof(*p);\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" Foo *p;\n"
" x = bar(sizeof(*p));\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void foo()\n"
"{\n"
" Foo *p;\n"
" x = bar(p->begin());\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("int foo(int x) { return x; }\n"
"void f2()\n"
"{\n"
" int x;\n"
" foo(x);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: x\n", errout.str());
checkUninitVar("void foo(const char *s)\n"
"{\n"
" char *p;\n"
" memcpy(p, s, 100);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
checkUninitVar("void foo(const char *s)\n"
"{\n"
" char *p = malloc(100);\n"
" memcpy(p, s, 100);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Passing uninitialized array as parameter to function. Ticket: #2188
2010-11-12 17:38:25 +01:00
checkUninitVar("int calc(const int *p, int n);\n"
"void f() {\n"
" int x[10];\n"
" calc(x,10);\n"
"}\n");
Fixed #2526 (Make TODO_ASSERT_EQUALS take three arguments (value, to_be, as_is)?... Removed replaced EXPECTED with... WANTED (to-be): The future expected value. CURRENT (as-is): Documenting how cppcheck behaves now. This removes the need for an ASSERT_EQUALS but enforces the check for every TODO_ASSERT_EQUALS.
2011-01-30 12:54:19 +01:00
TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n",
"", errout.str());
Uninitialized variables: Passing uninitialized array as parameter to function. Ticket: #2188
2010-11-12 17:38:25 +01:00
Fixed #2401 (false positive: Uninitialized variable: result)
2011-01-05 20:44:04 +01:00
// #2401 - unknown function/macro might init the variable
checkUninitVar("int f() {\n"
" int x;\n"
" INIT(x);\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3222 (false positive: Uninitialized variable with function pointer)
2011-10-30 17:22:30 +01:00
// #3222 - calling function through function pointer
checkUninitVar("char f() {\n"
" char buffer[100];\n"
" (foo.init)(buffer);\n"
" return buffer[0];\n"
"}");
ASSERT_EQUALS("", errout.str());
Fixed #3586 (false positive: uninitvar in argument in namespaced function)
2012-09-15 10:48:17 +02:00
checkUninitVar("void f() {\n" // #3586 - calling template function
" int i;\n"
" a::b<int>(i);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
// using uninitialized function pointer..
checkUninitVar("void foo()\n"
"{\n"
" void (*f)();\n"
" f();\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: f\n", errout.str());
// calling noreturn function..
checkUninitVar("int foo(int a) {\n"
" int x;\n"
" if (a==1)\n"
" g();\n" // might be a noreturn function
" else\n"
" x = 3;\n"
" return x;\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("int foo(int a) {\n"
" int x;\n"
" if (a==1)\n"
" g(1);\n" // might be a noreturn function
" else\n"
" x = 3;\n"
" return x;\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void (*init)(char *str);\n"
"\n"
"char x() {\n"
" char cmd[10];\n"
" init(cmd);\n"
" return cmd[0];\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2533 (false positive: (error) Uninitialized variable: cBuffer)
2011-02-03 22:29:32 +01:00
checkUninitVar("char fn(FILE *f) {\n"
" char buf[10];\n"
" fread(buf, 1, 10, f);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2775 (Uninitialized variable: Not detected when uninitialized struct pointer is dereferenced in sub function)
2011-07-04 21:04:32 +02:00
// #2775 - uninitialized struct pointer in subfunction
checkUninitVar("void a(struct Fred *fred) {\n"
" fred->x = 0;\n"
"}\n"
"\n"
"void b() {\n"
" struct Fred *p;\n"
" a(p);\n"
"}\n");
Fixed #2946 (False positive: Uninitialized buffer variable (init in subfunction))
2011-07-27 10:34:12 +02:00
// TODO: See #2946
TODO_ASSERT_EQUALS("[test.cpp:7]: (error) Uninitialized variable: p\n", "", errout.str());
// #2946 - FP array is initialized in subfunction
checkUninitVar("void a(char *buf) {\n"
" buf[0] = 0;\n"
"}\n"
"void b() {\n"
" char buf[10];\n"
" a(buf);\n"
" buf[1] = buf[0];\n"
"}");
ASSERT_EQUALS("", errout.str());
Fixed #3159 (Uninitialized variable false positive)
2011-10-02 20:38:58 +02:00
// #3159 - initialization by function
checkUninitVar("static int isnumber(const char *arg) {\n"
" char *p;\n"
" return strtod(arg, &p) != 0 || p != arg;\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("static int isnumber(const char *arg) {\n"
" char *p;\n"
" return strtod(&arg) != 0 || p != arg;\n"
"}");
TODO_ASSERT_EQUALS("error", "", errout.str());
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
}
Fixed #2367 (false positive: (error) Uninitialized variable: s)
2010-12-27 21:05:33 +01:00
fix
2011-02-26 20:08:37 +01:00
// valid and invalid use of 'int a(int x) { return x + x; }'
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void func_uninit_var() {
fix
2011-02-26 20:08:37 +01:00
const std::string funca("int a(int x) { return x + x; }\n");
checkUninitVar((funca +
"void b() {\n"
" int x;\n"
" a(x);\n"
"}").c_str());
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
checkUninitVar((funca +
"void b() {\n"
" int *p;\n"
" a(*p);\n"
"}").c_str());
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
}
Uninitialized variables: Added TODO test case
2011-02-12 12:42:16 +01:00
// valid and invalid use of 'void a(int *p) { *p = 0; }'
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void func_uninit_pointer() {
Uninitialized variables: Added TODO test case
2011-02-12 12:42:16 +01:00
const std::string funca("void a(int *p) { *p = 0; }\n");
// ok - initialized pointer
checkUninitVar((funca +
"void b() {\n"
" int buf[10];\n"
" a(buf);\n"
"}\n").c_str());
ASSERT_EQUALS("", errout.str());
// not ok - uninitialized pointer
checkUninitVar((funca +
"void b() {\n"
" int *p;\n"
" a(p);\n"
"}\n").c_str());
fix
2011-02-26 20:08:37 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
Uninitialized variables: Added TODO test case
2011-02-12 12:42:16 +01:00
}
changed the astyle formatting flags
2011-10-13 20:53:06 +02:00
void uninitvar_typeof() {
Fixed #2367 (false positive: (error) Uninitialized variable: s)
2010-12-27 21:05:33 +01:00
checkUninitVar("void f() {\n"
" struct Fred *fred;\n"
" typeof(fred->x);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2367 (false positive: (error) Uninitialized variable: s)
2010-12-27 21:18:36 +01:00
checkUninitVar("void f() {\n"
" struct SData * s;\n"
" ab(typeof(s->status));\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: typeof doesn't dereference. Ticket: #2367
2010-12-30 21:30:46 +01:00
checkUninitVar("void f() {\n"
" struct SData * s;\n"
" TYPEOF(s->status);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #2367 (false positive: (error) Uninitialized variable: s)
2010-12-27 21:05:33 +01:00
}
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
/** New checking that doesn't rely on ExecutionPath */
Uninitialized variables: better handling of initialization with >>. Ticket: #3369
2011-12-15 16:55:55 +01:00
void checkUninitVar2(const char code[], const char fname[] = "test.cpp") {
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
// Clear the error buffer..
errout.str("");
Settings settings;
// Tokenize..
Tokenizer tokenizer(&settings, this);
std::istringstream istr(code);
Uninitialized variables: better handling of initialization with >>. Ticket: #3369
2011-12-15 16:55:55 +01:00
tokenizer.tokenize(istr, fname);
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
tokenizer.simplifyTokenList();
// Check for redundant code..
CheckUninitVar checkuninitvar(&tokenizer, &settings, this);
checkuninitvar.check();
}
void uninitvar2() {
Uninitialized variables: improved check to detect more errors. Ticket: #3369
2011-12-14 06:00:17 +01:00
// using uninit var
checkUninitVar2("void f() {\n"
" int x;\n"
" x++;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: Detect more errors when variable is given as array index. Ticket: #3369
2011-12-14 19:56:58 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" str[x] = 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: improved check to detect more errors. Ticket: #3369
2011-12-14 06:00:17 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" int y = x & 3;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: Detect more errors. Ticket: #3369
2011-12-14 18:28:30 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" int y = 3 & x;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: check more variables
2011-12-26 14:01:46 +01:00
checkUninitVar2("void f() {\n"
" struct ABC *abc;\n"
" abc->a = 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: abc\n", errout.str());
Uninitialized variables: Fixed false positives (caused by my 'check more variables' commit)
2011-12-26 22:14:52 +01:00
checkUninitVar2("int f() {\n"
" static int x;\n"
" return ++x;\n"
"}");
ASSERT_EQUALS("", errout.str());
Fixed #3919 (False positive: uninitialized variable (extern))
2012-06-26 18:28:41 +02:00
checkUninitVar2("int f() {\n"
" extern int x;\n"
" return ++x;\n"
"}");
ASSERT_EQUALS("", errout.str());
Fixed #3926 (false postive: (error) Uninitialized variable: exitpattern)
2012-07-03 18:52:23 +02:00
checkUninitVar2("void f() {\n" // #3926 - weird cast.
" int x;\n"
" *(((char *)&x) + 0) = 0;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Detect more errors. Ticket: #3369
2011-12-14 18:28:30 +01:00
// using uninit var in condition
checkUninitVar2("void f() {\n"
" int x;\n"
" if (1 == (3 & x)) { }\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: x\n", errout.str());
Fixed #3463 (Uninitialized variable variable pointer)
2012-01-02 11:25:13 +01:00
// ?:
checkUninitVar2("int f(int *ptr) {\n"
" int a;\n"
" int *p = ptr ? ptr : &a;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positive when address of variable is taken inside = { .. }. Ticket: #3369
2011-12-17 07:56:46 +01:00
// = { .. }
checkUninitVar2("int f() {\n"
" int a;\n"
" int *p[] = { &a };\n"
" *p[0] = 0;\n"
" return a;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: better handling of initialization with >>. Ticket: #3369
2011-12-15 16:55:55 +01:00
// >> => initialization / usage
{
const char code[] = "void f() {\n"
" int x;\n"
" if (i >> x) { }\n"
"}";
checkUninitVar2(code, "test.cpp");
ASSERT_EQUALS("", errout.str());
checkUninitVar2(code, "test.c");
ASSERT_EQUALS("[test.c:3]: (error) Uninitialized variable: x\n", errout.str());
}
Fixed #3423 (Uninitialized variable in operator>>)
2011-12-16 20:34:44 +01:00
checkUninitVar2("void f() {\n"
" int i, i2;\n"
" strm >> i >> i2;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives for unconditional inner scopes
2011-12-26 17:52:32 +01:00
// unconditional initialization
checkUninitVar2("int f() {\n"
" int ret;\n"
" if (a) { ret = 1; }\n"
" else { {} ret = 2; }\n"
" return ret;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: improved check to detect more errors. Ticket: #3369
2011-12-14 06:00:17 +01:00
// conditional initialization
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" if (y == 1) { x = 1; }\n"
" else if (y == 2) { x = 1; }\n"
" return x;\n"
"}\n");
Uninitialized variables: Improved checking when there are multiple if/else and a certain path causes an error
2011-12-26 12:36:35 +01:00
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: x\n", errout.str());
checkUninitVar2("void f() {\n"
" int x;\n"
" if (y == 1) { x = 1; }\n"
" else if (y == 2) { x = 1; }\n"
" if (y == 3) { }\n" // <- ignore condition
" return x;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
Uninitialized variables: Fixed false positive in new checking when variable is initialized in condition
2011-12-14 17:17:24 +01:00
// initialization in condition
checkUninitVar2("void f() {\n"
" int a;\n"
" if (init(&a)) { }\n"
" a++;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives when goto is used.
2011-12-26 16:46:10 +01:00
// return, break, continue, goto
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" if (y == 1) { return; }\n"
" else { x = 1; }\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed TODO testcase
2012-11-29 18:41:48 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" if (y == 1) { return; }\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variable: Fixed test failure. Ticket: #3369
2011-12-15 20:15:37 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" return;\n"
"err:\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: handle unsimplified labels better
2012-12-25 10:37:21 +01:00
checkUninitVar2("int f(int x) {\n"
" int ret;\n"
" if (!x) {\n"
" ret = -123;\n"
" goto out1;\n"
" }\n"
" return 0;\n"
"out1:\n"
"out2:\n"
" return ret;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives when goto is used.
2011-12-26 16:46:10 +01:00
checkUninitVar2("void f() {\n"
" int i;\n"
" if (x) {\n"
" i = 1;\n"
" } else {\n"
" goto out;\n"
" }\n"
" i++;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fix false positives related to for loop
2011-12-27 08:18:05 +01:00
checkUninitVar2("int f() {\n"
" int i,x;\n"
" for (i=0;i<9;++i)\n"
" if (foo) break;\n"
" return x;\n"
"}\n");
Uninitialized variables: Fixed TODO testcase
2012-11-29 18:41:48 +01:00
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: Fix false positives related to for loop
2011-12-27 08:18:05 +01:00
Uninitialized variables: Fixed false negative in new checking when using while loops
2012-11-30 06:30:04 +01:00
checkUninitVar2("int f() {\n"
" int x;\n"
" while (foo)\n"
" if (bar) break;\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variables: Fixed false positives for loops. Ticket: #3369
2011-12-14 18:54:03 +01:00
// for, while
checkUninitVar2("void f() {\n"
" int x;\n"
" while (a) {\n"
" if (b) x++;\n"
" else x = 0;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positive in for condition. Ticket: #3369
2011-12-15 20:48:26 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" for (int i = 0; i < 10; i += x) {\n"
" x = y;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variable: added TODO test case. Ticket: #3369
2011-12-15 20:55:37 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
Uninitialized variables: Fix false positives related to for loop
2011-12-27 08:18:05 +01:00
" for (int i = 0; i < 10; i += x) { }\n"
Uninitialized variable: added TODO test case. Ticket: #3369
2011-12-15 20:55:37 +01:00
"}\n");
Uninitialized variables: Fixed false positives caused by recent commit when potentially uninitialized variable is read in condition
2011-12-26 18:32:42 +01:00
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: x\n", errout.str());
Uninitialized variable: added TODO test case. Ticket: #3369
2011-12-15 20:55:37 +01:00
Uninitialized variables: Fix false positives related to for loop
2011-12-27 08:18:05 +01:00
checkUninitVar2("int f() {\n"
" int i;\n"
" for (i=0;i<9;++i)\n"
" if (foo()) goto out;\n"
"out:\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #4175 (segmentation fault of cppcheck)
2012-09-09 18:56:26 +02:00
checkUninitVar2(">{ x while (y) z int = }"); // #4175 : don't crash
Fixed #3414 (false positive: (error) Uninitialized variable: SOutput)
2011-12-15 18:30:59 +01:00
// try
checkUninitVar2("void f() {\n"
" int i, *p = &i;\n"
" try { }\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives for break/continue/throw
2011-12-14 05:45:52 +01:00
// exit
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
checkUninitVar2("void f() {\n"
" int x;\n"
" if (y == 1) { exit(0); }\n"
" else { x = 1; }\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3415 (Segmentation fault in new check for uninitialized variables)
2011-12-15 16:49:14 +01:00
// strange code.. don't crash (#3415)
checkUninitVar2("void foo() {\n"
" int i;\n"
" ({ if (0); });\n"
" for_each(i) { }\n"
"}");
ASSERT_EQUALS("", errout.str());
Fixed #3417 (False positive: Uninitialized variable when conditionally set)
2011-12-15 18:15:58 +01:00
// if, if
checkUninitVar2("void f(int a) {\n"
" int i;\n"
" if (a) i = 0;\n"
" if (a) i++;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives when there are assembler code. Ticket: #3369
2011-12-15 20:29:57 +01:00
Uninitialized variables: Fixed false positives when many 'if' are used. Ticket: #3369
2011-12-16 19:56:13 +01:00
checkUninitVar2("void f() {\n"
" int a,b=0;\n"
" if (x) {\n"
" if (y) {\n"
" a = 0;\n"
" b = 1;\n"
" }\n"
" }\n"
" if (b) a++;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives caused by recent improvement when variable is potentially initialized in else block.
2011-12-26 18:17:13 +01:00
checkUninitVar2("void f() {\n"
" int a=0, b;\n"
" if (x) { }\n"
" else if (y==2) { a=1; b=2; }\n"
" if (a) { ++b; }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives caused by recent commit when potentially uninitialized variable is read in condition
2011-12-26 18:32:42 +01:00
checkUninitVar2("static void f(int x, int y) {\n"
" int a;\n"
" if (x == 0) { a = y; }\n"
" if (x == 0 && (a == 1)) { }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("static void f(int x, int y) {\n"
" int a;\n"
" if (x == 0 && (a == 1)) { }\n"
"}\n");
Uninitialized variables: Better handling of variable usage in condition
2011-12-26 18:56:40 +01:00
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
Uninitialized variables: Fixed false positives caused by recent commit when potentially uninitialized variable is read in condition
2011-12-26 18:32:42 +01:00
Uninitialized variables: Fixed false positives for such code: 'if (cond1) { a=0; } if (cond1) { if (cond2) { use_a; } }'
2011-12-27 13:16:16 +01:00
checkUninitVar2("void f() {\n"
" int a;\n"
" if (x) { a = 0; }\n"
" if (x) { if (y) { a++; } }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("void f() {\n"
" int a;\n"
" if (x) { a = 0; }\n"
" if (x) { if (y) { } else { a++; } }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives when there are assembler code. Ticket: #3369
2011-12-15 20:29:57 +01:00
// asm
checkUninitVar2("void f() {\n"
" int x;\n"
" asm();\n"
" x++;\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives in sizeof. Ticket: #3369
2011-12-17 09:51:45 +01:00
Uninitialized variables: Fixed false positives when using typeof()
2011-12-27 17:03:48 +01:00
// sizeof / typeof / offsetof / etc
Uninitialized variables: Fixed false positives in sizeof. Ticket: #3369
2011-12-17 09:51:45 +01:00
checkUninitVar2("void f() {\n"
" int i;\n"
" sizeof(i+1);\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives when sizeof is used in condition. Ticket: #3369
2011-12-17 16:08:55 +01:00
checkUninitVar2("void f() {\n"
" int i;\n"
" if (100 == sizeof(i+1));\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives when pointer is dereferenced in unexpanded macro
2011-12-27 10:18:49 +01:00
checkUninitVar2("void f() {\n"
" struct ABC *abc;\n"
" int i = ARRAY_SIZE(abc.a);"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Fixed false positives when using typeof()
2011-12-27 17:03:48 +01:00
checkUninitVar2("void f() {\n"
" int *abc;\n"
" typeof(*abc);\n"
"}");
ASSERT_EQUALS("", errout.str());
Fixed ticket #3486 (segmentation fault of cppcheck)
2012-01-13 23:30:43 +01:00
Uninitialized variables: Fixed FP when using typeof on uninitialized data in return statement
2012-12-25 13:31:54 +01:00
checkUninitVar2("void f() {\n"
" struct ABC *abc;\n"
" return do_something(typeof(*abc));\n"
"}");
ASSERT_EQUALS("", errout.str());
Fixed ticket #3486 (segmentation fault of cppcheck)
2012-01-13 23:30:43 +01:00
// Ticket #3486 - Don't crash garbage code
checkUninitVar2("void f()\n"
"{\n"
" (\n"
" x;\n"
" int a, a2, a2*x; if () ;\n"
" )\n"
"}\n");
Fixed #3890 (False positive Uninitialized variable on returning default value on a class member)
2012-06-19 20:04:10 +02:00
// Ticket #3890 - False positive for std::map
checkUninitVar2("void f() {\n"
" std::map<int,bool> x;\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3906 (false positive uninitvar for vector pointer)
2012-06-22 16:26:43 +02:00
// Ticket #3906 - False positive for std::vector pointer
checkUninitVar2("void f() {\n"
" std::vector<int> *x = NULL;\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #4426 (False positive: Unitialized variable warning when comparing addresses)
2012-12-28 12:32:15 +01:00
// &
checkUninitVar2("void f() {\n" // #4426 - address of uninitialized variable
" int a,b;\n"
" if (&a == &b);\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Started writing a new check. Ticket: #3369
2011-12-13 21:57:27 +01:00
}
Fixed #3869 (References to items in array result it 'Uninitialized variable' errors)
2012-06-08 16:17:55 +02:00
// #3869 - reference variable
void uninitvar4() {
checkUninitVar2("void f() {\n"
" int buf[10];\n"
" int &x = buf[0];\n"
" buf[0] = 0;\n"
" x++;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
Fixed #3861 (uninitialized variables)
2012-06-13 19:09:51 +02:00
// #3861
void uninitvar5() {
// ensure there is no false positive
checkUninitVar2("void f() {\n"
" x<char> c;\n"
" c << 2345;\n"
"}");
ASSERT_EQUALS("", errout.str());
// ensure there is no false negative
checkUninitVar2("void f() {\n"
" char c;\n"
" char a = c << 2;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: c\n", errout.str());
Fixed #4320 (False positives 'unassignedVariable' and 'uninitvar')
2012-12-18 19:02:30 +01:00
// #4320
checkUninitVar2("void f() {\n"
" int a;\n"
" a << 1;\n" // there might be a operator<<
"}\n");
ASSERT_EQUALS("", errout.str());
Fixed #3861 (uninitialized variables)
2012-06-13 19:09:51 +02:00
}
Reviewed handling of unknown types in CheckUninitVar
2012-06-22 16:39:39 +02:00
// Handling of unknown types. Assume they are POD in C.
void uninitvar6() {
const char code[] = "void f() {\n"
" dfs a;\n"
" return a;\n"
"}";
// Assume dfs is a non POD type if file is C++
checkUninitVar2(code, "test.cpp");
ASSERT_EQUALS("", errout.str());
// Assume dfs is a POD type if file is C
checkUninitVar2(code, "test.c");
ASSERT_EQUALS("[test.c:3]: (error) Uninitialized variable: a\n", errout.str());
Uninitialized variables: warn about structs in C code
2012-12-21 18:50:38 +01:00
const char code2[] = "struct AB { int a,b; };\n"
"void f() {\n"
" struct AB ab;\n"
" return ab;\n"
"}";
checkUninitVar2(code2, "test.cpp");
ASSERT_EQUALS("", errout.str());
checkUninitVar2(code2, "test.c");
ASSERT_EQUALS("[test.c:4]: (error) Uninitialized variable: ab\n", errout.str());
Reviewed handling of unknown types in CheckUninitVar
2012-06-22 16:39:39 +02:00
}
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
Uninitialized variables : fixed false positives when passing address of pointer to function.
2012-12-21 16:57:49 +01:00
// Handling of function calls
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
void uninitvar2_func() {
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
// non-pointer variable
checkUninitVar2("void a(char c);\n" // value => error
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
"void b() {\n"
" char c;\n"
" a(c);\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
checkUninitVar2("void a(const char c);\n" // const value => error
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
"void b() {\n"
" char c;\n"
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
" a(c);\n"
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
"}");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
checkUninitVar2("void a(char *c);\n" // address => no error
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
"void b() {\n"
" char c;\n"
" a(&c);\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: fixed FP when there are function calls where type* is converted to unknown_type
2012-12-25 14:05:29 +01:00
checkUninitVar2("void a(pstr s);\n" // address => no error
"void b() {\n"
" char c;\n"
" a(&c);\n"
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
checkUninitVar2("void a(const char *c);\n" // const address => error
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
"void b() {\n"
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
" char c;\n"
" a(&c);\n"
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
"}");
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
// pointer variable
checkUninitVar2("void a(char c);\n" // value => error
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
"void b() {\n"
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
" char *c;\n"
" a(*c);\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
Uninitialized variables : fixed false positives when passing address of pointer to function.
2012-12-21 16:57:49 +01:00
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
checkUninitVar2("void a(const char c);\n" // const value => error
Uninitialized variables: Improved handling of function calls
2012-12-21 17:04:15 +01:00
"void b() {\n"
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
" char c;\n"
" a(*c);\n"
Uninitialized variables: Improved handling of function calls
2012-12-21 17:04:15 +01:00
"}");
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
checkUninitVar2("void a(char *c);\n" // address => error
"void b() {\n"
" char *c;\n"
" a(c);\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
checkUninitVar2("void a(const char *c);\n" // const address => error
"void b() {\n"
" char *c;\n"
" a(c);\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
Uninitialized variables: Improved handling of function calls
2012-12-21 17:04:15 +01:00
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
checkUninitVar2("void a(char **c);\n" // address of pointer => no error
Uninitialized variables : fixed false positives when passing address of pointer to function.
2012-12-21 16:57:49 +01:00
"void b() {\n"
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
" char *c;\n"
Uninitialized variables: fixed FP when there are suspicious function calls where type** is converted to type*
2012-12-25 13:58:15 +01:00
" a(&c);\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("void a(char *c);\n" // address of pointer (suspicious cast to pointer) => no error
"void b() {\n"
" char *c;\n"
Uninitialized variables: Better testing of function handling
2012-12-21 19:32:56 +01:00
" a(&c);\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("void a(const char **c);\n" // const address of pointer => no error
"void b() {\n"
" const char *c;\n"
" a(&c);\n"
Uninitialized variables : fixed false positives when passing address of pointer to function.
2012-12-21 16:57:49 +01:00
"}");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Improved checking of functions
2012-12-20 19:45:30 +01:00
}
Uninitialized variables: Better value flow analysis. Fixed false positives.
2012-12-24 19:11:13 +01:00
void uninitvar2_value() {
checkUninitVar2("void f() {\n"
" int i;\n"
" if (x) {\n"
" int y = -ENOMEM;\n" // assume constant ENOMEM is nonzero since it's negated
" if (y != 0) return;\n"
" i++;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("void f() {\n"
" int i, y;\n"
" if (x) {\n"
" y = -ENOMEM;\n" // assume constant ENOMEM is nonzero since it's negated
" if (y != 0) return;\n"
" i++;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("void f() {\n"
" int i, y;\n"
" if (x) y = -ENOMEM;\n" // assume constant ENOMEM is nonzero since it's negated
" else y = get_value(i);\n"
" if (y != 0) return;\n" // <- condition is always true if i is uninitialized
" i++;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("void f(int x) {\n"
" int i;\n"
" if (!x) i = 0;\n"
" if (!x || i>0) {}\n" // <- error
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar2("void f(int x) {\n"
" int i;\n"
" if (x) i = 0;\n"
" if (!x || i>0) {}\n" // <- no error
"}\n");
ASSERT_EQUALS("", errout.str());
checkUninitVar2("void f(int x) {\n"
" int i;\n"
" if (!x) { }\n"
" else i = 0;\n"
" if (x || i>0) {}\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar2("void f(int x) {\n"
" int i;\n"
" if (x) { }\n"
" else i = 0;\n"
" if (x || i>0) {}\n" // <- no error
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: fixed false positives by bailing out when variable is conditionally initialized and then there is a conditional return.
2012-12-27 18:45:00 +01:00
// Unknown => bail out..
checkUninitVar2("void f(int x) {\n"
" int i;\n"
" if (a(x)) i = 0;\n"
" if (b(x)) return;\n"
" i++;\n" // <- no error if b(x) is always true when a(x) is false
"}\n");
ASSERT_EQUALS("", errout.str());
Uninitialized variables: Better value flow analysis. Fixed false positives.
2012-12-24 19:11:13 +01:00
}
Uninitialized variables: Broke out the checking into separate file
2010-10-31 12:31:11 +01:00
};
REGISTER_TEST(TestUninitVar)