From 01e14a12f10aa4de95ad3e0113ed1c3d98d77dcb Mon Sep 17 00:00:00 2001
From: Paul Fultz II <pfultz2@yahoo.com>
Date: Sat, 22 Jan 2022 05:25:20 -0600
Subject: [PATCH] Fix 10755: Assertion "!maxValue->isKnown()" from
 valueFlowInferCondition (#3739)

* Fix 10755: Assertion "!maxValue->isKnown()" from valueFlowInferCondition

* Format
---
 lib/token.cpp          |  7 +++++++
 test/testvalueflow.cpp | 21 ++++++++++++++++++---
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/lib/token.cpp b/lib/token.cpp
index a5006d6e6..dd270d327 100644
--- a/lib/token.cpp
+++ b/lib/token.cpp
@@ -2126,6 +2126,13 @@ bool Token::addValue(const ValueFlow::Value &value)
         });
     }
 
+    // Dont add a value if its already known
+    if (!value.isKnown() && mImpl->mValues &&
+        std::any_of(mImpl->mValues->begin(), mImpl->mValues->end(), [&](const ValueFlow::Value& x) {
+        return x.isKnown() && sameValueType(x, value) && !x.equalValue(value);
+    }))
+        return false;
+
     // assert(value.isKnown() || !mImpl->mValues || std::none_of(mImpl->mValues->begin(), mImpl->mValues->end(),
     // [&](const ValueFlow::Value& x) {
     //     return x.isKnown() && sameValueType(x, value);
diff --git a/test/testvalueflow.cpp b/test/testvalueflow.cpp
index 8509d3a41..cfb0adda2 100644
--- a/test/testvalueflow.cpp
+++ b/test/testvalueflow.cpp
@@ -3006,7 +3006,7 @@ private:
                "    auto x = !i;\n"
                "    return x;\n"
                "}\n";
-        ASSERT_EQUALS(true, testValueOfXImpossible(code, 4U, 1));
+        ASSERT_EQUALS(true, testValueOfXKnown(code, 4U, 0));
 
         code = "auto f(int i) {\n"
                "    if (i == 1) return;\n"
@@ -3918,7 +3918,8 @@ private:
                "  }\n"
                "}\n";
         ASSERT_EQUALS(false, testValueOfX(code, 4U, 0));
-        ASSERT_EQUALS(true,  testValueOfX(code, 4U, 9));
+        // Known to be true, but it could also be 9
+        ASSERT_EQUALS(true, testValueOfXKnown(code, 4U, 1));
 
         code = "void foo() {\n"
                "  for (int x = 0; x < 10; x++) {\n"
@@ -3936,7 +3937,8 @@ private:
                "  }\n"
                "}\n";
         ASSERT_EQUALS(false, testValueOfX(code, 4U, 0));
-        ASSERT_EQUALS(true,  testValueOfX(code, 4U, 9));
+        // Known to be true, but it could also be 9
+        ASSERT_EQUALS(true, testValueOfXKnown(code, 4U, 1));
 
         // After loop
         code = "void foo() {\n"
@@ -6211,6 +6213,19 @@ private:
                "    e.d.b = g - f.c;\n"
                "}\n";
         valueOfTok(code, "e");
+
+        code = "struct a {\n"
+               "  std::vector<a> b;\n"
+               "  void c(unsigned d) {\n"
+               "    size_t e = 0;\n"
+               "    size_t f = 0;\n"
+               "    for (auto child : b) {\n"
+               "      f = e;\n"
+               "      e = d - f;\n"
+               "    }\n"
+               "  }\n"
+               "};\n";
+        valueOfTok(code, "e");
     }
 
     void valueFlowHang() {