walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #1923 (False positive: Possible null pointer derefence in else if)

This commit is contained in:
Daniel Marjamäki 2010-08-07 19:59:56 +02:00
parent 262885f3e0
commit 029613d4c4
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -2394,7 +2394,7 @@ void CheckOther::nullPointerStructByDeRefAndChec()
else if (tok2->str() == "}") else if (tok2->str() == "}")
{ {
if (indentlevel2 == 0) if (indentlevel2 <= 1)
break; break;
--indentlevel2; --indentlevel2;
} }

12
test/testother.cpp
View File

@ -781,6 +781,18 @@ private:
" }\n" " }\n"
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// ticket #1923 - no false positive when using else if
checkNullPointer("void f(A *a)\n"
"{\n"
" if (a->x == 1)\n"
" {\n"
" a = a->next;\n"
" }\n"
" else if (a->x == 2) { }\n"
" if (a) { }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
} }
void nullpointer2() void nullpointer2()