From 02c2018f25e0da254b4b58af05db44c2fa123713 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Mon, 29 Oct 2018 14:21:56 +0100 Subject: [PATCH] Addition of a null pointer check in ProjectFileDialog::removeSuppression() (#1457) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The function “QListWidget::takeItem” is documented in the way that a null pointer can be returned. This result was not checked by the function “ProjectFileDialog::removeSuppression” so far. Thus add a corresponding check so that an inappropriate pointer access should not happen any more here. Link: https://sourceforge.net/p/cppcheck/discussion/development/thread/d1d0b65245/#a1bf Link: https://trac.cppcheck.net/ticket/8814 Signed-off-by: Markus Elfring --- gui/projectfiledialog.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gui/projectfiledialog.cpp b/gui/projectfiledialog.cpp index 085906eb6..ab53e13b8 100644 --- a/gui/projectfiledialog.cpp +++ b/gui/projectfiledialog.cpp @@ -636,6 +636,9 @@ void ProjectFileDialog::removeSuppression() { const int row = mUI.mListSuppressions->currentRow(); QListWidgetItem *item = mUI.mListSuppressions->takeItem(row); + if (!item) + return; + int suppressionIndex = getSuppressionIndex(item->text()); if (suppressionIndex >= 0) mSuppressions.removeAt(suppressionIndex);