walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #8998 (False positive uninitStructMember related to reference to member)

This commit is contained in:
Daniel Marjamäki 2019-12-19 20:18:25 +01:00
parent c84ba10b37
commit 02eaf6fa93
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/checkuninitvar.cpp
View File

@ -753,7 +753,10 @@ bool CheckUninitVar::checkScopeForVariable(const Token *tok, const Variable& var
return true; return true;
} }
else if (Token::Match(tok->previous(), "[(,] %name% [,)]")) if (Token::Match(tok->previous(), "[(,] %name% [,)]"))
return true;
if (Token::Match(tok->previous(), "= %var% . %var% ;") && membervar == tok->strAt(2))
return true; return true;
} else { } else {

14
test/testuninitvar.cpp
View File

@ -63,7 +63,7 @@ private:
TEST_CASE(uninitvar5); // #3861 TEST_CASE(uninitvar5); // #3861
TEST_CASE(uninitvar2_func); // function calls TEST_CASE(uninitvar2_func); // function calls
TEST_CASE(uninitvar2_value); // value flow TEST_CASE(uninitvar2_value); // value flow
TEST_CASE(uninitvar2_structmembers); // struct members TEST_CASE(uninitStructMember); // struct members
TEST_CASE(uninitvar2_while); TEST_CASE(uninitvar2_while);
TEST_CASE(uninitvar2_4494); // #4494 TEST_CASE(uninitvar2_4494); // #4494
TEST_CASE(uninitvar2_malloc); // malloc returns uninitialized data TEST_CASE(uninitvar2_malloc); // malloc returns uninitialized data
@ -3084,7 +3084,7 @@ private:
TODO_ASSERT_EQUALS("error", "", errout.str()); TODO_ASSERT_EQUALS("error", "", errout.str());
} }
void uninitvar2_structmembers() { // struct members void uninitStructMember() { // struct members
checkUninitVar("struct AB { int a; int b; };\n" checkUninitVar("struct AB { int a; int b; };\n"
"void f(void) {\n" "void f(void) {\n"
" struct AB ab;\n" " struct AB ab;\n"
@ -3531,6 +3531,16 @@ private:
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// Reference
checkUninitVar("struct A { int x; };\n"
"void foo() {\n"
" struct A a;\n"
" int& x = a.x;\n"
" x = 0;\n"
" return a.x;\n"
"}");
ASSERT_EQUALS("", errout.str());
// non static data-member initialization // non static data-member initialization
checkUninitVar("struct AB { int a=1; int b; };\n" checkUninitVar("struct AB { int a=1; int b; };\n"
"void f(void) {\n" "void f(void) {\n"