From 032d2e5cd198cb653ce70e2c03ecdc9c7a4a4cb8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Kr=C3=BCger?= Date: Fri, 19 Aug 2016 11:19:15 +0200 Subject: [PATCH] CXXFLAGS: remove -Winline (ticket #7693) The debug build (with -Winline) has no optimizations and when setting optimizations for a release builds, CXXFLAGS are overridden. So we either do a non-optimized debug build (where no inlining takes place which makes -Winline redundant) or do a release build without -Warning flags which means we would never see -O2 and -Winline together. --- Makefile | 2 +- tools/dmake.cpp | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 42a7bf7ab..a66cb9d3d 100644 --- a/Makefile +++ b/Makefile @@ -80,7 +80,7 @@ ifeq ($(CXX), clang++) CPPCHK_GLIBCXX_DEBUG= endif ifndef CXXFLAGS - CXXFLAGS=-include lib/cxx11emu.h -pedantic -Wall -Wextra -Wabi -Wcast-qual -Wfloat-equal -Winline -Wmissing-declarations -Wmissing-format-attribute -Wno-long-long -Wpacked -Wredundant-decls -Wshadow -Wno-missing-field-initializers -Wno-missing-braces -Wno-sign-compare -Wno-multichar $(CPPCHK_GLIBCXX_DEBUG) -g + CXXFLAGS=-include lib/cxx11emu.h -pedantic -Wall -Wextra -Wabi -Wcast-qual -Wfloat-equal -Wmissing-declarations -Wmissing-format-attribute -Wno-long-long -Wpacked -Wredundant-decls -Wshadow -Wno-missing-field-initializers -Wno-missing-braces -Wno-sign-compare -Wno-multichar $(CPPCHK_GLIBCXX_DEBUG) -g endif ifeq ($(CXX), g++) diff --git a/tools/dmake.cpp b/tools/dmake.cpp index 6d9d6c4e8..0183f0a5b 100644 --- a/tools/dmake.cpp +++ b/tools/dmake.cpp @@ -296,7 +296,6 @@ int main(int argc, char **argv) "-Wcast-qual " // "-Wconversion " // danmar: gives fp. for instance: unsigned int sizeof_pointer = sizeof(void *); "-Wfloat-equal " - "-Winline " // "-Wlogical-op " "-Wmissing-declarations " "-Wmissing-format-attribute "