From 037ecffc34596aca2ccc61497a8ce7b852e44475 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= <hyd_danmar@users.sourceforge.net>
Date: Sat, 23 Jan 2010 09:15:30 +0100
Subject: [PATCH] detect when function pointer that is null is used

---
 lib/checkother.cpp | 2 ++
 test/testother.cpp | 9 +++++++++
 2 files changed, 11 insertions(+)

diff --git a/lib/checkother.cpp b/lib/checkother.cpp
index 410261836..ead83c472 100644
--- a/lib/checkother.cpp
+++ b/lib/checkother.cpp
@@ -1307,6 +1307,8 @@ private:
                 dereference(foundError, checks, &tok);
             else if (Token::Match(tok.previous(), "return %var% [ %any% ]"))
                 dereference(foundError, checks, &tok);
+            else if (Token::Match(&tok, "%var% ("))
+                dereference(foundError, checks, &tok);
             else
                 bailOutVar(checks, tok.varId());
         }
diff --git a/test/testother.cpp b/test/testother.cpp
index 8a4674d4b..1b7fd94ed 100644
--- a/test/testother.cpp
+++ b/test/testother.cpp
@@ -990,6 +990,15 @@ private:
                          "    int sz = sizeof((*(struct dummy *)0).x);\n"
                          "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        // function pointer..
+        checkNullPointer("void foo()\n"
+                         "{\n"
+                         "    void (*f)();\n"
+                         "    f = 0;\n"
+                         "    f();\n"
+                         "}\n");
+        ASSERT_EQUALS("[test.cpp:5]: (error) Possible null pointer dereference: f\n", errout.str());
     }
 
     void nullpointer7()