walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

STL check: Look for string.c_str() / stringstream.str().c_str() "return" usage (object is destroyed on return)

This commit is contained in:
Thomas Jarosch 2011-10-26 21:07:48 +02:00
parent de71c41379
commit 03fd308dbf
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/checkstl.cpp
View File

@ -1019,6 +1019,14 @@ void CheckStl::string_c_str()
tok->next()->varId() > 0 && tok->next()->varId() > 0 &&
localvar.find(tok->next()->varId()) != localvar.end()) { localvar.find(tok->next()->varId()) != localvar.end()) {
string_c_strError(tok); string_c_strError(tok);
} else if (Token::Match(tok, "return %var% . c_str ( ) ;") &&
tok->next()->varId() > 0 &&
localvar.find(tok->next()->varId()) != localvar.end()) {
string_c_strError(tok);
} else if (Token::Match(tok, "return %var% . str ( ) . c_str ( ) ;") &&
tok->next()->varId() > 0 &&
localvar.find(tok->next()->varId()) != localvar.end()) {
string_c_strError(tok);
} else if (Token::Match(tok, "[;{}] %var% = %var% . str ( ) . c_str ( ) ;") && } else if (Token::Match(tok, "[;{}] %var% = %var% . str ( ) . c_str ( ) ;") &&
tok->next()->varId() > 0 && tok->next()->varId() > 0 &&
pointers.find(tok->next()->varId()) != pointers.end()) { pointers.find(tok->next()->varId()) != pointers.end()) {

12
test/teststl.cpp
View File

@ -1311,6 +1311,18 @@ private:
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str()\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str()\n", errout.str());
check("const char *get_msg() {\n"
" std::string errmsg;\n"
" return errmsg.c_str();\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str()\n", errout.str());
check("const char *get_msg() {\n"
" std::ostringstream errmsg;\n"
" return errmsg.str().c_str();\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str()\n", errout.str());
check("void f() {\n" check("void f() {\n"
" std::ostringstream errmsg;\n" " std::ostringstream errmsg;\n"
" const char *c = errmsg.str().c_str();\n" " const char *c = errmsg.str().c_str();\n"