removed some unused/unread member variables (and related code) found by CLion "Unused global declaration" inspection (#3808)

gui/checkthread.h

@@ -58,10 +58,6 @@ public:
         mAddonsAndTools = addonsAndTools;
     }
 
-    void setDataDir(const QString &dataDir) {
-        mDataDir = dataDir;
-    }
-
     void setClangIncludePaths(const QStringList &s) {
         mClangIncludePaths = s;
     }
@@ -136,7 +132,6 @@ private:
     QStringList mFiles;
     bool mAnalyseWholeProgram;
     QStringList mAddonsAndTools;
-    QString mDataDir;
     QStringList mClangIncludePaths;
     QList<Suppressions::Suppression> mSuppressions;
 };

gui/mainwindow.cpp

@@ -69,7 +69,6 @@ MainWindow::MainWindow(TranslationHandler* th, QSettings* settings) :
 {
     mUI.setupUi(this);
     mThread = new ThreadHandler(this);
-    mThread->setDataDir(getDataDir());
     mUI.mResults->initialize(mSettings, mApplications, mThread);
 
     // Filter timer to delay filtering results slightly while typing

gui/projectfiledialog.h

@@ -28,7 +28,6 @@
 #include <QStringList>
 
 class QWidget;
-class QCheckBox;
 
 /// @addtogroup GUI
 /// @{
@@ -323,9 +322,6 @@ private:
      */
     ProjectFile *mProjectFile;
 
-    /** @brief Library checkboxes */
-    QList<QCheckBox*> mLibraryCheckboxes;
-
     QString getExistingDirectory(const QString &caption, bool trailingSlash);
 
     QList<Suppressions::Suppression> mSuppressions;

gui/resultsview.h

@@ -382,9 +382,6 @@ private slots:
 private:
     QSet<QString> mFunctionContracts;
     QSet<QString> mVariableContracts;
-
-    /** Current file shown in the code editor */
-    QString mCurrentFileName;
 };
 /// @}
 #endif // RESULTSVIEW_H

gui/threadhandler.cpp

@@ -104,7 +104,6 @@ void ThreadHandler::check(const Settings &settings)
         mThreads[i]->setAddonsAndTools(addonsAndTools);
         mThreads[i]->setSuppressions(mSuppressions);
         mThreads[i]->setClangIncludePaths(mClangIncludePaths);
-        mThreads[i]->setDataDir(mDataDir);
         mThreads[i]->check(settings);
     }
 

gui/threadhandler.h

@@ -87,10 +87,6 @@ public:
         mClangIncludePaths = s;
     }
 
-    void setDataDir(const QString &dataDir) {
-        mDataDir = dataDir;
-    }
-
     /**
      * @brief Clear all files from cppcheck
      *
@@ -262,8 +258,6 @@ protected:
     QStringList mAddonsAndTools;
     QList<Suppressions::Suppression> mSuppressions;
     QStringList mClangIncludePaths;
-
-    QString mDataDir;
 private:
 
     /**

lib/cppcheck.cpp

@@ -359,7 +359,6 @@ CppCheck::CppCheck(ErrorLogger &errorLogger,
                    std::function<bool(std::string,std::vector<std::string>,std::string,std::string*)> executeCommand)
     : mErrorLogger(errorLogger)
     , mExitCode(0)
-    , mSuppressInternalErrorFound(false)
     , mUseGlobalSuppressions(useGlobalSuppressions)
     , mTooManyConfigs(false)
     , mSimplify(true)
@@ -585,7 +584,6 @@ unsigned int CppCheck::check(const ImportProject::FileSettings &fs)
 unsigned int CppCheck::checkFile(const std::string& filename, const std::string &cfgname, std::istream& fileStream)
 {
     mExitCode = 0;
-    mSuppressInternalErrorFound = false;
 
     // only show debug warnings for accepted C/C++ source files
     if (!Path::acceptFile(filename))
@@ -1515,8 +1513,6 @@ void CppCheck::purgedConfigurationMessage(const std::string &file, const std::st
 
 void CppCheck::reportErr(const ErrorMessage &msg)
 {
-    mSuppressInternalErrorFound = false;
-
     if (!mSettings.library.reportErrors(msg.file0))
         return;
 
@@ -1534,12 +1530,10 @@ void CppCheck::reportErr(const ErrorMessage &msg)
 
     if (mUseGlobalSuppressions) {
         if (mSettings.nomsg.isSuppressed(errorMessage)) {
-            mSuppressInternalErrorFound = true;
             return;
         }
     } else {
         if (mSettings.nomsg.isSuppressedLocal(errorMessage)) {
-            mSuppressInternalErrorFound = true;
             return;
         }
     }

lib/cppcheck.h

@@ -225,8 +225,6 @@ private:
 
     unsigned int mExitCode;
 
-    bool mSuppressInternalErrorFound;
-
     bool mUseGlobalSuppressions;
 
     /** Are there too many configs? */

lib/settings.h

@@ -135,9 +135,6 @@ public:
     /** Check for incomplete info in library files? */
     bool checkLibrary;
 
-    /** @brief List of selected Visual Studio configurations that should be checks */
-    std::list<std::string> checkVsConfigs;
-
     /** @brief check unknown function return values */
     std::set<std::string> checkUnknownFunctionReturn;