walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed false positive when ternary operator is used: case A&&B?B:A:

This commit is contained in:
PKEuS 2012-12-07 12:44:30 -08:00
parent 0ac4c3baf4
commit 068c695bd1
2 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/checkother.cpp
View File

@ -1074,11 +1074,21 @@ void CheckOther::checkSuspiciousCaseInSwitch()
for (const Token* tok = i->classStart->next(); tok != i->classEnd; tok = tok->next()) {
if (tok->str() == "case") {
const Token* end = 0;
for (const Token* tok2 = tok->next(); tok2; tok2 = tok2->next()) {
if (Token::Match(tok2, "[:;}{]"))
if (tok2->str() == ":") {
end = tok2;
break;
if (Token::Match(tok2, "&&|%oror%"))
suspiciousCaseInSwitchError(tok, tok2->str());
}
if (Token::Match(tok2, "[?;}{]")) {
break;
}
}
if (end) {
const Token* finding = Token::findmatch(tok->next(), "&&|%oror%", end);
if (finding)
suspiciousCaseInSwitchError(tok, finding->str());
}
}
}

8
test/testother.cpp
View File

@ -2750,6 +2750,14 @@ private:
" }\n"
"}");
ASSERT_EQUALS("", errout.str());
check("void foo() {\n"
" switch(a) {\n"
" case A&&B?B:A:\n"
" foo();\n"
" }\n"
"}");
ASSERT_EQUALS("", errout.str());
}