walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

fix #195 Unusual shift operation - check this kind of code 

return x >> ! y ? 8 : 2;
This commit is contained in:
seb777 2011-09-06 22:37:19 +02:00
parent cbbdd55177
commit 074ad10a30
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/checkother.cpp
View File

@ -87,6 +87,12 @@ void CheckOther::clarifyCalculation()
else else
continue; continue;
if (cond && cond->str() == "!")
cond = cond->previous();
if (!cond)
continue;
// calculation // calculation
if (!cond->isArithmeticalOp()) if (!cond->isArithmeticalOp())
continue; continue;

16
test/testother.cpp
View File

@ -2649,7 +2649,7 @@ private:
); );
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// ticket 2495 // ticket #2495
check("void f() {\n" check("void f() {\n"
" static float col[][3]={\n" " static float col[][3]={\n"
" {1,0,0},\n" " {1,0,0},\n"
@ -2664,14 +2664,14 @@ private:
); );
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// ticket 155 // ticket #155
check("void f() {\n" check("void f() {\n"
" char buff1[1024*64],buff2[sizeof(buff1)*2];\n" " char buff1[1024*64],buff2[sizeof(buff1)*2];\n"
"}\n" "}\n"
); );
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// ticket 2510 // ticket #2510
check("void f( int a[], int b) {\n" check("void f( int a[], int b) {\n"
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n" " std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
"}\n" "}\n"
@ -2679,7 +2679,7 @@ private:
ASSERT_EQUALS("[test.cpp:2]: (error) Using sizeof for array given as " ASSERT_EQUALS("[test.cpp:2]: (error) Using sizeof for array given as "
"function argument returns the size of pointer.\n", errout.str()); "function argument returns the size of pointer.\n", errout.str());
// ticket 2510 // ticket #2510
check("void f( int a[3] , int b[2] ) {\n" check("void f( int a[3] , int b[2] ) {\n"
" std::cout << sizeof(a) / sizeof(int) << std::endl;\n" " std::cout << sizeof(a) / sizeof(int) << std::endl;\n"
"}\n" "}\n"
@ -2687,7 +2687,7 @@ private:
ASSERT_EQUALS("[test.cpp:2]: (error) Using sizeof for array given as " ASSERT_EQUALS("[test.cpp:2]: (error) Using sizeof for array given as "
"function argument returns the size of pointer.\n", errout.str()); "function argument returns the size of pointer.\n", errout.str());
// ticket 2510 // ticket #2510
check("void f() {\n" check("void f() {\n"
" char buff1[1024*64],buff2[sizeof(buff1)*(2+1)];\n" " char buff1[1024*64],buff2[sizeof(buff1)*(2+1)];\n"
"}\n" "}\n"
@ -2757,6 +2757,12 @@ private:
" int ab = a - b ? 2 : 3;\n" " int ab = a - b ? 2 : 3;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:2]: (style) Clarify calculation precedence for - and ?\n", errout.str()); ASSERT_EQUALS("[test.cpp:2]: (style) Clarify calculation precedence for - and ?\n", errout.str());
// ticket #195
check("int f(int x, int y) {\n"
" return x >> ! y ? 8 : 2;\n"
"}");
ASSERT_EQUALS("[test.cpp:2]: (style) Clarify calculation precedence for >> and ?\n", errout.str());
} }
// clarify conditions with = and comparison // clarify conditions with = and comparison