walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Bug hunting; Fix test CVE-2019-19334

This commit is contained in:
Daniel Marjamäki 2020-12-05 18:52:18 +01:00
parent 492cba7d2f
commit 089f193d6c
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/bughuntingchecks.cpp
View File

@ -156,7 +156,12 @@ static void bufferOverflow(const Token *tok, const ExprEngine::Value &value, Exp
break;
}
std::shared_ptr<ExprEngine::ArrayValue> arrayValue2 = std::dynamic_pointer_cast<ExprEngine::ArrayValue>(otherValue);
if (arrayValue2 && arrayValue2->size.size() == 1 && isLessThan(dataBase, arrayValue->size[0], arrayValue2->size[0])) {
if (!arrayValue2 || arrayValue2->size.size() != 1) {
overflowArgument = argnr;
bailout = true;
break;
}
if (isLessThan(dataBase, arrayValue->size[0], arrayValue2->size[0])) {
overflowArgument = argnr;
break;
}