diff --git a/gui/checkstatistics.cpp b/gui/checkstatistics.cpp index e391be766..d4c98e3d2 100644 --- a/gui/checkstatistics.cpp +++ b/gui/checkstatistics.cpp @@ -99,10 +99,10 @@ unsigned CheckStatistics::getCount(const QString &tool, ShowTypes::ShowType type QStringList CheckStatistics::getTools() const { QSet ret; - foreach (QString tool, mStyle.keys()) ret.insert(tool); - foreach (QString tool, mWarning.keys()) ret.insert(tool); - foreach (QString tool, mPerformance.keys()) ret.insert(tool); - foreach (QString tool, mPortability.keys()) ret.insert(tool); - foreach (QString tool, mError.keys()) ret.insert(tool); + for (const QString& tool: mStyle.keys()) ret.insert(tool); + for (const QString& tool: mWarning.keys()) ret.insert(tool); + for (const QString& tool: mPerformance.keys()) ret.insert(tool); + for (const QString& tool: mPortability.keys()) ret.insert(tool); + for (const QString& tool: mError.keys()) ret.insert(tool); return QStringList(ret.values()); } diff --git a/gui/mainwindow.cpp b/gui/mainwindow.cpp index 8dc1504a5..e4c104996 100644 --- a/gui/mainwindow.cpp +++ b/gui/mainwindow.cpp @@ -515,8 +515,8 @@ void MainWindow::doAnalyzeFiles(const QStringList &files, const bool checkLibrar if (!checkSettings.buildDir.empty()) { checkSettings.loadSummaries(); std::list sourcefiles; - foreach (QString s, fileNames) - sourcefiles.push_back(s.toStdString()); + for (const QString& s: fileNames) + sourcefiles.push_back(s.toStdString()); AnalyzerInformation::writeFilesTxt(checkSettings.buildDir, sourcefiles, checkSettings.userDefines, checkSettings.project.fileSettings); }