From 0e40a4cc39cabc35aedd936cf38b7ea94b2d5f0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Kr=C3=BCger?= Date: Thu, 3 Aug 2017 22:12:12 +0200 Subject: [PATCH] gui: ThreadHandler::check() remove unused parameter "all". MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Was: threadhandler.cpp:78:58: warning: unused parameter ‘all’ [-Wunused-parameter] void ThreadHandler::check(const Settings &settings, bool all) ^~~ --- gui/mainwindow.cpp | 8 ++++---- gui/threadhandler.cpp | 2 +- gui/threadhandler.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gui/mainwindow.cpp b/gui/mainwindow.cpp index 94c65b6f6..bece1196a 100644 --- a/gui/mainwindow.cpp +++ b/gui/mainwindow.cpp @@ -415,7 +415,7 @@ void MainWindow::doAnalyzeProject(ImportProject p) if (mProjectFile) mThread->setAddons(mProjectFile->getAddons()); mThread->setProject(p); - mThread->check(checkSettings, true); + mThread->check(checkSettings); } void MainWindow::doAnalyzeFiles(const QStringList &files) @@ -471,7 +471,7 @@ void MainWindow::doAnalyzeFiles(const QStringList &files) } mThread->setCheckFiles(true); - mThread->check(checkSettings, true); + mThread->check(checkSettings); } void MainWindow::analyzeCode(const QString& code, const QString& filename) @@ -975,7 +975,7 @@ void MainWindow::reAnalyzeSelected(QStringList files, bool all) // considered in "Modified Files Check" performed after "Selected Files Check" // TODO: Should we store per file CheckStartTime? QDateTime saveCheckStartTime = mThread->getCheckStartTime(); - mThread->check(getCppcheckSettings(), all); + mThread->check(getCppcheckSettings()); mThread->setCheckStartTime(saveCheckStartTime); } @@ -999,7 +999,7 @@ void MainWindow::reAnalyze(bool all) qDebug() << "Rechecking project file" << mProjectFile->getFilename(); mThread->setCheckFiles(all); - mThread->check(getCppcheckSettings(), all); + mThread->check(getCppcheckSettings()); } void MainWindow::clearResults() diff --git a/gui/threadhandler.cpp b/gui/threadhandler.cpp index 9ea0775e8..ee24211fa 100644 --- a/gui/threadhandler.cpp +++ b/gui/threadhandler.cpp @@ -75,7 +75,7 @@ void ThreadHandler::setCheckFiles(QStringList files) } } -void ThreadHandler::check(const Settings &settings, bool all) +void ThreadHandler::check(const Settings &settings) { if (mResults.getFileCount() == 0 || mRunningThreadCount > 0 || settings.jobs == 0) { qDebug() << "Can't start checking if there's no files to check or if check is in progress."; diff --git a/gui/threadhandler.h b/gui/threadhandler.h index 8829f5cbe..fb52aed98 100644 --- a/gui/threadhandler.h +++ b/gui/threadhandler.h @@ -105,7 +105,7 @@ public: * @param settings Settings for checking * @param all true if all files, false if modified files */ - void check(const Settings &settings, bool all); + void check(const Settings &settings); /** * @brief Set files to check