walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Dont follow volatile variables (#1365)

This commit is contained in:
Paul Fultz II 2018-09-03 12:51:48 -05:00 committed by Daniel Marjamäki
parent 220c06e356
commit 0e5fabf4dc
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/astutils.cpp
View File

@ -175,6 +175,8 @@ static const Token * followVariableExpression(const Token * tok, bool cpp)
// Skip array access // Skip array access
if (Token::simpleMatch(varTok, "[")) if (Token::simpleMatch(varTok, "["))
return tok; return tok;
if (var->isVolatile())
return tok;
if (!var->isLocal() && !var->isConst()) if (!var->isLocal() && !var->isConst())
return tok; return tok;
if (var->isStatic() && !var->isConst()) if (var->isStatic() && !var->isConst())

4
test/testother.cpp
View File

@ -4075,6 +4075,10 @@ private:
" if(a == 1) {}\n" " if(a == 1) {}\n"
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("volatile const int var = 42;\n"
"void f() { if(var == 42) {} }\n");
ASSERT_EQUALS("", errout.str());
} }
void duplicateExpressionLoop() { void duplicateExpressionLoop() {