walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Use multiline in testing

This commit is contained in:
Daniel Marjamäki 2019-04-28 07:48:38 +02:00
parent fd4e371091
commit 0e8f2cdf63
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/testcondition.cpp
View File

@ -3080,17 +3080,23 @@ private:
} }
void duplicateConditionalAssign() { void duplicateConditionalAssign() {
setMultiline();
check("void f(int& x, int y) {\n" check("void f(int& x, int y) {\n"
" if (x == y)\n" " if (x == y)\n"
" x = y;\n" " x = y;\n"
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (style) Assignment 'x=y' is redundant with condition 'x==y'.\n", errout.str()); ASSERT_EQUALS("test.cpp:3:style:Assignment 'x=y' is redundant with condition 'x==y'.\n"
"test.cpp:2:note:Condition 'x==y'\n"
"test.cpp:3:note:Assignment 'x=y' is redundant\n", errout.str());
check("void f(int& x, int y) {\n" check("void f(int& x, int y) {\n"
" if (x != y)\n" " if (x != y)\n"
" x = y;\n" " x = y;\n"
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:3] -> [test.cpp:2]: (style) The statement 'if (x!=y) x=y' is logically equivalent to 'x=y'.\n", errout.str()); ASSERT_EQUALS("test.cpp:2:style:The statement 'if (x!=y) x=y' is logically equivalent to 'x=y'.\n"
"test.cpp:3:note:Assignment 'x=y'\n"
"test.cpp:2:note:Condition 'x!=y' is redundant\n", errout.str());
check("void f(int& x, int y) {\n" check("void f(int& x, int y) {\n"
" if (x == y)\n" " if (x == y)\n"
@ -3098,7 +3104,9 @@ private:
" else\n" " else\n"
" x = 1;\n" " x = 1;\n"
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (style) Assignment 'x=y' is redundant with condition 'x==y'.\n", errout.str()); ASSERT_EQUALS("test.cpp:3:style:Assignment 'x=y' is redundant with condition 'x==y'.\n"
"test.cpp:2:note:Condition 'x==y'\n"
"test.cpp:3:note:Assignment 'x=y' is redundant\n", errout.str());
check("void f(int& x, int y) {\n" check("void f(int& x, int y) {\n"
" if (x != y)\n" " if (x != y)\n"