walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

misra: Emit more accurate warnings for unused arguments in rule 2.7 (#3314) 

Make the MISRA addon emit extra warnings for unused arguments placed in
lines other than the function definition. This makes it easier for the
user to find violations.
This commit is contained in:
Georgiy Komarov 2021-06-29 12:17:38 +03:00 committed by GitHub
parent 1783fd1bba
commit 10123b4ad2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
addons/misra.py
View File

@ -1136,9 +1136,19 @@ class MisraChecker:
if token.variable is not None and token.variable in func_param_list:
func_param_list.remove(token.variable)
token = token.next
if len(func_param_list) > 0:
# At least one parameter has not been referenced in function body
self.reportError(func.tokenDef, 2, 7)
# Emit a warning for each unused variable, but no more that one warning per line
reported_linenrs = set()
for func_param in func_param_list:
if func_param.nameToken:
linenr = func_param.nameToken
if linenr not in reported_linenrs:
self.reportError(func_param.nameToken, 2, 7)
reported_linenrs.add(linenr)
else:
linenr = func.tokenDef.linenr
if linenr not in reported_linenrs:
self.reportError(func.tokenDef, 2, 7)
reported_linenrs.add(linenr)
def misra_3_1(self, rawTokens):
for token in rawTokens:

17
addons/test/misra/misra-test.c
View File

@ -65,8 +65,21 @@ void misra_2_7_used_params (int *param1, int param2, int param3)
*param1 = param2;
}
void misra_2_7_vararg(int a, ...) { (void)a; }
void misra_2_7_unnamed_arg(int) { } // 2.7 8.2
void misra_2_7_a(int a,
int b, // 2.7
int c,
int d) // 2.7
{
(void)a;
(void)c;
}
void misra_2_7_b(int a, int b, int c, // 2.7
int d) // 2.7
{
(void)a;
}
void misra_2_7_c(int a, ...) { (void)a; }
void misra_2_7_d(int) { } // 2.7 8.2
void misra_3_2(int enable)
{