walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Decouple pattern matching from other checks

This commit is contained in:
Dmitry-Me 2015-02-27 13:09:06 +03:00
parent 9b874b97f0
commit 10b762da98
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/checkother.cpp
View File

@ -1900,19 +1900,18 @@ void CheckOther::checkMathFunctions()
} }
// acos( x ), asin( x ) where x is defined for interval [-1,+1], but not beyond // acos( x ), asin( x ) where x is defined for interval [-1,+1], but not beyond
else if (Token::Match(tok, "acos|acosl|acosf|asin|asinf|asinl ( %num% )") && else if (Token::Match(tok, "acos|acosl|acosf|asin|asinf|asinl ( %num% )")) {
std::fabs(MathLib::toDoubleNumber(tok->strAt(2))) > 1.0) { if (std::fabs(MathLib::toDoubleNumber(tok->strAt(2))) > 1.0)
mathfunctionCallWarning(tok); mathfunctionCallWarning(tok);
} }
// sqrt( x ): if x is negative the result is undefined // sqrt( x ): if x is negative the result is undefined
else if (Token::Match(tok, "sqrt|sqrtf|sqrtl ( %num% )") && else if (Token::Match(tok, "sqrt|sqrtf|sqrtl ( %num% )")) {
MathLib::isNegative(tok->strAt(2))) { if (MathLib::isNegative(tok->strAt(2)))
mathfunctionCallWarning(tok); mathfunctionCallWarning(tok);
} }
// atan2 ( x , y): x and y can not be zero, because this is mathematically not defined // atan2 ( x , y): x and y can not be zero, because this is mathematically not defined
else if (Token::Match(tok, "atan2|atan2f|atan2l ( %num% , %num% )") && else if (Token::Match(tok, "atan2|atan2f|atan2l ( %num% , %num% )")) {
MathLib::isNullValue(tok->strAt(2)) && if (MathLib::isNullValue(tok->strAt(2)) && MathLib::isNullValue(tok->strAt(4)))
MathLib::isNullValue(tok->strAt(4))) {
mathfunctionCallWarning(tok, 2); mathfunctionCallWarning(tok, 2);
} }
// fmod ( x , y) If y is zero, then either a range error will occur or the function will return zero (implementation-defined). // fmod ( x , y) If y is zero, then either a range error will occur or the function will return zero (implementation-defined).
@ -1922,9 +1921,8 @@ void CheckOther::checkMathFunctions()
mathfunctionCallWarning(tok, 2); mathfunctionCallWarning(tok, 2);
} }
// pow ( x , y) If x is zero, and y is negative --> division by zero // pow ( x , y) If x is zero, and y is negative --> division by zero
else if (Token::Match(tok, "pow|powf|powl ( %num% , %num% )") && else if (Token::Match(tok, "pow|powf|powl ( %num% , %num% )")) {
MathLib::isNullValue(tok->strAt(2)) && if (MathLib::isNullValue(tok->strAt(2)) && MathLib::isNegative(tok->strAt(4)))
MathLib::isNegative(tok->strAt(4))) {
mathfunctionCallWarning(tok, 2); mathfunctionCallWarning(tok, 2);
} }