walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Use unsigned int for all flags 

Frank Zingsheim reported: With the parameter 'flag_'
and the member variable '_flags' having the type 'int'
produces a lot of warings in clang:

"warning: implicit conversion changes signedness: 'int' to 'unsigned int'".
This commit is contained in:
Thomas Jarosch 2015-01-17 16:46:05 +01:00
parent fd01cafb1b
commit 10fffbfce0
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/symboldatabase.h
View File

@ -148,7 +148,7 @@ class CPPCHECKLIB Variable {
* @param flag_ flag to get state of * @param flag_ flag to get state of
* @return true if flag set or false in flag not set * @return true if flag set or false in flag not set
*/ */
bool getFlag(int flag_) const { bool getFlag(unsigned int flag_) const {
return bool((_flags & flag_) != 0); return bool((_flags & flag_) != 0);
} }
@ -157,7 +157,7 @@ class CPPCHECKLIB Variable {
* @param flag_ flag to set state * @param flag_ flag to set state
* @param state_ new state of flag * @param state_ new state of flag
*/ */
void setFlag(int flag_, bool state_) { void setFlag(unsigned int flag_, bool state_) {
_flags = state_ ? _flags | flag_ : _flags & ~flag_; _flags = state_ ? _flags | flag_ : _flags & ~flag_;
} }
@ -541,7 +541,7 @@ private:
AccessControl _access; // public/protected/private AccessControl _access; // public/protected/private
/** @brief flags */ /** @brief flags */
int _flags; unsigned int _flags;
/** @brief pointer to user defined type info (for known types) */ /** @brief pointer to user defined type info (for known types) */
const Type *_type; const Type *_type;
@ -581,7 +581,7 @@ class CPPCHECKLIB Function {
* @param flag flag to get state of * @param flag flag to get state of
* @return true if flag set or false in flag not set * @return true if flag set or false in flag not set
*/ */
bool getFlag(int flag) const { bool getFlag(unsigned int flag) const {
return bool((flags & flag) != 0); return bool((flags & flag) != 0);
} }
@ -590,7 +590,7 @@ class CPPCHECKLIB Function {
* @param flag flag to set state * @param flag flag to set state
* @param state new state of flag * @param state new state of flag
*/ */
void setFlag(int flag, bool state) { void setFlag(unsigned int flag, bool state) {
flags = state ? flags | flag : flags & ~flag; flags = state ? flags | flag : flags & ~flag;
} }