code cleanup for invertOperatorForOperandSwap()

2014-04-03 16:22:07 +02:00 · 2014-04-03 16:22:07 +02:00 · 110f956029
parent ffac614f7e
commit 110f956029
1 changed files with 4 additions and 6 deletions
--- a/lib/checkother.cpp
+++ b/lib/checkother.cpp
@ -1253,12 +1253,10 @@ void CheckOther::selfAssignmentError(const Token *tok, const std::string &varnam

 static std::string invertOperatorForOperandSwap(std::string s)
 {
-    for (std::string::size_type i = 0; i < s.length(); i++) {
-        if (s[i] == '>')
-            s[i] = '<';
-        else if (s[i] == '<')
-            s[i] = '>';
-    }
+    if (s[0] == '<')
+        s[0] = '>';
+    else if (s[0] == '>')
+        s[0] = '<';
    return s;
 }