walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

unused variable: reading the value of variable in a for loop.. "for(;a;)" see ticket #18

This commit is contained in:
Daniel Marjamäki 2009-01-17 11:12:15 +00:00
parent f562f588fb
commit 121c0ee58f
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/checkother.cpp
View File

@ -927,6 +927,9 @@ void CheckOther::functionVariableUsage()
if (Token::Match(tok, "[(,] %var% [,)]")) if (Token::Match(tok, "[(,] %var% [,)]"))
varUsage[ tok->strAt(1)] |= USAGE_WRITE; varUsage[ tok->strAt(1)] |= USAGE_WRITE;
if (Token::Match(tok, "; %var% ;"))
varUsage[ tok->strAt(1)] |= USAGE_READ;
} }
// Check usage of all variables in the current scope.. // Check usage of all variables in the current scope..

10
test/testunusedvar.cpp
View File

@ -75,6 +75,7 @@ private:
TEST_CASE(localvarIf); // Usage in if TEST_CASE(localvarIf); // Usage in if
TEST_CASE(localvarIfElse); // return tmp1 ? tmp2 : tmp3; TEST_CASE(localvarIfElse); // return tmp1 ? tmp2 : tmp3;
TEST_CASE(localvarOpAssign); // a |= b; TEST_CASE(localvarOpAssign); // a |= b;
TEST_CASE(localvarFor); // for ( ; var; )
} }
void structmember1() void structmember1()
@ -335,6 +336,15 @@ private:
ASSERT_EQUALS(std::string("[test.cpp:2]: Variable 'a' is assigned a value that is never used\n"), errout.str()); ASSERT_EQUALS(std::string("[test.cpp:2]: Variable 'a' is assigned a value that is never used\n"), errout.str());
} }
void localvarFor()
{
functionVariableUsage("void foo()\n"
"{\n"
" int a = 1;\n"
" for (;a;);\n"
"}\n");
ASSERT_EQUALS(std::string(""), errout.str());
}
}; };