walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix #9488: MISRA addon: False positive for rule 10.6 in test for rule 10.1 (#5598)

This commit is contained in:
Swasti Shrivastava 2023-10-30 21:54:19 +05:30 committed by GitHub
parent 915b4b6c5a
commit 12844703de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
addons/misra.py
View File

@ -2387,6 +2387,9 @@ class MisraChecker:
e = getEssentialType(token.astOperand2) e = getEssentialType(token.astOperand2)
if not e: if not e:
continue continue
if e == "char" and vt1.type == "int":
# When arithmetic operations are performed on char values, they are usually promoted to int
continue
lhsbits = vt1.bits if vt1.bits else bitsOfEssentialType(vt1.type) lhsbits = vt1.bits if vt1.bits else bitsOfEssentialType(vt1.type)
if lhsbits > bitsOfEssentialType(e): if lhsbits > bitsOfEssentialType(e):
self.reportError(token, 10, 6) self.reportError(token, 10, 6)

2
addons/test/misra/misra-test.c
View File

@ -749,7 +749,7 @@ static void misra_10_6(u8 x, char c1, char c2) {
u16 y1 = x+x; // 10.6 u16 y1 = x+x; // 10.6
u16 y2 = (0x100u - 0x80u); // rhs is not a composite expression because it's a constant expression u16 y2 = (0x100u - 0x80u); // rhs is not a composite expression because it's a constant expression
u16 z = ~u8 x ;//10.6 u16 z = ~u8 x ;//10.6
s32 i = c1 - c2; // 10.3 FIXME: False positive for 10.6 (this is compliant). Trac #9488 s32 i = c1 - c2; // 10.3
struct misra_10_6_s s; struct misra_10_6_s s;
s.a = x & 1U; // no-warning (#10487) s.a = x & 1U; // no-warning (#10487)
} }