walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #4382 (Use of alloca causes VLA recommendation in C++)

This commit is contained in:
Daniel Marjamäki 2012-12-02 11:39:26 +01:00
parent bf91454136
commit 15ef6bb32f
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/checkobsoletefunctions.cpp
View File

@ -70,8 +70,9 @@ void CheckObsoleteFunctions::obsoleteFunctions()
}
}
if (_settings->standards.c >= Standards::C99) {
// alloca : this function is obsolete in C but not in C++ (#4382)
it = _obsoleteC99Functions.find(tok->str());
if (it != _obsoleteC99Functions.end()) {
if (it != _obsoleteC99Functions.end() && !(tok->str() == "alloca" && _tokenizer->isCPP())) {
reportError(tok->next(), Severity::style, "obsoleteFunctions"+it->first, it->second);
}
}

14
test/testobsoletefunctions.cpp
View File

@ -68,7 +68,7 @@ private:
TEST_CASE(ticket3238);
}
void check(const char code[]) {
void check(const char code[], const char filename[]="test.cpp") {
// Clear the error buffer..
errout.str("");
@ -80,7 +80,7 @@ private:
// Tokenize..
Tokenizer tokenizer(&settings, this);
std::istringstream istr(code);
tokenizer.tokenize(istr, "test.cpp");
tokenizer.tokenize(istr, filename);
tokenizer.simplifyTokenList();
// Check for obsolete functions..
@ -220,8 +220,14 @@ private:
check("void f()\n"
"{\n"
" char *x = alloca(10);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (style) Obsolete function 'alloca' called. In C99 and later it is recommended to use a variable length array instead.\n", errout.str());
"}\n", "test.cpp"); // #4382 - there are no VLAs in C++
ASSERT_EQUALS("", errout.str());
check("void f()\n"
"{\n"
" char *x = alloca(10);\n"
"}\n", "test.c");
ASSERT_EQUALS("[test.c:3]: (style) Obsolete function 'alloca' called. In C99 and later it is recommended to use a variable length array instead.\n", errout.str());
}
// ticket #3121