walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #4022 (false positive: (style) Variable 'sort_entry' is assigned a value that is never used)

This commit is contained in:
Daniel Marjamäki 2012-12-28 18:18:36 +01:00
parent 5ba2a300af
commit 1769240e15
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkunusedvar.cpp
View File

@ -547,13 +547,13 @@ static const Token* doAssignment(Variables &variables, const Token *tok, bool de
else else
variables.read(varid2, tok); variables.read(varid2, tok);
} else { } else {
variables.read(varid2, tok); variables.readAll(varid2, tok);
} }
} }
} else if (var1->_type == Variables::reference) { } else if (var1->_type == Variables::reference) {
variables.alias(varid1, varid2, true); variables.alias(varid1, varid2, true);
} else { } else {
if (var2->_type == Variables::pointer && tok->strAt(1) == "[") if ((var2->_type == Variables::pointer || var2->_type == Variables::pointerArray) && tok->strAt(1) == "[")
variables.readAliases(varid2, tok); variables.readAliases(varid2, tok);
variables.read(varid2, tok); variables.read(varid2, tok);

18
test/testunusedvar.cpp
View File

@ -2156,6 +2156,24 @@ private:
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:3]: (style) Variable 'a' is not assigned a value.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Variable 'a' is not assigned a value.\n", errout.str());
functionVariableUsage("void foo() {\n" // #4022 - FP (a is assigned a value that is never used)
" int a[2], *b[2];\n"
" a[0] = 123;\n"
" b[0] = &a[0];\n"
" int *d = b[0];\n"
" return *d;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
functionVariableUsage("void foo() {\n" // #4022 - FP (a is assigned a value that is never used)
" entry a[2], *b[2];\n"
" a[0].value = 123;\n"
" b[0] = &a[0];\n"
" int d = b[0].value;\n"
" return d;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
functionVariableUsage("struct S { char c[100]; };\n" functionVariableUsage("struct S { char c[100]; };\n"
"void foo()\n" "void foo()\n"
"{\n" "{\n"