walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Null pointer: Fixed false positive

This commit is contained in:
Daniel Marjamäki 2010-09-02 21:08:58 +02:00
parent 01b05618e5
commit 190a0040b7
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -2431,7 +2431,7 @@ void CheckOther::nullPointerLinkedList()
} }
--indentlevel4; --indentlevel4;
} }
else if (tok4->str() == "break") else if (tok4->str() == "break" || tok4->str() == "return")
break; break;
} }
} }

12
test/testother.cpp
View File

@ -925,6 +925,18 @@ private:
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
checkNullPointer("void f()\n"
"{\n"
" for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next())\n"
" {\n"
" while (tok && tok->str() != \"{\")\n"
" tok = tok->next();\n"
" if (!tok)\n"
" return;\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
// dynamic_cast.. // dynamic_cast..
checkNullPointer("void foo(ABC *abc)\n" checkNullPointer("void foo(ABC *abc)\n"
"{\n" "{\n"