walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #2806 (False positive with g_strstrip())

This commit is contained in:
Daniel Marjamäki 2011-05-29 17:44:10 +02:00
parent e06b2419a4
commit 1b4b4ee43e
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkmemoryleak.cpp
View File

@ -1090,7 +1090,7 @@ Token *CheckMemoryLeakInFunction::getcode(const Token *tok, std::list<const Toke
break;
}
if (Token::Match(tok2, "[=+] %varid%", varid))
if (Token::Match(tok2, "[=+(,] %varid%", varid))
{
rhs = true;
}

16
test/testmemleak.cpp
View File

@ -263,7 +263,8 @@ private:
TEST_CASE(realloc10);
TEST_CASE(realloc11);
TEST_CASE(assign);
TEST_CASE(assign1);
TEST_CASE(assign2); // #2806 - FP when using redundant assignment
TEST_CASE(varid);
@ -2705,7 +2706,7 @@ private:
ASSERT_EQUALS("", errout.str());
}
void assign()
void assign1()
{
check("void foo()\n"
"{\n"
@ -2761,6 +2762,17 @@ private:
ASSERT_EQUALS("", errout.str());
}
void assign2()
{
// #2806 - FP when there is redundant assignment
check("void foo() {\n"
" gchar *bar;\n"
" bar = g_strdup(fuba);\n"
" bar = g_strstrip(bar);\n"
" g_free(bar);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void varid()
{