walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix #794 (Floating point exception on CheckBufferOverrun) 

http://sourceforge.net/apps/trac/cppcheck/ticket/794
This commit is contained in:
Reijo Tomperi 2009-10-05 23:19:44 +03:00
parent edb28d2856
commit 1eba4b374f
2 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/checkbufferoverrun.cpp
View File

@ -277,6 +277,9 @@ void CheckBufferOverrun::checkScope(const Token *tok, const char *varname[], con
if (Token::Match(tok3, "%varid% += %num% )", counter_varid) ||
Token::Match(tok3, "%varid% = %num% + %varid% )", counter_varid))
{
if (!MathLib::isInt(tok3->strAt(2)))
continue;
const int num = std::atoi(tok3->strAt(2));
// We have for example code: "for(i=2;i<22;i+=6)
@ -293,6 +296,9 @@ void CheckBufferOverrun::checkScope(const Token *tok, const char *varname[], con
}
else if (Token::Match(tok3, "%varid% = %varid% + %num% )", counter_varid))
{
if (!MathLib::isInt(tok3->strAt(4)))
continue;
const int num = std::atoi(tok3->strAt(4));
long max = MathLib::toLongNumber(max_counter_value);
long min = MathLib::toLongNumber(min_counter_value);

30
test/testbufferoverrun.cpp
View File

@ -99,6 +99,7 @@ private:
TEST_CASE(buffer_overrun_8);
TEST_CASE(buffer_overrun_9);
TEST_CASE(buffer_overrun_10);
TEST_CASE(buffer_overrun_11);
TEST_CASE(sprintf1);
TEST_CASE(sprintf2);
@ -735,6 +736,35 @@ private:
ASSERT_EQUALS("", errout.str());
}
void buffer_overrun_11()
{
check("void f()\n"
"{\n"
" char a[4];\n"
" for (float i=0; i<10.0;i+=0.1)\n"
" {\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
check("void f()\n"
"{\n"
" char a[4];\n"
" for (float i=0; i<10.0;i=i+0.1)\n"
" {\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
check("void f()\n"
"{\n"
" char a[4];\n"
" for (float i=0; i<10.0;i=0.1+i)\n"
" {\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void sprintf1()
{