From 1f5c3670bd357c5e13901bb8e5adea76dd49da86 Mon Sep 17 00:00:00 2001 From: Paul Fultz II Date: Sat, 30 Oct 2021 02:07:06 -0500 Subject: [PATCH] Use a unique variable name when checking if a flag is valid (#3532) --- cmake/compileroptions.cmake | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/cmake/compileroptions.cmake b/cmake/compileroptions.cmake index ac19b7835..394176274 100644 --- a/cmake/compileroptions.cmake +++ b/cmake/compileroptions.cmake @@ -1,15 +1,17 @@ include(CheckCXXCompilerFlag) function(add_compile_options_safe FLAG) - check_cxx_compiler_flag(${FLAG} _has_flag) - if (_has_flag) + string(MAKE_C_IDENTIFIER "HAS_CXX_FLAG${FLAG}" mangled_flag) + check_cxx_compiler_flag(${FLAG} ${mangled_flag}) + if (${mangled_flag}) add_compile_options(${FLAG}) endif() endfunction() - + function(target_compile_options_safe TARGET FLAG) - check_cxx_compiler_flag(${FLAG} _has_flag) - if (_has_flag) + string(MAKE_C_IDENTIFIER "HAS_CXX_FLAG${FLAG}" mangled_flag) + check_cxx_compiler_flag(${FLAG} ${mangled_flag}) + if (${mangled_flag}) target_compile_options(${TARGET} PRIVATE ${FLAG}) endif() endfunction()