walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix 10784: False positive: returnDanglingLifetime using std::tie with variadic template parameters (#3805)

This commit is contained in:
Paul Fultz II 2022-02-08 02:03:51 -06:00 committed by GitHub
parent b5ed13c8bc
commit 20a5224d7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/valueflow.cpp
View File

@ -3021,6 +3021,8 @@ static std::vector<LifetimeToken> getLifetimeTokens(const Token* tok,
{ {
if (!tok) if (!tok)
return std::vector<LifetimeToken> {}; return std::vector<LifetimeToken> {};
if (Token::simpleMatch(tok, "..."))
return std::vector<LifetimeToken>{};
const Variable *var = tok->variable(); const Variable *var = tok->variable();
if (pred(tok)) if (pred(tok))
return {{tok, std::move(errorPath)}}; return {{tok, std::move(errorPath)}};

7
test/testautovariables.cpp
View File

@ -2955,6 +2955,13 @@ private:
ASSERT_EQUALS( ASSERT_EQUALS(
"[test.cpp:11] -> [test.cpp:10] -> [test.cpp:11]: (error) Non-local variable 'mMoreData.data1' will use pointer to local variable 'data'.\n", "[test.cpp:11] -> [test.cpp:10] -> [test.cpp:11]: (error) Non-local variable 'mMoreData.data1' will use pointer to local variable 'data'.\n",
errout.str()); errout.str());
// #10784
check("template <class... Ts>\n"
"auto f(int i, Ts&... xs) {\n"
" return std::tie(xs[i]...);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
} }
void danglingLifetimeFunction() { void danglingLifetimeFunction() {