From 22b0f37aafbb257336294169b31c437a57aa780a Mon Sep 17 00:00:00 2001
From: Dmitry-Me <wipedout@yandex.ru>
Date: Thu, 26 Feb 2015 14:34:18 +0300
Subject: [PATCH] Cache and reuse value

---
 lib/checkcondition.cpp | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/lib/checkcondition.cpp b/lib/checkcondition.cpp
index e1efb1c3a..6deddea9e 100644
--- a/lib/checkcondition.cpp
+++ b/lib/checkcondition.cpp
@@ -203,10 +203,11 @@ void CheckCondition::checkBadBitmaskCheck()
 
     for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) {
         if (tok->str() == "|" && tok->astOperand1() && tok->astOperand2() && tok->astParent()) {
-            const bool isBoolean = Token::Match(tok->astParent(), "&&|%oror%") ||
-                                   (tok->astParent()->str() == "?" && tok->astParent()->astOperand1() == tok) ||
-                                   (tok->astParent()->str() == "=" && tok->astParent()->astOperand2() == tok && tok->astParent()->astOperand1() && tok->astParent()->astOperand1()->variable() && tok->astParent()->astOperand1()->variable()->typeStartToken()->str() == "bool") ||
-                                   (tok->astParent()->str() == "(" && Token::Match(tok->astParent()->astOperand1(), "if|while"));
+            const Token* parent = tok->astParent();
+            const bool isBoolean = Token::Match(parent, "&&|%oror%") ||
+                                   (parent->str() == "?" && parent->astOperand1() == tok) ||
+                                   (parent->str() == "=" && parent->astOperand2() == tok && parent->astOperand1() && parent->astOperand1()->variable() && parent->astOperand1()->variable()->typeStartToken()->str() == "bool") ||
+                                   (parent->str() == "(" && Token::Match(parent->astOperand1(), "if|while"));
 
             const bool isTrue = (tok->astOperand1()->values.size() == 1 && tok->astOperand1()->values.front().intvalue != 0 && !tok->astOperand1()->values.front().conditional) ||
                                 (tok->astOperand2()->values.size() == 1 && tok->astOperand2()->values.front().intvalue != 0 && !tok->astOperand2()->values.front().conditional);
@@ -449,9 +450,11 @@ void CheckCondition::oppositeInnerCondition()
                     break;
                 if (tok->variable() &&
                     Token::Match(tok, "%name% . %name% (") &&
-                    !tok->variable()->isConst() &&
-                    !(tok->tokAt(2)->function() && tok->tokAt(2)->function()->isConst()))
-                    break;
+                    !tok->variable()->isConst()) {
+                    const Function* function = tok->tokAt(2)->function();
+                    if (!function || !function->isConst())
+                        break;
+                }
                 if (Token::Match(tok->previous(), "[(,] %name% [,)]")) {
                     // is variable unchanged? default is false..
                     bool unchanged = false;