walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

GUI: Remove the 'Safe Checks' tab in project settings. We need to tweak these checks and settings further.

This commit is contained in:
Daniel Marjamäki 2019-08-25 18:53:01 +02:00
parent 767667815d
commit 22d7ca648d
2 changed files with 4 additions and 151 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gui/projectfiledialog.cpp
View File

@ -272,6 +272,7 @@ void ProjectFileDialog::loadFromProjectFile(const ProjectFile *projectFile)
setSuppressions(projectFile->getSuppressions());
// Human knowledge..
/*
mUI.mListUnknownFunctionReturn->clear();
mUI.mListUnknownFunctionReturn->addItem("rand()");
for (int row = 0; row < mUI.mListUnknownFunctionReturn->count(); ++row) {
@ -284,6 +285,7 @@ void ProjectFileDialog::loadFromProjectFile(const ProjectFile *projectFile)
mUI.mCheckSafeExternalFunctions->setChecked(projectFile->getSafeChecks().externalFunctions);
mUI.mCheckSafeInternalFunctions->setChecked(projectFile->getSafeChecks().internalFunctions);
mUI.mCheckSafeExternalVariables->setChecked(projectFile->getSafeChecks().externalVariables);
*/
// Addons..
QSettings settings;
@ -339,6 +341,7 @@ void ProjectFileDialog::saveToProjectFile(ProjectFile *projectFile) const
}
projectFile->setSuppressions(getSuppressions());
// Human knowledge
/*
QStringList unknownReturnValues;
for (int row = 0; row < mUI.mListUnknownFunctionReturn->count(); ++row) {
QListWidgetItem *item = mUI.mListUnknownFunctionReturn->item(row);
@ -352,6 +355,7 @@ void ProjectFileDialog::saveToProjectFile(ProjectFile *projectFile) const
safeChecks.internalFunctions = mUI.mCheckSafeInternalFunctions->isChecked();
safeChecks.externalVariables = mUI.mCheckSafeExternalVariables->isChecked();
projectFile->setSafeChecks(safeChecks);
*/
// Addons
QStringList list;
if (mUI.mAddonThreadSafety->isChecked())

151
gui/projectfiledialog.ui
View File

@ -415,157 +415,6 @@
</item>
</layout>
</widget>
<widget class="QWidget" name="mTabHumanKnownledge">
<attribute name="title">
<string>Extended checks</string>
</attribute>
<layout class="QVBoxLayout" name="verticalLayout_19">
<item>
<widget class="QGroupBox" name="groupBox_10">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Expanding">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="title">
<string>&quot;Safe&quot; interface: Cppcheck does not only check how it is actually used, but analyze any possible usage.</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_16">
<property name="leftMargin">
<number>0</number>
</property>
<property name="topMargin">
<number>0</number>
</property>
<property name="rightMargin">
<number>0</number>
</property>
<property name="bottomMargin">
<number>0</number>
</property>
<item>
<widget class="QScrollArea" name="scrollArea">
<property name="minimumSize">
<size>
<width>0</width>
<height>200</height>
</size>
</property>
<property name="horizontalScrollBarPolicy">
<enum>Qt::ScrollBarAlwaysOff</enum>
</property>
<property name="widgetResizable">
<bool>true</bool>
</property>
<widget class="QWidget" name="scrollAreaWidgetContents">
<property name="geometry">
<rect>
<x>0</x>
<y>0</y>
<width>840</width>
<height>273</height>
</rect>
</property>
<layout class="QVBoxLayout" name="verticalLayout_17">
<item>
<widget class="QCheckBox" name="mCheckSafeClasses">
<property name="enabled">
<bool>true</bool>
</property>
<property name="text">
<string>Classes - Public interface
- public function parameters can have any value
- public functions can be called in any order
- public variables can have any value</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QCheckBox" name="mCheckSafeExternalFunctions">
<property name="text">
<string>External functions
- External functions can be called in any order
- Function parameters can have any value</string>
</property>
</widget>
</item>
<item>
<widget class="QCheckBox" name="mCheckSafeExternalVariables">
<property name="text">
<string>External variables
- Variable can have any value</string>
</property>
</widget>
</item>
<item>
<widget class="QCheckBox" name="mCheckSafeInternalFunctions">
<property name="text">
<string>Internal/private functions
- Function parameters can have any value</string>
</property>
</widget>
</item>
</layout>
</widget>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QGroupBox" name="groupBox_13">
<property name="title">
<string>Input from file/network/user/...</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_14">
<item>
<widget class="QLabel" name="label_6">
<property name="text">
<string>If the return value from a function below is always completely unknown, then click on its checkbox</string>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<layout class="QHBoxLayout" name="horizontalLayout_9">
<item>
<widget class="QListWidget" name="mListUnknownFunctionReturn">
<property name="maximumSize">
<size>
<width>16777215</width>
<height>60</height>
</size>
</property>
<item>
<property name="text">
<string>rand()</string>
</property>
</item>
</widget>
</item>
<item>
<widget class="QPushButton" name="mButtonAddUnknownFunctionReturn">
<property name="enabled">
<bool>false</bool>
</property>
<property name="text">
<string>Add..</string>
</property>
</widget>
</item>
</layout>
</item>
</layout>
</widget>
</item>
</layout>
</widget>
<widget class="QWidget" name="mTabWarningOptions">
<attribute name="title">
<string>Warning options</string>