walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #9640 (clang import: reference parameter)

This commit is contained in:
Daniel Marjamäki 2020-02-17 18:56:25 +01:00
parent 75b1ade316
commit 244e291605
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/symboldatabase.cpp
View File

@ -1753,6 +1753,9 @@ Variable::Variable(const Token *name_, const std::string &clangType, const Token
if (start && start->str() == "static") if (start && start->str() == "static")
setFlag(fIsStatic, true); setFlag(fIsStatic, true);
if (endsWith(clangType, " &", 2))
setFlag(fIsReference, true);
std::string::size_type pos = clangType.find("["); std::string::size_type pos = clangType.find("[");
if (pos != std::string::npos) { if (pos != std::string::npos) {
setFlag(fIsArray, true); setFlag(fIsArray, true);

18
test/testclangimport.cpp
View File

@ -94,6 +94,7 @@ private:
TEST_CASE(symbolDatabaseEnum1); TEST_CASE(symbolDatabaseEnum1);
TEST_CASE(symbolDatabaseFunction1); TEST_CASE(symbolDatabaseFunction1);
TEST_CASE(symbolDatabaseFunction2); TEST_CASE(symbolDatabaseFunction2);
TEST_CASE(symbolDatabaseFunction3);
TEST_CASE(symbolDatabaseNodeType1); TEST_CASE(symbolDatabaseNodeType1);
TEST_CASE(valueFlow1); TEST_CASE(valueFlow1);
@ -931,6 +932,23 @@ private:
ASSERT_EQUALS(0, (long long)func->getArgumentVar(1)->nameToken()); ASSERT_EQUALS(0, (long long)func->getArgumentVar(1)->nameToken());
} }
void symbolDatabaseFunction3() { // #9640
const char clang[] = "`-FunctionDecl 0x238fcd8 <9640.cpp:1:1, col:26> col:6 used bar 'bool (const char, int &)'\n"
" |-ParmVarDecl 0x238fb10 <col:10, col:16> col:20 'const char'\n"
" |-ParmVarDecl 0x238fbc0 <col:22, col:25> col:26 'int &'\n"
" `-CompoundStmt 0x3d45c48 <col:12>\n";
GET_SYMBOL_DB(clang);
// There is a function foo that has 2 arguments
ASSERT_EQUALS(1, db->functionScopes.size());
const Scope *scope = db->functionScopes[0];
const Function *func = scope->function;
ASSERT_EQUALS(2, func->argCount());
ASSERT_EQUALS(false, func->getArgumentVar(0)->isReference());
ASSERT_EQUALS(true, func->getArgumentVar(1)->isReference());
}
void symbolDatabaseNodeType1() { void symbolDatabaseNodeType1() {
const char clang[] = "`-FunctionDecl 0x32438c0 <line:5:1, line:7:1> line:5:6 foo 'a::b (a::b)'\n" const char clang[] = "`-FunctionDecl 0x32438c0 <line:5:1, line:7:1> line:5:6 foo 'a::b (a::b)'\n"
" |-ParmVarDecl 0x32437b0 <col:10, col:15> col:15 used i 'a::b':'long'\n" " |-ParmVarDecl 0x32437b0 <col:10, col:15> col:15 used i 'a::b':'long'\n"