walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

checkother: Removed statement that is always true. (#1059)

This commit is contained in:
orbitcowboy 2018-01-26 22:49:07 +01:00 committed by Daniel Marjamäki
parent 71ba513bdb
commit 27d9aaa8f5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -1502,7 +1502,7 @@ void CheckOther::checkCharVariable()
v1 = tok->astOperand1()->getValueGE(0x80, _settings); v1 = tok->astOperand1()->getValueGE(0x80, _settings);
if (v1 && !(tok->str() == "&" && v2 && v2->isKnown() && v2->intvalue >= 0 && v2->intvalue < 0x100)) if (v1 && !(tok->str() == "&" && v2 && v2->isKnown() && v2->intvalue >= 0 && v2->intvalue < 0x100))
warn = true; warn = true;
} else if (!warn && astIsSignedChar(tok->astOperand2())) { } else if (astIsSignedChar(tok->astOperand2())) {
const ValueFlow::Value *v1 = tok->astOperand2()->getValueLE(-1, _settings); const ValueFlow::Value *v1 = tok->astOperand2()->getValueLE(-1, _settings);
const ValueFlow::Value *v2 = tok->astOperand1()->getMaxValue(false); const ValueFlow::Value *v2 = tok->astOperand1()->getMaxValue(false);
if (!v1) if (!v1)