walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Changed severity and message formatting of argumentSize message.

This commit is contained in:
PKEuS 2013-02-16 00:52:27 -08:00
parent 7b3493322d
commit 27f7917349
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkbufferoverrun.cpp
View File

@ -178,7 +178,7 @@ void CheckBufferOverrun::bufferNotZeroTerminatedError(const Token *tok, const st
void CheckBufferOverrun::argumentSizeError(const Token *tok, const std::string &functionName, const std::string &varname) void CheckBufferOverrun::argumentSizeError(const Token *tok, const std::string &functionName, const std::string &varname)
{ {
reportError(tok, Severity::style, "argumentSize", "the array " + varname + " is too small, the function " + functionName + " expects a bigger array"); reportError(tok, Severity::warning, "argumentSize", "The array '" + varname + "' is too small, the function '" + functionName + "' expects a bigger one.");
} }
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------

6
test/testbufferoverrun.cpp
View File

@ -2701,21 +2701,21 @@ private:
" char a[2];\n" " char a[2];\n"
" f(a);\n" " f(a);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (style) the array a is too small, the function f expects a bigger array\n", errout.str()); ASSERT_EQUALS("[test.cpp:4]: (warning) The array 'a' is too small, the function 'f' expects a bigger one.\n", errout.str());
check("void f(float a[10][20]);\n" check("void f(float a[10][20]);\n"
"void g() {\n" "void g() {\n"
" float a[2][3];\n" " float a[2][3];\n"
" f(a);\n" " f(a);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (style) the array a is too small, the function f expects a bigger array\n", errout.str()); ASSERT_EQUALS("[test.cpp:4]: (warning) The array 'a' is too small, the function 'f' expects a bigger one.\n", errout.str());
check("void f(char a[20]);\n" check("void f(char a[20]);\n"
"void g() {\n" "void g() {\n"
" int a[2];\n" " int a[2];\n"
" f(a);\n" " f(a);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (style) the array a is too small, the function f expects a bigger array\n", errout.str()); ASSERT_EQUALS("[test.cpp:4]: (warning) The array 'a' is too small, the function 'f' expects a bigger one.\n", errout.str());
check("void f(char a[20]);\n" check("void f(char a[20]);\n"
"void g() {\n" "void g() {\n"